)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"eaac21ccf0467076fd32bed3ba3e46a48d1f28d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4f3e438_34fa3e52","updated":"2021-11-10 16:25:14.000000000","message":"I totally agree to extend the possibility for non-cores to mark a review: \"I promise I will help landing this\"\n\nHowever I still think that we don\u0027t need yet another way for commit authors to express: \"I need review on my patch\".","commit_id":"52d32a77d00c7d942f4f63bdcf1b679d885360ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2c71b1170c6b62639e235a915a9ff9dc5d143485","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2516f786_a84d500d","updated":"2021-12-08 14:18:35.000000000","message":"Looks good to me.","commit_id":"890cd82b84751e6574045b40c5988cf88fec5662"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0a67625847578a25b2d1f52202382f055b4168ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2e8523e8_407af971","updated":"2021-12-14 16:13:05.000000000","message":"my comment is not blocker which is extra documentation and can be added in follow up too if it make it more clear.\n\nnot +W, waiting more core to vote here.","commit_id":"890cd82b84751e6574045b40c5988cf88fec5662"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b2e9a3d33648f1728da8f79ec651b473932c8bf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ef5d1625_9917e069","updated":"2021-12-07 16:40:26.000000000","message":"overall lgtm, 1 comment to make RP +1 more clear","commit_id":"890cd82b84751e6574045b40c5988cf88fec5662"},{"author":{"_account_id":34153,"name":"GirishChilukuri","email":"giri1899@gmail.com"},"change_message_id":"af493800ad5d53ef63f922c2ae51741deafc38fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a721f993_3be77ebb","updated":"2022-01-20 16:08:26.000000000","message":"recheck","commit_id":"890cd82b84751e6574045b40c5988cf88fec5662"}],"doc/source/contributor/process.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"eaac21ccf0467076fd32bed3ba3e46a48d1f28d1","unresolved":true,"context_lines":[{"line_number":696,"context_line":"2) It was as effective as we, cores, are kept it honest and allocated our"},{"line_number":697,"context_line":"   review time on the patches in the slots. Such commitment is hard to get or"},{"line_number":698,"context_line":"   follow up on without being aggressive."},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"So the aim of the new review priority process is to be as decentralized amongst"},{"line_number":701,"context_line":"cores as possible. We trust cores that when they mark something as priority"},{"line_number":702,"context_line":"then they also themselves commit to review the patch. We also assume that if a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6b06b5bf_a1af2aed","line":699,"updated":"2021-11-10 16:25:14.000000000","message":"So this description states here what the problem was we wanted to solve with the review priority label. And below described our solution. Now you proposed additional things to the solution but it is not described here what was the original problem where we needed this new extended solution.","commit_id":"52d32a77d00c7d942f4f63bdcf1b679d885360ea"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0c17e7f8d88a2696a042d8dc8ed83e027b1f0d93","unresolved":false,"context_lines":[{"line_number":696,"context_line":"2) It was as effective as we, cores, are kept it honest and allocated our"},{"line_number":697,"context_line":"   review time on the patches in the slots. Such commitment is hard to get or"},{"line_number":698,"context_line":"   follow up on without being aggressive."},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"So the aim of the new review priority process is to be as decentralized amongst"},{"line_number":701,"context_line":"cores as possible. We trust cores that when they mark something as priority"},{"line_number":702,"context_line":"then they also themselves commit to review the patch. We also assume that if a"}],"source_content_type":"text/x-rst","patch_set":1,"id":"109b9369_f247c3cf","line":699,"in_reply_to":"6b06b5bf_a1af2aed","updated":"2021-11-12 10:16:44.000000000","message":"Ack","commit_id":"52d32a77d00c7d942f4f63bdcf1b679d885360ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"eaac21ccf0467076fd32bed3ba3e46a48d1f28d1","unresolved":true,"context_lines":[{"line_number":704,"context_line":"second reviewer when needed. We also want contributors to be able to \"ping\""},{"line_number":705,"context_line":"cores asynchronously by asking them to review their own changes."},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"Note that this process does not want to change how a patch is discovered to be"},{"line_number":708,"context_line":"ready for review. The patch authors free to you any existing forums and ways to"},{"line_number":709,"context_line":"get review attention."},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"Therefore we use the Review-Priority label in Gerrit in the following way:"},{"line_number":712,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"8923731c_8ed32662","line":709,"range":{"start_line":707,"start_character":0,"end_line":709,"end_character":21},"updated":"2021-11-10 16:25:14.000000000","message":"This is now in direct contradiction with the above added sentence","commit_id":"52d32a77d00c7d942f4f63bdcf1b679d885360ea"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0c17e7f8d88a2696a042d8dc8ed83e027b1f0d93","unresolved":false,"context_lines":[{"line_number":704,"context_line":"second reviewer when needed. We also want contributors to be able to \"ping\""},{"line_number":705,"context_line":"cores asynchronously by asking them to review their own changes."},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"Note that this process does not want to change how a patch is discovered to be"},{"line_number":708,"context_line":"ready for review. The patch authors free to you any existing forums and ways to"},{"line_number":709,"context_line":"get review attention."},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"Therefore we use the Review-Priority label in Gerrit in the following way:"},{"line_number":712,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"85096347_0780a061","line":709,"range":{"start_line":707,"start_character":0,"end_line":709,"end_character":21},"in_reply_to":"8923731c_8ed32662","updated":"2021-11-12 10:16:44.000000000","message":"Ack","commit_id":"52d32a77d00c7d942f4f63bdcf1b679d885360ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"eaac21ccf0467076fd32bed3ba3e46a48d1f28d1","unresolved":true,"context_lines":[{"line_number":712,"context_line":""},{"line_number":713,"context_line":"* Review-Priority is a label with 0, +1 or +2 values."},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"* A contributor can set the Review-Priority flag to +1 to indicate they will"},{"line_number":716,"context_line":"  want cores to review the patch but also that the contributor will also"},{"line_number":717,"context_line":"  review too or reply any comment if they are the patch author."},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"* A core sets the Review-Priority flag to +2 to indicate that they will help"},{"line_number":720,"context_line":"  the author to get the patch merged."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e19f71fb_15c101b7","line":717,"range":{"start_line":715,"start_character":0,"end_line":717,"end_character":63},"updated":"2021-11-10 16:25:14.000000000","message":"I think you trying to handle two cases here in single bullet making the bullet complicated:\n\n* the commit author sets +1 on its own patch -\u003e the author commits to answer review comments and provider new revisions if needed\n\n*  a non core reviewer sets a +1 on a patch where they is not the author -\u003e similarly to +2 it means the reviewer commits to help landing the patch by (re-)reviewing it frequently.\n\nI suggest to handle these two cases in separate bullet points for clarity.","commit_id":"52d32a77d00c7d942f4f63bdcf1b679d885360ea"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0c17e7f8d88a2696a042d8dc8ed83e027b1f0d93","unresolved":false,"context_lines":[{"line_number":712,"context_line":""},{"line_number":713,"context_line":"* Review-Priority is a label with 0, +1 or +2 values."},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"* A contributor can set the Review-Priority flag to +1 to indicate they will"},{"line_number":716,"context_line":"  want cores to review the patch but also that the contributor will also"},{"line_number":717,"context_line":"  review too or reply any comment if they are the patch author."},{"line_number":718,"context_line":""},{"line_number":719,"context_line":"* A core sets the Review-Priority flag to +2 to indicate that they will help"},{"line_number":720,"context_line":"  the author to get the patch merged."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e4bbfb57_42db122d","line":717,"range":{"start_line":715,"start_character":0,"end_line":717,"end_character":63},"in_reply_to":"e19f71fb_15c101b7","updated":"2021-11-12 10:16:44.000000000","message":"Ack","commit_id":"52d32a77d00c7d942f4f63bdcf1b679d885360ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"49fa9e9482371ca1fc75681eba89c5e914c5ec26","unresolved":true,"context_lines":[{"line_number":697,"context_line":"   review time on the patches in the slots. Such commitment is hard to get or"},{"line_number":698,"context_line":"   follow up on without being aggressive."},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"3) Non-cores were not able to tell they were happy with reviewing some change"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"4) Owners were able to ask for some reviews but they were not really knowing"},{"line_number":703,"context_line":"   how to do this (hum, what is an etherpad ?)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"573c24ad_c6fded2b","line":700,"updated":"2021-11-12 11:43:17.000000000","message":"+1","commit_id":"db0519ffe706fbd198acf432815a457b48bc40dc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"49fa9e9482371ca1fc75681eba89c5e914c5ec26","unresolved":true,"context_lines":[{"line_number":699,"context_line":""},{"line_number":700,"context_line":"3) Non-cores were not able to tell they were happy with reviewing some change"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"4) Owners were able to ask for some reviews but they were not really knowing"},{"line_number":703,"context_line":"   how to do this (hum, what is an etherpad ?)"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"So the aim of the new review priority process is to be as decentralized amongst"},{"line_number":706,"context_line":"cores as possible. We trust cores that when they mark something as priority"}],"source_content_type":"text/x-rst","patch_set":2,"id":"61394193_9aa80e22","line":703,"range":{"start_line":702,"start_character":0,"end_line":703,"end_character":46},"updated":"2021-11-12 11:43:17.000000000","message":"I had different experience. The etherpad had a long list of reviews waiting in the queue. So using it to asking for review wasn\u0027t a problem. The problem was (paraphrasing from above):\n\n1) The list of patches in the queue needed to be regularly checked. Is this review still valid? Or is it in merge conflict? Or is it got review feedback already while sitting in the queue? Does the patch series has new patches in the middle? Does it now depend on another series that need to land first?\nUnfortunately people are more motivated to add their stuff to the review queue than going back and update the queue if their patch is changed state. The PTL kept the queue in shape and that does not really scaled well.\n\n\n2) The patch series that was selected for a review slot did not really get review attention. So they timed out in the slot and went back to the end of the queue. I, as a PTL, did not kicked the cores enough to look at reviews in the slot as I did not feel that it would be productive forcing people. I showed the content of the slots on the meeting to get attention but in my experience it did not really worked well to commit to reviews in the slot and then delivering on that commitment.","commit_id":"db0519ffe706fbd198acf432815a457b48bc40dc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"49fa9e9482371ca1fc75681eba89c5e914c5ec26","unresolved":true,"context_lines":[{"line_number":706,"context_line":"cores as possible. We trust cores that when they mark something as priority"},{"line_number":707,"context_line":"then they also themselves commit to review the patch. We also assume that if a"},{"line_number":708,"context_line":"core reviewed a patch then that core should easily find another core as a"},{"line_number":709,"context_line":"second reviewer when needed. We also want contributors to be able to \"ping\""},{"line_number":710,"context_line":"cores asynchronously by asking them to review their own changes."},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"That said, this process doesn\u0027t explain how a patch is discovered to be"},{"line_number":713,"context_line":"ready for review. While previously The patch authors were able to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b10e3218_14f12f80","line":710,"range":{"start_line":709,"start_character":29,"end_line":710,"end_character":64},"updated":"2021-11-12 11:43:17.000000000","message":"I agree that we might want that, I disagree that it is need to be implemented via the Review-Priority label. \n\nPeople can ping asynchronously via IRC. Most of the cores are keeping their clients up all the time and read the scroll back.\n\nPeople can ping async via the ML. \n\nPeople can add certain reviewers to the patch in gerrit as reviewer or as CC. This is also async and close to the review system.","commit_id":"db0519ffe706fbd198acf432815a457b48bc40dc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"49fa9e9482371ca1fc75681eba89c5e914c5ec26","unresolved":true,"context_lines":[{"line_number":723,"context_line":""},{"line_number":724,"context_line":"* Review-Priority is a label with 0, +1 or +2 values."},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"* A contributor can set the Review-Priority flag to +1 to indicate they will"},{"line_number":727,"context_line":"  want cores to review the patch."},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"* A core sets the Review-Priority flag to +2 to indicate that they will help"},{"line_number":730,"context_line":"  the author to get the patch merged."}],"source_content_type":"text/x-rst","patch_set":2,"id":"e9c9a62b_810a30a5","line":727,"range":{"start_line":726,"start_character":2,"end_line":727,"end_character":33},"updated":"2021-11-12 11:43:17.000000000","message":"This is what I don\u0027t like. We have already a plethora of ways to express \"I need reviews\". \n\nWhat I agree with is that a non-core sets +1 to say, I as a non-core commit myself to (re)review this patch in the future, helping it to land.","commit_id":"db0519ffe706fbd198acf432815a457b48bc40dc"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b2e9a3d33648f1728da8f79ec651b473932c8bf8","unresolved":true,"context_lines":[{"line_number":718,"context_line":"* Review-Priority is a label with 0, +1 or +2 values."},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"* A contributor can set the Review-Priority flag to +1 to indicate they will"},{"line_number":721,"context_line":"  want cores to review the patch."},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"* A core sets the Review-Priority flag to +2 to indicate that they will help"},{"line_number":724,"context_line":"  the author to get the patch merged."}],"source_content_type":"text/x-rst","patch_set":3,"id":"dffa2881_c6722b6e","line":721,"range":{"start_line":721,"start_character":32,"end_line":721,"end_character":33},"updated":"2021-12-07 16:40:26.000000000","message":"let\u0027s add a sentence here like it is not to add RP as +1 on your own patch to get more review/attention from core.","commit_id":"890cd82b84751e6574045b40c5988cf88fec5662"}]}