)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c4a0d4eb12d7cc515e7120b9f9f17e84cd0c50f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba8ff893_0c13d9dd","updated":"2021-11-08 15:12:12.000000000","message":"This is a nice simple patch.\n\ni would be tempted to also keep a rolling average also but perhaps its better to just keep this simple.","commit_id":"5a2f44ae5804d862d6cec963b3d8bf2695936823"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"a98b7cdb0617b47eee12b59b82b939052ff8f7d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b9bc5889_a7239c49","updated":"2021-11-10 19:09:10.000000000","message":"LGTM thanks!","commit_id":"af7762713ffaa0ea3e183d36a89b24b3bceb163e"}],"nova/compute/manager.py":[{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"08d67918d110366586540f51c43d33d49598a655","unresolved":true,"context_lines":[{"line_number":487,"context_line":"                decision \u003d error_callback(event_name, instance)"},{"line_number":488,"context_line":"                if decision is False:"},{"line_number":489,"context_line":"                    break"},{"line_number":490,"context_line":"        LOG.debug(\u0027VIF plugging completed in %i seconds\u0027, sw.elapsed())"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def update_compute_provider_status(self, context, rp_uuid, enabled):"},{"line_number":493,"context_line":"        \"\"\"Used to add/remove the COMPUTE_STATUS_DISABLED trait on the provider"}],"source_content_type":"text/x-python","patch_set":1,"id":"04fe1b9c_2db479ea","line":490,"updated":"2021-11-09 13:56:26.000000000","message":"LOG.debug(\u0027VIF plugging completed in %i seconds for instance %s\u0027, sw.elapsed(), instance)","commit_id":"5a2f44ae5804d862d6cec963b3d8bf2695936823"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"72c3393d10b6404b668568dbd2eb9c0f1460f74f","unresolved":true,"context_lines":[{"line_number":487,"context_line":"                decision \u003d error_callback(event_name, instance)"},{"line_number":488,"context_line":"                if decision is False:"},{"line_number":489,"context_line":"                    break"},{"line_number":490,"context_line":"        LOG.debug(\u0027VIF plugging completed in %i seconds\u0027, sw.elapsed())"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def update_compute_provider_status(self, context, rp_uuid, enabled):"},{"line_number":493,"context_line":"        \"\"\"Used to add/remove the COMPUTE_STATUS_DISABLED trait on the provider"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ca7e226_6dcd354a","line":490,"range":{"start_line":490,"start_character":19,"end_line":490,"end_character":31},"updated":"2021-11-10 14:36:39.000000000","message":"wait_for_instance_event isn\u0027t just used for VIF plugging events right? Shouldn\u0027t we also log this for each event as they complete above?","commit_id":"5a2f44ae5804d862d6cec963b3d8bf2695936823"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"72c3393d10b6404b668568dbd2eb9c0f1460f74f","unresolved":true,"context_lines":[{"line_number":487,"context_line":"                decision \u003d error_callback(event_name, instance)"},{"line_number":488,"context_line":"                if decision is False:"},{"line_number":489,"context_line":"                    break"},{"line_number":490,"context_line":"        LOG.debug(\u0027VIF plugging completed in %i seconds\u0027, sw.elapsed())"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def update_compute_provider_status(self, context, rp_uuid, enabled):"},{"line_number":493,"context_line":"        \"\"\"Used to add/remove the COMPUTE_STATUS_DISABLED trait on the provider"}],"source_content_type":"text/x-python","patch_set":1,"id":"835999bc_a75ba125","line":490,"in_reply_to":"04fe1b9c_2db479ea","updated":"2021-11-10 14:36:39.000000000","message":"FWIW you just need the instance\u003dinstance kwarg here and oslo.log will add the instance.uuid to the line for us.\n\nhttps://github.com/openstack/oslo.log/blob/51324b276a8a5f69847d3a17fa89924dabad4759/oslo_log/formatters.py#L406-L449\n\nIf we had the request context here we wouldn\u0027t even need that.","commit_id":"5a2f44ae5804d862d6cec963b3d8bf2695936823"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c5c9459af82799e52fd7ca842db395bc4e36f2ee","unresolved":true,"context_lines":[{"line_number":487,"context_line":"                decision \u003d error_callback(event_name, instance)"},{"line_number":488,"context_line":"                if decision is False:"},{"line_number":489,"context_line":"                    break"},{"line_number":490,"context_line":"        LOG.debug(\u0027VIF plugging completed in %i seconds\u0027, sw.elapsed())"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"    def update_compute_provider_status(self, context, rp_uuid, enabled):"},{"line_number":493,"context_line":"        \"\"\"Used to add/remove the COMPUTE_STATUS_DISABLED trait on the provider"}],"source_content_type":"text/x-python","patch_set":1,"id":"87802236_957ba3c2","line":490,"range":{"start_line":490,"start_character":19,"end_line":490,"end_character":31},"in_reply_to":"6ca7e226_6dcd354a","updated":"2021-11-10 17:58:40.000000000","message":"I think it is currently, but you\u0027re absolutely right that we shouldn\u0027t imply so here. I think just logging the event name list would be the solution.","commit_id":"5a2f44ae5804d862d6cec963b3d8bf2695936823"}],"nova/tests/unit/compute/test_virtapi.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1c4a0d4eb12d7cc515e7120b9f9f17e84cd0c50f","unresolved":true,"context_lines":[{"line_number":131,"context_line":"                          [(\u0027foo\u0027, \u0027bar\u0027),"},{"line_number":132,"context_line":"                           (\u0027foo\u0027, \u0027baz\u0027)])"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @mock.patch.object(compute_manager, \u0027LOG\u0027)"},{"line_number":135,"context_line":"    def test_wait_for_instance_event(self, mock_log):"},{"line_number":136,"context_line":"        and_i_ran \u003d \u0027\u0027"},{"line_number":137,"context_line":"        event_1_tag \u003d objects.InstanceExternalEvent.make_key("}],"source_content_type":"text/x-python","patch_set":1,"id":"2aeae4fe_804f0119","line":134,"range":{"start_line":134,"start_character":41,"end_line":134,"end_character":44},"updated":"2021-11-08 15:12:12.000000000","message":"i think we have a global log fixture by the way at least in the functional test we do\nbut this will work fine and its easy to follow.","commit_id":"5a2f44ae5804d862d6cec963b3d8bf2695936823"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"08d67918d110366586540f51c43d33d49598a655","unresolved":true,"context_lines":[{"line_number":151,"context_line":"            self.assertEqual(\u0027instance\u0027, event.instance)"},{"line_number":152,"context_line":"            self.assertIn((event.name, event.tag), events.keys())"},{"line_number":153,"context_line":"            event.wait.assert_called_once_with()"},{"line_number":154,"context_line":"        mock_log.debug.assert_called_once_with("},{"line_number":155,"context_line":"            \u0027VIF plugging completed in %i seconds\u0027, mock.ANY)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_wait_for_instance_event_failed(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"0bc53706_f251a373","line":154,"updated":"2021-11-09 13:56:26.000000000","message":"ditto, should be fine to log also instance id.","commit_id":"5a2f44ae5804d862d6cec963b3d8bf2695936823"}]}