)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33761,"name":"Jun Chen","display_name":"Jun Chen","email":"chenjun@chinatelecom.cn","username":"CDream"},"change_message_id":"0e7531bc61504ff5f3cdd27dabe19e579f5590d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23b983e2_ee06959b","updated":"2021-11-10 06:14:13.000000000","message":"pkvm- recheck","commit_id":"da4d0dd5c2ba5d0520ecb14f19f50a8e075a75d3"},{"author":{"_account_id":33761,"name":"Jun Chen","display_name":"Jun Chen","email":"chenjun@chinatelecom.cn","username":"CDream"},"change_message_id":"4fc52f3d66775786aa0b4fb6aaba8eef7b617722","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"96dfe385_cfac0c76","updated":"2021-11-10 03:09:51.000000000","message":"run-Cloudbase Nova Ceph Hyper-V CI","commit_id":"da4d0dd5c2ba5d0520ecb14f19f50a8e075a75d3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8412bf99ffaed6ab692eaa856cba00dc42889f93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56a49ba5_0c97ab06","updated":"2022-02-21 18:54:33.000000000","message":"Looks like lyarwood\u0027s comments have been addressed ","commit_id":"f831618b25feb4e0000373acbfaee3cd83602739"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"907b6324ea4c911a44e8b111c1dea0e1fafebb67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"82094b7b_756e2f30","updated":"2022-07-12 07:56:08.000000000","message":"thanks for finding this","commit_id":"f831618b25feb4e0000373acbfaee3cd83602739"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"5ffc653667bf1ab3eb8b732428af5d6768507759","unresolved":true,"context_lines":[{"line_number":3879,"context_line":"        try:"},{"line_number":3880,"context_line":"            guest.shutdown()"},{"line_number":3881,"context_line":"        except libvirt.libvirtError:"},{"line_number":3882,"context_line":"            LOG.debug(\"Ignoring libvirt exception from shutdown \""},{"line_number":3883,"context_line":"                      \"request.\", instance\u003dinstance)"},{"line_number":3884,"context_line":"        retry_countdown \u003d retry_interval"},{"line_number":3885,"context_line":""},{"line_number":3886,"context_line":"        for sec in range(timeout):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8679ac3_556ea586","line":3883,"range":{"start_line":3882,"start_character":0,"end_line":3883,"end_character":52},"updated":"2021-11-10 14:54:03.000000000","message":"I see we do this below and assume it\u0027s because we\u0027ve raced and a previous call has already shut the instance down but I\u0027m not a fan of just swallowing perfectly useful context held by the exception here. I\u0027d much rather both used LOG.exception and still ignored it.","commit_id":"da4d0dd5c2ba5d0520ecb14f19f50a8e075a75d3"},{"author":{"_account_id":33761,"name":"Jun Chen","display_name":"Jun Chen","email":"chenjun@chinatelecom.cn","username":"CDream"},"change_message_id":"2500366a9731df91d351536c85dcf07e1262642d","unresolved":false,"context_lines":[{"line_number":3879,"context_line":"        try:"},{"line_number":3880,"context_line":"            guest.shutdown()"},{"line_number":3881,"context_line":"        except libvirt.libvirtError:"},{"line_number":3882,"context_line":"            LOG.debug(\"Ignoring libvirt exception from shutdown \""},{"line_number":3883,"context_line":"                      \"request.\", instance\u003dinstance)"},{"line_number":3884,"context_line":"        retry_countdown \u003d retry_interval"},{"line_number":3885,"context_line":""},{"line_number":3886,"context_line":"        for sec in range(timeout):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e05d435a_a6381cce","line":3883,"range":{"start_line":3882,"start_character":0,"end_line":3883,"end_character":52},"in_reply_to":"a8679ac3_556ea586","updated":"2021-11-15 02:52:44.000000000","message":"Thanks for you comment! The exception context is logged now.","commit_id":"da4d0dd5c2ba5d0520ecb14f19f50a8e075a75d3"},{"author":{"_account_id":33761,"name":"Jun Chen","display_name":"Jun Chen","email":"chenjun@chinatelecom.cn","username":"CDream"},"change_message_id":"719bf06928ed5385c2578bf6289db2d8f6994ee8","unresolved":false,"context_lines":[{"line_number":3879,"context_line":"        try:"},{"line_number":3880,"context_line":"            guest.shutdown()"},{"line_number":3881,"context_line":"        except libvirt.libvirtError:"},{"line_number":3882,"context_line":"            LOG.debug(\"Ignoring libvirt exception from shutdown \""},{"line_number":3883,"context_line":"                      \"request.\", instance\u003dinstance)"},{"line_number":3884,"context_line":"        retry_countdown \u003d retry_interval"},{"line_number":3885,"context_line":""},{"line_number":3886,"context_line":"        for sec in range(timeout):"}],"source_content_type":"text/x-python","patch_set":1,"id":"34b331a4_35e0d7f3","line":3883,"range":{"start_line":3882,"start_character":0,"end_line":3883,"end_character":52},"in_reply_to":"e05d435a_a6381cce","updated":"2021-11-15 03:00:13.000000000","message":"And I think debug level is enough, just like logging the libvirt error caught in reboot procedure.","commit_id":"da4d0dd5c2ba5d0520ecb14f19f50a8e075a75d3"}]}