)]}'
{"id":"openstack%2Fnova~817214","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I7f2b6330decb92e2838aa7cee47fb228f00f47da","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1882521","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2021-11-12 09:53:33.000000000","reason":"Removed by gibi by clicking the attention icon"}},"hashtags":[],"change_id":"I7f2b6330decb92e2838aa7cee47fb228f00f47da","subject":"Replace blind retry with libvirt event waiting in detach","status":"ABANDONED","created":"2021-11-09 14:00:53.000000000","updated":"2021-12-08 15:03:21.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f51729b65e5126ee16d505d7bdc3c1319d296b03","_number":817214,"virtual_id_number":817214,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-11-10 20:31:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-09 15:02:00.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-09 16:09:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-09 17:09:57.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"}],"messages":[{"id":"c13c36fd0ba53049987dac4b8992f07e723be5b2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-11-09 14:00:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6b2daa3e6b727f24d8467b24824b89b565642069","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-11-09 15:02:00.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/14/817214/1/check/tempest-dsvm-full-focal-py3/6688ab2/ : POST_FAILURE in 25m 58s","accounts_in_message":[],"_revision_number":1},{"id":"f8805e8708cf73bf8a81a35f1d033f365e1b3b79","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-09 16:09:54.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/407ce95ed67f40a7b133865303972276 : SUCCESS in 1h 15m 45s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/90f0c722d9bf427dafbbf608c948f961 : FAILURE in 9m 56s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/de58e7c32f1045eba865aea410e492e7 : SUCCESS in 19m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1f40b92dd135425fa2f6ae98942711ba : SUCCESS in 18m 28s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/85044812f77746e8ad0c4c0643b5f492 : SUCCESS in 10m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d383890d4c2a4ee391d3dd8a2b4f5c4a : SUCCESS in 14m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bc7987fdd20a4f778100955beeec27b0 : SUCCESS in 16m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cfe7b66948b8424d92dce088aa2839d3 : SUCCESS in 13m 32s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/dfefbb892dfc491283c8f63fa376ff55 : SUCCESS in 21m 47s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/bb2f68392c02474bad60fa5de877b9e1 : SUCCESS in 1h 19m 18s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/7f30f179d64349db94de4e6df9d1b166 : FAILURE in 1h 26m 44s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/3ed2fbc6351c4a7284242cfc0d78aa20 : SUCCESS in 53m 21s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/eed85561a06f4dc3a5d60c3132c9932a : SUCCESS in 1h 05m 57s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/387612e0c9e24f41b263274943331f36 : FAILURE in 1h 29m 36s\n- nova-next https://zuul.opendev.org/t/openstack/build/a3accddbb5b74de5a357f8651ce66a0d : SUCCESS in 1h 32m 26s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/528630551c05403ea02668fd9e26684c : SUCCESS in 8m 11s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a36cde2e0a6e455c92d4d07d4b047186 : SUCCESS in 19m 50s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/96b86692a7584c34b165a9c9d8c0391f : SUCCESS in 1h 16m 40s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c1836859204444d18f53d9156445a51d : SUCCESS in 1h 18m 07s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/37a8a4c3b7ed4526a2598fddf8542d2e : SUCCESS in 57m 16s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/f9ed61fb1e074216aaee1d9982c6f785 : SUCCESS in 34m 18s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/261a9e058bc2462a9b050163fa0ca7da : SUCCESS in 44m 03s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4c21944c2fdf19061f65d22896347e1fe1a72b01","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-11-09 17:09:57.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/817214/1/iscsi : FAILURE in 3h 05m 02s","accounts_in_message":[],"_revision_number":1},{"id":"8165f6f8dd63ecf08a89e46789d37f11fa616d2b","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-11-10 09:56:35.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"614e11f9bfda34c471cb479ec31a6df5a429d1e7","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-11-10 10:27:01.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 tempest-dsvm-full-focal-py3 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"1499155cf9aae94e5e49b6355f2b3e20d0d80377","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-10 11:31:27.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/8e17e843621d426dbf43d2bcb4f0ec99 : SUCCESS in 1h 13m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/30195450733649768f46ebe59224b183 : SUCCESS in 21m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8ac071f7c6f5439c8fa79117286159f7 : SUCCESS in 16m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5cb2a40315334aa897b44dd469c4967e : SUCCESS in 9m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7ec72914fa5048218eafb39046c433ff : SUCCESS in 14m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8d061360d2634386a892659eb82190a6 : SUCCESS in 14m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/950067f0673b4b368580c29f0d678078 : SUCCESS in 11m 01s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b398ee07f6c54f9d803349d33dc71083 : SUCCESS in 23m 46s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/374e1390877c4d95ac6b9312f1e9875a : SUCCESS in 1h 23m 41s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/9975adf802e6479b9dd16c7cc28e595a : SUCCESS in 1h 19m 32s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/6d65ccaeeaa54740b0480e068f6bec52 : SUCCESS in 49m 53s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/9f1e39d2f9994fb2b1ba114fc0403734 : SUCCESS in 57m 32s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/6c9d890893dd49e8b6abce6811850454 : SUCCESS in 1h 25m 48s\n- nova-next https://zuul.opendev.org/t/openstack/build/f6d7897fad104f4a861c67f9124f7445 : SUCCESS in 1h 25m 51s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/d74f049b2d044ea5aa7a496856a21a52 : SUCCESS in 6m 18s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/754679a7149a445294a4050d93448355 : SUCCESS in 19m 30s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/5ff1af065318467784997c4e63889ec2 : FAILURE in 1h 21m 51s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/20e9a2eea14e49259051ae12ee3f0a60 : SUCCESS in 1h 01m 28s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/868d196d4b134e57a69a70dfc8e0e2b3 : SUCCESS in 55m 12s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/91a6cd7992ba4ba687b549485aad4cf4 : SUCCESS in 33m 54s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/ac07c1fd07704ecb820e734880e73daa : SUCCESS in 46m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"93b23128e8e2622c2e20ec9f9af7c167c851f2f6","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-11-10 12:47:51.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/817214/1/iscsi : FAILURE in 2h 44m 13s","accounts_in_message":[],"_revision_number":1},{"id":"dfaea1edc5e96c9ffc3dd8cb1184fa5b35f10831","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-11-10 16:48:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"85cdc090dbe561548aa66ff941fa24ce18f84717","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-11-10 17:18:55.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 tempest-dsvm-full-focal-py3 : NODE_FAILURE in 0s","accounts_in_message":[],"_revision_number":1},{"id":"ba8d21ef0535b10c0ebc85eab8aa2dc86132fe83","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-11-10 19:30:28.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/817214/1/iscsi : SUCCESS in 2h 36m 16s","accounts_in_message":[],"_revision_number":1},{"id":"2f63cb89bc9a989b2b5a839e97958f25b8b0dc3d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-10 20:31:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/d5cb2e1778b343a498482df9e456fba4 : SUCCESS in 1h 38m 53s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2e4b4f3ebf6a4ca7aa66826d589bea50 : SUCCESS in 21m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/07bfc914a1ba4baca578535e538b1343 : SUCCESS in 17m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7a96eecfebd640d29441fd5dd01f09d5 : SUCCESS in 10m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7437d78778b4466da1d867cce83edf16 : SUCCESS in 13m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f0ca2f79cce944d983fae8476c8ce180 : SUCCESS in 16m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/70a05a050e574586a9f0b1e3c54c5a86 : SUCCESS in 15m 44s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4d6c17fdd26d4c91b79b16835e29c616 : SUCCESS in 22m 58s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/fae2ea100da6458ead323f02b750708a : SUCCESS in 1h 43m 53s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/7df5454dc8684f17b2e24b130c0f39c2 : SUCCESS in 1h 32m 36s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/cc9d4878a4154ed480f6478ce2eb00aa : SUCCESS in 54m 38s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/8495420e6d274347b8427cd528eb04af : FAILURE in 49m 07s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/6f71c88955264e548d8dd5b4e4182e6d : SUCCESS in 1h 25m 37s\n- nova-next https://zuul.opendev.org/t/openstack/build/989dd33378964f12932979ca739a8853 : SUCCESS in 1h 30m 13s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/66be42c2fd1e4e1dbe8e4bc8b39a9da1 : SUCCESS in 8m 22s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/5e4eb2a16038474194e6e0a88174bcb8 : SUCCESS in 23m 30s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/0c379a0cbfe949948ecc0b0cfbd1da38 : SUCCESS in 1h 19m 29s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e374b03fa7ee44c19058dd55c9eb6cc5 : SUCCESS in 1h 05m 18s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/e35095e5daec4f67bded6f9970fc6364 : SUCCESS in 1h 01m 03s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/a641e1bf876348acb3cc7b77208f86e1 : SUCCESS in 33m 41s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/b7da374eb4ef4d2bb0a2a07d833a2367 : SUCCESS in 42m 30s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f51729b65e5126ee16d505d7bdc3c1319d296b03","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-12-08 15:03:21.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9230fecd04c06305bfa7d3e63ae5e2fa51dcc323","revisions":{"9230fecd04c06305bfa7d3e63ae5e2fa51dcc323":{"kind":"REWORK","_number":1,"created":"2021-11-09 14:00:53.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/14/817214/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/14/817214/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/817214/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/817214/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/14/817214/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/14/817214/1"}}},"commit":{"parents":[{"commit":"f7f4a21d010220026d63bf1dd932e39890d9ed4e","subject":"libvirt: parse alias out from device config","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f7f4a21d010220026d63bf1dd932e39890d9ed4e"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-01-12 07:23:17.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-11-09 13:23:03.000000000","tz":60},"subject":"Replace blind retry with libvirt event waiting in detach","message":"Replace blind retry with libvirt event waiting in detach\n\nNova so far applied a retry loop that tried to periodically detach the\ndevice from libvirt while the device was visible in the domain xml. This\ncould lead to an issue where an already progressing detach on the\nlibvirt side is interrupted by nova re-sending the detach request for\nthe same device. See bug #1882521 for more information.\n\nAlso if there was both a persistent and a live domain the nova tried the\ndetach from both at the same call. This lead to confusion about the\nresult when such call failed. Was the detach failed partially?\n\nWe can do better, at least for the live detach case. Based on the\nlibvirt developers detaching from the persistent domain always\nsucceeds and it is a synchronous process. Detaching from the live\ndomain can be both synchronous or asynchronous depending on the guest\nOS and the load on the hypervisor. But for live detach libvirt always\nsends an event [1] nova can wait for.\n\nSo this patch does two things.\n\n1) Separates the detach from the persistent domain from the detach from\n   the live domain to make the error cases clearer.\n\n2) Changes the retry mechanism.\n\n   Detaching from the persistent domain is not retried. If libvirt\n   reports device not found, while both persistent and live detach\n   is needed, the error is ignored, and the process continues with\n   the live detach. In any other case the error considered as fatal.\n\n   Detaching from the live domain is changed to always wait for the\n   libvirt event. In case of timeout, the live detach is retried.\n   But a failure event from libvirt considered fatal, based on the\n   information from the libvirt developers, so in this case the\n   detach is not retried.\n\nConflicts:\n      nova/tests/unit/virt/libvirt/test_driver.py\n      nova/tests/unit/virt/libvirt/test_guest.py\n      nova/virt/libvirt/driver.py\n      nova/virt/libvirt/guest.py\n\nThese conflicts are due to two difference:\n1) I45f1df4935905170957c2ea2496c8a698a7464a2 is not in victoria as it\n   was a feature in a newer branch\n\n2) I32908b77c18f8ec08211dd67be49bbf903611c34 is not in wallaby and newer\n   as min libvirt version was bumped in wallaby over 4.1.0\n\nRelated-Bug: #1882521\n\n[1]https://libvirt.org/html/libvirt-libvirt-domain.html#virConnectDomainEventDeviceRemovedCallback\n\nChange-Id: I7f2b6330decb92e2838aa7cee47fb228f00f47da\n(cherry picked from commit e56cc4f439846558fc13298c2360d7cdd473cc89)\n(cherry picked from commit 30317e6b3f5ee5e7fd1e8c564a1d6f3e3a2fb91b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9230fecd04c06305bfa7d3e63ae5e2fa51dcc323"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9230fecd04c06305bfa7d3e63ae5e2fa51dcc323"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[]}