)]}'
{"id":"openstack%2Fnova~817216","triplet_id":"openstack%2Fnova~stable%2Fvictoria~I0b93bdc12cdce591c7e642ab8830e92445467b9a","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1882521","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2021-12-08 15:03:38.000000000","reason":"Change was abandoned"},"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2021-11-10 09:57:37.000000000","reason":"gibi replied on the change"}},"hashtags":[],"change_id":"I0b93bdc12cdce591c7e642ab8830e92445467b9a","subject":"libvirt: Remove dead error handling code","status":"ABANDONED","created":"2021-11-09 14:03:04.000000000","updated":"2021-12-08 15:03:38.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9cf228fac76c587445bbe011d944ddf874449156","_number":817216,"virtual_id_number":817216,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-11-09 16:16:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":-1,"date":"2021-11-10 09:57:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-09 14:03:04.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2021-11-09 16:16:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-09 17:16:06.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2021-11-09 17:38:14.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"f6a4902ae2f1a7e6e956aab34e56064b720e843a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-11-09 14:03:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"966b59b376501e60331dfb4b3401a1dd8114aac0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-09 16:16:06.000000000","message":"Patch Set 1: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/d2261363e53841cbbff34de4ff161497 : SUCCESS in 1h 19m 55s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/adf9a74c85ca43ba9f2567369baf1935 : FAILURE in 12m 21s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8b9761dc4cd44db98c2c92d27c8f4255 : SUCCESS in 19m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/33af0ea9d8354bf0953ef05de500599a : SUCCESS in 17m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2807da90c90a41f081fcc92c3824425d : FAILURE in 10m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4fac455bda244639b22070ea2ed2bcb5 : SUCCESS in 15m 54s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/df4b79dcfd694bb885f3fa22e28670c8 : SUCCESS in 16m 57s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/111406514d494132b887b58f005bb571 : SUCCESS in 17m 12s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/95abecd74f2b4c09ab0df069f56da56b : SUCCESS in 1h 26m 15s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/232f409d45a84217b2645452506ba058 : SUCCESS in 1h 34m 03s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/924ed2ac730045cd986591eef278803c : SUCCESS in 56m 33s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/dc08bf3779584b9b8d75f0f5208abba0 : SUCCESS in 46m 17s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/1fcb73d73f4c4260aaa4524ad1ef96a1 : SUCCESS in 1h 33m 42s\n- nova-next https://zuul.opendev.org/t/openstack/build/159941f8900e4f7b8cb20c90b1b9bca4 : SUCCESS in 1h 19m 09s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/f2df9ab0cd784ba5934803d627e0ebfd : SUCCESS in 8m 18s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/5766fd3c9ef34f13914e387784c7fd1b : SUCCESS in 21m 30s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/80593871666f4a8fab6d239a7f1ee223 : SUCCESS in 1h 09m 17s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7030812d205244809ab3f15c7542b72e : SUCCESS in 58m 56s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f32deff64b1d43f5bb06b1395286e938 : SUCCESS in 55m 29s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/a038d6b466ab41f6aa27906416b1c95f : SUCCESS in 32m 45s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/3a125f63dc05403fb6837290050bffa5 : SUCCESS in 48m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"11ecf273601e347be75396753b3eaaadcfe4b2cd","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-11-09 17:16:06.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/817216/1/iscsi : SUCCESS in 3h 01m 15s","accounts_in_message":[],"_revision_number":1},{"id":"60442c4f4ddb685731ed62af0cd0d96ccc0682e6","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-11-09 17:38:14.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/16/817216/1/check/tempest-dsvm-full-focal-py3/eca9d42/ : TIMED_OUT in 3h 09m 39s","accounts_in_message":[],"_revision_number":1},{"id":"76202fa9e9bf7876a7381be0f729b5c12a622b3c","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-11-10 09:57:37.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9cf228fac76c587445bbe011d944ddf874449156","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-12-08 15:03:38.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"49fec6fb91193137e03adb7560d3368f012c170a","revisions":{"49fec6fb91193137e03adb7560d3368f012c170a":{"kind":"REWORK","_number":1,"created":"2021-11-09 14:03:04.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/16/817216/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/16/817216/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/16/817216/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/16/817216/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/16/817216/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/16/817216/1"}}},"commit":{"parents":[{"commit":"8e5188dd01a477f63c8e0ab05e88d10389e05285","subject":"Move the guest.get_disk test to test_guest","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8e5188dd01a477f63c8e0ab05e88d10389e05285"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2021-03-09 18:43:19.000000000","tz":0},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-11-09 13:37:46.000000000","tz":60},"subject":"libvirt: Remove dead error handling code","message":"libvirt: Remove dead error handling code\n\nWe removed calls to configure the libvirt-based firewall driver in\n\u0027_create_guest_with_network\u0027 as part of change\nI5a9e5532c46a5f7064441ae644125d21efe5fda1. Since then, there only other\nway we can successfully create a guest and still end up in an exception\nhandler is if the plugging of VIFs fails. Despite this, all three code\npaths still contained references to a \u0027guest\u0027 attribute that would never\nbe set.\n\nClarify things by removing the use of the \u0027guest\u0027 attribute from the\nother code paths. This means the \u0027_cleanup_failed_start\u0027 helper only has\none caller and some unnecessary logic itself, so we can fold that into\nits caller. We also take this opportunity to remove an unnecessary\nerror handler - \u0027nova.exception.VirtualInterfaceCreateException\u0027 is\nderived from \u0027Exception\u0027 and doesn\u0027t need its own handler - and add the\ntype hints for the function. The heavy lifting for the latter was\nalready done in change I2489bf16dabc8a83b2044139247f4245ae29adb1 so this\nis pretty easy to grok.\n\nNext up, we really need to stop passing around dicts of block device\nmapping info, but that\u0027s another change for another day.\n\nConflicts:\n      nova/virt/libvirt/driver.py: Due to I decided not to backport\n      I42c579531bac61063a381598094720271364ec92 and\n      I332ea49184200fcaf8d1480da9658fcbb2f325c5 as those are only\n      mypy related and it is getting hard to backport them properly.\n\nChange-Id: I0b93bdc12cdce591c7e642ab8830e92445467b9a\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n(cherry picked from commit dc814a6822c98e0f3ec9d652d48f523d0f76b96f)\n(cherry picked from commit 14596ca30fdfab78cb9f1e2ba331bcefa1033450)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/49fec6fb91193137e03adb7560d3368f012c170a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/49fec6fb91193137e03adb7560d3368f012c170a"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[]}