)]}'
{"id":"openstack%2Fnova~817218","triplet_id":"openstack%2Fnova~stable%2Fvictoria~Ic6eb66bc2396949aceecda50bda334a1bc7dab31","project":"openstack/nova","branch":"stable/victoria","topic":"bug/1882521","attention_set":{},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2021-11-10 16:49:15.000000000","reason":"Removed by gibi by clicking the attention icon"}},"hashtags":[],"change_id":"Ic6eb66bc2396949aceecda50bda334a1bc7dab31","subject":"Consolidate device detach error handling","status":"ABANDONED","created":"2021-11-09 14:03:04.000000000","updated":"2021-12-08 15:03:51.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"45637c4182d29a77ddcf44651db6f035486c6638","_number":817218,"virtual_id_number":817218,"owner":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2021-11-09 16:13:59.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-09 16:13:59.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-09 17:25:51.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-09 19:23:01.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"}],"messages":[{"id":"dfec560312fb1db7f0b86d30ff1022d2b9241367","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-11-09 14:03:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4ed83ffd7c7de60a927ee7fe1da94d376e7796fe","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-09 16:13:59.000000000","message":"Patch Set 1: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/4c56b2af5c7c435c8d9aca7b89209ac3 : SUCCESS in 1h 18m 07s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/ff0e2ddb39ad4cea83efdcd236bdb5d6 : FAILURE in 16m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/57d8db0a5a5e417e81aad48ce99f0b35 : SUCCESS in 19m 34s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3cfc657d5a964585addadff255be9709 : SUCCESS in 19m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/229b8180f1bc4e0f9b15b80fb4316d76 : FAILURE in 10m 36s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d9ceec2c8d43492bba014503fc7584bb : SUCCESS in 17m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/a42ae43cebe04abfa8c13c1a72ea5a55 : SUCCESS in 14m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4bf789a47435426e8d0f82681adbb5f4 : SUCCESS in 13m 10s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/d51db8ec93654f7db74930c713b72337 : SUCCESS in 1h 18m 44s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/c54d7e90b3ad490d9bdc75c213025346 : SUCCESS in 1h 23m 02s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/57a2337afbfb4e6eb31788c7231dd487 : SUCCESS in 49m 56s\n- nova-lvm https://zuul.opendev.org/t/openstack/build/91b1e7eb7ac64375a59c7d01675658a1 : FAILURE in 1h 02m 36s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/4b445cc542984e2abaf4fbbb4dcc5c7f : SUCCESS in 1h 30m 24s\n- nova-next https://zuul.opendev.org/t/openstack/build/1e00ac24a73943ec88a106f7808a81de : SUCCESS in 1h 32m 00s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/fe30a33740754aa9bc2903eb473b3162 : SUCCESS in 9m 05s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/340620a215304796b7e2b78c460a726b : SUCCESS in 20m 10s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/6e20a626cda24c768322a6061448c3b6 : SUCCESS in 1h 09m 29s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5062d3d441ab46c18e7a6ad392beb908 : SUCCESS in 1h 03m 52s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/4cf93fdbc7c54b0f9b4cd2bf62aeb892 : SUCCESS in 1h 02m 34s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/1c26e0769cf8453399da0770055fa889 : SUCCESS in 31m 05s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/62b4334a6d414be89804082d36724432 : FAILURE in 40m 27s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"20c5bf6cfff7a31530b2e4ee78f388e3070759e6","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-11-09 17:25:51.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/18/817218/1/check/tempest-dsvm-full-focal-py3/aab87da/ : SUCCESS in 2h 41m 16s","accounts_in_message":[],"_revision_number":1},{"id":"b1468ef6320316970ac7c165604e5d042ff9d066","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-11-09 19:23:01.000000000","message":"Patch Set 1:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/817218/1/iscsi : SUCCESS in 3h 02m 15s","accounts_in_message":[],"_revision_number":1},{"id":"45637c4182d29a77ddcf44651db6f035486c6638","tag":"autogenerated:gerrit:abandon","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2021-12-08 15:03:51.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3508f0e41175135965232fd50727a167a09095a3","revisions":{"3508f0e41175135965232fd50727a167a09095a3":{"kind":"REWORK","_number":1,"created":"2021-11-09 14:03:04.000000000","uploader":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"ref":"refs/changes/18/817218/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/18/817218/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/817218/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/817218/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/18/817218/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/18/817218/1"}}},"commit":{"parents":[{"commit":"a6054f50e6c79851816f853fcd7dbff9feaa4486","subject":"Move instance power state check to _detach_with_retry","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a6054f50e6c79851816f853fcd7dbff9feaa4486"}]}],"author":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-03-05 15:44:51.000000000","tz":60},"committer":{"name":"Balazs Gibizer","email":"balazs.gibizer@est.tech","date":"2021-11-09 13:47:53.000000000","tz":60},"subject":"Consolidate device detach error handling","message":"Consolidate device detach error handling\n\nAfter I7f2b6330decb92e2838aa7cee47fb228f00f47da the error handling of\nthe callers of _detach_with_retry() can be consolidated. Libvirt related\nerrors now handled in _detach_sync() and various DeviceNotFound cases\nnow don\u0027t need special handling on the caller side.\n\nConflicts:\n      nova/tests/unit/virt/libvirt/test_driver.py: due to\n      Ic6eb66bc2396949aceecda50bda334a1bc7dab31 is not in victoria\n\nChange-Id: Ic6eb66bc2396949aceecda50bda334a1bc7dab31\n(cherry picked from commit 7317cfbc67e25a71aa1b6bfb03f71ddfa9ead293)\n(cherry picked from commit 8b50f48ed2f04b39d416391a72faae8ad7e9d0f0)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3508f0e41175135965232fd50727a167a09095a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3508f0e41175135965232fd50727a167a09095a3"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
