)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f3ff020b2700b177b626d83bf0d311236c6f6b7b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fill the AcceleratorRequestBindingFailed exception msg info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1950276"},{"line_number":10,"context_line":"Change-Id: Iac1d74ebeefc8e4192896b10c76c16942dbe30fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a7d8884d_0d020230","line":9,"updated":"2021-11-30 16:08:38.000000000","message":"Closes-Bug would be better","commit_id":"2841fe50bfa65f2ee3d77f8e83d3db4036aef279"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"3426a22cc0bf8b0091fe312aa46e49f6990ca21b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fill the AcceleratorRequestBindingFailed exception msg info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1950276"},{"line_number":10,"context_line":"Change-Id: Iac1d74ebeefc8e4192896b10c76c16942dbe30fc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4ba49966_bd49ea8f","line":9,"in_reply_to":"a7d8884d_0d020230","updated":"2021-12-10 05:36:15.000000000","message":"Done","commit_id":"2841fe50bfa65f2ee3d77f8e83d3db4036aef279"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"0d2362ce3036cacde9d99ef4584cff6331cff0eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0a58f63d_bf6a15c1","updated":"2021-12-15 00:47:13.000000000","message":"recheck","commit_id":"2af7eb00f57b766458d96a13565570169423a256"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"1a602773b9b5e10fe78c78ce635d7d32de12f30e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8f2d211b_119c70a3","updated":"2022-01-17 00:36:02.000000000","message":"recheck","commit_id":"2af7eb00f57b766458d96a13565570169423a256"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"22f037d7d2592c0051f632400a541827c323d605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c036e217_19d06d94","updated":"2021-12-20 00:53:27.000000000","message":"recheck","commit_id":"2af7eb00f57b766458d96a13565570169423a256"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ff4fb5159be44c199b3c357034ed0432519a0047","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"11b53b86_15b3db89","updated":"2022-01-14 18:17:41.000000000","message":"tbh, this could do with a test to exercise this code, but gibi\u0027s happy with this as-is so so am I","commit_id":"2af7eb00f57b766458d96a13565570169423a256"}],"nova/exception.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"46b7d827a980552aff1ec5836dbd667753acf437","unresolved":true,"context_lines":[{"line_number":2362,"context_line":"class AcceleratorRequestBindingFailed(NovaException):"},{"line_number":2363,"context_line":"    msg_fmt \u003d _(\"Failed to bind accelerator requests: %(msg)s\")"},{"line_number":2364,"context_line":""},{"line_number":2365,"context_line":"    def __init__(self, message\u003dNone, arqs\u003dNone, **kwargs):"},{"line_number":2366,"context_line":"        super(AcceleratorRequestBindingFailed, self).__init__("},{"line_number":2367,"context_line":"            message\u003dmessage, **kwargs)"},{"line_number":2368,"context_line":"        self.arqs \u003d arqs or []"}],"source_content_type":"text/x-python","patch_set":3,"id":"37fe2b95_cc78da0c","line":2365,"updated":"2021-12-13 10:55:21.000000000","message":"Why do you need the message args? As far as I see it is not used in the codebase. \n\nhttps://github.com/openstack/nova/blob/755aa11e0c9a59dc1cdb6de5c71f4f9249b37741/nova/accelerator/cyborg.py#L275-L276","commit_id":"e5c86efecc99ba63da900d6181fea3c4b6643123"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"257707aff4956fef1db640b10e8ef50e478072d4","unresolved":false,"context_lines":[{"line_number":2362,"context_line":"class AcceleratorRequestBindingFailed(NovaException):"},{"line_number":2363,"context_line":"    msg_fmt \u003d _(\"Failed to bind accelerator requests: %(msg)s\")"},{"line_number":2364,"context_line":""},{"line_number":2365,"context_line":"    def __init__(self, message\u003dNone, arqs\u003dNone, **kwargs):"},{"line_number":2366,"context_line":"        super(AcceleratorRequestBindingFailed, self).__init__("},{"line_number":2367,"context_line":"            message\u003dmessage, **kwargs)"},{"line_number":2368,"context_line":"        self.arqs \u003d arqs or []"}],"source_content_type":"text/x-python","patch_set":3,"id":"8e96abba_307c9326","line":2365,"in_reply_to":"37fe2b95_cc78da0c","updated":"2021-12-13 12:00:20.000000000","message":"Yes, gibi, this args is really neednot, thanks.","commit_id":"e5c86efecc99ba63da900d6181fea3c4b6643123"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8836a1f88db9cda29ce74689490b0d02de4519a3","unresolved":false,"context_lines":[{"line_number":2362,"context_line":"class AcceleratorRequestBindingFailed(NovaException):"},{"line_number":2363,"context_line":"    msg_fmt \u003d _(\"Failed to bind accelerator requests: %(msg)s\")"},{"line_number":2364,"context_line":""},{"line_number":2365,"context_line":"    def __init__(self, message\u003dNone, arqs\u003dNone, **kwargs):"},{"line_number":2366,"context_line":"        super(AcceleratorRequestBindingFailed, self).__init__("},{"line_number":2367,"context_line":"            message\u003dmessage, **kwargs)"},{"line_number":2368,"context_line":"        self.arqs \u003d arqs or []"}],"source_content_type":"text/x-python","patch_set":3,"id":"039e34f5_ca546a0a","line":2365,"in_reply_to":"5572e75b_fb565ddb","updated":"2021-12-16 13:32:45.000000000","message":"That test case feels pretty bad. It passes something like an error code not a message. But meh.","commit_id":"e5c86efecc99ba63da900d6181fea3c4b6643123"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"475601db237bde589e23d00090df7459a0c65738","unresolved":false,"context_lines":[{"line_number":2362,"context_line":"class AcceleratorRequestBindingFailed(NovaException):"},{"line_number":2363,"context_line":"    msg_fmt \u003d _(\"Failed to bind accelerator requests: %(msg)s\")"},{"line_number":2364,"context_line":""},{"line_number":2365,"context_line":"    def __init__(self, message\u003dNone, arqs\u003dNone, **kwargs):"},{"line_number":2366,"context_line":"        super(AcceleratorRequestBindingFailed, self).__init__("},{"line_number":2367,"context_line":"            message\u003dmessage, **kwargs)"},{"line_number":2368,"context_line":"        self.arqs \u003d arqs or []"}],"source_content_type":"text/x-python","patch_set":3,"id":"5572e75b_fb565ddb","line":2365,"in_reply_to":"8e96abba_307c9326","updated":"2021-12-14 09:38:00.000000000","message":"gibi, we cannot remove message args, or the case nova.tests.unit.test_exception.ExceptionTestCase.test_exceptions_raise will not pass, because this case transform _raise_exc as the message param.","commit_id":"e5c86efecc99ba63da900d6181fea3c4b6643123"}]}
