)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"e1c1b916570ddc9074c5f6a78c6f181a935e6f77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3154a72_5f373545","updated":"2021-11-23 01:45:15.000000000","message":"LGTM","commit_id":"be4e01c101c7e870e5becaf8627a3eb0067ea428"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"75ceeff6ef1518c14ea506421cd3f987674da6bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58e1d165_2659ee60","updated":"2021-11-25 16:35:38.000000000","message":"recheck something about failing to create a server image in the centos 8 stream job, which isn\u0027t relevant","commit_id":"be4e01c101c7e870e5becaf8627a3eb0067ea428"}],"nova/db/main/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"cbc218b84211ebfd5b4466f0ec4c1d0330154866","unresolved":true,"context_lines":[{"line_number":600,"context_line":"    results \u003d conn.execute(select).fetchall()"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    # Callers expect dict-like objects, not SQLAlchemy RowProxy objects..."},{"line_number":603,"context_line":"    results \u003d [dict(r._mapping) for r in results]"},{"line_number":604,"context_line":"    conn.close()"},{"line_number":605,"context_line":"    return results"},{"line_number":606,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6690000b_3989ece7","line":603,"range":{"start_line":603,"start_character":22,"end_line":603,"end_character":24},"updated":"2021-11-23 09:45:41.000000000","message":"this feels shady as we are accessing sqla private fields.","commit_id":"be4e01c101c7e870e5becaf8627a3eb0067ea428"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4fdd7c7d40b5a2e254db5b919b97272699f60e38","unresolved":false,"context_lines":[{"line_number":600,"context_line":"    results \u003d conn.execute(select).fetchall()"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    # Callers expect dict-like objects, not SQLAlchemy RowProxy objects..."},{"line_number":603,"context_line":"    results \u003d [dict(r._mapping) for r in results]"},{"line_number":604,"context_line":"    conn.close()"},{"line_number":605,"context_line":"    return results"},{"line_number":606,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7989ca_d7d1f65e","line":603,"range":{"start_line":603,"start_character":22,"end_line":603,"end_character":24},"in_reply_to":"04891a51_d1eb7e43","updated":"2021-11-25 11:38:14.000000000","message":"Hm, if SQLA itself suggest that then I don\u0027t see what else we can do :/","commit_id":"be4e01c101c7e870e5becaf8627a3eb0067ea428"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"01a604c363b6b89377feb2914e7589749f46319f","unresolved":false,"context_lines":[{"line_number":600,"context_line":"    results \u003d conn.execute(select).fetchall()"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"    # Callers expect dict-like objects, not SQLAlchemy RowProxy objects..."},{"line_number":603,"context_line":"    results \u003d [dict(r._mapping) for r in results]"},{"line_number":604,"context_line":"    conn.close()"},{"line_number":605,"context_line":"    return results"},{"line_number":606,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"04891a51_d1eb7e43","line":603,"range":{"start_line":603,"start_character":22,"end_line":603,"end_character":24},"in_reply_to":"6690000b_3989ece7","updated":"2021-11-25 10:46:26.000000000","message":"Yeah, the deprecation warning itself says we should use this, which is unfortunate to say the least /o\\","commit_id":"be4e01c101c7e870e5becaf8627a3eb0067ea428"}]}
