)]}'
{"api-ref/source/servers-actions.inc":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"af074519c191dd29ea5fe6a18f81ba785e14a264","unresolved":true,"context_lines":[{"line_number":783,"context_line":"  - adminPass: adminPass_rescue_request"},{"line_number":784,"context_line":"  - rescue_image_ref: rescue_image_ref"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":".. note:: The ability to inject passwords into guest operating systems is"},{"line_number":787,"context_line":"          configuration-dependant, and may not be supported by every cloud."},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"**Example Rescue server (rescue Action)**"},{"line_number":790,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"4e368583_f3f03945","line":787,"range":{"start_line":786,"start_character":0,"end_line":787,"end_character":75},"updated":"2021-11-22 18:34:14.000000000","message":"Yup that sucks, did you also want to reference that we can also provide it in the config-drive if required?\n\nI wouldn\u0027t be against turning CONF.libvirt.inject_{partition,password,key} etc into compute traits to allow us to reject such requests in the API before casting down to the compute tbh.","commit_id":"57d8e7c97c48cf9e7e0a72efd5442d19d0c70ed8"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c116f79a3b440e4dc5529c1dfc5f9a4b48325570","unresolved":true,"context_lines":[{"line_number":783,"context_line":"  - adminPass: adminPass_rescue_request"},{"line_number":784,"context_line":"  - rescue_image_ref: rescue_image_ref"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":".. note:: The ability to inject passwords into guest operating systems is"},{"line_number":787,"context_line":"          configuration-dependant, and may not be supported by every cloud."},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"**Example Rescue server (rescue Action)**"},{"line_number":790,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"cb3e7263_13737acf","line":787,"range":{"start_line":786,"start_character":0,"end_line":787,"end_character":75},"in_reply_to":"4e368583_f3f03945","updated":"2021-11-23 15:53:17.000000000","message":"\u003e Yup that sucks, did you also want to reference that we can also provide it in the config-drive if required?\n\nHow does that actually happen though? As part of user-data? I can\u0027t find any reference to admin passwords (or admin anything, in fact) in our metadata API code (which I\u0027m assuming is the same info that ends up in the config drive?)\n\n\u003e I wouldn\u0027t be against turning CONF.libvirt.inject_{partition,password,key} etc into compute traits to allow us to reject such requests in the API before casting down to the compute tbh.","commit_id":"57d8e7c97c48cf9e7e0a72efd5442d19d0c70ed8"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"af074519c191dd29ea5fe6a18f81ba785e14a264","unresolved":true,"context_lines":[{"line_number":795,"context_line":"--------"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"  - adminPass: adminPass_response"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"**Example Rescue server (rescue Action)**"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"a78fa567_eaae35a7","line":799,"range":{"start_line":798,"start_character":0,"end_line":799,"end_character":33},"updated":"2021-11-22 18:34:14.000000000","message":"You might also want to highlight that this is config driven which is awful.","commit_id":"57d8e7c97c48cf9e7e0a72efd5442d19d0c70ed8"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c116f79a3b440e4dc5529c1dfc5f9a4b48325570","unresolved":true,"context_lines":[{"line_number":795,"context_line":"--------"},{"line_number":796,"context_line":""},{"line_number":797,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"  - adminPass: adminPass_response"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"**Example Rescue server (rescue Action)**"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1adcc89f_237986a3","line":799,"range":{"start_line":798,"start_character":0,"end_line":799,"end_character":33},"in_reply_to":"a78fa567_eaae35a7","updated":"2021-11-23 15:53:17.000000000","message":"I would need to test this - is this *absent* entirely if injection isn\u0027t enabled, or is it present with the value the user supplied in the boot request, but meaningless because nothing was actually injected?","commit_id":"57d8e7c97c48cf9e7e0a72efd5442d19d0c70ed8"}]}