)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"806c13da7d09b6a76dccd487de7086d6ea549ec0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-26 02:47:40 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMWare: spawn refactor - get_vif_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_vif_info converts OpenStacks nova network_info"},{"line_number":10,"context_line":"into a data structure that is used to prepare the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAWH%2F90v8%3D","line":7,"updated":"2014-04-01 21:25:00.000000000","message":"change to\nVMWare: spawn refactor - phase 1 - get_vif_info","commit_id":"d80609a865ccb773702192c706adb14498a84df2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e7ebbacc42ad4313ba7d33a181630b89851da973","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-03-26 02:47:40 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMWare: spawn refactor - get_vif_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"get_vif_info converts OpenStacks nova network_info"},{"line_number":10,"context_line":"into a data structure that is used to prepare the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAWH%2F9xmU%3D","line":7,"in_reply_to":"AAAAWH%2F90v8%3D","updated":"2014-04-02 08:20:20.000000000","message":"Done","commit_id":"d80609a865ccb773702192c706adb14498a84df2"}],"nova/virt/vmwareapi/vif.py":[{"author":{"_account_id":10327,"name":"Feng Xi Yan","email":"yanfengxi@cn.ibm.com","username":"yanfengxi"},"change_message_id":"95dffc5af3e6cf9789a8db09544868c4fab63344","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def get_vif_info(session, cluster, is_neutron, vif_model, network_info):"},{"line_number":158,"context_line":"    vif_infos \u003d []"},{"line_number":159,"context_line":"    if network_info is None:"},{"line_number":160,"context_line":"        return vif_infos"},{"line_number":161,"context_line":"    for vif in network_info:"},{"line_number":162,"context_line":"        mac_address \u003d vif[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B4e4%3D","line":159,"updated":"2014-03-22 01:01:10.000000000","message":"L159-L160 can be removed.","commit_id":"a4e85b3b28107f1b9ae2f91ea05997a6aede40e9"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7f18cc7efe8594ac33f3ee7766c318a1a5b76b9e","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def get_vif_info(session, cluster, is_neutron, vif_model, network_info):"},{"line_number":158,"context_line":"    vif_infos \u003d []"},{"line_number":159,"context_line":"    if network_info is None:"},{"line_number":160,"context_line":"        return vif_infos"},{"line_number":161,"context_line":"    for vif in network_info:"},{"line_number":162,"context_line":"        mac_address \u003d vif[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F%2B3Ho%3D","line":159,"in_reply_to":"AAAAWH%2F%2B4e4%3D","updated":"2014-03-23 07:03:22.000000000","message":"That is required - without it you get:\n\nTraceback (most recent call last):\n  File \"nova/tests/virt/vmwareapi/test_vif.py\", line 329, in test_get_vif_info_none\n    \u0027is_neutron\u0027, \u0027fake_model\u0027, None)\n  File \"nova/virt/vmwareapi/vif.py\", line 159, in get_vif_info\n    for vif in network_info:\nTypeError: \u0027NoneType\u0027 object is not iterable","commit_id":"a4e85b3b28107f1b9ae2f91ea05997a6aede40e9"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"aae6f6c2a849703cbdfb8b1feab99a9c5c96323a","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def get_vif_info(session, cluster, is_neutron, vif_model, network_info):"},{"line_number":158,"context_line":"    vif_infos \u003d []"},{"line_number":159,"context_line":"    if network_info is None:"},{"line_number":160,"context_line":"        return vif_infos"},{"line_number":161,"context_line":"    for vif in network_info:"},{"line_number":162,"context_line":"        mac_address \u003d vif[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F%2Bf%2FI%3D","line":159,"updated":"2014-03-26 11:36:40.000000000","message":"A little problem, if it would better use \"if not network_info\"?\n\nI am not sure if the network_info can be \"[]\" :)\n\nMy Best.","commit_id":"d80609a865ccb773702192c706adb14498a84df2"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"806c13da7d09b6a76dccd487de7086d6ea549ec0","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def get_vif_info(session, cluster, is_neutron, vif_model, network_info):"},{"line_number":158,"context_line":"    vif_infos \u003d []"},{"line_number":159,"context_line":"    if network_info is None:"},{"line_number":160,"context_line":"        return vif_infos"},{"line_number":161,"context_line":"    for vif in network_info:"},{"line_number":162,"context_line":"        mac_address \u003d vif[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F90uQ%3D","line":159,"in_reply_to":"AAAAWH%2F%2Bf%2FI%3D","updated":"2014-04-01 21:25:00.000000000","message":"Good point. But I don\u0027t think this requires a change...\n\nhttps://github.com/openstack/nova/blob/master/nova/network/model.py#L352\n\nLooks like it is possible for the NetworkInfo object to be an empty list. But if it is empty the for loop below is does nothing.\n\nThe only time we could have a problem is if network_info were a None value, in which case returning an empty list is still the right thing to do.","commit_id":"d80609a865ccb773702192c706adb14498a84df2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e7ebbacc42ad4313ba7d33a181630b89851da973","unresolved":false,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"def get_vif_info(session, cluster, is_neutron, vif_model, network_info):"},{"line_number":158,"context_line":"    vif_infos \u003d []"},{"line_number":159,"context_line":"    if network_info is None:"},{"line_number":160,"context_line":"        return vif_infos"},{"line_number":161,"context_line":"    for vif in network_info:"},{"line_number":162,"context_line":"        mac_address \u003d vif[\u0027address\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F9xk8%3D","line":159,"in_reply_to":"AAAAWH%2F90uQ%3D","updated":"2014-04-02 08:20:20.000000000","message":"I prefer the if not ...","commit_id":"d80609a865ccb773702192c706adb14498a84df2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"91b4dfb747340ecc3237b68f519b8ce7fe8f3f09","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               help\u003d\u0027Name of Integration Bridge\u0027),"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"CONF.register_opts(vmwareapi_vif_opts, \u0027vmware\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def _get_associated_vswitch_for_interface(session, interface, cluster\u003dNone):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXH%2F%2F5O8%3D","line":40,"updated":"2014-04-16 16:30:12.000000000","message":"Hmm, I guess this automatically creates a \"vmware\" group, right? You\u0027re losing the nice title that was there previously, I think. Any reason not to bring over the creation of the group object from vmops.py like it was?","commit_id":"273bb44d66cfab766564e6e516c493e701981113"}]}