)]}'
{"id":"openstack%2Fnova~819389","triplet_id":"openstack%2Fnova~master~I4849ed0d43bb4078fee3b5476dbcfd0b4f66de4f","project":"openstack/nova","branch":"master","topic":"bp/policy-defaults-refresh-2","attention_set":{},"removed_from_attention_set":{"8556":{"account":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"last_update":"2021-11-30 20:50:22.000000000","reason":"Ghanshyam replied on the change"}},"hashtags":[],"change_id":"I4849ed0d43bb4078fee3b5476dbcfd0b4f66de4f","subject":"Introduce \u0027admin\u0027 policy base rule","status":"ABANDONED","created":"2021-11-26 01:15:41.000000000","updated":"2021-11-30 20:50:25.000000000","total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"839ef691587b405c0a143cca1044aabf77d8f40d","_number":819389,"virtual_id_number":819389,"owner":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"actions":{},"labels":{"Verified":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-11-26 01:55:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-26 03:47:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-11-26 03:55:21.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2021-11-26 04:17:56.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"}],"messages":[{"id":"4e2a94b04e8a29ca8975c36c1dccf834d281847a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-11-26 01:15:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ffaf09aa23fff240ff9cfe5bda97f266a83c54fa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-11-26 01:22:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b78489d22850bc63fabf50a2c29594dcb4457e31","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-26 01:55:49.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/93f161a6fba7452abc6681b53dfd500f : FAILURE in 28m 58s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/4a0bfaf095544753944e52904dea30ef : FAILURE in 27m 37s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"a9f7b5f2b7dcea8a274f9755d1c0582069b1471f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-11-26 01:56:36.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"68b6a5fd67eb3c984f90386bb00bd0fd9196920c","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-11-26 01:59:15.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"3017e054656ba4687a2eaac13fee6ea6da47ba96","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-26 02:25:46.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/2c66b1afca6d4a3eb21111fb31659a85 : SUCCESS in 19m 37s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/a92a299da0a24160960eb0a53a81aa50 : SUCCESS in 24m 33s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"d954db9a2f4b900eea435537774489f7419c9651","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-26 03:47:32.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/97e0c70e26994f73920d08876474fe53 : SUCCESS in 1h 34m 15s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/ca23f83e6451464ebefc42885279ca75 : SUCCESS in 1h 40m 19s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/63fa2592b67f401f8899273e5fd3cc5e : SUCCESS in 17m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/870e2d0781d044fa8f2fc800eedb4d02 : SUCCESS in 14m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/afb6577cdb95415aa46bf3aab0c10b8a : SUCCESS in 12m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/42c25749212d477d96d7a23c2d2df4fe : SUCCESS in 13m 26s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/f9c884309a2e404fbaeba4b2a9fa45ae : SUCCESS in 13m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4067fb8bc4f44d28bf1b10b965069f87 : SUCCESS in 11m 19s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/888241b96d1b4d178cd1cfee765b24cc : SUCCESS in 1h 13m 03s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/82a20d3570c2478d97e452f0c12a4bd6 : FAILURE in 1h 10m 36s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/aa495a63f6724fa49b27b7ae5573dc10 : SUCCESS in 51m 35s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/1de0b055b09d4d4f99a6b576590bf81d : SUCCESS in 47m 38s (non-voting)\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/06647b14047940b4b4b67219341b89a7 : SUCCESS in 1h 12m 34s\n- nova-next https://zuul.opendev.org/t/openstack/build/24388a0a69404ca49e927038159a20eb : SUCCESS in 1h 32m 41s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/6a5c3c530fbf4da3a98f2c44bcdcef6b : SUCCESS in 6m 14s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/95e182ae208346919533c16ca768b10e : SUCCESS in 20m 13s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/3d90e6432851404896ecc714c7fc846c : SUCCESS in 20m 06s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/40d7ebf138114644a95581f075153e67 : SUCCESS in 20m 33s (non-voting)\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/20a7bc4713eb4d5a9df7bb8fd5d938cc : FAILURE in 1h 02m 40s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/5bf46f0c204a44a3989575c744a20c9b : SUCCESS in 48m 22s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/4444eb9d58074c6ba3ebcc53ded54944 : SUCCESS in 46m 44s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/afc23d2fbd7c40b2ba940df075315a64 : SUCCESS in 28m 29s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/f899dbac85c14a189110c554d5ce69f5 : SUCCESS in 38m 14s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"76bfb3a572fbf33199015fd08e8e13429b4270c6","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2021-11-26 03:55:21.000000000","message":"Patch Set 3:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/89/819389/3/check/tempest-dsvm-full-focal-py3/c5ed61f/ : SUCCESS in 1h 54m 55s","accounts_in_message":[],"_revision_number":3},{"id":"2f4f7677838ecab59af30a101f727df7d71d3d04","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-11-26 04:17:56.000000000","message":"Patch Set 3:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/819389/3/iscsi : SUCCESS in 2h 20m 15s","accounts_in_message":[],"_revision_number":3},{"id":"2d08de3a1b9c61ad5ef4169cab87aa6bd4ff684b","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-11-30 19:07:49.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"d7394af32f13401dbf91b152ff17a301d46f15d8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-11-30 19:39:39.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"227170fa16874983c954faf21bd54f9e7f47fc74","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2021-11-30 19:57:24.000000000","message":"Patch Set 4:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/819389/4/iscsi : FAILURE in 16m 40s","accounts_in_message":[],"_revision_number":4},{"id":"d21ff6c54b8f498f7442d663d937445adb787827","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-11-30 20:12:19.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/8430840e6b854fad8e3c802a2fd71727 : SUCCESS in 29m 20s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/2e33e451d5b24126afcc8632191e1674 : SUCCESS in 20m 09s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"d74a24fe04227b2a76d4889879f4986b95e8647d","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-11-30 20:50:22.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"839ef691587b405c0a143cca1044aabf77d8f40d","tag":"autogenerated:gerrit:abandon","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2021-11-30 20:50:25.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"34b7b2f382e662c813846204e40f21ec16656346","revisions":{"4753bbb106b5f85c225a7c61ae1a15a16acf3006":{"kind":"REWORK","_number":1,"created":"2021-11-26 01:15:41.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/89/819389/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/89/819389/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/89/819389/1"}}},"commit":{"parents":[{"commit":"9cc235f918aa7daf679ac2240e030854babfa6de","subject":"Revert project-specific APIs for servers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9cc235f918aa7daf679ac2240e030854babfa6de"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-11-26 00:50:14.000000000","tz":-360},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-11-26 00:50:14.000000000","tz":-360},"subject":"Introduce \u0027admin\u0027 policy base rule","message":"Introduce \u0027admin\u0027 policy base rule\n\nWith the new direction in RBAC design, we need to make\nsure that default rules are not tighly tied with the scope.\nWith the new policy, if anyone disable the scope checks\n(nova.conf-\u003eenforce_scope\u003dFalse which is default currently)\ntheir old token like legacy admin or project admin should\nkeep working on the system admin APIs.\n\nThis commit adds a new rule \u0027admin\u0027 which is standard and easy\nto understand name for admin role. We will use this for all the\nsystem and project(with project-id) admin APIs.\n\nPartial implement blueprint policy-defaults-refresh-2\n\nChange-Id: I4849ed0d43bb4078fee3b5476dbcfd0b4f66de4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4753bbb106b5f85c225a7c61ae1a15a16acf3006"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4753bbb106b5f85c225a7c61ae1a15a16acf3006"}]},"branch":"refs/heads/master"},"bb93afaccca875bd35d220bb3f8311b5c0c61898":{"kind":"REWORK","_number":2,"created":"2021-11-26 01:22:35.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/89/819389/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/89/819389/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/89/819389/2"}}},"commit":{"parents":[{"commit":"9cc235f918aa7daf679ac2240e030854babfa6de","subject":"Revert project-specific APIs for servers","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9cc235f918aa7daf679ac2240e030854babfa6de"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-11-26 00:50:14.000000000","tz":-360},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-11-26 01:22:23.000000000","tz":-360},"subject":"Introduce \u0027admin\u0027 policy base rule","message":"Introduce \u0027admin\u0027 policy base rule\n\nWith the new direction in RBAC design, we need to make\nsure that default rules are not tighly tied with the scope.\nWith the new policy, if anyone disable the scope checks\n(nova.conf-\u003eenforce_scope\u003dFalse which is default currently)\ntheir old token like legacy admin or project admin should\nkeep working on the system admin APIs.\n\nThis commit adds a new rule \u0027admin\u0027 which is standard and easy\nto understand name for admin role. We will use this for all the\nsystem and project(with project-id) admin APIs.\n\nPartial implement blueprint policy-defaults-refresh-2\n\nChange-Id: I4849ed0d43bb4078fee3b5476dbcfd0b4f66de4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bb93afaccca875bd35d220bb3f8311b5c0c61898"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bb93afaccca875bd35d220bb3f8311b5c0c61898"}]},"branch":"refs/heads/master"},"7ca1dc0a1f20554e355e367926de129cd7ce5f13":{"kind":"REWORK","_number":3,"created":"2021-11-26 01:56:36.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/89/819389/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/89/819389/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/89/819389/3"}}},"commit":{"parents":[{"commit":"4a359d576ddbc4b104116515c7e8b4176ac511f7","subject":"Merge \"db: Don\u0027t use legacy \u0027Row()\u0027 methods\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4a359d576ddbc4b104116515c7e8b4176ac511f7"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-11-26 01:53:25.000000000","tz":-360},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-11-26 01:55:58.000000000","tz":-360},"subject":"Introduce \u0027admin\u0027 policy base rule","message":"Introduce \u0027admin\u0027 policy base rule\n\nWith the new direction in RBAC design, we need to make\nsure that default rules are not tighly tied with the scope.\nSo that if anyone disable the scope checks\n(nova.conf-\u003eenforce_scope\u003dFalse which is default currently)\nthe old token like legacy admin or project admin should\nkeep working on the system admin APIs.\n\nThis commit adds a new rule \u0027admin\u0027 which is standard and easy\nto understand name for admin role. We will use this for all the\nsystem and project(with project-id) admin APIs.\n\nPartial implement blueprint policy-defaults-refresh-2\n\nChange-Id: I4849ed0d43bb4078fee3b5476dbcfd0b4f66de4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7ca1dc0a1f20554e355e367926de129cd7ce5f13"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7ca1dc0a1f20554e355e367926de129cd7ce5f13"}]},"branch":"refs/heads/master"},"34b7b2f382e662c813846204e40f21ec16656346":{"kind":"REWORK","_number":4,"created":"2021-11-30 19:39:39.000000000","uploader":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"ref":"refs/changes/89/819389/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/89/819389/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/819389/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/89/819389/4"}}},"commit":{"parents":[{"commit":"d630615a02469442fb50ed4aa7e092206a28166a","subject":"Merge \"Updating tests with Yoga testing runtime\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d630615a02469442fb50ed4aa7e092206a28166a"}]}],"author":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-11-26 01:53:25.000000000","tz":-360},"committer":{"name":"Ghanshyam Mann","email":"gmann@ghanshyammann.com","date":"2021-11-30 19:28:44.000000000","tz":-360},"subject":"Introduce \u0027admin\u0027 policy base rule","message":"Introduce \u0027admin\u0027 policy base rule\n\nWith the new direction in RBAC design, we need to make\nsure that default rules are not tighly tied with the scope.\nSo that if anyone disable the scope checks\n(nova.conf-\u003eenforce_scope\u003dFalse which is default currently)\nthe old token like legacy admin or project admin should\nkeep working on the system admin APIs.\n\nThis commit renames \u0027context_is_admin\u0027 rule to \u0027admin\u0027 and add\nold rule as deprecated rule for new \u0027admin\u0027 rule. so that if anyone\nhas overriden the \u0027context_is_admin\u0027 rule will keep working. New rule\nname \u0027admin\u0027 is helpful and easy to use/read when we remove the\nold \u0027admin_api\u0027 and \u0027context_is_admin\u0027 rules and keep single rule to\nbe used or override for admin APIs.\n\nPartial implement blueprint policy-defaults-refresh-2\n\nChange-Id: I4849ed0d43bb4078fee3b5476dbcfd0b4f66de4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/34b7b2f382e662c813846204e40f21ec16656346"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/34b7b2f382e662c813846204e40f21ec16656346"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}