)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed507fc9133685c512272de62c44c2c9e1a5aa62","unresolved":true,"context_lines":[{"line_number":66,"context_line":"78a08d44ea68b31e27ce344f452756886ad309bd, that added the migration"},{"line_number":67,"context_line":"parameter to finish_revert_migration(). This is no longer needed, as"},{"line_number":68,"context_line":"the migration was only used to obtain plug-time events. We\u0027ll have to"},{"line_number":69,"context_line":"undo that as well."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Closes-bug: 1952003"},{"line_number":72,"context_line":"Change-Id: I3cb39a9ec2c260f422b3c48122b9db512cdd799b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d75b4b5c_edd2f170","line":69,"updated":"2022-01-31 16:23:07.000000000","message":"Does this have to be done _here_? I suspect not since all tests are passing but I\u0027m not certain","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"cc87d27c029415ad939d618bf8366db1a1e68259","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b92eafe4_64453be7","updated":"2021-11-29 18:56:53.000000000","message":"recheck","commit_id":"2f590c2dcaa5cc21ac732a737e6b5aa4145d77c0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"dc4604d15bba6bde4220217a2a1801828b8da51c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b977be64_91c904d4","updated":"2021-11-29 17:10:26.000000000","message":"recheck","commit_id":"2f590c2dcaa5cc21ac732a737e6b5aa4145d77c0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ed866fe9bd38c279722650f50a65f4870e3ed20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"af7d0db5_b1bae336","updated":"2022-02-01 12:33:26.000000000","message":"I\u0027m OK with this but I hold my +2 as there is an unresolved request inline.","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed507fc9133685c512272de62c44c2c9e1a5aa62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97c1d123_f8bcc192","updated":"2022-01-31 16:23:07.000000000","message":"Looks reasonable. Two potential TODOs inline though, so not +2ing as a result","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"400e4cff057ab10fc72cdc67ade492bd7b6f37d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"be5a5611_d71d81c8","updated":"2022-02-01 22:28:23.000000000","message":"Please stop rechecking until https://bugs.launchpad.net/tempest/+bug/1959682 is fixed.","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"26e34e7cf4387ecf2a1dc6b9b2ca85ce94c0eba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ccb7395d_902ec7d4","updated":"2022-02-03 15:09:50.000000000","message":"The last one here is\n\ntest_anti_affinity_group\n\nhttps://60372c8100ce208cc5d0-295a7ccb810a3ccc27324edb0b3083ba.ssl.cf2.rackcdn.com/819494/6/check/nova-tox-functional-centos8-py36/56850f8/testr_results.html\n\n2022-02-03 11:40:59,721 ERROR [nova.api.openstack.wsgi] Unexpected exception in API method\nTraceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/nova/.tox/functional-py36/lib/python3.6/site-packages/urllib3/connectionpool.py\", line 440, in _make_request\n    httplib_response \u003d conn.getresponse(buffering\u003dTrue)\nTypeError: getresponse() got an unexpected keyword argument \u0027buffering\u0027\n\n\nDoesn\u0027t look related: I filed a new bug here https://bugs.launchpad.net/nova/+bug/1959909\n\n","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"b8d7540daa82984422fa34a4a3749f6775f639f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a5cdddfb_f82cef74","updated":"2022-02-04 15:34:34.000000000","message":"\\o/","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8a24aa20aa03269d70445404c0303a5f43b32b8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3af8ab03_181559e7","updated":"2022-02-01 17:09:39.000000000","message":"followup has been proposed","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2d52807f3751143ec20c95e12b9e312413819db9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e153397_adf3d0c6","updated":"2022-01-31 13:14:27.000000000","message":"for backport reason we are going to defer fixing the other bug in this change\nand keeping this as a clean or mostly clean revert.","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"4c7e71ac91fa2b4544bfc4d4781c24d007d5d4fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4b51f1ef_107409bd","updated":"2022-02-03 15:10:05.000000000","message":"recheck","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"419441c81d80206a10378125819f557af9b4a089","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"501e2271_29944c3e","updated":"2022-02-02 09:45:58.000000000","message":"recheck","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"fca9d3ed0530374c71933679444b1d234808b1f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6b69ea32_99a7eebb","updated":"2022-01-31 16:10:27.000000000","message":"recheck","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"6fb14b8b22265cd6bede28e64f1b3d3860b4212b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"87564ae0_4ffdbbf0","updated":"2022-02-03 19:42:55.000000000","message":"recheck","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"1f626d873cde8868e1c5a80599ca6c852792bd85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a2946027_d62d6f07","updated":"2022-02-03 11:22:05.000000000","message":"recheck","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"73cbe748344402a04260a09ca64cbbefb220bd1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c41f1351_c09380fe","updated":"2022-02-01 20:36:30.000000000","message":"recheck","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"0a43aa785a53aebfd0da35c05f5c81064b93bc3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d9439cdd_52a06a9e","updated":"2022-02-01 13:11:03.000000000","message":"recheck","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"2694499e8a11e122f566f145ed000baa8bbbb6dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f3992cc5_acf89a2e","updated":"2022-02-04 11:33:58.000000000","message":"recheck","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ed819a7b5d98a03146819385c56e76680a400eb3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5330cd95_839e4792","updated":"2022-02-02 18:24:50.000000000","message":"recheck (╯°□°）╯︵ ┻━┻","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"444fbe449dd619e7993222f874e3babc2126fe0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4c85b6b7_c546b32e","updated":"2022-02-02 11:27:55.000000000","message":"recheck unrelated grenade test_network_basic_ops failure","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"501243241b312d8ec248f745e1e8449da8fe1788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"14e08b11_91cbff46","updated":"2022-02-02 15:33:23.000000000","message":"recheck unrelated test_live_migration_with_trunk nova-next failure","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ce751600b14051aec861282a1a2248caf0cf9e55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"52b73102_c781a79c","in_reply_to":"a2946027_d62d6f07","updated":"2022-02-03 13:14:18.000000000","message":"yepp the trunk test issue is a known neutron bug https://bugs.launchpad.net/neutron/+bug/1940425","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"b3e88de310d7314f10f01a6da75fbe9fcb904bc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d41d0a18_0fe08901","in_reply_to":"af7d0db5_b1bae336","updated":"2022-02-01 16:03:52.000000000","message":"https://review.opendev.org/c/openstack/nova/+/827314 is the requested WIP patch.","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"06b33f7329f5996890057d3792f5d3e409166cbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f53f3798_64c838d4","in_reply_to":"be5a5611_d71d81c8","updated":"2022-02-02 10:34:18.000000000","message":"Ack, my apologies for the extra noise.","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8a24aa20aa03269d70445404c0303a5f43b32b8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"225d9897_5c4434f5","in_reply_to":"d41d0a18_0fe08901","updated":"2022-02-01 17:09:39.000000000","message":"Cool. Upgrading my vote.","commit_id":"0b0f40d1b308b29da537859b72080488560c23d4"}],"nova/network/model.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e57ede8aeb5f848cd2cff681f8cc8acebafe7681","unresolved":true,"context_lines":[{"line_number":491,"context_line":"        be sent by Neutron at \"plugtime\" - in other words, as soon as neutron"},{"line_number":492,"context_line":"        completes configuring the network backend."},{"line_number":493,"context_line":"        \"\"\""},{"line_number":494,"context_line":"        return self.is_hybrid_plug_enabled()"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def is_hybrid_plug_enabled(self):"},{"line_number":497,"context_line":"        return self[\u0027details\u0027].get(VIF_DETAILS_OVS_HYBRID_PLUG, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"671a05aa_18507001","line":494,"updated":"2021-12-10 14:53:16.000000000","message":"we should be checking the vif status here also\n\nreturn self.is_hybrid_plug_enabled() and self[\u0027active\u0027] \u003d\u003d True\nor jsut\nreturn self.is_hybrid_plug_enabled() and self[\u0027active\u0027]\n\nthis is needed to fully adress https://bugs.launchpad.net/nova/+bug/1951623","commit_id":"2f590c2dcaa5cc21ac732a737e6b5aa4145d77c0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c5dbdc130b41920541907941fac2ea936c900e16","unresolved":true,"context_lines":[{"line_number":491,"context_line":"        be sent by Neutron at \"plugtime\" - in other words, as soon as neutron"},{"line_number":492,"context_line":"        completes configuring the network backend."},{"line_number":493,"context_line":"        \"\"\""},{"line_number":494,"context_line":"        return self.is_hybrid_plug_enabled()"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def is_hybrid_plug_enabled(self):"},{"line_number":497,"context_line":"        return self[\u0027details\u0027].get(VIF_DETAILS_OVS_HYBRID_PLUG, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"57888766_0e9a3141","line":494,"in_reply_to":"3f290273_38a18d2b","updated":"2022-01-25 02:17:11.000000000","message":"we spoke about this on irc\n\nim ok to drop my -1 but i would like to see at least a WIP patch up to adress the other bug as a followup.\n\nonce that is up i think im good to proceed with this.\n\nill review again tomorrow to confirm and update my CR accordingly.","commit_id":"2f590c2dcaa5cc21ac732a737e6b5aa4145d77c0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed507fc9133685c512272de62c44c2c9e1a5aa62","unresolved":true,"context_lines":[{"line_number":491,"context_line":"        be sent by Neutron at \"plugtime\" - in other words, as soon as neutron"},{"line_number":492,"context_line":"        completes configuring the network backend."},{"line_number":493,"context_line":"        \"\"\""},{"line_number":494,"context_line":"        return self.is_hybrid_plug_enabled()"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def is_hybrid_plug_enabled(self):"},{"line_number":497,"context_line":"        return self[\u0027details\u0027].get(VIF_DETAILS_OVS_HYBRID_PLUG, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"cab267a9_de5ded3f","line":494,"in_reply_to":"57888766_0e9a3141","updated":"2022-01-31 16:23:07.000000000","message":"Does this patch exist now? Link if so?","commit_id":"2f590c2dcaa5cc21ac732a737e6b5aa4145d77c0"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"1b255a20b25ce4eb9d046f55dcd02369197cbefb","unresolved":true,"context_lines":[{"line_number":491,"context_line":"        be sent by Neutron at \"plugtime\" - in other words, as soon as neutron"},{"line_number":492,"context_line":"        completes configuring the network backend."},{"line_number":493,"context_line":"        \"\"\""},{"line_number":494,"context_line":"        return self.is_hybrid_plug_enabled()"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def is_hybrid_plug_enabled(self):"},{"line_number":497,"context_line":"        return self[\u0027details\u0027].get(VIF_DETAILS_OVS_HYBRID_PLUG, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f290273_38a18d2b","line":494,"in_reply_to":"671a05aa_18507001","updated":"2021-12-10 15:18:04.000000000","message":"Yeah, it\u0027s a different bug though. I initially had them both in the commit message, but then realized what you said here, and removed 1951623. That fix should live in a separate patch.","commit_id":"2f590c2dcaa5cc21ac732a737e6b5aa4145d77c0"}]}