)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"54382c270c0e87ffc95aabddfcfac64c7b7f0b50","unresolved":false,"context_lines":[{"line_number":19,"context_line":"migration context is not applied yet. This leads to CPU pinning error if"},{"line_number":20,"context_line":"the source topology does not fit to the dest topology. Also it stops the"},{"line_number":21,"context_line":"periodic task and leaves the tracker in an inconsistent state. The"},{"line_number":22,"context_line":"inconsistent state only cleanup up after the periodic is run outside of"},{"line_number":23,"context_line":"the race window."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch applies the migration context temporarily to the specific"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"13f4bf08_1ddb31fb","line":22,"range":{"start_line":22,"start_character":19,"end_line":22,"end_character":31},"updated":"2021-12-15 11:26:22.000000000","message":"nit: is only cleaned","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"54382c270c0e87ffc95aabddfcfac64c7b7f0b50","unresolved":false,"context_lines":[{"line_number":20,"context_line":"the source topology does not fit to the dest topology. Also it stops the"},{"line_number":21,"context_line":"periodic task and leaves the tracker in an inconsistent state. The"},{"line_number":22,"context_line":"inconsistent state only cleanup up after the periodic is run outside of"},{"line_number":23,"context_line":"the race window."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch applies the migration context temporarily to the specific"},{"line_number":26,"context_line":"instances during the periodic to keep resource accounting correct."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf3615ec_0c63a267","line":23,"updated":"2021-12-15 11:26:22.000000000","message":"Sigh, I missed this when fixing other race conditions in changes I26b050c402f5721fc490126e9becb643af9279b4 and I29d6f4a78c0206385a550967ce244794e71cef6d","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"209c526566c067f983c30d64e255635ac733293d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae706f69_c8700591","updated":"2021-12-06 20:39:26.000000000","message":"FYI a patch that might be for the same issue:\n\nhttps://review.opendev.org/c/openstack/nova/+/820381","commit_id":"4ea8787daf8430911a3fc5a792157e2893b5d3eb"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b57e49c95726ad50e79a562b405ff39a71435706","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"262548ff_c6ae40be","updated":"2021-12-13 14:10:41.000000000","message":"Eventually we said yes to this, and as the test verified, it fixes both of the two issues.","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"143ab1fb59b486cea32778f05c5d38045eeabeda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e77aac8_6125f1a7","updated":"2021-12-07 14:32:18.000000000","message":"First glance looks good.","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"},{"author":{"_account_id":33608,"name":"Gabriel Silva Trevisan","display_name":"Gabriel Silva Trevisan","email":"gabriel.silvatrevisan@windriver.com","username":"gtrevisan"},"change_message_id":"4605da1b9aa7883df5924e222e7d1555044fc164","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a230b04_ac2425d4","updated":"2021-12-07 16:16:05.000000000","message":"Looks good to me. Tested the fix on stable/ussuri by forcing the task to start at the beginning of finish_resize, then issuing revert-resize, and no issues occurred after the fix.","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"54382c270c0e87ffc95aabddfcfac64c7b7f0b50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"402b258f_7c181eb2","updated":"2021-12-15 11:26:22.000000000","message":"Sigh, this thing is so racy it would give Usain a run for his money 🙈 Nice work here","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ad9f7d10af98aa0ab30e39248c3a9345251b4881","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6fd2fd2c_89f2200e","updated":"2021-12-07 23:14:55.000000000","message":"recheck bug 1944779","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"}],"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"143ab1fb59b486cea32778f05c5d38045eeabeda","unresolved":true,"context_lines":[{"line_number":1021,"context_line":"        post \u003d {\u0027revertResize\u0027: {}}"},{"line_number":1022,"context_line":"        self.admin_api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":1023,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":1024,"context_line":"        self.assertNotIn("},{"line_number":1025,"context_line":"            \u0027nova.exception.CPUUnpinningInvalid: CPU set to unpin [1] must be \u0027"},{"line_number":1026,"context_line":"            \u0027a subset of pinned CPU set [0]\u0027,"},{"line_number":1027,"context_line":"            self.stdlog.logger.output,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f4d648e4_29878fe6","line":1024,"updated":"2021-12-07 14:32:18.000000000","message":"so this also fixes the finish_resize case directly.","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b57e49c95726ad50e79a562b405ff39a71435706","unresolved":true,"context_lines":[{"line_number":1021,"context_line":"        post \u003d {\u0027revertResize\u0027: {}}"},{"line_number":1022,"context_line":"        self.admin_api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":1023,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":1024,"context_line":"        self.assertNotIn("},{"line_number":1025,"context_line":"            \u0027nova.exception.CPUUnpinningInvalid: CPU set to unpin [1] must be \u0027"},{"line_number":1026,"context_line":"            \u0027a subset of pinned CPU set [0]\u0027,"},{"line_number":1027,"context_line":"            self.stdlog.logger.output,"}],"source_content_type":"text/x-python","patch_set":2,"id":"c4145be7_1ac2b207","line":1024,"in_reply_to":"0be2632c_0edd9eaf","updated":"2021-12-13 14:10:41.000000000","message":"++","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"54382c270c0e87ffc95aabddfcfac64c7b7f0b50","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"        post \u003d {\u0027revertResize\u0027: {}}"},{"line_number":1022,"context_line":"        self.admin_api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":1023,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":1024,"context_line":"        self.assertNotIn("},{"line_number":1025,"context_line":"            \u0027nova.exception.CPUUnpinningInvalid: CPU set to unpin [1] must be \u0027"},{"line_number":1026,"context_line":"            \u0027a subset of pinned CPU set [0]\u0027,"},{"line_number":1027,"context_line":"            self.stdlog.logger.output,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6165bfa3_f6d9c8cb","line":1024,"in_reply_to":"c4145be7_1ac2b207","updated":"2021-12-15 11:26:22.000000000","message":"Ack","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ab3c739d233b5ed3272a5227e85b1a7c5c08670b","unresolved":true,"context_lines":[{"line_number":1021,"context_line":"        post \u003d {\u0027revertResize\u0027: {}}"},{"line_number":1022,"context_line":"        self.admin_api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":1023,"context_line":"        self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":1024,"context_line":"        self.assertNotIn("},{"line_number":1025,"context_line":"            \u0027nova.exception.CPUUnpinningInvalid: CPU set to unpin [1] must be \u0027"},{"line_number":1026,"context_line":"            \u0027a subset of pinned CPU set [0]\u0027,"},{"line_number":1027,"context_line":"            self.stdlog.logger.output,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0be2632c_0edd9eaf","line":1024,"in_reply_to":"f4d648e4_29878fe6","updated":"2021-12-08 13:56:53.000000000","message":"Yes. This proves that the fix covers both fault as they have the same root cause.\n\nI also got back test result from the downstream env where the original error was seen as it fixed the downstream test scenario(a lot of mixed resize and migration operations) as well.","commit_id":"32c1044d86a8d02712c8e3abdf8b3e4cff234a9c"}]}