)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3cefb978883b63c70a29c3424b77e6e6e2657493","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"daa7ade2_35e7e95d","updated":"2022-01-06 20:28:43.000000000","message":"Thanks Gustavo for the backport!\n\nThe patch is almost clean cherry pick from master, where the patch has merged. I only see some doc related change, that should be fixed (see my comment inline).\n\nOn the other hand, this bug fix is a bit \"featureish\", but maybe it is OK to backport. Anyway I\u0027d hear other stable cores opinion as well.\n\nGiving -1 now only for the doc related changes (also, please indicate if something is changed in the patch compared to the cherry pick, to make the reviewing easier)","commit_id":"b1257ae3b4ee1eccaa5bcc34d0b6f7802bb50c48"},{"author":{"_account_id":33006,"name":"Gustavo Santos","email":"gufsnts@gmail.com","username":"gooshtavow"},"change_message_id":"e9d4a862c4908ae76cad9c23d2e4147fe6159e0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5582acd6_89620247","in_reply_to":"daa7ade2_35e7e95d","updated":"2022-01-06 20:58:17.000000000","message":"Thank you for reviewing!\n\nYou\u0027re right, the differences from the original patch are in the docs and release notes, where you wrote the inline comments. They are the only changes in the other backports too, until Victoria, and I will update them accordingly once the best way to document that is settled.\n\nThe Ussuri patch is a little different, as I had to update the minimum libvirt version to 4.3.0, along with the fakelibvirt version used in the unit tests.\n\nPlease let me know what else I have to change in order to get this merged back to Ussuri. Thanks.","commit_id":"b1257ae3b4ee1eccaa5bcc34d0b6f7802bb50c48"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"4d7395962ddc54a7f33d212c1c8fb7bb7f66c4a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5b4e1143_af1e00a1","updated":"2022-04-21 11:53:03.000000000","message":"Considering Sylvain\u0027s review I\u0027m also upgrading to +2. Gate is also unblocked, so we can merge this. Thanks Gustavo!","commit_id":"15c32e89e4f5ad7823c490c976075280c5dfccd9"},{"author":{"_account_id":33006,"name":"Gustavo Santos","email":"gufsnts@gmail.com","username":"gooshtavow"},"change_message_id":"44944399a0d855028d1d9972555f2aa3bd766b30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"37d4c92f_b07efb11","updated":"2022-04-25 19:28:16.000000000","message":"Thank you for approving this, folks! Any chance we can get some attention for the Wallaby and Victoria code reviews? They are pretty much the same as this; only the Ussuri one brings more changes.","commit_id":"15c32e89e4f5ad7823c490c976075280c5dfccd9"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"88427aa7160057b5d87420254568be7e63498db9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cd2d3b20_db55669d","updated":"2022-01-07 08:03:22.000000000","message":"Thanks for the update! LGTM. As I mentioned previously i\u0027d rather wait for other stable cores to review this (regarding the backportability), so giving only +1 for now. (Anyway, I think this is probably OK)","commit_id":"15c32e89e4f5ad7823c490c976075280c5dfccd9"}],"doc/source/admin/virtual-gpu.rst":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3cefb978883b63c70a29c3424b77e6e6e2657493","unresolved":true,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"  .. versionchanged:: 24.0.0"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"   This has been resolved in the Xena release. See `bug 1948705`_."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"* Resizing an instance with a new flavor that has vGPU resources doesn\u0027t"},{"line_number":309,"context_line":"  allocate those vGPUs to the instance (the instance is created without"}],"source_content_type":"text/x-rst","patch_set":1,"id":"4a804aff_4ade7445","line":306,"updated":"2022-01-06 20:28:43.000000000","message":"I\u0027d rather leave this as it was originally (resolved in Yoga, 25.0.0) as 24.0.0 (Xena 1st release) does not contain this fix.\nOne possible update could be to extend this with a comment that says the fix is backported to Xena.","commit_id":"b1257ae3b4ee1eccaa5bcc34d0b6f7802bb50c48"},{"author":{"_account_id":33006,"name":"Gustavo Santos","email":"gufsnts@gmail.com","username":"gooshtavow"},"change_message_id":"e9d4a862c4908ae76cad9c23d2e4147fe6159e0c","unresolved":false,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"  .. versionchanged:: 24.0.0"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"   This has been resolved in the Xena release. See `bug 1948705`_."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"* Resizing an instance with a new flavor that has vGPU resources doesn\u0027t"},{"line_number":309,"context_line":"  allocate those vGPUs to the instance (the instance is created without"}],"source_content_type":"text/x-rst","patch_set":1,"id":"b48969a8_1b66a900","line":306,"in_reply_to":"4a804aff_4ade7445","updated":"2022-01-06 20:58:17.000000000","message":"Done","commit_id":"b1257ae3b4ee1eccaa5bcc34d0b6f7802bb50c48"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"88427aa7160057b5d87420254568be7e63498db9","unresolved":true,"context_lines":[{"line_number":303,"context_line":""},{"line_number":304,"context_line":"  .. versionchanged:: 25.0.0"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"   This has been resolved in the Yoga release and backported to Xena. See"},{"line_number":307,"context_line":"   `bug 1948705`_."},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"* Resizing an instance with a new flavor that has vGPU resources doesn\u0027t"}],"source_content_type":"text/x-rst","patch_set":3,"id":"85bf933e_229b6ee6","line":306,"range":{"start_line":306,"start_character":45,"end_line":306,"end_character":68},"updated":"2022-01-07 08:03:22.000000000","message":"Thanks, this looks good to me.","commit_id":"15c32e89e4f5ad7823c490c976075280c5dfccd9"}],"releasenotes/notes/bug-1948705-ff80ae392c525475.yaml":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3cefb978883b63c70a29c3424b77e6e6e2657493","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Amended the guest resume operation to support mediated devices, as"},{"line_number":5,"context_line":"    libvirt\u0027s minimum required version (v6.0.0) supports the hot-plug/unplug of"},{"line_number":6,"context_line":"    mediated devices, which was addressed in v4.3.0."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bf1c81d8_7f64c146","line":6,"updated":"2022-01-06 20:28:43.000000000","message":"MIN_LIBVIRT_VERSION is 6.0.0 in Xena, so this is still valid.","commit_id":"b1257ae3b4ee1eccaa5bcc34d0b6f7802bb50c48"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eaeb1e62d1974ea9f343bd68cc99fd6f10f78cfc","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Amended the guest resume operation to support mediated devices, as"},{"line_number":5,"context_line":"    libvirt\u0027s minimum required version (v6.0.0) supports the hot-plug/unplug of"},{"line_number":6,"context_line":"    mediated devices, which was addressed in v4.3.0."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"50a811c4_a8e95cdd","line":6,"in_reply_to":"50ddad65_41a5de5b","updated":"2022-04-13 09:36:44.000000000","message":"Correct, we can backport it.","commit_id":"b1257ae3b4ee1eccaa5bcc34d0b6f7802bb50c48"},{"author":{"_account_id":33006,"name":"Gustavo Santos","email":"gufsnts@gmail.com","username":"gooshtavow"},"change_message_id":"e9d4a862c4908ae76cad9c23d2e4147fe6159e0c","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Amended the guest resume operation to support mediated devices, as"},{"line_number":5,"context_line":"    libvirt\u0027s minimum required version (v6.0.0) supports the hot-plug/unplug of"},{"line_number":6,"context_line":"    mediated devices, which was addressed in v4.3.0."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"50ddad65_41a5de5b","line":6,"in_reply_to":"bf1c81d8_7f64c146","updated":"2022-01-06 20:58:17.000000000","message":"Ack. So there\u0027s nothing to change here, right?","commit_id":"b1257ae3b4ee1eccaa5bcc34d0b6f7802bb50c48"}]}
