)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a1932cdb684ff47bac8a84f30c5069674c6c2664","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Fixes:"},{"line_number":16,"context_line":"    - Changed \u0027start_compute\u0027 call to \u0027start_computes\u0027, since the former"},{"line_number":17,"context_line":"      is not present in Ussuri"},{"line_number":18,"context_line":"    - Added more memory to mock \u0027host_info\u0027, since the default would not"},{"line_number":19,"context_line":"      fit the instance. Default was changed in later releases"},{"line_number":20,"context_line":"    - Bumped the API version from 2.0 to 2.1 in the test, since"},{"line_number":21,"context_line":"      microversion 2.47 is required creating an instance"},{"line_number":22,"context_line":"      in a specific host and 2.0 is not supporting microversions. This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"6165acd9_47b207bb","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":61},"updated":"2022-05-19 13:57:49.000000000","message":"nit: this is actually valid for the Victoria version of this patch. In ussuri this part is clean cherry pick.","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6c81dda63492a8515949f2e4924782cce205cdd3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Fixes:"},{"line_number":16,"context_line":"    - Changed \u0027start_compute\u0027 call to \u0027start_computes\u0027, since the former"},{"line_number":17,"context_line":"      is not present in Ussuri"},{"line_number":18,"context_line":"    - Added more memory to mock \u0027host_info\u0027, since the default would not"},{"line_number":19,"context_line":"      fit the instance. Default was changed in later releases"},{"line_number":20,"context_line":"    - Bumped the API version from 2.0 to 2.1 in the test, since"},{"line_number":21,"context_line":"      microversion 2.47 is required creating an instance"},{"line_number":22,"context_line":"      in a specific host and 2.0 is not supporting microversions. This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"0458cd15_69fb8f58","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":61},"in_reply_to":"6165acd9_47b207bb","updated":"2022-06-02 09:03:04.000000000","message":"Ack","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33608,"name":"Gabriel Silva Trevisan","display_name":"Gabriel Silva Trevisan","email":"gabriel.silvatrevisan@windriver.com","username":"gtrevisan"},"change_message_id":"f56aa9690ebcb0f25ad7c375d641c1b602c80cc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"738edbd0_e650f978","updated":"2021-12-30 13:59:11.000000000","message":"recheck","commit_id":"3b1c7f6121202c8f510d048fb8bde2dea418b56f"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ed2f75a3311df6e3f469a21c93dcfeb6c393e4c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b2b41fa2_6d063ce7","updated":"2022-04-08 11:02:36.000000000","message":"@Gabriel: do you plan to backport this to stable/train too? Or should I make a change for it?","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":33608,"name":"Gabriel Silva Trevisan","display_name":"Gabriel Silva Trevisan","email":"gabriel.silvatrevisan@windriver.com","username":"gtrevisan"},"change_message_id":"035631a24bfc98f0fb47473be63b9d048dd3db55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c5934bc0_9cb6bc3a","in_reply_to":"b2b41fa2_6d063ce7","updated":"2022-04-13 12:53:14.000000000","message":"Hi, sorry for the late reply.\n\nHm, I was not planning for stable/train. Right now, I\u0027m focused on some other tasks, so it would probably take me some time to be able to get back to it. If it\u0027s okay, could you make the change?","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a40f3cdb3d984570754ed7f854b8f1fbbeef344","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e435c60_37731fde","in_reply_to":"c5934bc0_9cb6bc3a","updated":"2022-04-21 08:40:27.000000000","message":"Sure I can do the train backport. Thanks for the information.","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0bba081b6757b3eded544e35a69ade967ebc2e41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2febd148_1c50f4ec","updated":"2022-06-15 02:39:37.000000000","message":"I understand those couple of differences now, this looks good, backport from stable/victoria and differences are cited in the commit message, regression test coverage for bug fix, LGTM","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c9b3ea5769a96a638b2abc27b0fb7b5d93861c34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0b9cb99d_b062caa8","updated":"2022-04-28 18:02:40.000000000","message":"I\u0027ve only fixed my small comment on microversion handling. This looks good now.","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fb580607d1a37aee3c1b7289de06d124f0fa083a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"25393cd0_50896a83","updated":"2022-06-13 23:29:12.000000000","message":"Sorry I missed gibi\u0027s reply earlier.","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a1932cdb684ff47bac8a84f30c5069674c6c2664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"da51b635_00076e45","updated":"2022-05-19 13:57:49.000000000","message":"The backport looks good, tests are passing and stable/victoria version has merged. I was hesitant because of the api_major_version bump in ServersTestBase, but the tests are passing and v2.1 was introduced in mitaka, so shouldn\u0027t be a problem using it in \"newer\" stable branches.","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"122daf717bfc870eba1caf35a0f5245b409fb555","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7b247792_d75276f3","updated":"2022-05-03 15:45:54.000000000","message":"recheck the doc job issue should have been fixed","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6d02b023f31165651578ac47ca2ac18dba98dc0d","unresolved":true,"context_lines":[{"line_number":380,"context_line":"        server \u003d api.post_server({\u0027server\u0027: body})"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        # Reset API microversion to original state"},{"line_number":383,"context_line":"        api.microversion \u003d microversion"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        return self._wait_for_state_change(server, expected_state)"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4614b748_f3c54448","line":383,"updated":"2022-06-15 00:01:37.000000000","message":"I don\u0027t understand why we need this here but didn\u0027t need it in the stable/victoria change? I\u0027m going to look around some more to see if I can find.","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0bba081b6757b3eded544e35a69ade967ebc2e41","unresolved":true,"context_lines":[{"line_number":380,"context_line":"        server \u003d api.post_server({\u0027server\u0027: body})"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"        # Reset API microversion to original state"},{"line_number":383,"context_line":"        api.microversion \u003d microversion"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"        return self._wait_for_state_change(server, expected_state)"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"12c63e05_b54eaae1","line":383,"in_reply_to":"4614b748_f3c54448","updated":"2022-06-15 02:39:37.000000000","message":"OK, finally realized it\u0027s because change I999fc4aaf14cca02e4ed730afb844a043b59530c is not in ussuri. That change added the \u0027networks\u0027 kwarg to the _create_server call, which is required in microversion 2.74 (and since 2.37) [1].\n\n[1] https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id35","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"}],"nova/tests/functional/libvirt/test_numa_servers.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f1157b8ab1be06e7e81098c4af02f57b9642e135","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NUMAServersTestBase(base.ServersTestBase):"},{"line_number":38,"context_line":"    ADDITIONAL_FILTERS \u003d [\u0027NUMATopologyFilter\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(NUMAServersTestBase, self).setUp()"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"416195ba_f72f8e55","line":39,"updated":"2022-06-02 01:57:46.000000000","message":"Would it not be better to put\n\n api_major_version \u003d \u0027v2.1\u0027\n\nhere instead of in ServersTestBase? To limit the scope of the change?","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b6a9ff26b09d86112a1c0aa52a353bf18fab3001","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NUMAServersTestBase(base.ServersTestBase):"},{"line_number":38,"context_line":"    ADDITIONAL_FILTERS \u003d [\u0027NUMATopologyFilter\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(NUMAServersTestBase, self).setUp()"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"81d06f2b_dc706d49","line":39,"in_reply_to":"144b1c5c_b811e5c0","updated":"2022-06-14 11:14:21.000000000","message":"Overriding in NUMAServersTestBase would not be enough. See the original proposal to fix this by adding the same thing to VGPUTestBase discussed here https://review.opendev.org/c/openstack/nova/+/822047/3/nova/tests/functional/libvirt/test_vgpu.py#228","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fb580607d1a37aee3c1b7289de06d124f0fa083a","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NUMAServersTestBase(base.ServersTestBase):"},{"line_number":38,"context_line":"    ADDITIONAL_FILTERS \u003d [\u0027NUMATopologyFilter\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(NUMAServersTestBase, self).setUp()"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"144b1c5c_b811e5c0","line":39,"in_reply_to":"30cdb00a_a69943eb","updated":"2022-06-13 23:29:12.000000000","message":"I\u0027m not suggesting adding anything to ServersTestBase, I\u0027m asking if there is a reason not to override api_major_version \u003d \u0027v2.1\u0027 in this class (NUMAServersTestBase) instead of changing the default for everything that derives from ServersTestBase?","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6c81dda63492a8515949f2e4924782cce205cdd3","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NUMAServersTestBase(base.ServersTestBase):"},{"line_number":38,"context_line":"    ADDITIONAL_FILTERS \u003d [\u0027NUMATopologyFilter\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(NUMAServersTestBase, self).setUp()"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"30cdb00a_a69943eb","line":39,"in_reply_to":"416195ba_f72f8e55","updated":"2022-06-02 09:03:04.000000000","message":"For the details why it is needed please read https://review.opendev.org/c/openstack/nova/+/822047/4#message-f023edbce7be018e7486e7c59e076f2c083f89f3 tl;dr: without this the tests are using the v2.0 api without microversion support. v2.0 is a _very_ old API (microversions are added in Kilo). So I consider using v2.0 as a bug itself that was fixed in newer branches during a refactor but not here.\n\nIf it considered cleaner then I can propose a separate commit adding api_major_version \u003d \u0027v2.1\u0027 to the ServersTestBase. But I would like to make that change happen as not using the microversion aware API in these tests feels very dangerous to me.","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6d02b023f31165651578ac47ca2ac18dba98dc0d","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class NUMAServersTestBase(base.ServersTestBase):"},{"line_number":38,"context_line":"    ADDITIONAL_FILTERS \u003d [\u0027NUMATopologyFilter\u0027]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(NUMAServersTestBase, self).setUp()"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f92b5364_b6856403","line":39,"in_reply_to":"81d06f2b_dc706d49","updated":"2022-06-15 00:01:37.000000000","message":"Thanks. I had trouble understanding this issue, apologies for making you repeat things you explained in earlier PS.","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a1932cdb684ff47bac8a84f30c5069674c6c2664","unresolved":true,"context_lines":[{"line_number":769,"context_line":"        host_info \u003d fakelibvirt.HostInfo(cpu_nodes\u003d1, cpu_sockets\u003d1,"},{"line_number":770,"context_line":"                                         cpu_cores\u003d2, cpu_threads\u003d1,"},{"line_number":771,"context_line":"                                         kB_mem\u003d15740000)"},{"line_number":772,"context_line":"        fake_connection \u003d self._get_connection(host_info\u003dhost_info)"},{"line_number":773,"context_line":"        self.mock_conn.return_value \u003d fake_connection"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        self.start_computes({\u0027compute1\u0027: host_info})"},{"line_number":776,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"cc5f71ee_9cdf8c2b","line":773,"range":{"start_line":772,"start_character":8,"end_line":773,"end_character":53},"updated":"2022-05-19 13:57:49.000000000","message":"note: this is another change compared to original patch, and needed because we need to use in ussuri the self.start_computes() instead of the self.start_compute().","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6c81dda63492a8515949f2e4924782cce205cdd3","unresolved":false,"context_lines":[{"line_number":769,"context_line":"        host_info \u003d fakelibvirt.HostInfo(cpu_nodes\u003d1, cpu_sockets\u003d1,"},{"line_number":770,"context_line":"                                         cpu_cores\u003d2, cpu_threads\u003d1,"},{"line_number":771,"context_line":"                                         kB_mem\u003d15740000)"},{"line_number":772,"context_line":"        fake_connection \u003d self._get_connection(host_info\u003dhost_info)"},{"line_number":773,"context_line":"        self.mock_conn.return_value \u003d fake_connection"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"        self.start_computes({\u0027compute1\u0027: host_info})"},{"line_number":776,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e5146125_b6fe00ba","line":773,"range":{"start_line":772,"start_character":8,"end_line":773,"end_character":53},"in_reply_to":"cc5f71ee_9cdf8c2b","updated":"2022-06-02 09:03:04.000000000","message":"Ack","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"}],"nova/tests/functional/libvirt/test_vgpu.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c3f0dc933f05daacda9fa40b7528ed9192998b6e","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        # Using newer API version for forced host instance creation"},{"line_number":234,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":235,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":236,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        extra_spec \u003d {\"resources:VGPU\": \"1\"}"},{"line_number":239,"context_line":"        self.flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"cb47fe1d_6dff7c1d","line":236,"updated":"2022-04-07 17:02:53.000000000","message":"It is strange that we need this. The original patch did not touch this test class.","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a40f3cdb3d984570754ed7f854b8f1fbbeef344","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        # Using newer API version for forced host instance creation"},{"line_number":234,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":235,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":236,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        extra_spec \u003d {\"resources:VGPU\": \"1\"}"},{"line_number":239,"context_line":"        self.flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"908e4c41_af93ff2b","line":236,"in_reply_to":"0746c1ff_ef1168a5","updated":"2022-04-21 08:40:27.000000000","message":"thanks!","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":33608,"name":"Gabriel Silva Trevisan","display_name":"Gabriel Silva Trevisan","email":"gabriel.silvatrevisan@windriver.com","username":"gtrevisan"},"change_message_id":"cfd04973ae5c0f6f6d891a3aaca523493dcaf063","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        # Using newer API version for forced host instance creation"},{"line_number":234,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":235,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":236,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        extra_spec \u003d {\"resources:VGPU\": \"1\"}"},{"line_number":239,"context_line":"        self.flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd1476a3_98e3b596","line":236,"in_reply_to":"2aa1fe86_4fdd617b","updated":"2022-05-06 12:46:30.000000000","message":"Looks better now, thanks a lot for the help.","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c9b3ea5769a96a638b2abc27b0fb7b5d93861c34","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        # Using newer API version for forced host instance creation"},{"line_number":234,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":235,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":236,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        extra_spec \u003d {\"resources:VGPU\": \"1\"}"},{"line_number":239,"context_line":"        self.flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"2aa1fe86_4fdd617b","line":236,"in_reply_to":"53d856ad_7e79112f","updated":"2022-04-28 18:02:40.000000000","message":"No problem. I\u0027ve pushed the update.","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ed2f75a3311df6e3f469a21c93dcfeb6c393e4c2","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        # Using newer API version for forced host instance creation"},{"line_number":234,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":235,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":236,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        extra_spec \u003d {\"resources:VGPU\": \"1\"}"},{"line_number":239,"context_line":"        self.flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"f53d498a_568ef80a","line":236,"in_reply_to":"825cb061_178f1f84","updated":"2022-04-08 11:02:36.000000000","message":"Thanks for the hints. In my tests the vgpu tests are failing if the above admin api definition is not added. I think the real reason is a bug in the normal api client (self.api) definition of these test. It is coming from [1] and it requests an old v2 api client instead of the proper v2.1 api client. The v2 client does not understand microversions, and therefore the host forcing code change in the integrated_helpers cannot request 2.74. \n\nI think it is better to bump the api client to v2.1 in the base class in [1]. \n\nYou are correct that in victoria this problem is not visible as the code in [1] is dissolved by some refactoring.\n\n[1]https://github.com/openstack/nova/blob/184a3c976faed38907af148a533bc6e9faa410f5/nova/tests/functional/test_servers.py#L68","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bb1b4242fd81816cc9b58754933b81446519f269","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        # Using newer API version for forced host instance creation"},{"line_number":234,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":235,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":236,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        extra_spec \u003d {\"resources:VGPU\": \"1\"}"},{"line_number":239,"context_line":"        self.flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"94bfe561_e2e30ad5","line":236,"in_reply_to":"908e4c41_af93ff2b","updated":"2022-04-28 14:39:01.000000000","message":"Let me know if you have no time to fix this up. I happy to take over.","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":33608,"name":"Gabriel Silva Trevisan","display_name":"Gabriel Silva Trevisan","email":"gabriel.silvatrevisan@windriver.com","username":"gtrevisan"},"change_message_id":"94b873fc997313a93b0422d26061fa13cf2315a5","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        # Using newer API version for forced host instance creation"},{"line_number":234,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":235,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":236,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        extra_spec \u003d {\"resources:VGPU\": \"1\"}"},{"line_number":239,"context_line":"        self.flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"53d856ad_7e79112f","line":236,"in_reply_to":"94bfe561_e2e30ad5","updated":"2022-04-28 14:51:55.000000000","message":"Hi, I\u0027m sorry for not having taken this up yet, if you are available to do it, I would be really thankful.","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":33608,"name":"Gabriel Silva Trevisan","display_name":"Gabriel Silva Trevisan","email":"gabriel.silvatrevisan@windriver.com","username":"gtrevisan"},"change_message_id":"f023edbce7be018e7486e7c59e076f2c083f89f3","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        # Using newer API version for forced host instance creation"},{"line_number":234,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":235,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":236,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        extra_spec \u003d {\"resources:VGPU\": \"1\"}"},{"line_number":239,"context_line":"        self.flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"825cb061_178f1f84","line":236,"in_reply_to":"cb47fe1d_6dff7c1d","updated":"2022-04-07 17:47:38.000000000","message":"You\u0027re right, these tests are not really related to the fix. From what I can recall, they also passed without this change. However since they also try to create servers on specific hosts, figured we could fix them to use the 2.1 API version for correctness as well.\n\nThe patch-backs for the other versions did not require this due to [1], which changes the API version on the base class, but is not present in Ussuri. Figured it would be less risky for this change to update the versions directly in the classes that specified the host on the create requests.\n\n[1] https://review.opendev.org/c/openstack/nova/+/741282","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"},{"author":{"_account_id":33608,"name":"Gabriel Silva Trevisan","display_name":"Gabriel Silva Trevisan","email":"gabriel.silvatrevisan@windriver.com","username":"gtrevisan"},"change_message_id":"e5a0a0452b9c1be9eea8e8768b6bb433ba2102bf","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        # Using newer API version for forced host instance creation"},{"line_number":234,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":235,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":236,"context_line":"        self.admin_api \u003d api_fixture.admin_api"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"        extra_spec \u003d {\"resources:VGPU\": \"1\"}"},{"line_number":239,"context_line":"        self.flavor \u003d self._create_flavor(extra_spec\u003dextra_spec)"}],"source_content_type":"text/x-python","patch_set":3,"id":"0746c1ff_ef1168a5","line":236,"in_reply_to":"f53d498a_568ef80a","updated":"2022-04-13 12:56:24.000000000","message":"Got it, thanks for the suggestion. Will test adding the change to the base class.","commit_id":"338992239cee2a9d69b3152bd045a7943f5c30de"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"a1932cdb684ff47bac8a84f30c5069674c6c2664","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class ServersTestBase(integrated_helpers._IntegratedTestBase):"},{"line_number":68,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":69,"context_line":"    _force_delete_parameter \u003d \u0027forceDelete\u0027"},{"line_number":70,"context_line":"    _image_ref_parameter \u003d \u0027imageRef\u0027"},{"line_number":71,"context_line":"    _flavor_ref_parameter \u003d \u0027flavorRef\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"a9a74929_c76d1d09","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":29},"updated":"2022-05-19 13:57:49.000000000","message":"As i understand this api version bump is necessary for the backport. Since this is test code and all the tests are passing, probably this is not a big issue... but could cause some extra test failures in the future backports, right? :S","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6c81dda63492a8515949f2e4924782cce205cdd3","unresolved":true,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class ServersTestBase(integrated_helpers._IntegratedTestBase):"},{"line_number":68,"context_line":"    api_major_version \u003d \u0027v2.1\u0027"},{"line_number":69,"context_line":"    _force_delete_parameter \u003d \u0027forceDelete\u0027"},{"line_number":70,"context_line":"    _image_ref_parameter \u003d \u0027imageRef\u0027"},{"line_number":71,"context_line":"    _flavor_ref_parameter \u003d \u0027flavorRef\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"c33d3a26_30b21d1f","line":68,"range":{"start_line":68,"start_character":25,"end_line":68,"end_character":29},"in_reply_to":"a9a74929_c76d1d09","updated":"2022-06-02 09:03:04.000000000","message":"For the details why it is needed please read https://review.opendev.org/c/openstack/nova/+/822047/4#message-f023edbce7be018e7486e7c59e076f2c083f89f3 tl;dr: without this the tests are using the v2.0 api without microversion support. v2.0 is a _very_ old API (microversions are added in Kilo). So I consider using v2.0 as a bug itself that was fixed in newer branches during a refactor but not here.","commit_id":"c92e7821e3b97c8469fc2a68621428549d36d755"}]}