)]}'
{".zuul.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"41395cddecbd53ba40a3be0afb950a0e05a23314","unresolved":true,"context_lines":[{"line_number":279,"context_line":"      - ^tox.ini$"},{"line_number":280,"context_line":"    required-projects:"},{"line_number":281,"context_line":"      - openstack/nova"},{"line_number":282,"context_line":"      - openstack/os-traits"},{"line_number":283,"context_line":"    post-run:"},{"line_number":284,"context_line":"      - playbooks/nova-emulation/post.yaml"},{"line_number":285,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"3c817a90_ebdb1d68","line":282,"updated":"2022-02-01 12:26:22.000000000","message":"Do we really want this in the long run? I think it means this is gating with the unreleased version of os-traits instead of using the os-traits defined in upper-constraints.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"237b376cb6562d16935b9ef38186da18c305cf20","unresolved":false,"context_lines":[{"line_number":279,"context_line":"      - ^tox.ini$"},{"line_number":280,"context_line":"    required-projects:"},{"line_number":281,"context_line":"      - openstack/nova"},{"line_number":282,"context_line":"      - openstack/os-traits"},{"line_number":283,"context_line":"    post-run:"},{"line_number":284,"context_line":"      - playbooks/nova-emulation/post.yaml"},{"line_number":285,"context_line":"    vars:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"5269d4f5_fee337ba","line":282,"in_reply_to":"3c817a90_ebdb1d68","updated":"2022-02-01 15:16:39.000000000","message":"ack, removed. had issues during my rebase and thought I had gotten rid of this.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"41395cddecbd53ba40a3be0afb950a0e05a23314","unresolved":true,"context_lines":[{"line_number":681,"context_line":"        - tempest-centos8-stream-fips:"},{"line_number":682,"context_line":"            irrelevant-files: *nova-base-irrelevant-files"},{"line_number":683,"context_line":"            voting: false"},{"line_number":684,"context_line":"        - nova-emulation"},{"line_number":685,"context_line":"    gate:"},{"line_number":686,"context_line":"      jobs:"},{"line_number":687,"context_line":"        - nova-live-migration"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"394a48c4_7d5f597c","line":684,"updated":"2022-02-01 12:26:22.000000000","message":"If we agree to put it as voting in the check queue then I suggest to add it to the gate queue as well. \n\nBut instead suggest to add to both queues as non-voting first. See if this is stable and make it voting after couple of weeks.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"237b376cb6562d16935b9ef38186da18c305cf20","unresolved":true,"context_lines":[{"line_number":681,"context_line":"        - tempest-centos8-stream-fips:"},{"line_number":682,"context_line":"            irrelevant-files: *nova-base-irrelevant-files"},{"line_number":683,"context_line":"            voting: false"},{"line_number":684,"context_line":"        - nova-emulation"},{"line_number":685,"context_line":"    gate:"},{"line_number":686,"context_line":"      jobs:"},{"line_number":687,"context_line":"        - nova-live-migration"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"d5b5cf4a_e64cee79","line":684,"in_reply_to":"394a48c4_7d5f597c","updated":"2022-02-01 15:16:39.000000000","message":"I set it to non-voting in check, and will hold off on gate. i know that sean-k-mooney wanted to weigh in as well, as we wanted to set this job to be weekly and periodic. I just dont particularly know how to do that, will research more.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e2446ced70e205bf609b893368769be2a685c29","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        - tempest-centos8-stream-fips:"},{"line_number":682,"context_line":"            irrelevant-files: *nova-base-irrelevant-files"},{"line_number":683,"context_line":"            voting: false"},{"line_number":684,"context_line":"        - nova-emulation"},{"line_number":685,"context_line":"    gate:"},{"line_number":686,"context_line":"      jobs:"},{"line_number":687,"context_line":"        - nova-live-migration"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"f646afa6_30c85c32","line":684,"in_reply_to":"d5b5cf4a_e64cee79","updated":"2022-02-04 10:54:01.000000000","message":"OK","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"}],"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8e9402f8d283f798ee9a1254f3d49c9ea9476fcc","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Adds a variable check to pull host architecture into hw_architecture field for"},{"line_number":15,"context_line":"emulation checks to be made"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Adds a custom function that simply performs a check for hw_emulation_architecture"},{"line_number":18,"context_line":"field being set, allowing for core code to function as normal while enabling a"},{"line_number":19,"context_line":"simple check to enable emulated architectures to follow the same path as all"},{"line_number":20,"context_line":"multi-arch support already established for physical nodes but instead levaraging"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"639d4924_272868ff","line":17,"range":{"start_line":17,"start_character":56,"end_line":17,"end_character":81},"updated":"2022-01-05 21:57:31.000000000","message":"by the way im ok with adding hw_emulation_architecture to opt into emulation that actully i think solve some of the problems of previous attems which overloaded hw_architrure\n\nthe prefilet shoudl should convert the value of hw_emulation_architecture into a COMPTE_ARCH_* trait request\nand hw_architecture into HW_ARCH_* traits\n\n\nyou can use the transform_image_metadata prefilter as an example of how to do this\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/request_filter.py#L200-L238\n\nwe could possble also extend that to hanel both of those keys.\n\nyou woudl jsut have to add the to the prfix map\n\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/request_filter.py#L210-L215\n\n\n  prefix_map \u003d {\n        \u0027hw_cdrom_bus\u0027: \u0027COMPUTE_STORAGE_BUS\u0027,\n        \u0027hw_disk_bus\u0027: \u0027COMPUTE_STORAGE_BUS\u0027,\n        \u0027hw_video_model\u0027: \u0027COMPUTE_GRAPHICS_MODEL\u0027,\n        \u0027hw_vif_model\u0027: \u0027COMPUTE_NET_VIF_MODEL\u0027,\n        \u0027hw_architrure\u0027: \u0027HW_ARCH\u0027,\n        \u0027hw_emulation_architecture\u0027: \u0027COMPUTE_ARCH\u0027,\n    }\n\nand you would have to add the traits to os-trait to make this work\nas i did in https://github.com/openstack/os-traits/commit/21f232bd1c78459fc79c19fd2b4f2defdb758a63#diff-b46015b87a73247024aaa123aed56fa349b901b25378d46a2a4eaef99a8c746f\n\n\nthe set of possible architeture is defiend here\n\nhttps://github.com/openstack/nova/blob/master/nova/objects/fields.py#L120-L171\n\nif you made those change, added a release note and started working on a zuul job to test this i think those are the main gap i would ask to be adress in the spec review.\n\nwe should have a spec however to make sure we have not missed anything else.\n\nwith regards to this patch you will also need a release note for the feature. i just quickly skimmed this so ill do a full review tomorow but those are the main issue i see but directionally this could work.","commit_id":"0f989981ea72421529c8bd9c910c2bd15102ef49"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"28bbf207c9e29db292560f401f2c76633f3b582c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Adds a variable check to pull host architecture into hw_architecture field for"},{"line_number":15,"context_line":"emulation checks to be made"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Adds a custom function that simply performs a check for hw_emulation_architecture"},{"line_number":18,"context_line":"field being set, allowing for core code to function as normal while enabling a"},{"line_number":19,"context_line":"simple check to enable emulated architectures to follow the same path as all"},{"line_number":20,"context_line":"multi-arch support already established for physical nodes but instead levaraging"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"eca9e4fa_367e05af","line":17,"range":{"start_line":17,"start_character":56,"end_line":17,"end_character":81},"in_reply_to":"639d4924_272868ff","updated":"2022-01-11 14:22:34.000000000","message":"added required changes in patchset 12 and also required traits in https://review.opendev.org/c/openstack/os-traits/+/824050","commit_id":"0f989981ea72421529c8bd9c910c2bd15102ef49"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6e26837cc6c70cfde70541d179193be25e6e6194","unresolved":true,"context_lines":[{"line_number":35,"context_line":"Added additional test cases test_driver validating emulation functionality"},{"line_number":36,"context_line":"with checking hw_emulation_architecture against the os_arch/hw_architecture field"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implements: pick-guest-arch-based-on-host-arch-in-libvirt-driver"},{"line_number":39,"context_line":"Closes-Bug: 1863728"},{"line_number":40,"context_line":"Change-Id: Ia070a29186c6123cf51e1b17373c2dc69676ae7c"},{"line_number":41,"context_line":"Signed-off-by: Jonathan Race \u003cjrace@augusta.edu\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"6a6bc225_e05e4718","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":19},"updated":"2022-01-05 21:45:11.000000000","message":"as this is a new feature not a bug fix it requries a spec or specless blueprint\n\nhttps://blueprints.launchpad.net/nova/+spec/pick-guest-arch-based-on-host-arch-in-libvirt-driver\n\nis not approved as a specless blueprint and i think thei really does need a spec to move this forward.\n\nwith that said ill star this and try to come back to do a code review tomorrow.\n\nto do this properly we wil need new traits in placment to model both the host archiecture and what architecure can be emulated.\nwe also need an  opt in prefilter to allow requesting those traits\n\nso this is currently incompelte.","commit_id":"0f989981ea72421529c8bd9c910c2bd15102ef49"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"9caedece4501e689f70fb07ca5af5ca879b1a418","unresolved":true,"context_lines":[{"line_number":35,"context_line":"Added additional test cases test_driver validating emulation functionality"},{"line_number":36,"context_line":"with checking hw_emulation_architecture against the os_arch/hw_architecture field"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implements: pick-guest-arch-based-on-host-arch-in-libvirt-driver"},{"line_number":39,"context_line":"Closes-Bug: 1863728"},{"line_number":40,"context_line":"Change-Id: Ia070a29186c6123cf51e1b17373c2dc69676ae7c"},{"line_number":41,"context_line":"Signed-off-by: Jonathan Race \u003cjrace@augusta.edu\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bca8a2d0_56d68351","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":19},"in_reply_to":"6a6bc225_e05e4718","updated":"2022-01-11 14:20:11.000000000","message":"submitted spec for review:\nhttps://review.opendev.org/c/openstack/nova-specs/+/824044","commit_id":"0f989981ea72421529c8bd9c910c2bd15102ef49"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"28bbf207c9e29db292560f401f2c76633f3b582c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Added additional test cases test_driver validating emulation functionality"},{"line_number":36,"context_line":"with checking hw_emulation_architecture against the os_arch/hw_architecture field"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implements: pick-guest-arch-based-on-host-arch-in-libvirt-driver"},{"line_number":39,"context_line":"Closes-Bug: 1863728"},{"line_number":40,"context_line":"Change-Id: Ia070a29186c6123cf51e1b17373c2dc69676ae7c"},{"line_number":41,"context_line":"Signed-off-by: Jonathan Race \u003cjrace@augusta.edu\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"4701b3c5_e8f22cf9","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":19},"in_reply_to":"bca8a2d0_56d68351","updated":"2022-01-11 14:22:34.000000000","message":"Done","commit_id":"0f989981ea72421529c8bd9c910c2bd15102ef49"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"41395cddecbd53ba40a3be0afb950a0e05a23314","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Additions include:"},{"line_number":12,"context_line":"An additional image meta property to support specifying which images will load via emulation."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Additional config  variable check to pull host architecture into hw_architecture field for emulation checks to be made."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Adds a custom function that simply performs a check for hw_emulation_architecture field being set, allowing for core code to function as normal while enabling a simple check to enable emulated architectures to follow the same path as all multi-arch support already established for physical nodes but instead levaraging qemu which allows for the overall emulation."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"e8d1081c_1a4f6889","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":19},"updated":"2022-02-01 12:26:22.000000000","message":"nit: remove double space","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"237b376cb6562d16935b9ef38186da18c305cf20","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Additions include:"},{"line_number":12,"context_line":"An additional image meta property to support specifying which images will load via emulation."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Additional config  variable check to pull host architecture into hw_architecture field for emulation checks to be made."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Adds a custom function that simply performs a check for hw_emulation_architecture field being set, allowing for core code to function as normal while enabling a simple check to enable emulated architectures to follow the same path as all multi-arch support already established for physical nodes but instead levaraging qemu which allows for the overall emulation."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"e004c617_5888977b","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":19},"in_reply_to":"e8d1081c_1a4f6889","updated":"2022-02-01 15:16:39.000000000","message":"fixed","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"8c3cb8b114a3b242adf0436607a8d105fd2005cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b8302c7_a4958a13","updated":"2021-12-17 12:38:02.000000000","message":"added clarifying comments, and will submit second patch set to catch up to master.","commit_id":"811774fcc8ad590be3777b1688dd6aeaceb776bb"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7ffce85f1706e7b72e1717d3475052e496ea8de1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"29b5a3eb_a68ac5b0","updated":"2021-12-17 10:07:06.000000000","message":"do you have any spec for this? I guess it\u0027s a feature that using x86 to simulate other arch?\njust curious .. thanks","commit_id":"811774fcc8ad590be3777b1688dd6aeaceb776bb"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"206e8e92845bc19b27bb542142c1839e410ab616","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae5d530c_6193b3a1","in_reply_to":"21c26cdd_e60f0530","updated":"2021-12-17 13:52:40.000000000","message":"https://blueprints.launchpad.net/nova/+spec/pick-guest-arch-based-on-host-arch-in-libvirt-driver","commit_id":"811774fcc8ad590be3777b1688dd6aeaceb776bb"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"8c3cb8b114a3b242adf0436607a8d105fd2005cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"21c26cdd_e60f0530","in_reply_to":"29b5a3eb_a68ac5b0","updated":"2021-12-17 12:38:02.000000000","message":"exactly that. We hope to expand it down the road, but first just the initial support on x86 to run aarch and ppc","commit_id":"811774fcc8ad590be3777b1688dd6aeaceb776bb"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"206e8e92845bc19b27bb542142c1839e410ab616","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca07415b_f13725aa","updated":"2021-12-17 13:52:40.000000000","message":"added initial blueprint associated. I\u0027m chateaulav in irc.","commit_id":"f3bb112eca80b247cbb17be78b1b773a036326b9"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ee2914f10bcc14cf3dd2b9fc951fcfcad81a6248","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"352c1b26_739e07bf","updated":"2021-12-18 15:59:04.000000000","message":"The following tests should be fixed.\n\n* nova.tests.unit.notifications.objects.test_notification.TestNotificationObjectVersions.test_versions\n* nova.tests.unit.objects.test_objects.TestObjectVersions.test_versions\n* nova.tests.functional.libvirt.test_uefi.UEFIServersTest.test_create_server\n","commit_id":"adca01a4ef71a581ad994dd8afb797b671142673"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"96d5ebcf987136c1c98ef68c7cfb75dc42e89413","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"eb4f362c_908617e2","in_reply_to":"352c1b26_739e07bf","updated":"2021-12-20 13:58:51.000000000","message":"Done","commit_id":"adca01a4ef71a581ad994dd8afb797b671142673"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"96d5ebcf987136c1c98ef68c7cfb75dc42e89413","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"84487da0_05f1b4a5","updated":"2021-12-20 13:58:51.000000000","message":"changes made, and tested locally. Submitted patchset for validation through zuul, and for further review. Thank You","commit_id":"a575b915f969d205c50666695506a0e3a288d5ec"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"1182631f02345656894916ca235e9c9228172f63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8461d023_e4c21075","updated":"2022-01-27 13:56:10.000000000","message":"os-traits version bump: https://review.opendev.org/c/openstack/nova/+/826675","commit_id":"b93a1752e7d33ea88001e8ec0454ddffb1368898"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"41395cddecbd53ba40a3be0afb950a0e05a23314","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"0948eb4f_f69cfd74","updated":"2022-02-01 12:26:22.000000000","message":"I\u0027m wondering if we need to do the bash script based testing here. Can we somehow filter the existing tempest tests instead to those cases that is supported on emulation too and run those with emulation requested in the flavor / image?","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e2446ced70e205bf609b893368769be2a685c29","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"a68d77fe_e8976ff6","in_reply_to":"0948eb4f_f69cfd74","updated":"2022-02-04 10:54:01.000000000","message":"I think you missed this","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"bb611c83c11d926e6909f8e499c81ec669699680","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"b9665e8f_9504467f","in_reply_to":"0d660e24_5c8c1c5a","updated":"2022-02-08 14:18:56.000000000","message":"seeing how tempest is leveraged now, I will be removing the files related to the playbook and tasks that I added. I will narrow down the tests that are compatible and supported by the emulation.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"9fe7eaef75ae2cea0c83e01e65ddc6687c896e8f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":29,"id":"0d660e24_5c8c1c5a","in_reply_to":"a68d77fe_e8976ff6","updated":"2022-02-04 20:59:51.000000000","message":"yeah, i may need help there. that is my focus next week, to get the ci and tempest items remedied.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"9fe7eaef75ae2cea0c83e01e65ddc6687c896e8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"0f910e03_5003288c","updated":"2022-02-04 20:59:51.000000000","message":"see patchset 33 with appropriate fixes. validation still ongoing to ensure riscv and mipsel will be in initial feature or added later as support is increased by qemu and libvirt.","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8da010645deddcefec6a6c85d350fcdbb2c927e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"0e94f805_3303c50e","updated":"2022-02-07 08:59:45.000000000","message":"I think there is a bug. See inline","commit_id":"dff500ba96a2ed6b770e57094086973d1d1b9cf3"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"bb611c83c11d926e6909f8e499c81ec669699680","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"2a9e86f1_11ae24ec","updated":"2022-02-08 14:18:56.000000000","message":"adjusted zuul to account for direction to head in running accurate testing, will pair down exactly what jobs are required. latest patchset has fixes to last reviews as well as intermidiate fix for riscv, as cpu topology testing is still ongoing.","commit_id":"e167ff886be9dbe35f5b84ea2a711364273f35b9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b781bf86c0e8ad9d1fdcc74335f62afa2b88f353","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"42edf5d5_ff1a312c","updated":"2022-02-22 09:55:39.000000000","message":"I have couple of comments inline","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"01a33a862f7b800b6846bed701c2aa0daeeb6c24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":59,"id":"1bc64865_cac7d1bc","updated":"2022-02-23 10:47:49.000000000","message":"recheck glance-store 3.0.0 was missing from the mirror but it is released","commit_id":"eaf971cfdaa26638aa88248f071ab0184f5ba790"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5c02847a0de81160130e882e256d5452bc2c1d8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":60,"id":"2a6e14b1_d1f50ef9","updated":"2022-02-23 12:47:36.000000000","message":"Looks good","commit_id":"eed2d4e94806550065e536184dfb8c507c8f4492"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c225e680123c0126ea5a1885d3156cf6a7695603","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":62,"id":"d465b9a3_0f33a2ef","updated":"2022-02-24 12:06:22.000000000","message":"Still looks good","commit_id":"6055b0df820a2e15fba7576abd752f83a1ebba88"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f7a5cca5e5a7ba120f4c387fad4d745b4311eb4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"d337dfde_a80de8cd","updated":"2022-02-24 13:32:12.000000000","message":"the doc looks good to me and the rest seams fine.\ni was considering if we want more fucntional tests for this going forward but since we are considering\nit as experimental i guess this is sufficent for now.\n\nit woudl be nice to extend the libvirt fucntional test to explcitly test creating arm or other emulateds acrhitures at some point.","commit_id":"f68f8f00ab20817cf8fface475642bc8e51617c6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2a219fb853dda3667013f8da790ca9110ffac8fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"77ba4112_470b783d","updated":"2022-02-24 15:57:30.000000000","message":"looking at zuul this is going to fail\nthere a re a number of tox tests that need to be adressed","commit_id":"ff75a739fa5b6f4b93df47ba7e6b887c45913de4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5eda68dc4cea8d830501b332cd48226ce7f4fa0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":65,"id":"7bf1d15e_5f717de7","updated":"2022-02-24 17:30:11.000000000","message":"Looks like a clear rebase","commit_id":"31ff7ce7e21fc7c654ab7b4187774fec5be371ca"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f675d2109015d9eeb0803d216f683157e1bb62c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":65,"id":"81064040_52895e74","updated":"2022-02-24 19:57:16.000000000","message":"ok rebase looks good now.\n\nwe agreed on irc before that we can merge this and continue to work on the zuul jobs after FF so +w","commit_id":"31ff7ce7e21fc7c654ab7b4187774fec5be371ca"}],"doc/source/admin/hw-emulation-architecture.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":21,"context_line":"   when defined within the image metadata properties, to be emulated through"},{"line_number":22,"context_line":"   QEMU."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"   Added ``hw_emulation_architecture`` as an available image_meta property. "},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. note::"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":57,"id":"5e51acc5_ae958738","line":24,"range":{"start_line":24,"start_character":75,"end_line":24,"end_character":76},"updated":"2022-02-22 09:55:28.000000000","message":"trailing whitespace","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"   when defined within the image metadata properties, to be emulated through"},{"line_number":22,"context_line":"   QEMU."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"   Added ``hw_emulation_architecture`` as an available image_meta property. "},{"line_number":25,"context_line":""},{"line_number":26,"context_line":".. note::"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-rst","patch_set":57,"id":"b5315041_e76b3da9","line":24,"range":{"start_line":24,"start_character":75,"end_line":24,"end_character":76},"in_reply_to":"5e51acc5_ae958738","updated":"2022-02-22 14:46:50.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Consideration need to be made in regards to which architectures you want to"},{"line_number":61,"context_line":"support, as there are limitations on support through spice, movnc, and"},{"line_number":62,"context_line":"serial. All testing and validation has been done to ensure that spice and"},{"line_number":63,"context_line":"serial connections function as expected."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":57,"id":"66f04b10_16245a63","line":61,"range":{"start_line":61,"start_character":60,"end_line":61,"end_character":65},"updated":"2022-02-22 09:55:28.000000000","message":"novnc\n   ________\n  \u003c MooVNC \u003e\n   --------\n          \\   ^__^\n           \\  (oo)\\_______\n              (__)\\       )\\/\\\n                  ||----w |\n                  ||     ||\n\n:)","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"Consideration need to be made in regards to which architectures you want to"},{"line_number":61,"context_line":"support, as there are limitations on support through spice, movnc, and"},{"line_number":62,"context_line":"serial. All testing and validation has been done to ensure that spice and"},{"line_number":63,"context_line":"serial connections function as expected."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":57,"id":"dff89d3c_5d031ea7","line":61,"range":{"start_line":61,"start_character":60,"end_line":61,"end_character":65},"in_reply_to":"66f04b10_16245a63","updated":"2022-02-22 14:46:50.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    $ openstack image set --property hw_machine_type\u003dvirt $IMAGE"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"RISCV64"},{"line_number":134,"context_line":"~~~~~~~"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"``Testing and validation is ongoing, requires use of custom firmware."},{"line_number":137,"context_line":"Expected implementation in Z release.``"}],"source_content_type":"text/x-rst","patch_set":57,"id":"c37a9bc0_79f6a2ea","line":134,"updated":"2022-02-22 09:55:28.000000000","message":"It think we can drop this as the riscv support is removed from the patch series too","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    $ openstack image set --property hw_machine_type\u003dvirt $IMAGE"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"RISCV64"},{"line_number":134,"context_line":"~~~~~~~"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"``Testing and validation is ongoing, requires use of custom firmware."},{"line_number":137,"context_line":"Expected implementation in Z release.``"}],"source_content_type":"text/x-rst","patch_set":57,"id":"d438d689_51ab0b84","line":134,"in_reply_to":"c37a9bc0_79f6a2ea","updated":"2022-02-22 14:46:50.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"}],"nova/objects/fields.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e2446ced70e205bf609b893368769be2a685c29","unresolved":true,"context_lines":[{"line_number":168,"context_line":"    XTENSA \u003d arch.XTENSA"},{"line_number":169,"context_line":"    XTENSAEB \u003d arch.XTENSAEB"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    RISCV64 \u003d \u0027riscv64\u0027"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    ALL \u003d arch.ALL"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"ac668f36_1d9c1299","line":171,"range":{"start_line":171,"start_character":14,"end_line":171,"end_character":23},"updated":"2022-02-04 10:54:01.000000000","message":"there is a constant for this in arch now\n    RISCV64 \u003d arch.RISCV64","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"9fe7eaef75ae2cea0c83e01e65ddc6687c896e8f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    XTENSA \u003d arch.XTENSA"},{"line_number":169,"context_line":"    XTENSAEB \u003d arch.XTENSAEB"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    RISCV64 \u003d \u0027riscv64\u0027"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    ALL \u003d arch.ALL"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"348b58d7_e9d667e4","line":171,"range":{"start_line":171,"start_character":14,"end_line":171,"end_character":23},"in_reply_to":"ac668f36_1d9c1299","updated":"2022-02-04 20:59:51.000000000","message":"Ack","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"}],"nova/objects/image_meta.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"41395cddecbd53ba40a3be0afb950a0e05a23314","unresolved":true,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        # hw_architecture field is leveraged for checks against physical nodes"},{"line_number":298,"context_line":"        # name of desired emulation architecture eg i686, x86_64, ppc64"},{"line_number":299,"context_line":"        \u0027hw_emulation_architecture\u0027: fields.StringField(),"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # used to decide to expand root disk partition and fs to full size of"},{"line_number":302,"context_line":"        # root disk"}],"source_content_type":"text/x-python","patch_set":29,"id":"4870fbe3_65d82337","line":299,"updated":"2022-02-01 12:26:22.000000000","message":"can we have an enum, similar to ArchitectureField, here as well?","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e2446ced70e205bf609b893368769be2a685c29","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        # hw_architecture field is leveraged for checks against physical nodes"},{"line_number":298,"context_line":"        # name of desired emulation architecture eg i686, x86_64, ppc64"},{"line_number":299,"context_line":"        \u0027hw_emulation_architecture\u0027: fields.StringField(),"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # used to decide to expand root disk partition and fs to full size of"},{"line_number":302,"context_line":"        # root disk"}],"source_content_type":"text/x-python","patch_set":29,"id":"ac05d968_e10d7b2a","line":299,"in_reply_to":"116b2524_c544abd5","updated":"2022-02-04 10:54:01.000000000","message":"Ack","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"237b376cb6562d16935b9ef38186da18c305cf20","unresolved":true,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        # hw_architecture field is leveraged for checks against physical nodes"},{"line_number":298,"context_line":"        # name of desired emulation architecture eg i686, x86_64, ppc64"},{"line_number":299,"context_line":"        \u0027hw_emulation_architecture\u0027: fields.StringField(),"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # used to decide to expand root disk partition and fs to full size of"},{"line_number":302,"context_line":"        # root disk"}],"source_content_type":"text/x-python","patch_set":29,"id":"116b2524_c544abd5","line":299,"in_reply_to":"4870fbe3_65d82337","updated":"2022-02-01 15:16:39.000000000","message":"I imagine we can actually reuse the same enum as that is technically the limitations, unless we feel we need to manage a separate one that is almost if not identical. changed to ArchitectureField for now.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d99693f7cda73ee9bcac30d375aca3e7b0684d52","unresolved":true,"context_lines":[{"line_number":297,"context_line":"        # hw_architecture field is leveraged for checks against physical nodes"},{"line_number":298,"context_line":"        # name of desired emulation architecture eg i686, x86_64, ppc64"},{"line_number":299,"context_line":"        \u0027hw_emulation_architecture\u0027: fields.StringField(),"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # used to decide to expand root disk partition and fs to full size of"},{"line_number":302,"context_line":"        # root disk"},{"line_number":303,"context_line":"        \u0027hw_auto_disk_config\u0027: fields.StringField(),"}],"source_content_type":"text/x-python","patch_set":29,"id":"03bd7b67_b15dbf33","line":300,"updated":"2022-02-01 08:35:45.000000000","message":"you can\u0027t just add a field without bumping the object version. Also, you need to support an older object version by punting this field if needed.\nPlease look at how the object is modified when adding a new field by any change doing it, like https://review.opendev.org/c/openstack/nova/+/756552","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"41395cddecbd53ba40a3be0afb950a0e05a23314","unresolved":true,"context_lines":[{"line_number":297,"context_line":"        # hw_architecture field is leveraged for checks against physical nodes"},{"line_number":298,"context_line":"        # name of desired emulation architecture eg i686, x86_64, ppc64"},{"line_number":299,"context_line":"        \u0027hw_emulation_architecture\u0027: fields.StringField(),"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # used to decide to expand root disk partition and fs to full size of"},{"line_number":302,"context_line":"        # root disk"},{"line_number":303,"context_line":"        \u0027hw_auto_disk_config\u0027: fields.StringField(),"}],"source_content_type":"text/x-python","patch_set":29,"id":"35c52752_988cba59","line":300,"in_reply_to":"03bd7b67_b15dbf33","updated":"2022-02-01 12:26:22.000000000","message":"also this probably means you need to change the version of the related notification payload object as well","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"237b376cb6562d16935b9ef38186da18c305cf20","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        # hw_architecture field is leveraged for checks against physical nodes"},{"line_number":298,"context_line":"        # name of desired emulation architecture eg i686, x86_64, ppc64"},{"line_number":299,"context_line":"        \u0027hw_emulation_architecture\u0027: fields.StringField(),"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        # used to decide to expand root disk partition and fs to full size of"},{"line_number":302,"context_line":"        # root disk"},{"line_number":303,"context_line":"        \u0027hw_auto_disk_config\u0027: fields.StringField(),"}],"source_content_type":"text/x-python","patch_set":29,"id":"13ea1f57_9a16236f","line":300,"in_reply_to":"35c52752_988cba59","updated":"2022-02-01 15:16:39.000000000","message":"updated required fields and will be in next patchset.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e2446ced70e205bf609b893368769be2a685c29","unresolved":true,"context_lines":[{"line_number":187,"context_line":"    # Version 1.28: Added \u0027socket\u0027 to \u0027hw_pci_numa_affinity_policy\u0027"},{"line_number":188,"context_line":"    # Version 1.29: Added \u0027hw_input_bus\u0027 field"},{"line_number":189,"context_line":"    # Version 1.30: Added \u0027bochs\u0027 as an option to \u0027hw_video_model\u0027"},{"line_number":190,"context_line":"    # Version 1.30: Added \u0027hw_emulation_architecture\u0027 field"},{"line_number":191,"context_line":"    # NOTE(efried): When bumping this version, the version of"},{"line_number":192,"context_line":"    # ImageMetaPropsPayload must also be bumped. See its docstring for details."},{"line_number":193,"context_line":"    VERSION \u003d \u00271.31\u0027"}],"source_content_type":"text/x-python","patch_set":32,"id":"706cf4d0_6bed1e57","line":190,"range":{"start_line":190,"start_character":16,"end_line":190,"end_character":18},"updated":"2022-02-04 10:54:01.000000000","message":"31","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"9fe7eaef75ae2cea0c83e01e65ddc6687c896e8f","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    # Version 1.28: Added \u0027socket\u0027 to \u0027hw_pci_numa_affinity_policy\u0027"},{"line_number":188,"context_line":"    # Version 1.29: Added \u0027hw_input_bus\u0027 field"},{"line_number":189,"context_line":"    # Version 1.30: Added \u0027bochs\u0027 as an option to \u0027hw_video_model\u0027"},{"line_number":190,"context_line":"    # Version 1.30: Added \u0027hw_emulation_architecture\u0027 field"},{"line_number":191,"context_line":"    # NOTE(efried): When bumping this version, the version of"},{"line_number":192,"context_line":"    # ImageMetaPropsPayload must also be bumped. See its docstring for details."},{"line_number":193,"context_line":"    VERSION \u003d \u00271.31\u0027"}],"source_content_type":"text/x-python","patch_set":32,"id":"01192a56_bd714da7","line":190,"range":{"start_line":190,"start_character":16,"end_line":190,"end_character":18},"in_reply_to":"706cf4d0_6bed1e57","updated":"2022-02-04 20:59:51.000000000","message":"Ack","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"}],"nova/tests/unit/objects/test_image_meta.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e2446ced70e205bf609b893368769be2a685c29","unresolved":true,"context_lines":[{"line_number":18,"context_line":"from nova import objects"},{"line_number":19,"context_line":"from nova.objects import fields"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from nova import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"614a762f_b67535f2","line":21,"updated":"2022-02-04 10:54:01.000000000","message":"probably unnecessary","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"9fe7eaef75ae2cea0c83e01e65ddc6687c896e8f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from nova import objects"},{"line_number":19,"context_line":"from nova.objects import fields"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from nova import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"7037720f_5f337073","line":21,"in_reply_to":"614a762f_b67535f2","updated":"2022-02-04 20:59:51.000000000","message":"Ack","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from nova import exception"},{"line_number":18,"context_line":"from nova import objects"},{"line_number":19,"context_line":"from nova.objects import fields"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova import test"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":57,"id":"be0b2cf0_af041b85","line":20,"updated":"2022-02-22 09:55:28.000000000","message":"probably unrelated change","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from nova import exception"},{"line_number":18,"context_line":"from nova import objects"},{"line_number":19,"context_line":"from nova.objects import fields"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from nova import test"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":57,"id":"dcd47e3f_b269a9fd","line":20,"in_reply_to":"be0b2cf0_af041b85","updated":"2022-02-22 14:46:50.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e2446ced70e205bf609b893368769be2a685c29","unresolved":true,"context_lines":[{"line_number":1066,"context_line":"    \u0027EC2InstanceMapping\u0027: \u00271.0-a4556eb5c5e94c045fe84f49cf71644f\u0027,"},{"line_number":1067,"context_line":"    \u0027Flavor\u0027: \u00271.2-4ce99b41327bb230262e5a8f45ff0ce3\u0027,"},{"line_number":1068,"context_line":"    \u0027FlavorList\u0027: \u00271.1-52b5928600e7ca973aa4fc1e46f3934c\u0027,"},{"line_number":1069,"context_line":"    \u0027HVSpec\u0027: \u00271.2-039d074ce845e705069aacb49d622d0d\u0027,"},{"line_number":1070,"context_line":"    \u0027HostMapping\u0027: \u00271.0-1a3390a696792a552ab7bd31a77ba9ac\u0027,"},{"line_number":1071,"context_line":"    \u0027HostMappingList\u0027: \u00271.1-18ac2bfb8c1eb5545bed856da58a79bc\u0027,"},{"line_number":1072,"context_line":"    \u0027HyperVLiveMigrateData\u0027: \u00271.4-e265780e6acfa631476c8170e8d6fce0\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"8fcdb898_187b1907","line":1069,"updated":"2022-02-04 10:54:01.000000000","message":"You need to bump the version of this object too, probably because it is also using the ArchitectureField you extended","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"9fe7eaef75ae2cea0c83e01e65ddc6687c896e8f","unresolved":false,"context_lines":[{"line_number":1066,"context_line":"    \u0027EC2InstanceMapping\u0027: \u00271.0-a4556eb5c5e94c045fe84f49cf71644f\u0027,"},{"line_number":1067,"context_line":"    \u0027Flavor\u0027: \u00271.2-4ce99b41327bb230262e5a8f45ff0ce3\u0027,"},{"line_number":1068,"context_line":"    \u0027FlavorList\u0027: \u00271.1-52b5928600e7ca973aa4fc1e46f3934c\u0027,"},{"line_number":1069,"context_line":"    \u0027HVSpec\u0027: \u00271.2-039d074ce845e705069aacb49d622d0d\u0027,"},{"line_number":1070,"context_line":"    \u0027HostMapping\u0027: \u00271.0-1a3390a696792a552ab7bd31a77ba9ac\u0027,"},{"line_number":1071,"context_line":"    \u0027HostMappingList\u0027: \u00271.1-18ac2bfb8c1eb5545bed856da58a79bc\u0027,"},{"line_number":1072,"context_line":"    \u0027HyperVLiveMigrateData\u0027: \u00271.4-e265780e6acfa631476c8170e8d6fce0\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"1af3f073_4d0c6e96","line":1069,"in_reply_to":"8fcdb898_187b1907","updated":"2022-02-04 20:59:51.000000000","message":"Ack","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8e2446ced70e205bf609b893368769be2a685c29","unresolved":true,"context_lines":[{"line_number":1144,"context_line":"    \u0027VIFMigrateData\u0027: \u00271.0-cb15282b25a039ab35046ed705eb931d\u0027,"},{"line_number":1145,"context_line":"    \u0027VMwareLiveMigrateData\u0027: \u00271.0-a3cc858a2bf1d3806d6f57cfaa1fb98a\u0027,"},{"line_number":1146,"context_line":"    \u0027VirtCPUFeature\u0027: \u00271.0-ea2464bdd09084bd388e5f61d5d4fc86\u0027,"},{"line_number":1147,"context_line":"    \u0027VirtCPUModel\u0027: \u00271.0-1af2ccb8e738d95bad85317c9780a6a0\u0027,"},{"line_number":1148,"context_line":"    \u0027VirtCPUTopology\u0027: \u00271.0-fc694de72e20298f7c6bab1083fd4563\u0027,"},{"line_number":1149,"context_line":"    \u0027VirtualInterface\u0027: \u00271.3-efd3ca8ebcc5ce65fff5a25f31754c54\u0027,"},{"line_number":1150,"context_line":"    \u0027VirtualInterfaceList\u0027: \u00271.0-9750e2074437b3077e46359102779fc6\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"29099427_3ba6e78b","line":1147,"updated":"2022-02-04 10:54:01.000000000","message":"ditto","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"9fe7eaef75ae2cea0c83e01e65ddc6687c896e8f","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"    \u0027VIFMigrateData\u0027: \u00271.0-cb15282b25a039ab35046ed705eb931d\u0027,"},{"line_number":1145,"context_line":"    \u0027VMwareLiveMigrateData\u0027: \u00271.0-a3cc858a2bf1d3806d6f57cfaa1fb98a\u0027,"},{"line_number":1146,"context_line":"    \u0027VirtCPUFeature\u0027: \u00271.0-ea2464bdd09084bd388e5f61d5d4fc86\u0027,"},{"line_number":1147,"context_line":"    \u0027VirtCPUModel\u0027: \u00271.0-1af2ccb8e738d95bad85317c9780a6a0\u0027,"},{"line_number":1148,"context_line":"    \u0027VirtCPUTopology\u0027: \u00271.0-fc694de72e20298f7c6bab1083fd4563\u0027,"},{"line_number":1149,"context_line":"    \u0027VirtualInterface\u0027: \u00271.3-efd3ca8ebcc5ce65fff5a25f31754c54\u0027,"},{"line_number":1150,"context_line":"    \u0027VirtualInterfaceList\u0027: \u00271.0-9750e2074437b3077e46359102779fc6\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"838cfbb9_eeb0aa1e","line":1147,"in_reply_to":"29099427_3ba6e78b","updated":"2022-02-04 20:59:51.000000000","message":"Ack","commit_id":"c9dedf0145bcc6a6a376e57fc65859171776fbca"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":19742,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":19743,"context_line":"        hw_firmware_type \u003d image_meta.properties.get("},{"line_number":19744,"context_line":"            \u0027hw_firmware_type\u0027)"},{"line_number":19745,"context_line":""},{"line_number":19746,"context_line":"        old_connection_info \u003d {\u0027driver_volume_type\u0027: \u0027fake\u0027,"},{"line_number":19747,"context_line":"                               \u0027serial\u0027: \u0027old-volume-id\u0027,"},{"line_number":19748,"context_line":"                               \u0027data\u0027: {\u0027device_path\u0027: \u0027/fake-old-volume\u0027,"}],"source_content_type":"text/x-python","patch_set":57,"id":"d38d150d_21c11509","line":19745,"updated":"2022-02-22 09:55:28.000000000","message":"probably unrelated change","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":false,"context_lines":[{"line_number":19742,"context_line":"        image_meta \u003d objects.ImageMeta.from_dict(self.test_image_meta)"},{"line_number":19743,"context_line":"        hw_firmware_type \u003d image_meta.properties.get("},{"line_number":19744,"context_line":"            \u0027hw_firmware_type\u0027)"},{"line_number":19745,"context_line":""},{"line_number":19746,"context_line":"        old_connection_info \u003d {\u0027driver_volume_type\u0027: \u0027fake\u0027,"},{"line_number":19747,"context_line":"                               \u0027serial\u0027: \u0027old-volume-id\u0027,"},{"line_number":19748,"context_line":"                               \u0027data\u0027: {\u0027device_path\u0027: \u0027/fake-old-volume\u0027,"}],"source_content_type":"text/x-python","patch_set":57,"id":"f03fb9c5_6f0bce54","line":19745,"in_reply_to":"d38d150d_21c11509","updated":"2022-02-22 14:46:50.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7ffce85f1706e7b72e1717d3475052e496ea8de1","unresolved":true,"context_lines":[{"line_number":5044,"context_line":"        # similar to GRUB_TERMINAL\u003dconsole"},{"line_number":5045,"context_line":"        # https://gist.github.com/brianredbeard/36f5bc52f8e8602b8ac0fcbd8bacc4e3"},{"line_number":5046,"context_line":"        #"},{"line_number":5047,"context_line":"        # s390x console recognition, need further testing for defining port with console"},{"line_number":5048,"context_line":"        emulation_arch \u003d image_meta.properties.get(\"hw_emulation_architecture\")"},{"line_number":5049,"context_line":"        if emulation_arch:"},{"line_number":5050,"context_line":"            arch \u003d emulation_arch"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c2f4f64_6e84c4e2","line":5047,"updated":"2021-12-17 10:07:06.000000000","message":"s390x doesn\u0027t have VNC, but support console \nso not sure the meaning of the comments here","commit_id":"811774fcc8ad590be3777b1688dd6aeaceb776bb"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"8c3cb8b114a3b242adf0436607a8d105fd2005cf","unresolved":false,"context_lines":[{"line_number":5044,"context_line":"        # similar to GRUB_TERMINAL\u003dconsole"},{"line_number":5045,"context_line":"        # https://gist.github.com/brianredbeard/36f5bc52f8e8602b8ac0fcbd8bacc4e3"},{"line_number":5046,"context_line":"        #"},{"line_number":5047,"context_line":"        # s390x console recognition, need further testing for defining port with console"},{"line_number":5048,"context_line":"        emulation_arch \u003d image_meta.properties.get(\"hw_emulation_architecture\")"},{"line_number":5049,"context_line":"        if emulation_arch:"},{"line_number":5050,"context_line":"            arch \u003d emulation_arch"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7dbaef7_45362166","line":5047,"in_reply_to":"2c2f4f64_6e84c4e2","updated":"2021-12-17 12:38:02.000000000","message":"pushing another patchset, to reflect the todo better on this one. issues with powerstate mismatch between instance and db due to crash.\n\n-object rng-random,id\u003dobjrng0,filename\u003d/dev/urandom \\\n-device virtio-rng-ccw,rng\u003dobjrng0,id\u003drng0,devno\u003dfe.0.0005 \\\n-sandbox on,obsolete\u003ddeny,elevateprivileges\u003ddeny,spawn\u003ddeny,resourcecontrol\u003ddeny \\\n-msg timestamp\u003don\nchar device redirected to /dev/pts/2 (label charconsole0)\n2021-12-17T12:21:48.247745Z qemu-system-s390x: warning: Setting device address of a display device to SPICE: Not a PCI device.\n2021-12-17T12:21:48.249570Z qemu-system-s390x: warning: global mc146818rtc.lost_tick_policy has invalid class name\n2021-12-17 12:21:48.910+0000: panic s390: core\u003d\u00270\u0027 psw-mask\u003d\u00270x0002000180000000\u0027 psw-addr\u003d\u00270x0000000000000000\u0027 reason\u003d\u0027disabled-wait\u0027\n2021-12-17 12:21:48.911+0000: shutting down, reason\u003dcrashed\n2021-12-17T12:21:48.912103Z qemu-system-s390x: terminating on signal 15 from pid 2380 (/usr/sbin/libvirtd)","commit_id":"811774fcc8ad590be3777b1688dd6aeaceb776bb"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7ffce85f1706e7b72e1717d3475052e496ea8de1","unresolved":true,"context_lines":[{"line_number":5213,"context_line":"            if arch \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":5214,"context_line":"                cpu.model \u003d \"cortex-a57\""},{"line_number":5215,"context_line":"            elif arch \u003d\u003d fields.Architecture.PPC64LE:"},{"line_number":5216,"context_line":"                cpu.model \u003d \"POWER8\""},{"line_number":5217,"context_line":""},{"line_number":5218,"context_line":"        return cpu"},{"line_number":5219,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b47e8b22_dc9e0cc9","line":5216,"updated":"2021-12-17 10:07:06.000000000","message":"I knew latest power is power10, not sure this is related though...","commit_id":"811774fcc8ad590be3777b1688dd6aeaceb776bb"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"8c3cb8b114a3b242adf0436607a8d105fd2005cf","unresolved":false,"context_lines":[{"line_number":5213,"context_line":"            if arch \u003d\u003d fields.Architecture.AARCH64:"},{"line_number":5214,"context_line":"                cpu.model \u003d \"cortex-a57\""},{"line_number":5215,"context_line":"            elif arch \u003d\u003d fields.Architecture.PPC64LE:"},{"line_number":5216,"context_line":"                cpu.model \u003d \"POWER8\""},{"line_number":5217,"context_line":""},{"line_number":5218,"context_line":"        return cpu"},{"line_number":5219,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b8408a0d_313990a3","line":5216,"in_reply_to":"b47e8b22_dc9e0cc9","updated":"2021-12-17 12:38:02.000000000","message":"unrelated at the moment. This would change as nova updates overall support in code for that. From the nova \u003e tests \u003e fixtures \u003e libvirt.py \n\n            \u0027ppc64\u0027: [\n                \u0027POWER6\u0027,\n                \u0027POWER7\u0027,\n                \u0027POWER8\u0027,\n                \u0027POWER9\u0027,\n                \u0027POWERPC_e5500\u0027,\n                \u0027POWERPC_e6500\u0027]","commit_id":"811774fcc8ad590be3777b1688dd6aeaceb776bb"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ee2914f10bcc14cf3dd2b9fc951fcfcad81a6248","unresolved":true,"context_lines":[{"line_number":5020,"context_line":"    def _check_emulation_arch(self, image_meta):"},{"line_number":5021,"context_line":"        # NOTE(chateaulav) In order to support emulation via qemu,"},{"line_number":5022,"context_line":"        # there are required metadata properties that need applied"},{"line_number":5023,"context_line":"        # to the designated glance image. The config drive is not "},{"line_number":5024,"context_line":"        # option is not supported. This leverages the hw_architecture"},{"line_number":5025,"context_line":"        # and hw_emulation_architecture image_meta fields to allow for"},{"line_number":5026,"context_line":"        # emulation to take advantage of all physical multiarch work"}],"source_content_type":"text/x-python","patch_set":5,"id":"c4bd9068_fffcb85e","line":5023,"range":{"start_line":5023,"start_character":65,"end_line":5023,"end_character":66},"updated":"2021-12-18 15:59:04.000000000","message":"Remove this white space.","commit_id":"adca01a4ef71a581ad994dd8afb797b671142673"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"96d5ebcf987136c1c98ef68c7cfb75dc42e89413","unresolved":false,"context_lines":[{"line_number":5020,"context_line":"    def _check_emulation_arch(self, image_meta):"},{"line_number":5021,"context_line":"        # NOTE(chateaulav) In order to support emulation via qemu,"},{"line_number":5022,"context_line":"        # there are required metadata properties that need applied"},{"line_number":5023,"context_line":"        # to the designated glance image. The config drive is not "},{"line_number":5024,"context_line":"        # option is not supported. This leverages the hw_architecture"},{"line_number":5025,"context_line":"        # and hw_emulation_architecture image_meta fields to allow for"},{"line_number":5026,"context_line":"        # emulation to take advantage of all physical multiarch work"}],"source_content_type":"text/x-python","patch_set":5,"id":"ccd6653c_167c3083","line":5023,"range":{"start_line":5023,"start_character":65,"end_line":5023,"end_character":66},"in_reply_to":"c4bd9068_fffcb85e","updated":"2021-12-20 13:58:51.000000000","message":"Done","commit_id":"adca01a4ef71a581ad994dd8afb797b671142673"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ee2914f10bcc14cf3dd2b9fc951fcfcad81a6248","unresolved":true,"context_lines":[{"line_number":5050,"context_line":"        # similar to GRUB_TERMINAL\u003dconsole"},{"line_number":5051,"context_line":"        # https://gist.github.com/brianredbeard/36f5bc52f8e8602b8ac0fcbd8bacc4e3"},{"line_number":5052,"context_line":"        #"},{"line_number":5053,"context_line":"        # s390x needs troublshoot to determine how to overcome shutting down due "},{"line_number":5054,"context_line":"        # to kernel crash causing inconsistent poowerstate"},{"line_number":5055,"context_line":"        emulation_arch \u003d image_meta.properties.get(\"hw_emulation_architecture\")"},{"line_number":5056,"context_line":"        if emulation_arch:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5911e139_61087dc1","line":5053,"range":{"start_line":5053,"start_character":80,"end_line":5053,"end_character":81},"updated":"2021-12-18 15:59:04.000000000","message":"ditto","commit_id":"adca01a4ef71a581ad994dd8afb797b671142673"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"96d5ebcf987136c1c98ef68c7cfb75dc42e89413","unresolved":false,"context_lines":[{"line_number":5050,"context_line":"        # similar to GRUB_TERMINAL\u003dconsole"},{"line_number":5051,"context_line":"        # https://gist.github.com/brianredbeard/36f5bc52f8e8602b8ac0fcbd8bacc4e3"},{"line_number":5052,"context_line":"        #"},{"line_number":5053,"context_line":"        # s390x needs troublshoot to determine how to overcome shutting down due "},{"line_number":5054,"context_line":"        # to kernel crash causing inconsistent poowerstate"},{"line_number":5055,"context_line":"        emulation_arch \u003d image_meta.properties.get(\"hw_emulation_architecture\")"},{"line_number":5056,"context_line":"        if emulation_arch:"}],"source_content_type":"text/x-python","patch_set":5,"id":"775aac84_6fd696dc","line":5053,"range":{"start_line":5053,"start_character":80,"end_line":5053,"end_character":81},"in_reply_to":"5911e139_61087dc1","updated":"2021-12-20 13:58:51.000000000","message":"Done","commit_id":"adca01a4ef71a581ad994dd8afb797b671142673"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ee2914f10bcc14cf3dd2b9fc951fcfcad81a6248","unresolved":true,"context_lines":[{"line_number":6613,"context_line":"        # controller (x86 gets one by default)"},{"line_number":6614,"context_line":"        usbhost.model \u003d None"},{"line_number":6615,"context_line":"        if not self._guest_needs_usb(guest, image_meta):"},{"line_number":6616,"context_line":"            archs \u003d (fields.Architecture.PPC, fields.Architecture.PPC64, fields.Architecture.PPC64LE)"},{"line_number":6617,"context_line":"            if self._check_emulation_arch(image_meta) in archs:"},{"line_number":6618,"context_line":"                usbhost.model \u003d None"},{"line_number":6619,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a4191338_b48f5d6d","line":6616,"updated":"2021-12-18 15:59:04.000000000","message":"This line should be wrapped less than 80 characters.","commit_id":"adca01a4ef71a581ad994dd8afb797b671142673"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"96d5ebcf987136c1c98ef68c7cfb75dc42e89413","unresolved":false,"context_lines":[{"line_number":6613,"context_line":"        # controller (x86 gets one by default)"},{"line_number":6614,"context_line":"        usbhost.model \u003d None"},{"line_number":6615,"context_line":"        if not self._guest_needs_usb(guest, image_meta):"},{"line_number":6616,"context_line":"            archs \u003d (fields.Architecture.PPC, fields.Architecture.PPC64, fields.Architecture.PPC64LE)"},{"line_number":6617,"context_line":"            if self._check_emulation_arch(image_meta) in archs:"},{"line_number":6618,"context_line":"                usbhost.model \u003d None"},{"line_number":6619,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"285b97a3_508688cf","line":6616,"in_reply_to":"a4191338_b48f5d6d","updated":"2021-12-20 13:58:51.000000000","message":"Done","commit_id":"adca01a4ef71a581ad994dd8afb797b671142673"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"41395cddecbd53ba40a3be0afb950a0e05a23314","unresolved":true,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"def patch_tpool_proxy():"},{"line_number":195,"context_line":"    \"\"\"eventlet.tpool.Proxy doesn\u0027t work with old-style class in"},{"line_number":196,"context_line":"    __str__() or __repr__() calls. See bug #962840 for details."},{"line_number":197,"context_line":"    We perform a monkey patch to replace those two instance methods."},{"line_number":198,"context_line":"    \"\"\""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"acd7e22b_e211c433","line":196,"updated":"2022-02-01 12:26:22.000000000","message":"this is probably an unrealated change","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"237b376cb6562d16935b9ef38186da18c305cf20","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"def patch_tpool_proxy():"},{"line_number":195,"context_line":"    \"\"\"eventlet.tpool.Proxy doesn\u0027t work with old-style class in"},{"line_number":196,"context_line":"    __str__() or __repr__() calls. See bug #962840 for details."},{"line_number":197,"context_line":"    We perform a monkey patch to replace those two instance methods."},{"line_number":198,"context_line":"    \"\"\""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"094f1281_87fcf576","line":196,"in_reply_to":"acd7e22b_e211c433","updated":"2022-02-01 15:16:39.000000000","message":"reverted","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"41395cddecbd53ba40a3be0afb950a0e05a23314","unresolved":true,"context_lines":[{"line_number":5021,"context_line":"    def _check_emulation_arch(self, image_meta):"},{"line_number":5022,"context_line":"        # NOTE(chateaulav) In order to support emulation via qemu,"},{"line_number":5023,"context_line":"        # there are required metadata properties that need applied"},{"line_number":5024,"context_line":"        # to the designated glance image. The config drive is not"},{"line_number":5025,"context_line":"        # option is not supported. This leverages the hw_architecture"},{"line_number":5026,"context_line":"        # and hw_emulation_architecture image_meta fields to allow for"},{"line_number":5027,"context_line":"        # emulation to take advantage of all physical multiarch work"},{"line_number":5028,"context_line":"        # being done."}],"source_content_type":"text/x-python","patch_set":29,"id":"e2ae3983_267e5d1e","line":5025,"range":{"start_line":5024,"start_character":42,"end_line":5025,"end_character":34},"updated":"2022-02-01 12:26:22.000000000","message":"I cannot parse this.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"237b376cb6562d16935b9ef38186da18c305cf20","unresolved":false,"context_lines":[{"line_number":5021,"context_line":"    def _check_emulation_arch(self, image_meta):"},{"line_number":5022,"context_line":"        # NOTE(chateaulav) In order to support emulation via qemu,"},{"line_number":5023,"context_line":"        # there are required metadata properties that need applied"},{"line_number":5024,"context_line":"        # to the designated glance image. The config drive is not"},{"line_number":5025,"context_line":"        # option is not supported. This leverages the hw_architecture"},{"line_number":5026,"context_line":"        # and hw_emulation_architecture image_meta fields to allow for"},{"line_number":5027,"context_line":"        # emulation to take advantage of all physical multiarch work"},{"line_number":5028,"context_line":"        # being done."}],"source_content_type":"text/x-python","patch_set":29,"id":"c45ba6b2_9bf3d88d","line":5025,"range":{"start_line":5024,"start_character":42,"end_line":5025,"end_character":34},"in_reply_to":"e2ae3983_267e5d1e","updated":"2022-02-01 15:16:39.000000000","message":"bad english, and I am working to transfer over to a docs page or incorporate the properties being set within driver.","commit_id":"f9fc17f8d35d228c5d008a121c7be8e6d0e7d058"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8da010645deddcefec6a6c85d350fcdbb2c927e2","unresolved":true,"context_lines":[{"line_number":6038,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6039,"context_line":"        elif guestarch \u003d\u003d fields.Architecture.MIPSEL:"},{"line_number":6040,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6041,"context_line":"        elif guestarch \u003d\u003d \u0027riscv64\u0027:"},{"line_number":6042,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6043,"context_line":"        elif CONF.spice.enabled:"},{"line_number":6044,"context_line":"            video.type \u003d \u0027qxl\u0027"}],"source_content_type":"text/x-python","patch_set":33,"id":"24375b59_46a9b84f","line":6041,"range":{"start_line":6041,"start_character":26,"end_line":6041,"end_character":35},"updated":"2022-02-07 08:59:45.000000000","message":"I guess you can use the constant here too:\n fields.Architecture.RISCV64","commit_id":"dff500ba96a2ed6b770e57094086973d1d1b9cf3"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"bb1f0d057d842232961ab68b4b5b48433b2c0f15","unresolved":false,"context_lines":[{"line_number":6038,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6039,"context_line":"        elif guestarch \u003d\u003d fields.Architecture.MIPSEL:"},{"line_number":6040,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6041,"context_line":"        elif guestarch \u003d\u003d \u0027riscv64\u0027:"},{"line_number":6042,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6043,"context_line":"        elif CONF.spice.enabled:"},{"line_number":6044,"context_line":"            video.type \u003d \u0027qxl\u0027"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba35239a_5d1887de","line":6041,"range":{"start_line":6041,"start_character":26,"end_line":6041,"end_character":35},"in_reply_to":"24375b59_46a9b84f","updated":"2022-02-08 14:14:32.000000000","message":"Ack","commit_id":"dff500ba96a2ed6b770e57094086973d1d1b9cf3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8da010645deddcefec6a6c85d350fcdbb2c927e2","unresolved":true,"context_lines":[{"line_number":6039,"context_line":"        elif guestarch \u003d\u003d fields.Architecture.MIPSEL:"},{"line_number":6040,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6041,"context_line":"        elif guestarch \u003d\u003d \u0027riscv64\u0027:"},{"line_number":6042,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6043,"context_line":"        elif CONF.spice.enabled:"},{"line_number":6044,"context_line":"            video.type \u003d \u0027qxl\u0027"},{"line_number":6045,"context_line":"        if image_meta.properties.get(\u0027hw_video_model\u0027):"}],"source_content_type":"text/x-python","patch_set":33,"id":"e24c8d1e_f643d9f3","line":6042,"updated":"2022-02-07 08:59:45.000000000","message":"nit: you can merge the elif branches to\n\n   elif guestarch in (fields.Architecture.MIPSEL, fields.Architecture.RISCV64):\n      video.type \u003d \u0027virtio\u0027","commit_id":"dff500ba96a2ed6b770e57094086973d1d1b9cf3"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"bb1f0d057d842232961ab68b4b5b48433b2c0f15","unresolved":false,"context_lines":[{"line_number":6039,"context_line":"        elif guestarch \u003d\u003d fields.Architecture.MIPSEL:"},{"line_number":6040,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6041,"context_line":"        elif guestarch \u003d\u003d \u0027riscv64\u0027:"},{"line_number":6042,"context_line":"            video.type \u003d \u0027virtio\u0027"},{"line_number":6043,"context_line":"        elif CONF.spice.enabled:"},{"line_number":6044,"context_line":"            video.type \u003d \u0027qxl\u0027"},{"line_number":6045,"context_line":"        if image_meta.properties.get(\u0027hw_video_model\u0027):"}],"source_content_type":"text/x-python","patch_set":33,"id":"6582440a_40413950","line":6042,"in_reply_to":"e24c8d1e_f643d9f3","updated":"2022-02-08 14:14:32.000000000","message":"Ack","commit_id":"dff500ba96a2ed6b770e57094086973d1d1b9cf3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8da010645deddcefec6a6c85d350fcdbb2c927e2","unresolved":true,"context_lines":[{"line_number":6447,"context_line":"        return self._check_emulation_arch(image_meta) in mipsel_archs"},{"line_number":6448,"context_line":""},{"line_number":6449,"context_line":"    def _is_riscv64_guest(self, image_meta):"},{"line_number":6450,"context_line":"        riscv_archs \u003d (fields.Architecture.RISCV64)"},{"line_number":6451,"context_line":"        return self._check_emulation_arch(image_meta) in riscv_archs"},{"line_number":6452,"context_line":""},{"line_number":6453,"context_line":"    def _is_s390x_guest(self, image_meta):"}],"source_content_type":"text/x-python","patch_set":33,"id":"c666e395_406b8f5f","line":6450,"range":{"start_line":6450,"start_character":22,"end_line":6450,"end_character":51},"updated":"2022-02-07 08:59:45.000000000","message":"this is probably a bug. riscv_archs is now a string pointed by fields.Architecture.RISCV64 then in the next line you check if the string from the image meta is in the string of the enum. \n\nWhat you probably want is a tuple of a single item. That would look like\n\n    riscv_archs \u003d (fields.Architecture.RISCV64,)\n\n//\n\n\u003e\u003e\u003e type((\u0027foo\u0027))\n\u003cclass \u0027str\u0027\u003e\n\u003e\u003e\u003e type((\u0027foo\u0027,))\n\u003cclass \u0027tuple\u0027\u003e\n\u003e\u003e\u003e","commit_id":"dff500ba96a2ed6b770e57094086973d1d1b9cf3"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"bb1f0d057d842232961ab68b4b5b48433b2c0f15","unresolved":false,"context_lines":[{"line_number":6447,"context_line":"        return self._check_emulation_arch(image_meta) in mipsel_archs"},{"line_number":6448,"context_line":""},{"line_number":6449,"context_line":"    def _is_riscv64_guest(self, image_meta):"},{"line_number":6450,"context_line":"        riscv_archs \u003d (fields.Architecture.RISCV64)"},{"line_number":6451,"context_line":"        return self._check_emulation_arch(image_meta) in riscv_archs"},{"line_number":6452,"context_line":""},{"line_number":6453,"context_line":"    def _is_s390x_guest(self, image_meta):"}],"source_content_type":"text/x-python","patch_set":33,"id":"27e72b32_386867c1","line":6450,"range":{"start_line":6450,"start_character":22,"end_line":6450,"end_character":51},"in_reply_to":"c666e395_406b8f5f","updated":"2022-02-08 14:14:32.000000000","message":"makes sense.","commit_id":"dff500ba96a2ed6b770e57094086973d1d1b9cf3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":6443,"context_line":"                    guest_cfg, instance, flavor, image_meta)"},{"line_number":6444,"context_line":""},{"line_number":6445,"context_line":"    def _is_mipsel_guest(self, image_meta):"},{"line_number":6446,"context_line":"        archs \u003d (fields.Architecture.MIPSEL,"},{"line_number":6447,"context_line":"                        fields.Architecture.MIPS64EL)"},{"line_number":6448,"context_line":"        return self._check_emulation_arch(image_meta) in archs"},{"line_number":6449,"context_line":""},{"line_number":6450,"context_line":"    def _is_s390x_guest(self, image_meta):"}],"source_content_type":"text/x-python","patch_set":57,"id":"800fbbb4_c7f0d15d","line":6447,"range":{"start_line":6446,"start_character":8,"end_line":6447,"end_character":53},"updated":"2022-02-22 09:55:28.000000000","message":"nit: this fits in a single line","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":false,"context_lines":[{"line_number":6443,"context_line":"                    guest_cfg, instance, flavor, image_meta)"},{"line_number":6444,"context_line":""},{"line_number":6445,"context_line":"    def _is_mipsel_guest(self, image_meta):"},{"line_number":6446,"context_line":"        archs \u003d (fields.Architecture.MIPSEL,"},{"line_number":6447,"context_line":"                        fields.Architecture.MIPS64EL)"},{"line_number":6448,"context_line":"        return self._check_emulation_arch(image_meta) in archs"},{"line_number":6449,"context_line":""},{"line_number":6450,"context_line":"    def _is_s390x_guest(self, image_meta):"}],"source_content_type":"text/x-python","patch_set":57,"id":"b81a6c14_560ddbb7","line":6447,"range":{"start_line":6446,"start_character":8,"end_line":6447,"end_character":53},"in_reply_to":"800fbbb4_c7f0d15d","updated":"2022-02-22 14:46:50.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":6622,"context_line":"        # controller (x86 gets one by default)"},{"line_number":6623,"context_line":"        usbhost.model \u003d None"},{"line_number":6624,"context_line":"        if not self._guest_needs_usb(guest, image_meta):"},{"line_number":6625,"context_line":"            archs \u003d (fields.Architecture.PPC,"},{"line_number":6626,"context_line":"                    fields.Architecture.PPC64, fields.Architecture.PPC64LE)"},{"line_number":6627,"context_line":"            if self._check_emulation_arch(image_meta) in archs:"},{"line_number":6628,"context_line":"                usbhost.model \u003d None"},{"line_number":6629,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":57,"id":"11e87a3a_421ee3f8","line":6626,"range":{"start_line":6625,"start_character":0,"end_line":6626,"end_character":75},"updated":"2022-02-22 09:55:28.000000000","message":"the fields.Architecture.PPC64 is underindented\nI (and black) would format this like:\n\n            archs \u003d (\n                fields.Architecture.PPC,\n                fields.Architecture.PPC64,\n                fields.Architecture.PPC64LE,\n            )","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":false,"context_lines":[{"line_number":6622,"context_line":"        # controller (x86 gets one by default)"},{"line_number":6623,"context_line":"        usbhost.model \u003d None"},{"line_number":6624,"context_line":"        if not self._guest_needs_usb(guest, image_meta):"},{"line_number":6625,"context_line":"            archs \u003d (fields.Architecture.PPC,"},{"line_number":6626,"context_line":"                    fields.Architecture.PPC64, fields.Architecture.PPC64LE)"},{"line_number":6627,"context_line":"            if self._check_emulation_arch(image_meta) in archs:"},{"line_number":6628,"context_line":"                usbhost.model \u003d None"},{"line_number":6629,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":57,"id":"3666bed5_4bac227a","line":6626,"range":{"start_line":6625,"start_character":0,"end_line":6626,"end_character":75},"in_reply_to":"11e87a3a_421ee3f8","updated":"2022-02-22 14:46:50.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":6625,"context_line":"            archs \u003d (fields.Architecture.PPC,"},{"line_number":6626,"context_line":"                    fields.Architecture.PPC64, fields.Architecture.PPC64LE)"},{"line_number":6627,"context_line":"            if self._check_emulation_arch(image_meta) in archs:"},{"line_number":6628,"context_line":"                usbhost.model \u003d None"},{"line_number":6629,"context_line":"            else:"},{"line_number":6630,"context_line":"                usbhost.model \u003d \u0027none\u0027"},{"line_number":6631,"context_line":"        guest.add_device(usbhost)"}],"source_content_type":"text/x-python","patch_set":57,"id":"78ccee45_3a61f6c6","line":6628,"updated":"2022-02-22 09:55:28.000000000","message":"I\u0027m wondering if this is correct. The libvirt documentation[1] says it should be \u0027none\u0027 to disable it. And we use that below too. \n\n[1] https://libvirt.org/formatdomain.html#controllers","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"bf38bf90e414f205d028e99f6df43cfb1f5ba774","unresolved":false,"context_lines":[{"line_number":6625,"context_line":"            archs \u003d (fields.Architecture.PPC,"},{"line_number":6626,"context_line":"                    fields.Architecture.PPC64, fields.Architecture.PPC64LE)"},{"line_number":6627,"context_line":"            if self._check_emulation_arch(image_meta) in archs:"},{"line_number":6628,"context_line":"                usbhost.model \u003d None"},{"line_number":6629,"context_line":"            else:"},{"line_number":6630,"context_line":"                usbhost.model \u003d \u0027none\u0027"},{"line_number":6631,"context_line":"        guest.add_device(usbhost)"}],"source_content_type":"text/x-python","patch_set":57,"id":"44dbf47e_1b46a53c","line":6628,"in_reply_to":"34bef54b_706a3869","updated":"2022-02-23 18:19:20.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":true,"context_lines":[{"line_number":6625,"context_line":"            archs \u003d (fields.Architecture.PPC,"},{"line_number":6626,"context_line":"                    fields.Architecture.PPC64, fields.Architecture.PPC64LE)"},{"line_number":6627,"context_line":"            if self._check_emulation_arch(image_meta) in archs:"},{"line_number":6628,"context_line":"                usbhost.model \u003d None"},{"line_number":6629,"context_line":"            else:"},{"line_number":6630,"context_line":"                usbhost.model \u003d \u0027none\u0027"},{"line_number":6631,"context_line":"        guest.add_device(usbhost)"}],"source_content_type":"text/x-python","patch_set":57,"id":"dabfdde0_3d53f729","line":6628,"in_reply_to":"78ccee45_3a61f6c6","updated":"2022-02-22 14:46:50.000000000","message":"during actual testing and implementation it wanted None for ppc, as this removes it from the domain xml, where \u0027none\u0027 adds it but then disables it causing libvirt errors and the instances not being able to build.","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f234c8a3245abbd9573eca57d2976df647510dc8","unresolved":true,"context_lines":[{"line_number":6625,"context_line":"            archs \u003d (fields.Architecture.PPC,"},{"line_number":6626,"context_line":"                    fields.Architecture.PPC64, fields.Architecture.PPC64LE)"},{"line_number":6627,"context_line":"            if self._check_emulation_arch(image_meta) in archs:"},{"line_number":6628,"context_line":"                usbhost.model \u003d None"},{"line_number":6629,"context_line":"            else:"},{"line_number":6630,"context_line":"                usbhost.model \u003d \u0027none\u0027"},{"line_number":6631,"context_line":"        guest.add_device(usbhost)"}],"source_content_type":"text/x-python","patch_set":57,"id":"34bef54b_706a3869","line":6628,"in_reply_to":"dabfdde0_3d53f729","updated":"2022-02-23 12:47:27.000000000","message":"I see. I think this information would be an excellent code comment above this code.","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"}],"nova/virt/libvirt/utils.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":529,"context_line":"    # TODO(chateaulav): Testing of emulated archs ongoing"},{"line_number":530,"context_line":"    # elif arch \u003d\u003d obj_fields.Architecture.MIPSEL:"},{"line_number":531,"context_line":"    #     mode \u003d \u002724Kf-mips-cpu\u0027"},{"line_number":532,"context_line":"    # elif arch \u003d\u003d obj_fields.Architecture.RISCV64:"},{"line_number":533,"context_line":"    #     mode \u003d \u0027rv64-riscv-cpu\u0027"},{"line_number":534,"context_line":"    # NOTE(kevinz): In aarch64, cpu model \u0027max\u0027 will offer the capabilities"},{"line_number":535,"context_line":"    # that all the stuff it can currently emulate, both for \"TCG\" and \"KVM\""},{"line_number":536,"context_line":"    elif arch \u003d\u003d obj_fields.Architecture.AARCH64:"}],"source_content_type":"text/x-python","patch_set":57,"id":"a16ac3d6_a6817e2f","line":533,"range":{"start_line":532,"start_character":0,"end_line":533,"end_character":33},"updated":"2022-02-22 09:55:28.000000000","message":"this can be dropped now","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":false,"context_lines":[{"line_number":529,"context_line":"    # TODO(chateaulav): Testing of emulated archs ongoing"},{"line_number":530,"context_line":"    # elif arch \u003d\u003d obj_fields.Architecture.MIPSEL:"},{"line_number":531,"context_line":"    #     mode \u003d \u002724Kf-mips-cpu\u0027"},{"line_number":532,"context_line":"    # elif arch \u003d\u003d obj_fields.Architecture.RISCV64:"},{"line_number":533,"context_line":"    #     mode \u003d \u0027rv64-riscv-cpu\u0027"},{"line_number":534,"context_line":"    # NOTE(kevinz): In aarch64, cpu model \u0027max\u0027 will offer the capabilities"},{"line_number":535,"context_line":"    # that all the stuff it can currently emulate, both for \"TCG\" and \"KVM\""},{"line_number":536,"context_line":"    elif arch \u003d\u003d obj_fields.Architecture.AARCH64:"}],"source_content_type":"text/x-python","patch_set":57,"id":"b6a3daa2_d379c287","line":533,"range":{"start_line":532,"start_character":0,"end_line":533,"end_character":33},"in_reply_to":"a16ac3d6_a6817e2f","updated":"2022-02-22 14:46:50.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"}],"releasenotes/notes/bp-pick-guest-arch-based-on-host-arch-in-libvirt-driver-f087c3799d388bb6.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    image meta now includes the ``hw_emulation_architecture`` property."},{"line_number":5,"context_line":"    This allows an operator to define their cpu architecture for an image,"},{"line_number":6,"context_line":"    and nova will deploy accordingly."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    See the `spec`_ for more details and reasoning."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"c2b3daa0_446102bc","line":5,"range":{"start_line":5,"start_character":38,"end_line":5,"end_character":47},"updated":"2022-02-22 09:55:28.000000000","message":"their emulated cpu","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    image meta now includes the ``hw_emulation_architecture`` property."},{"line_number":5,"context_line":"    This allows an operator to define their cpu architecture for an image,"},{"line_number":6,"context_line":"    and nova will deploy accordingly."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    See the `spec`_ for more details and reasoning."}],"source_content_type":"text/x-yaml","patch_set":57,"id":"a027e9b4_83cf31bd","line":5,"range":{"start_line":5,"start_character":38,"end_line":5,"end_character":47},"in_reply_to":"c2b3daa0_446102bc","updated":"2022-02-22 14:46:50.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"}],"tools/hooks/post_test_hook.sh":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"000581207233cdd100220f5d05b815166ae612be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":57,"id":"d118a7f8_3a2936a8","updated":"2022-02-22 09:55:28.000000000","message":"I this change related to this commit of the series? It seems it is more belongs to the next one adding the gate job","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"36df0ae7af2ec1ca30d0c0ee02b2067c0a5acba9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":57,"id":"dd704b02_6bdec9c6","in_reply_to":"d118a7f8_3a2936a8","updated":"2022-02-22 14:46:50.000000000","message":"this is not related, and was never intended to be changed. it shows as a typechange, I have done a reset on it to try and remove it from my patch.","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"},{"author":{"_account_id":34141,"name":"Jonathan Race","display_name":"chateaulav","email":"jrace@augusta.edu","username":"chateaulav","status":"Always Available"},"change_message_id":"bf38bf90e414f205d028e99f6df43cfb1f5ba774","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"94772435_f5b7c614","in_reply_to":"dd704b02_6bdec9c6","updated":"2022-02-23 18:19:20.000000000","message":"Ack","commit_id":"556991dca6eef759879aa8d678e993dbd594c7ed"}]}