)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f703e24d95611628c7057e5e6ac9c6a806368d0b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-01-05 16:44:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"it takes too long to update novadb.instance_info_caches and operations"},{"line_number":8,"context_line":"such as `openstack server add floating ip` won\u0027t be visible with"},{"line_number":9,"context_line":"`openstack server list` before heal_instance_info_cache_interval x nb instances"},{"line_number":10,"context_line":"Change : iterate over all instances rather than one by one."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2994b5cf_61ecec4f","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":42},"updated":"2022-01-05 19:20:03.000000000","message":"if this is the operation you care about specifically then you shoudl\ninstead add a direct refesh of the instance info cache wehn the floatign ip is added","commit_id":"ad8eb6ada4caa249a3331a677cba2c3fc8f069e4"},{"author":{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"},"change_message_id":"66c65b76afde31877e845915eb6bade010377200","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-01-05 16:44:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"it takes too long to update novadb.instance_info_caches and operations"},{"line_number":8,"context_line":"such as `openstack server add floating ip` won\u0027t be visible with"},{"line_number":9,"context_line":"`openstack server list` before heal_instance_info_cache_interval x nb instances"},{"line_number":10,"context_line":"Change : iterate over all instances rather than one by one."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"33e0f485_962421a1","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":42},"in_reply_to":"2994b5cf_61ecec4f","updated":"2022-01-07 08:12:42.000000000","message":"Yes, operations floatin assocaitae/disassociate. That would be on neutron code side then, right ?","commit_id":"ad8eb6ada4caa249a3331a677cba2c3fc8f069e4"},{"author":{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"},"change_message_id":"0f52cedd10e216df10b432d0a476de524abf5aae","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-01-05 16:44:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"it takes too long to update novadb.instance_info_caches and operations"},{"line_number":8,"context_line":"such as `openstack server add floating ip` won\u0027t be visible with"},{"line_number":9,"context_line":"`openstack server list` before heal_instance_info_cache_interval x nb instances"},{"line_number":10,"context_line":"Change : iterate over all instances rather than one by one."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c6e24ae2_83c65960","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":42},"in_reply_to":"3256a99b_9611a2c5","updated":"2022-01-11 09:01:50.000000000","message":"issue appears using both `openstack server add flaoting ip` and `openstack floating ip set`\n\nI am a bit confused. It doesn\u0027t seem I go throught the code you mentioned even after adding some debug in the code. Also there\u0027s this comment : \n\u003e \"\"\"This API is deprecated from the Microversion \u00272.44\u0027.\"\"\"\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L179\n\n\n``openstack --debug server add floating ip`` shows that the API called is the neutron one, with such queries :\n\n\u003e \"GET /network/v2.0/floatingips/111.222.333.444 HTTP/1.1\"\n\u003e \"GET /network/v2.0/floatingips HTTP/1.1\"\n\nThe decorator refresh_cache is indeed loaded when nova-api starts but looks to me that it is never used...\n\nserver side : debian nova-api 2:22.2.2-1~bpo11+1 \nclient side : python3-openstackclient 5.2.0-0ubuntu1","commit_id":"ad8eb6ada4caa249a3331a677cba2c3fc8f069e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"997ab6e70b673b9826042bcac5d83f06b8f9230d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-01-05 16:44:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"it takes too long to update novadb.instance_info_caches and operations"},{"line_number":8,"context_line":"such as `openstack server add floating ip` won\u0027t be visible with"},{"line_number":9,"context_line":"`openstack server list` before heal_instance_info_cache_interval x nb instances"},{"line_number":10,"context_line":"Change : iterate over all instances rather than one by one."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3256a99b_9611a2c5","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":42},"in_reply_to":"33e0f485_962421a1","updated":"2022-01-10 14:42:11.000000000","message":"both in nova the api is implemented here\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L186-L300\n\nwhich calls neutron via \nhttps://github.com/openstack/nova/blob/master/nova/network/neutron.py#L2545-L2616\n\nwe actully have a conditional refersh of the network info cache already.\n\nto resolve your issue w likely need to alway refesh the network info cache instead.\n\nso at first glance after the current update of the old port you would  need to add an update of the new port\ne.g. ``update_instance_cache_with_nw_info(context,instnace)`` at\nhttps://github.com/openstack/nova/blob/master/nova/network/neutron.py#L2580\nhowever that function is decorated with refresh_cache\nhttps://github.com/openstack/nova/blob/master/nova/network/neutron.py#L132-L158\nwhich does this automatically.\n\nso if you associate the floating ip with the instance via the nova api we are already doing the cache refersh correctly.\n\nif you are associateing the ip via neutron then neutron need to send a network-vif-changed external event to refresh the cache.\nthe recomended way to manage floatign ip assignment was previously to only do it via nova so perhaps neutron has a bug and does\nnot send the network vif plugged event if you bypass nova and do the association directly in neutron.\n\n``openstack server add floating ip`` shoudl be useing the nova api.\n\nis this how you are adding the floating ip or are doing it via neutron with \n\n``openstack floating ip set --port \u003cneutron port\u003e [--fixed-ip \u003cport private ip\u003e] \u003cfloating ip\u003e``\n\nthis will associated the fip with the vif via neutron without invoking nova fip add or remote apis.\n\nas a result this will only be refected in the network info cache if netorn send the netwrok-vif-chagned external event or the perodic task runs. neutron should do the former. if it does nto its a bug that hsould be fixed there.","commit_id":"ad8eb6ada4caa249a3331a677cba2c3fc8f069e4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"},"change_message_id":"74d74ebabc1cca02e7e9cb4750358434d9682511","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24d78da3_b3ee8eda","updated":"2022-01-05 12:57:07.000000000","message":"recheck","commit_id":"9419a6f558a5d80149d8f895de668b10e5f4b54f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cdd9a75ba53301222ffdc1087bc160c1d47cf4d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"febc24ab_06c3075e","updated":"2022-01-05 19:18:58.000000000","message":"iterating over one by one was done intentionally as iterating over all instance can block the agent for along time.\n\nwe could perhaps make it batchable or make it configurable but we cannot simple iterate over all of them\n\nyou should also file a bug for this and explain exactly how it fails or why the current behavior does not work.\n\n","commit_id":"ad8eb6ada4caa249a3331a677cba2c3fc8f069e4"},{"author":{"_account_id":29422,"name":"Olivier Chaze","display_name":"Olivier Chaze","email":"olivier.chaze@infomaniak.com","username":"o.chaze"},"change_message_id":"e0ba10077085099c372d2be5fa1ceb3701012904","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"81527873_6dd8d56e","in_reply_to":"febc24ab_06c3075e","updated":"2022-01-07 08:11:13.000000000","message":"ok, I didn\u0027t think about the agent being blocked while doing the iteration, that is indeed a problem...","commit_id":"ad8eb6ada4caa249a3331a677cba2c3fc8f069e4"}]}