)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"52496a8bb3b4fa80ecf1ea31c2200204ad76133d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5709f44d_ae0224cf","updated":"2022-01-11 14:31:43.000000000","message":"Hello Lior.\n\nI would like to provide a brief explanation why two reviews were created for single patch and few tips about next steps.\n\nGerrit uses change-id at the end of commit messages to group inbound patches: if appropriate project already has a patch with particular change-id uploaded for review, then pushed patch is used to update existing review and is uploaded as the latest one.\n\nIf appropriate project doesn\u0027t have a patch with particular change-id uploaded for review yet, then new review is created. That\u0027s the reason why a separate review was created for new patch: you have two different Change IDs in the commit message and the latest one didn\u0027t match Change-ID of existing review.\n\nI also can see another problems with proposed commit message: it doesn\u0027t contain any justification/explanation of this change. I am not sure if you consider this a bug (launchpad bug should exist) or a feature (release note should likely be created), but this is another point about commit message to consider.","commit_id":"62b874d4fa7d6a4e4ff7bf8d326ea2e3574cb6ee"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"2ebf8b4524d36f31de204fc4fe70b0762480ae93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"79b1f442_aeb4a9d8","updated":"2022-01-10 09:06:11.000000000","message":"Sorry guys for the inconvenience about the duplicate PR (the original was abandoned). \nAgain, this change is needed for supporting multipath in the NVMeoF Connector - passing the use_multipath flag also for the Nvme driver.  ","commit_id":"62b874d4fa7d6a4e4ff7bf8d326ea2e3574cb6ee"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"d15189546fcfe0aaba569198515736ece1d12f30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c2d07220_8abcdc77","in_reply_to":"5709f44d_ae0224cf","updated":"2022-01-11 15:17:02.000000000","message":"Hi Alexey,\n\nThanks a lot for your reply and explanations - Gerrit is quite new to me.\n\nSo on the next commit for this patch will I need to mark on the commit message Change-Id: I20f6aa2d422259601c44d024099cd5760a8e21c6 (the Change-Id of the last commit)?\n\nIn addition, this patch is a feature and not a bug - a preparation for supporting multipath on the nvmeof connector.","commit_id":"62b874d4fa7d6a4e4ff7bf8d326ea2e3574cb6ee"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"1f75d0d6177a77dd990229b773e58fe924ff7669","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"34c19375_1d5c5aa0","in_reply_to":"c2d07220_8abcdc77","updated":"2022-01-11 15:21:42.000000000","message":"Lior, only one change id should present in commit message and IMO it is better to have original change ID instead of new one. I think that it doesn\u0027t matter which review would be used here (old one or current one), just pick one of the option and leave one Change-ID in commit message.\n\nI can recommend you to take a look at the following documents to decide if you need to add release notes and which note is needed:\nhttps://docs.openstack.org/nova/latest/contributor/index.html\nhttps://docs.openstack.org/nova/latest/contributor/releasenotes.html","commit_id":"62b874d4fa7d6a4e4ff7bf8d326ea2e3574cb6ee"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"cd0884b3e6b9d581c811383b38ba0e02c8433fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c47b3079_1023ed9a","updated":"2022-01-17 16:08:54.000000000","message":"Hi again Lior. I would like to recommend one change: please consider tuning commit message, so only one Change-Id remains. You can take a look at any merged patch and use it as an example.","commit_id":"c5c570ef694db5337b976693e5ac0c0fc39a621b"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"5d0c860a38aedfb949799a08db14405753af3b4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"701bc2dc_3fc014a6","updated":"2022-01-19 16:18:16.000000000","message":"Looking good and definitely needed","commit_id":"d4d65055ad09e52b9187c5a2f3bfce0dc4f2ca5f"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"0bd2b4be962dbaeca9f8a428a1f392cbdb7adac9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b5ec9e95_daa0d0da","updated":"2022-01-19 17:51:51.000000000","message":"recheck","commit_id":"d4d65055ad09e52b9187c5a2f3bfce0dc4f2ca5f"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"2a38fa92e44812b6913cd125705ad3ad116cc068","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"819d5a38_2e4164c2","updated":"2022-02-09 14:08:08.000000000","message":"Hi,\n\nWhat is please needs to be done here for merging this patch? ","commit_id":"9053318104c9e55bc4a2ff9f7cbb9b4072719c80"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"63d47bab2f942d42857dd877dab29da27758ecbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e8bcfeb2_08153deb","updated":"2022-01-21 11:18:20.000000000","message":"LGTM, you\u0027ve missed the positive unit test case but I appreciate this is just boilerplate so +2 from me.","commit_id":"9053318104c9e55bc4a2ff9f7cbb9b4072719c80"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"0cc706ea267910325975d3a42559029b0dff7788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"799b18d5_e267ac44","updated":"2022-02-09 13:33:27.000000000","message":"run-KIOXIA CI","commit_id":"9053318104c9e55bc4a2ff9f7cbb9b4072719c80"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"afa4f600ecc0cc0c414a2e322044f491587c9a15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f7609237_cf486ccf","in_reply_to":"819d5a38_2e4164c2","updated":"2022-02-10 13:40:47.000000000","message":"Another core reviewer should add his +2 to this patch. You can ask for their attention at proper IRC channels.\n\nAlso it could make sense to rebase this patch.","commit_id":"9053318104c9e55bc4a2ff9f7cbb9b4072719c80"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"83605a5ef364ff852d0682ff7bb5c49754dfeae7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ba6d1bae_61442c55","updated":"2022-02-10 17:11:18.000000000","message":"Added the positive test for the use_multipath flag.\nWe will appreciate more reviews for merging it this release - it is critical for our whole multipath feature.    ","commit_id":"9ecf5b5f0207d641fc95455af0760d8a1685a0bb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c30a52ef015171e5c5755734c6397d6596f03f84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3e410fd8_85ea1058","updated":"2022-02-17 09:35:32.000000000","message":"+2 for now pending the team meeting.\n\nif this is approved as a specless blueprint then sylvain can remove the procedural -2 and add +w\nif you have not already done so please file a blueprint at https://blueprints.launchpad.net/nova/+addspec\n\nfor this with a very short summary of what your trying to enable.\nin this case multipath support for nvme over fabric when using the libvirt virt driver.\n\nonce that is filed please add a link to the blueprint to the adgenda for the meeting here\nhttps://wiki.openstack.org/wiki/Meetings/Nova","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c8e16f8de1e919dc672703e224974646c4bc570a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e5ed3b12_6ee023e8","updated":"2022-02-22 16:37:03.000000000","message":"As we agreed on today\u0027s meeting [1], we accept this as a feature exception for Yoga as the blueprint is specless.\nGiven Sean and Stephen already +2d this change, I just +W it.\n\n\n[1]","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"8f3e9da07b5d399f0ab0a8e570aad8ba8625c6c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"13df3114_f57f779c","updated":"2022-02-17 08:37:09.000000000","message":"For the moment, -2 for not asking to merge this change until we accept to have a specless blueprint during the Feb 22th nova meeting.\n\nLior, please be able to be around in the meeting, see https://wiki.openstack.org/wiki/Meetings/Nova for details.\n\nIf we accept this, then I\u0027ll remove the -2 review.","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"afb7057fb2838651a1a215391bd1bee649087d45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d5111f3e_7c30de95","updated":"2022-02-16 16:18:33.000000000","message":"We will appreciate more reviews for merging this patch - it is crucial for the whole multipath feature in our NVMeoF Connector.   ","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df59660bb8ae1f49940a37e74919c532a3265ecb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d940e5ac_c4407b31","updated":"2022-02-16 19:01:40.000000000","message":"stephen has some nits but since he is +2 i think we are ok to proceed as is.\nif we want to rename things in the futre we can do that as a followup change\nrather then holding this.\n\nhowever this does not appear to be assocated with an approved blueprint or spec\nand it does not refrence a bug so a procedual -1 untill we figure out how to proceed.\n\nthis is pretty trivial so i think it coudl be done with a specless blueprint\nif you already have an approved specless blueprint then please update the commit with it\n\n\nlookign quickly i found\nhttps://blueprints.launchpad.net/nova/+spec/nvme-volume-driver\nhttps://blueprints.launchpad.net/nova/+spec/add-nvme-bus-to-kvm-hypervisor\nrelated to nvm and the following related to multipath\nhttps://blueprints.launchpad.net/nova/+spec/nova-support-multiple-multipath-tools\nhttps://blueprints.launchpad.net/nova/+spec/iscsi-multipath\n\nnone of these are approved \n\nlooking at https://etherpad.opendev.org/p/nova-yoga-blueprint-status\n\nthis is also not tracked there.\n\nso as i said procedural -1 until this is approveds as a blueprint.\ncan you attend the next nova meeting on tuseday the 22nd and ask for this to be approved\nas a specless blueprint. we are well after the normal approval deadline so really we shoudl\ndefer this until the Zed cycle but given how small the patch is im supportive of makeing an excpiton if other are..","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"f59c657029cddc0dc6061188f3ea545056440195","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e6203615_7d4827e8","in_reply_to":"13df3114_f57f779c","updated":"2022-02-17 08:46:11.000000000","message":"Thanks Sylvain,\nI will attend the Feb 22th nova meeting.","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"da70fca1893df75f48aa3ae835902beb2d8808fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"85bbfe42_afd077dd","in_reply_to":"3e410fd8_85ea1058","updated":"2022-02-17 10:30:32.000000000","message":"I had created a blueprint https://blueprints.launchpad.net/nova/+spec/nvmeof-multipath and added it to the https://etherpad.opendev.org/p/nova-yoga-blueprint-status\nHope I had done it correctly as I should.","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"0b17a2f133b938ec48d5be4211ec272572b4987c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"311adab0_ac3a28c9","in_reply_to":"4dbd118c_ca6590b1","updated":"2022-02-22 16:40:22.000000000","message":"Sylvain, Thanks a lot for your efforts here!","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"87792ee66f286cd1d254278db9fd19883f3e9ead","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"92607e6d_18a26614","in_reply_to":"85bbfe42_afd077dd","updated":"2022-02-17 10:44:42.000000000","message":"more or less you just missed adding it to \nhttps://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting\nwhich i have done","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"26e3fae3497550334aece58a92ec5b788b7a22e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"97d771a8_87165cac","in_reply_to":"92607e6d_18a26614","updated":"2022-02-17 10:49:51.000000000","message":"Great, Thanks!","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f410223b871de7989054883a445f7e8235e1095f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"658d4230_b37bf3da","in_reply_to":"af9370cc_eac747e0","updated":"2022-02-17 08:42:32.000000000","message":"\u003e Thank\u0027s Sean for your review here.\n\u003e I will attend the next nova meeting on Tuesday the 22nd.\n\n\nGreat, thanks. Details on how to attend it is https://wiki.openstack.org/wiki/Meetings/Nova#Weekly_Nova_team_meeting\n\n\u003e So if the mentioned blueprints above will be approved - this patch will be able to be merged?\n\n\nI just provided a procedural -2 but Sean or anyone other nova-core can continue to review this change and either providing -1 or +2.\nIf you get two +2s, then if we agree on accepting this specless blueprint for Yoga, I could just +W directly.","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"b909427a6e3130cb50f5af06a16b8f560c9e6328","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"af9370cc_eac747e0","in_reply_to":"d940e5ac_c4407b31","updated":"2022-02-17 08:13:53.000000000","message":"Thank\u0027s Sean for your review here.\nI will attend the next nova meeting on Tuesday the 22nd.\nSo if the mentioned blueprints above will be approved - this patch will be able to be merged?","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"39f2775e827332960acec2ed3677795a2036d372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4dbd118c_ca6590b1","in_reply_to":"e5ed3b12_6ee023e8","updated":"2022-02-22 16:37:35.000000000","message":"Damn, forgot the meeting minutes :\n\n[1] https://meetings.opendev.org/meetings/nova/2022/nova.2022-02-22-16.02.html","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"}],"nova/tests/unit/virt/libvirt/volume/test_nvme.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"63d47bab2f942d42857dd877dab29da27758ecbe","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LibvirtNVMEVolumeDriverTestCase(test_volume.LibvirtVolumeBaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue)"},{"line_number":24,"context_line":"    @mock.patch(\u0027nova.utils.get_root_helper\u0027)"},{"line_number":25,"context_line":"    @mock.patch(\u0027os_brick.initiator.connector.InitiatorConnector.factory\u0027)"},{"line_number":26,"context_line":"    def test_libvirt_nvme_driver(self, mock_factory, mock_helper, exists):"},{"line_number":27,"context_line":"        self.flags(num_nvme_discover_tries\u003d3, group\u003d\u0027libvirt\u0027)"},{"line_number":28,"context_line":"        mock_helper.return_value \u003d \u0027sudo\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        nvme.LibvirtNVMEVolumeDriver(self.fake_host)"},{"line_number":31,"context_line":"        mock_factory.assert_called_once_with("},{"line_number":32,"context_line":"            initiator.NVME, \u0027sudo\u0027, use_multipath\u003dFalse,"},{"line_number":33,"context_line":"            device_scan_attempts\u003d3)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch(\u0027os_brick.initiator.connector.InitiatorConnector.factory\u0027,"},{"line_number":36,"context_line":"        new\u003dmock.Mock(return_value\u003dmock.Mock()))"}],"source_content_type":"text/x-python","patch_set":5,"id":"775dc76d_2ea9b94a","line":33,"range":{"start_line":23,"start_character":0,"end_line":33,"end_character":35},"updated":"2022-01-21 11:18:20.000000000","message":"nit - A version of this test that asserts that the flag is passed to the connector would be nice.","commit_id":"9053318104c9e55bc4a2ff9f7cbb9b4072719c80"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"5d335f75a19d1a0d0422f4d8f740830d718e4de3","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LibvirtNVMEVolumeDriverTestCase(test_volume.LibvirtVolumeBaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue)"},{"line_number":24,"context_line":"    @mock.patch(\u0027nova.utils.get_root_helper\u0027)"},{"line_number":25,"context_line":"    @mock.patch(\u0027os_brick.initiator.connector.InitiatorConnector.factory\u0027)"},{"line_number":26,"context_line":"    def test_libvirt_nvme_driver(self, mock_factory, mock_helper, exists):"},{"line_number":27,"context_line":"        self.flags(num_nvme_discover_tries\u003d3, group\u003d\u0027libvirt\u0027)"},{"line_number":28,"context_line":"        mock_helper.return_value \u003d \u0027sudo\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        nvme.LibvirtNVMEVolumeDriver(self.fake_host)"},{"line_number":31,"context_line":"        mock_factory.assert_called_once_with("},{"line_number":32,"context_line":"            initiator.NVME, \u0027sudo\u0027, use_multipath\u003dFalse,"},{"line_number":33,"context_line":"            device_scan_attempts\u003d3)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch(\u0027os_brick.initiator.connector.InitiatorConnector.factory\u0027,"},{"line_number":36,"context_line":"        new\u003dmock.Mock(return_value\u003dmock.Mock()))"}],"source_content_type":"text/x-python","patch_set":5,"id":"ec87c7da_f4e6eba4","line":33,"range":{"start_line":23,"start_character":0,"end_line":33,"end_character":35},"in_reply_to":"775dc76d_2ea9b94a","updated":"2022-01-23 06:48:01.000000000","message":"Hi Lee,\nYour comment here is not clear to me.\nCan you please address me an example of what do mean by test version?","commit_id":"9053318104c9e55bc4a2ff9f7cbb9b4072719c80"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"83605a5ef364ff852d0682ff7bb5c49754dfeae7","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LibvirtNVMEVolumeDriverTestCase(test_volume.LibvirtVolumeBaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue)"},{"line_number":24,"context_line":"    @mock.patch(\u0027nova.utils.get_root_helper\u0027)"},{"line_number":25,"context_line":"    @mock.patch(\u0027os_brick.initiator.connector.InitiatorConnector.factory\u0027)"},{"line_number":26,"context_line":"    def test_libvirt_nvme_driver(self, mock_factory, mock_helper, exists):"},{"line_number":27,"context_line":"        self.flags(num_nvme_discover_tries\u003d3, group\u003d\u0027libvirt\u0027)"},{"line_number":28,"context_line":"        mock_helper.return_value \u003d \u0027sudo\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        nvme.LibvirtNVMEVolumeDriver(self.fake_host)"},{"line_number":31,"context_line":"        mock_factory.assert_called_once_with("},{"line_number":32,"context_line":"            initiator.NVME, \u0027sudo\u0027, use_multipath\u003dFalse,"},{"line_number":33,"context_line":"            device_scan_attempts\u003d3)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch(\u0027os_brick.initiator.connector.InitiatorConnector.factory\u0027,"},{"line_number":36,"context_line":"        new\u003dmock.Mock(return_value\u003dmock.Mock()))"}],"source_content_type":"text/x-python","patch_set":5,"id":"d950874e_407f8faf","line":33,"range":{"start_line":23,"start_character":0,"end_line":33,"end_character":35},"in_reply_to":"d3651afe_f41e43f3","updated":"2022-02-10 17:11:18.000000000","message":"Done","commit_id":"9053318104c9e55bc4a2ff9f7cbb9b4072719c80"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"afa4f600ecc0cc0c414a2e322044f491587c9a15","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class LibvirtNVMEVolumeDriverTestCase(test_volume.LibvirtVolumeBaseTestCase):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @mock.patch(\u0027os.path.exists\u0027, return_value\u003dTrue)"},{"line_number":24,"context_line":"    @mock.patch(\u0027nova.utils.get_root_helper\u0027)"},{"line_number":25,"context_line":"    @mock.patch(\u0027os_brick.initiator.connector.InitiatorConnector.factory\u0027)"},{"line_number":26,"context_line":"    def test_libvirt_nvme_driver(self, mock_factory, mock_helper, exists):"},{"line_number":27,"context_line":"        self.flags(num_nvme_discover_tries\u003d3, group\u003d\u0027libvirt\u0027)"},{"line_number":28,"context_line":"        mock_helper.return_value \u003d \u0027sudo\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        nvme.LibvirtNVMEVolumeDriver(self.fake_host)"},{"line_number":31,"context_line":"        mock_factory.assert_called_once_with("},{"line_number":32,"context_line":"            initiator.NVME, \u0027sudo\u0027, use_multipath\u003dFalse,"},{"line_number":33,"context_line":"            device_scan_attempts\u003d3)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @mock.patch(\u0027os_brick.initiator.connector.InitiatorConnector.factory\u0027,"},{"line_number":36,"context_line":"        new\u003dmock.Mock(return_value\u003dmock.Mock()))"}],"source_content_type":"text/x-python","patch_set":5,"id":"d3651afe_f41e43f3","line":33,"range":{"start_line":23,"start_character":0,"end_line":33,"end_character":35},"in_reply_to":"ec87c7da_f4e6eba4","updated":"2022-02-10 13:40:47.000000000","message":"Lee likely tries to say that adding similar test to confirm that introduced flag is passed to connector would be nice to have.","commit_id":"9053318104c9e55bc4a2ff9f7cbb9b4072719c80"}],"nova/virt/libvirt/volume/nvme.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f085d4499d6a0edfefb91544ba6da079d6acad85","unresolved":true,"context_lines":[{"line_number":32,"context_line":"              self).__init__(connection)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.connector \u003d connector.InitiatorConnector.factory("},{"line_number":35,"context_line":"            initiator.NVME, utils.get_root_helper(),"},{"line_number":36,"context_line":"            use_multipath\u003dCONF.libvirt.volume_use_multipath,"},{"line_number":37,"context_line":"            device_scan_attempts\u003dCONF.libvirt.num_nvme_discover_tries)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"2e7c5254_6449a224","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":26},"updated":"2022-02-14 10:20:17.000000000","message":"At some point, we need to change this to NVMEOF [1][2]\n\n[1] https://github.com/openstack/os-brick/blob/e761ab6423/os_brick/initiator/connector.py#L112-L117\n[2] https://github.com/openstack/os-brick/commit/0f057aee6e0351bdef68fadf1fc56ac315027c98","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df59660bb8ae1f49940a37e74919c532a3265ecb","unresolved":false,"context_lines":[{"line_number":32,"context_line":"              self).__init__(connection)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.connector \u003d connector.InitiatorConnector.factory("},{"line_number":35,"context_line":"            initiator.NVME, utils.get_root_helper(),"},{"line_number":36,"context_line":"            use_multipath\u003dCONF.libvirt.volume_use_multipath,"},{"line_number":37,"context_line":"            device_scan_attempts\u003dCONF.libvirt.num_nvme_discover_tries)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"4ed9164b_1ef88261","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":26},"in_reply_to":"174e9d32_a64a9754","updated":"2022-02-16 19:01:40.000000000","message":"well it depend in this context i guess yes but normally i would assume NVME was a local nvme disk. rather then a remote nvmeof volume but since this is in the volume module they are more or less equvalent","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":34173,"name":"Lior Friedman","display_name":"Lior Friedman","email":"lior.friedman@kioxia.com","username":"liorf95"},"change_message_id":"056ee1d61d2bdff704fd6c65af0a1899b4e7668b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"              self).__init__(connection)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.connector \u003d connector.InitiatorConnector.factory("},{"line_number":35,"context_line":"            initiator.NVME, utils.get_root_helper(),"},{"line_number":36,"context_line":"            use_multipath\u003dCONF.libvirt.volume_use_multipath,"},{"line_number":37,"context_line":"            device_scan_attempts\u003dCONF.libvirt.num_nvme_discover_tries)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6500f119_4d7306d4","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":26},"in_reply_to":"2e7c5254_6449a224","updated":"2022-02-14 10:55:51.000000000","message":"Ack\nBut then it should be a new separate driver called LibvirtNVMeOFVolumeDriver on a new nvmeof.py file.","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d3fa85af64e70db569dc14c9ea6ee77ef03f5966","unresolved":false,"context_lines":[{"line_number":32,"context_line":"              self).__init__(connection)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.connector \u003d connector.InitiatorConnector.factory("},{"line_number":35,"context_line":"            initiator.NVME, utils.get_root_helper(),"},{"line_number":36,"context_line":"            use_multipath\u003dCONF.libvirt.volume_use_multipath,"},{"line_number":37,"context_line":"            device_scan_attempts\u003dCONF.libvirt.num_nvme_discover_tries)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"174e9d32_a64a9754","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":26},"in_reply_to":"6500f119_4d7306d4","updated":"2022-02-14 15:23:39.000000000","message":"I don\u0027t think so. initiator.NVMEOF \u003d\u003d initiator.NVME. Look at the commits I linked","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"}],"releasenotes/notes/use-multipath-0a0aa2b479e02370.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f085d4499d6a0edfefb91544ba6da079d6acad85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bd0ed816_ab719ca5","line":8,"updated":"2022-02-14 10:20:17.000000000","message":"nit: extra newline","commit_id":"e8380b96a0893229629a6b790b3785c5a31e1f0c"}]}