)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"72c6140d1f6a2f211cdd7ea209d94616dfd21f4e","unresolved":true,"context_lines":[{"line_number":34,"context_line":"as tainted by libvirt."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: I8140c8fe592dd54fc09a9510723892806db49a56"},{"line_number":37,"context_line":"(cherry picked from commit 6a75053344a91f0dd9b5da380f929319ca0e8d8e)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Change-Id: I7a6a6fe5f5b23e76948b59a85ca9be075a1c2d6d"},{"line_number":40,"context_line":"(cherry picked from commit d44e24efe28e825fbfd2c75a032bf2d10109a439)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bd2c9b2e_c6dc1f1b","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":67},"updated":"2022-02-09 15:20:23.000000000","message":"nit: 2aa1ed5810b67b9a8f18b2ec5e21004f93831168","commit_id":"547dd71db145a162a239b561d7cf9b36a556b842"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d095dc7a9554205b113e211f5d2ec084fba04667","unresolved":false,"context_lines":[{"line_number":34,"context_line":"as tainted by libvirt."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Change-Id: I8140c8fe592dd54fc09a9510723892806db49a56"},{"line_number":37,"context_line":"(cherry picked from commit 6a75053344a91f0dd9b5da380f929319ca0e8d8e)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Change-Id: I7a6a6fe5f5b23e76948b59a85ca9be075a1c2d6d"},{"line_number":40,"context_line":"(cherry picked from commit d44e24efe28e825fbfd2c75a032bf2d10109a439)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c3d2cc9d_659a8c99","line":37,"range":{"start_line":37,"start_character":27,"end_line":37,"end_character":67},"in_reply_to":"bd2c9b2e_c6dc1f1b","updated":"2022-02-09 22:27:15.000000000","message":"Oops!","commit_id":"547dd71db145a162a239b561d7cf9b36a556b842"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9419bcd8ed12996b0e73a246e7c81190581ce50d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f07062f6_f8b631e8","updated":"2022-01-21 23:02:26.000000000","message":"This is a clean backport of a workaround for a widespread operational issue involving packet loss. It is disabled by default and the caveats around it are shown in the release note. Based on this, it looks appropriate to me for backport.","commit_id":"72a7d72e52e62f99202258f5bc261872ff558a2a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"df8167367cd8d6c37f1f3d2f02e373aad12d3324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c21e6dbf_d4dfc0a2","updated":"2022-01-28 19:12:13.000000000","message":"+1 for now until the master update change merges.","commit_id":"547dd71db145a162a239b561d7cf9b36a556b842"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"72c6140d1f6a2f211cdd7ea209d94616dfd21f4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f8ff292a_5cec6908","updated":"2022-02-09 15:20:23.000000000","message":"In general this looks good + valid for backport to me. (Thanks @melwitt for the details in your review comments!)\n\nThe only problem is that the squashed 2nd patch is not yet merged in (nor has it the noted commit hash anymore). Let\u0027s wait for that to merge and then please update the hash here in the commit message and this will be good to go.","commit_id":"547dd71db145a162a239b561d7cf9b36a556b842"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f46ce1058de94c5e01e18f5914047beabc2d7d90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef5a2146_9daae8d3","updated":"2022-02-14 17:21:40.000000000","message":"OK the squash looks good.","commit_id":"a8981422afdd09f8cfea053e592c15e771fbe969"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"3db11cd57d7fbddabfb5f3208fc2c3fed1fdf145","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"754a5087_1a93cc6a","updated":"2022-02-10 09:18:23.000000000","message":"The follow-up patch has merged on master. Thanks for the update! LGTM.","commit_id":"a8981422afdd09f8cfea053e592c15e771fbe969"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"4130154f83d1dc68f4b2f6264a099c14a97457e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4610f024_84fe5c1f","updated":"2022-02-15 08:39:07.000000000","message":"recheck","commit_id":"a8981422afdd09f8cfea053e592c15e771fbe969"}],"nova/conf/workarounds.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9419bcd8ed12996b0e73a246e7c81190581ce50d","unresolved":true,"context_lines":[{"line_number":365,"context_line":"If it is set to True the libvirt driver will  try as a best effort to send"},{"line_number":366,"context_line":"the announce-self command to the QEMU monitor so that it generates RARP frames"},{"line_number":367,"context_line":"to update network switches in the post live migration phase on the destination."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"Related options:"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* :oslo.config:option:`DEFAULT.compute_driver` (libvirt)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d695020_6415e144","line":368,"updated":"2022-01-21 23:02:26.000000000","message":"I wish the note from the release note had also been included here in the config option help:\n\n \"Please note that this causes the domain to be considered tainted by libvirt.\"\n\nhttps://review.opendev.org/c/openstack/nova/+/825064/1/releasenotes/notes/announce-self-post-live-migration-936721b1ab887514.yaml#7","commit_id":"72a7d72e52e62f99202258f5bc261872ff558a2a"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6b44d55db8f625beb902cd66c1c1cb7c414d760c","unresolved":false,"context_lines":[{"line_number":365,"context_line":"If it is set to True the libvirt driver will  try as a best effort to send"},{"line_number":366,"context_line":"the announce-self command to the QEMU monitor so that it generates RARP frames"},{"line_number":367,"context_line":"to update network switches in the post live migration phase on the destination."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"Related options:"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* :oslo.config:option:`DEFAULT.compute_driver` (libvirt)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c4384f43_465a44c1","line":368,"in_reply_to":"9d695020_6415e144","updated":"2022-01-28 08:44:09.000000000","message":"Done, also pushed update to master.","commit_id":"72a7d72e52e62f99202258f5bc261872ff558a2a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"df8167367cd8d6c37f1f3d2f02e373aad12d3324","unresolved":false,"context_lines":[{"line_number":365,"context_line":"If it is set to True the libvirt driver will  try as a best effort to send"},{"line_number":366,"context_line":"the announce-self command to the QEMU monitor so that it generates RARP frames"},{"line_number":367,"context_line":"to update network switches in the post live migration phase on the destination."},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"Related options:"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"* :oslo.config:option:`DEFAULT.compute_driver` (libvirt)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a72b4beb_974c1010","line":368,"in_reply_to":"c4384f43_465a44c1","updated":"2022-01-28 19:12:13.000000000","message":"Thanks for doing that. Technically we now need to document in the commit message that this backport is now a squash of the two patches together. I will make that update and then +2 after the config update patch lands on master.","commit_id":"72a7d72e52e62f99202258f5bc261872ff558a2a"}],"releasenotes/notes/announce-self-post-live-migration-936721b1ab887514.yaml":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9419bcd8ed12996b0e73a246e7c81190581ce50d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    that when enabled causes the Libvirt driver to send a announce_self QEMU"},{"line_number":6,"context_line":"    monitor command post live-migration. Please see `bug 1815989 \u003chttps://bugs.launchpad.net/nova/+bug/1815989\u003e`_"},{"line_number":7,"context_line":"    for more details. Please note that this causes the domain to be considered"},{"line_number":8,"context_line":"    tainted by libvirt."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f5a5162_ac2bd4f7","line":8,"updated":"2022-01-21 23:02:26.000000000","message":"Also wish this would have mentioned that you need \u003e\u003d QEMU 4.0 in order for this to work when enabled.","commit_id":"72a7d72e52e62f99202258f5bc261872ff558a2a"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"72c6140d1f6a2f211cdd7ea209d94616dfd21f4e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    that when enabled causes the Libvirt driver to send a announce_self QEMU"},{"line_number":6,"context_line":"    monitor command post live-migration. Please see `bug 1815989 \u003chttps://bugs.launchpad.net/nova/+bug/1815989\u003e`_"},{"line_number":7,"context_line":"    for more details. Please note that this causes the domain to be considered"},{"line_number":8,"context_line":"    tainted by libvirt."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9ee71f1b_17b99926","line":8,"in_reply_to":"3dca9fb0_b944c4e8","updated":"2022-02-09 15:20:23.000000000","message":"I\u0027ve looked at the MIN_QEMU_VERSION and we are good back until Ussuri. In Ussuri IN_QEMU_VERSION \u003d (2, 11, 0). Maybe we can backport this patch there as well (since the workaround is disabled by default), but need some extra warning there at least.","commit_id":"72a7d72e52e62f99202258f5bc261872ff558a2a"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"6b44d55db8f625beb902cd66c1c1cb7c414d760c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    that when enabled causes the Libvirt driver to send a announce_self QEMU"},{"line_number":6,"context_line":"    monitor command post live-migration. Please see `bug 1815989 \u003chttps://bugs.launchpad.net/nova/+bug/1815989\u003e`_"},{"line_number":7,"context_line":"    for more details. Please note that this causes the domain to be considered"},{"line_number":8,"context_line":"    tainted by libvirt."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eaef93d4_de8b3398","line":8,"in_reply_to":"3f5a5162_ac2bd4f7","updated":"2022-01-28 08:44:09.000000000","message":"This is not really needed since MIN_QEMU_VERSION is 4.2.0 on Xena, but maybe for the other backports this would make sense (it originally was in patch that went into master but was removed due to request.","commit_id":"72a7d72e52e62f99202258f5bc261872ff558a2a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"df8167367cd8d6c37f1f3d2f02e373aad12d3324","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    that when enabled causes the Libvirt driver to send a announce_self QEMU"},{"line_number":6,"context_line":"    monitor command post live-migration. Please see `bug 1815989 \u003chttps://bugs.launchpad.net/nova/+bug/1815989\u003e`_"},{"line_number":7,"context_line":"    for more details. Please note that this causes the domain to be considered"},{"line_number":8,"context_line":"    tainted by libvirt."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3dca9fb0_b944c4e8","line":8,"in_reply_to":"eaef93d4_de8b3398","updated":"2022-01-28 19:12:13.000000000","message":"Yeah, that\u0027s exactly what I was thinking about ... newer QEMU is often used with older nova versions. And my bad, I didn\u0027t realize someone had asked you to remove it originally /facepalm","commit_id":"72a7d72e52e62f99202258f5bc261872ff558a2a"}]}