)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34462,"name":"Imran Hussain","email":"ih@imranh.co.uk","username":"imranh2"},"change_message_id":"80b41e92d9919e790a1f14321077be67aa8c7c43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4dc510cf_01754671","updated":"2022-01-21 09:58:17.000000000","message":"Alternative to https://review.opendev.org/c/openstack/nova/+/825496","commit_id":"2fa505b8dd71dd5a44b8247ae28a8d6a8d5ea6d8"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"d2ad592ba7c185da024eb567e1642e85c72678f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"05f06e1d_279a713f","updated":"2022-01-25 15:57:11.000000000","message":"I think changes [1] could provide some context\n\nhttps://review.opendev.org/c/openstack/nova/+/775691\nhttps://review.opendev.org/c/openstack/nova/+/779302/\n","commit_id":"c8c020dfcf275c5b86b7f3b77904f3535d05ffc0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d3e386922567b4069adc31d6aa95393640294af5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"69c2e199_d909affa","updated":"2022-01-28 16:36:05.000000000","message":"This is probably the correct thing to do long-term, but ultimately it will probably require a spec since this is functionality that was added in more recent versions of libvirt than what we targeted when doing this work. We\u0027d need to either (a) raise the minimum libvirt version or (b) insert logic to change what we\u0027re generating depending on the underlying libvirt version until we can raise the minimum. -2 because there\u0027s obviously discussion and a lot more work needed here. [1] seems like a more viable option in the short term so I\u0027d focus efforts there.\n\n[1] https://review.opendev.org/c/openstack/nova/+/825496","commit_id":"c8c020dfcf275c5b86b7f3b77904f3535d05ffc0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"102fa7c1977802f431f22db913f6fd3e4a01a67b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4167e5d5_342514fc","updated":"2022-01-31 10:56:10.000000000","message":"[Comment on paperwork] Yeah, auto-selecting firmware, while correct in the long-term, needs at least a blueprint to indicate the direction of the feature.","commit_id":"c8c020dfcf275c5b86b7f3b77904f3535d05ffc0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3beb0db84d488b87b5d2eb177da02bc97a62519c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"34d1ff4a_677b8a0a","updated":"2022-01-28 19:35:06.000000000","message":"i agree with stephen let go with the other approch. if we want to do this in the future we need to do it on master only and not backport it.\n\nwe also need to ensure we will default to bios boot and if we want to change the default in the future only do so for new vms and only if the vm support uefi booting.\n\ni dont think we shoudl do that in the near term(1-2 cycles)","commit_id":"c8c020dfcf275c5b86b7f3b77904f3535d05ffc0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b3b7f59c4e55a69b2bb25d6854aeb7384b24192c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e065e1eb_a260107d","in_reply_to":"05610dbf_916b907c","updated":"2022-01-28 19:11:01.000000000","message":"It wouldn\u0027t because we purposefully avoided enabling the auto-configured when implementing that spec because it was missing important features [1]. Those features were added in a later release (I don\u0027t know what one - [1] would tell you). If we were to start using these features now, that would be a big enough change to warrant a new spec IMO\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d1929357","commit_id":"c8c020dfcf275c5b86b7f3b77904f3535d05ffc0"},{"author":{"_account_id":34462,"name":"Imran Hussain","email":"ih@imranh.co.uk","username":"imranh2"},"change_message_id":"e3087b68e05039be6d556478b9f1a86d147e9143","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"05610dbf_916b907c","in_reply_to":"69c2e199_d909affa","updated":"2022-01-28 17:53:47.000000000","message":"Hi Stephen, I\u0027m new to the Openstack project and don\u0027t quite know all the processes, but wouldn\u0027t this (https://specs.openstack.org/openstack/nova-specs/specs/train/approved/allow-secure-boot-for-qemu-kvm-guests.html) spec cover it?\n\nFrom what I understand so far the minimum versions are already aligned (libvirt 5.3 and Nova already requires 5.0 since Victoria, 6.0 in Wallaby) so this could be in the next release and only be backported to Wallaby.","commit_id":"c8c020dfcf275c5b86b7f3b77904f3535d05ffc0"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3beb0db84d488b87b5d2eb177da02bc97a62519c","unresolved":true,"context_lines":[{"line_number":2848,"context_line":"    def _format_os(self, root):"},{"line_number":2849,"context_line":"        os \u003d etree.Element(\"os\")"},{"line_number":2850,"context_line":""},{"line_number":2851,"context_line":"        if self.os_loader is not None:"},{"line_number":2852,"context_line":"            self.os_firmware \u003d \"efi\""},{"line_number":2853,"context_line":""},{"line_number":2854,"context_line":"        if self.os_firmware is not None:"},{"line_number":2855,"context_line":"            os.set(\"firmware\", self.os_firmware)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a115daab_dde56803","line":2852,"range":{"start_line":2851,"start_character":8,"end_line":2852,"end_character":36},"updated":"2022-01-28 19:35:06.000000000","message":"i have not traced this but if it would result in defaulting to efi that is not something we can do","commit_id":"c8c020dfcf275c5b86b7f3b77904f3535d05ffc0"},{"author":{"_account_id":34462,"name":"Imran Hussain","email":"ih@imranh.co.uk","username":"imranh2"},"change_message_id":"98009ae1141d2cf63a154d09aa600ff7372923a5","unresolved":true,"context_lines":[{"line_number":2848,"context_line":"    def _format_os(self, root):"},{"line_number":2849,"context_line":"        os \u003d etree.Element(\"os\")"},{"line_number":2850,"context_line":""},{"line_number":2851,"context_line":"        if self.os_loader is not None:"},{"line_number":2852,"context_line":"            self.os_firmware \u003d \"efi\""},{"line_number":2853,"context_line":""},{"line_number":2854,"context_line":"        if self.os_firmware is not None:"},{"line_number":2855,"context_line":"            os.set(\"firmware\", self.os_firmware)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c2b197d6_3ba0ca04","line":2852,"range":{"start_line":2851,"start_character":8,"end_line":2852,"end_character":36},"in_reply_to":"a115daab_dde56803","updated":"2022-01-28 20:09:26.000000000","message":"Tested this on my own system and BIOS i.e. image with hw_firmware_type *not* set booted just fine and wasn\u0027t uefi. Will double check that though....","commit_id":"c8c020dfcf275c5b86b7f3b77904f3535d05ffc0"}]}