)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4ba1dcc0401d5de6699ff5047c1e598f4173569b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0c94db3_a4792460","updated":"2022-01-24 15:29:01.000000000","message":"downgrading to +1 until dan responce regarding the wsgi module.","commit_id":"7885d1c4794525e6b9a99f2ee73a890c97951b79"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"beaeed10a448fbcfe846224f92e92e8f47d4bdb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84896c34_a339b612","updated":"2022-01-24 15:24:33.000000000","message":"im holding off on +w because when i was testing mixing version recently i tought i needed to remove this check in 2 place so i just want to double check that this is the only place its required.","commit_id":"7885d1c4794525e6b9a99f2ee73a890c97951b79"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9a5621a86d8212e99e54c59710b147db31784b38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"89e8fd2e_709369e3","updated":"2022-01-24 15:00:45.000000000","message":"simple enough","commit_id":"7885d1c4794525e6b9a99f2ee73a890c97951b79"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0f0129988adb4501c78f458475abd1a71e41e247","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"84d749e8_06c0ec67","updated":"2022-01-24 16:57:29.000000000","message":"dan adress the wsgi case and the grenade job that depends on this for ffu now works\nhttps://review.opendev.org/c/openstack/grenade/+/826101\nso +2+w","commit_id":"7d2e4815892ddd523c21bf1785cc113981871998"}],"nova/service.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4ba1dcc0401d5de6699ff5047c1e598f4173569b","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        # raise_if_old_compute() depends on the RPC to be up and does not"},{"line_number":263,"context_line":"        # implement its own retry mechanism to connect to the conductor."},{"line_number":264,"context_line":"        try:"},{"line_number":265,"context_line":"            utils.raise_if_old_compute()"},{"line_number":266,"context_line":"        except exception.TooOldComputeService as e:"},{"line_number":267,"context_line":"            if CONF.workarounds.disable_compute_service_check_for_ffu:"},{"line_number":268,"context_line":"                LOG.warning(str(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"a41ee10c_f1a8cb04","line":265,"range":{"start_line":265,"start_character":11,"end_line":265,"end_character":40},"updated":"2022-01-24 15:29:01.000000000","message":"this is also called in the wsgi app directly here \n\nhttps://github.com/openstack/nova/blob/909cfc76369b94b026cf42b86fb5a310dce21a8c/nova/api/openstack/wsgi_app.py#L50\n\nso you need to add the same try catch or the api will fail to start.\nalthoug that might be ok.\n\nwe need to conductor to be up so that the compute service can update there veriosn in the db.\n\nwe dont nessiarly need the api to be up untill the compute service are in a vaild state but i kind of feel like ti would be better to make this work for the conductor and the api.","commit_id":"7885d1c4794525e6b9a99f2ee73a890c97951b79"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"9af93fa74eb93e799930cc5a99d6293f6705c4f9","unresolved":true,"context_lines":[{"line_number":262,"context_line":"        # raise_if_old_compute() depends on the RPC to be up and does not"},{"line_number":263,"context_line":"        # implement its own retry mechanism to connect to the conductor."},{"line_number":264,"context_line":"        try:"},{"line_number":265,"context_line":"            utils.raise_if_old_compute()"},{"line_number":266,"context_line":"        except exception.TooOldComputeService as e:"},{"line_number":267,"context_line":"            if CONF.workarounds.disable_compute_service_check_for_ffu:"},{"line_number":268,"context_line":"                LOG.warning(str(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"e6d10dfa_287eb597","line":265,"range":{"start_line":265,"start_character":11,"end_line":265,"end_character":40},"in_reply_to":"a41ee10c_f1a8cb04","updated":"2022-01-24 15:33:54.000000000","message":"Yep, especially if some other API-using upgrade fix needed to happen.. like forcing down a compute you weren\u0027t going to upgrade or something.","commit_id":"7885d1c4794525e6b9a99f2ee73a890c97951b79"}],"nova/tests/unit/test_service.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"beaeed10a448fbcfe846224f92e92e8f47d4bdb2","unresolved":true,"context_lines":[{"line_number":297,"context_line":"            min_service_level\u003d2,"},{"line_number":298,"context_line":"            oldest_supported_service\u003d1)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        self.assertRaises(exception.TooOldComputeService,"},{"line_number":301,"context_line":"                          service.Service.create,"},{"line_number":302,"context_line":"                          self.host, \u0027nova-conductor\u0027, self.topic,"},{"line_number":303,"context_line":"                          \u0027nova.tests.unit.test_service.FakeManager\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d2702d5_0940a03a","line":300,"updated":"2022-01-24 15:24:33.000000000","message":"ack so initaly it will raise since the workaround is disabled.","commit_id":"7885d1c4794525e6b9a99f2ee73a890c97951b79"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"beaeed10a448fbcfe846224f92e92e8f47d4bdb2","unresolved":true,"context_lines":[{"line_number":305,"context_line":"        CONF.set_override(\u0027disable_compute_service_check_for_ffu\u0027, True,"},{"line_number":306,"context_line":"                          group\u003d\u0027workarounds\u0027)"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        service.Service.create(self.host, \u0027nova-conductor\u0027, self.topic,"},{"line_number":309,"context_line":"                               \u0027nova.tests.unit.test_service.FakeManager\u0027)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        mock_check_old.assert_has_calls([mock.call(), mock.call()])"}],"source_content_type":"text/x-python","patch_set":1,"id":"d3621291_9700ed53","line":308,"updated":"2022-01-24 15:24:33.000000000","message":"and then the same call does not raise when the workaround is enabled.","commit_id":"7885d1c4794525e6b9a99f2ee73a890c97951b79"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"beaeed10a448fbcfe846224f92e92e8f47d4bdb2","unresolved":true,"context_lines":[{"line_number":308,"context_line":"        service.Service.create(self.host, \u0027nova-conductor\u0027, self.topic,"},{"line_number":309,"context_line":"                               \u0027nova.tests.unit.test_service.FakeManager\u0027)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        mock_check_old.assert_has_calls([mock.call(), mock.call()])"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"class TestWSGIService(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"d9d546b6_afbef896","line":311,"updated":"2022-01-24 15:24:33.000000000","message":"you could also assert the warning happens i guess but i think this cover the main functional change\nwhich is that the service creation is no longer fatal.","commit_id":"7885d1c4794525e6b9a99f2ee73a890c97951b79"}]}