)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"e7f74b0167c847b0ccb945bdc513d5af61df90f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"afac6872_31b5dd5c","updated":"2022-02-11 18:55:47.000000000","message":"Right, this is just moving the default to the kwarg in the method definition, rather than the callers.","commit_id":"ee6e8c883da0922e513f31c2bab0d1198e28a358"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ea32294fd0ea4d91370fe13bdfb9150beb385110","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3a6d5dd2_c80ee380","updated":"2022-02-18 16:19:00.000000000","message":"Test failures are legit - looks like CONF.libvirt.images_type is still at the \u0027default\u0027 value when the code in imagebackend.py gets loaded, and the self.flags() declarations in the test classes only take effect after.","commit_id":"ee6e8c883da0922e513f31c2bab0d1198e28a358"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"00d4bcca63c72f7204b4a50de78596741db4374f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6d10d7d0_e559c43b","updated":"2022-02-21 18:19:42.000000000","message":"recheck","commit_id":"ba710e4268f274469ed7986c65bb779e1d7b1511"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3a96f206f5ae794abe423dccaa8c42d4611e90fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7d65ea85_99cb8709","updated":"2022-08-09 15:11:39.000000000","message":"Trivial change since PS4 that did exactly what Sean asked for. I\u0027ll assume they\u0027re happy with this and +W it.","commit_id":"184f0074cc5f4609642b52c98a7ccbfc5f892a33"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"68e2d31fdcda07e07ad958a91e5b28157bdfc586","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dc6f1bc4_fb0354fc","updated":"2022-08-18 03:30:09.000000000","message":"recheck","commit_id":"184f0074cc5f4609642b52c98a7ccbfc5f892a33"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"539947af9f67bf0b67690ed1032441e86c43f5d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"56d545af_078cc16d","updated":"2022-08-18 08:45:35.000000000","message":"recheck timeout","commit_id":"184f0074cc5f4609642b52c98a7ccbfc5f892a33"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"43fa7cf3e29c48337cb1b369bdb0310d0abc7fe8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a2f5949d_3bb22d1b","updated":"2022-08-09 15:14:28.000000000","message":"yep this looks good to me\n\nthanks both for updating it","commit_id":"184f0074cc5f4609642b52c98a7ccbfc5f892a33"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ea000803ce6944e1264f7972ccbc076cc257e63d","unresolved":true,"context_lines":[{"line_number":1314,"context_line":"        # NOTE(artom) To pass functional tests, wherein the code here is loaded"},{"line_number":1315,"context_line":"        # *before* any config with self.flags() is done, we need to have the"},{"line_number":1316,"context_line":"        # default inline in the method, and not in the kwarg declaration."},{"line_number":1317,"context_line":"        if image_type is None:"},{"line_number":1318,"context_line":"            image_type \u003d CONF.libvirt.images_type"},{"line_number":1319,"context_line":"        backend \u003d self.backend(image_type)"},{"line_number":1320,"context_line":"        return backend(instance\u003dinstance, disk_name\u003dname)"},{"line_number":1321,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8c2d3b54_4dc4301e","line":1318,"range":{"start_line":1317,"start_character":7,"end_line":1318,"end_character":49},"updated":"2022-07-12 08:02:46.000000000","message":"you can also write this as\n\nimage_type \u003d image_type or CONF.libvirt.images_type","commit_id":"7459a6c3b972fadb2b0b90be4d2f67902b0a24e3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d673d8a3bfd2d11c9b37293d1228fd9107474cb4","unresolved":false,"context_lines":[{"line_number":1314,"context_line":"        # NOTE(artom) To pass functional tests, wherein the code here is loaded"},{"line_number":1315,"context_line":"        # *before* any config with self.flags() is done, we need to have the"},{"line_number":1316,"context_line":"        # default inline in the method, and not in the kwarg declaration."},{"line_number":1317,"context_line":"        if image_type is None:"},{"line_number":1318,"context_line":"            image_type \u003d CONF.libvirt.images_type"},{"line_number":1319,"context_line":"        backend \u003d self.backend(image_type)"},{"line_number":1320,"context_line":"        return backend(instance\u003dinstance, disk_name\u003dname)"},{"line_number":1321,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e2401199_223028d6","line":1318,"range":{"start_line":1317,"start_character":7,"end_line":1318,"end_character":49},"in_reply_to":"8c2d3b54_4dc4301e","updated":"2022-07-20 02:15:08.000000000","message":"Done","commit_id":"7459a6c3b972fadb2b0b90be4d2f67902b0a24e3"}]}