)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f55cff1acb1d0436b3995b8408f898f0b80160e9","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-08-02 21:25:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"block_device: Add DriverImageBlockDevice to block_device_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I17e0758e3b77caebd4d142664a8367ab4601ebdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"9d9b2b2d_fa1a0b68","line":8,"updated":"2022-08-09 16:00:44.000000000","message":"I should have said this last time I reviewed it, but a little more context here would be helpful. FWICT, this is closing out a long-standing todo","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"456f41c8608340b5cef2292475de890358bbdecc","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-08-02 21:25:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"block_device: Add DriverImageBlockDevice to block_device_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I17e0758e3b77caebd4d142664a8367ab4601ebdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f7442f4_87d5b8ea","line":8,"in_reply_to":"312c002e_6032f6f3","updated":"2022-08-17 10:17:52.000000000","message":"i think its oke to rely on the gerrit topic for now.\ni have started the process of merging the start of the seriese once that is done you can add the implemtnes or related blueprint to the end of the seriese but i would leave it for now.","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7e70aa8d975e401fec2a02a735c362ac7af8e033","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-08-02 21:25:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"block_device: Add DriverImageBlockDevice to block_device_info"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I17e0758e3b77caebd4d142664a8367ab4601ebdf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"312c002e_6032f6f3","line":8,"in_reply_to":"9d9b2b2d_fa1a0b68","updated":"2022-08-16 09:01:13.000000000","message":"I think you are right, based on the note:: this patch is removing, the representation of \"image\" in the block_device_info was known to be missing and in order to add encryption for \"image\", it had to finally be properly represented in the data structure.\n\nI also noticed that I didn\u0027t go back and reference the blueprint on any of the stack /o\\ but I won\u0027t touch anything for now as I\u0027m sure keeping track of what\u0027s been reviewed has been challenging enough already.\n\nI can update commit messages if yall prefer, just want to get the go ahead before I wiping out all the votes.","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"dd38c52c4fb981c43f998792994410775209f47f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"16ab2bb7_51f21d53","updated":"2022-04-23 00:41:14.000000000","message":"recheck bug 1763181","commit_id":"b1a51f97df590b98a62b4798505126e8c75ec162"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f55cff1acb1d0436b3995b8408f898f0b80160e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cf2f7a0a_501e43bd","updated":"2022-08-09 16:00:44.000000000","message":"Would like more context on the commit message but won\u0027t block on that (or the nit from PS3)","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"456f41c8608340b5cef2292475de890358bbdecc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3881766a_9d977e6d","updated":"2022-08-17 10:17:52.000000000","message":"i have some nits but those can be adressed in a follow up so lets proceed with thsi version as is for now to reduce the outstanding patches to review.","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"18725980d8aead0a929d889ea96c0b4030b8cb1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"03ab0256_62d2e22b","updated":"2022-08-18 03:32:03.000000000","message":"recheck","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"ea8bbbd3fc10ee4fe13a7024c6f82244b45345b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"308c09f1_1350741f","updated":"2022-08-18 23:42:33.000000000","message":"recheck","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d64bd7c515321adb4a511f60cdbdf1e407897121","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6e98f441_8d2f0887","updated":"2022-08-19 04:11:22.000000000","message":"recheck nova-next timeout","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"a211b36e4220c3d9e020d83062a6d66035161312","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"931092d9_66e2cb52","updated":"2022-08-18 08:50:23.000000000","message":"recheck timeout","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"536476dd1de4acb6648585cc4adf545292eacd77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bb5aed50_a211d9ce","updated":"2022-08-19 11:49:48.000000000","message":"recheck unrelated failure","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d7e90611598fdcc2f540b8cb1f56111554bf58c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d3ba9c0a_c5c1e143","updated":"2022-08-18 10:59:09.000000000","message":"recheck unrelated live migration failure","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"}],"doc/source/reference/block-device-structs.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"05843986409c8fb7c3e489ef5bcd88bec9fc09dc","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"``root_device_name``"},{"line_number":73,"context_line":"    Hypervisor\u0027s notion of the root device\u0027s name"},{"line_number":74,"context_line":"``image``"},{"line_number":75,"context_line":"    An image backed disk if used"},{"line_number":76,"context_line":"``ephemerals``"},{"line_number":77,"context_line":"    A list of all ephemeral disks"}],"source_content_type":"text/x-rst","patch_set":8,"id":"326b01aa_f269326e","line":74,"range":{"start_line":74,"start_character":2,"end_line":74,"end_character":7},"updated":"2022-08-10 09:13:06.000000000","message":"since this will always be the root disk.\ni kind of feel like using root is better then image.","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9c4c4fe9d12dce4578c828260a347a332ca953e0","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"``root_device_name``"},{"line_number":73,"context_line":"    Hypervisor\u0027s notion of the root device\u0027s name"},{"line_number":74,"context_line":"``image``"},{"line_number":75,"context_line":"    An image backed disk if used"},{"line_number":76,"context_line":"``ephemerals``"},{"line_number":77,"context_line":"    A list of all ephemeral disks"}],"source_content_type":"text/x-rst","patch_set":8,"id":"ea1b57ad_d549ed95","line":74,"range":{"start_line":74,"start_character":2,"end_line":74,"end_character":7},"in_reply_to":"1f1b1d83_f8c5b880","updated":"2022-08-16 10:24:49.000000000","message":"ok that works for me i guess to keep things consistent.\n\naltough apart form lee im not sure how many peopel actully know this code well enough to have that context :)","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7e70aa8d975e401fec2a02a735c362ac7af8e033","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"``root_device_name``"},{"line_number":73,"context_line":"    Hypervisor\u0027s notion of the root device\u0027s name"},{"line_number":74,"context_line":"``image``"},{"line_number":75,"context_line":"    An image backed disk if used"},{"line_number":76,"context_line":"``ephemerals``"},{"line_number":77,"context_line":"    A list of all ephemeral disks"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1f1b1d83_f8c5b880","line":74,"range":{"start_line":74,"start_character":2,"end_line":74,"end_character":7},"in_reply_to":"326b01aa_f269326e","updated":"2022-08-16 09:01:13.000000000","message":"I see your point but I\u0027m wary of changing this given that it appears long established that this was going to be called \"image\" and DriverImageBlockDevice (i.e. the note:: that\u0027s being removed in this file).\n\nI\u0027ll add \"root\" in the description for this key.","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"456f41c8608340b5cef2292475de890358bbdecc","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"``root_device_name``"},{"line_number":73,"context_line":"    Hypervisor\u0027s notion of the root device\u0027s name"},{"line_number":74,"context_line":"``image``"},{"line_number":75,"context_line":"    An image backed disk if used"},{"line_number":76,"context_line":"``ephemerals``"},{"line_number":77,"context_line":"    A list of all ephemeral disks"}],"source_content_type":"text/x-rst","patch_set":8,"id":"8aa526f6_291d0e12","line":74,"range":{"start_line":74,"start_character":2,"end_line":74,"end_character":7},"in_reply_to":"ea1b57ad_d549ed95","updated":"2022-08-17 10:17:52.000000000","message":"lets address this in a followup later in the series","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"05843986409c8fb7c3e489ef5bcd88bec9fc09dc","unresolved":true,"context_lines":[{"line_number":74,"context_line":"``image``"},{"line_number":75,"context_line":"    An image backed disk if used"},{"line_number":76,"context_line":"``ephemerals``"},{"line_number":77,"context_line":"    A list of all ephemeral disks"},{"line_number":78,"context_line":"``block_device_mapping``"},{"line_number":79,"context_line":"    A list of all cinder volumes"},{"line_number":80,"context_line":"``swap``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3aeaa56a_fde3a9b1","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":33},"updated":"2022-08-10 09:13:06.000000000","message":"this explictly nerver contains the root disk as its not considered ephmeral as it does not come form the flavor.ephmereal_gb\n\ni dont know if we want to note that.","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7e70aa8d975e401fec2a02a735c362ac7af8e033","unresolved":true,"context_lines":[{"line_number":74,"context_line":"``image``"},{"line_number":75,"context_line":"    An image backed disk if used"},{"line_number":76,"context_line":"``ephemerals``"},{"line_number":77,"context_line":"    A list of all ephemeral disks"},{"line_number":78,"context_line":"``block_device_mapping``"},{"line_number":79,"context_line":"    A list of all cinder volumes"},{"line_number":80,"context_line":"``swap``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3cf74a44_4a2b2ed5","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":33},"in_reply_to":"3aeaa56a_fde3a9b1","updated":"2022-08-16 09:01:13.000000000","message":"Sure, I think it could help.","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9c4c4fe9d12dce4578c828260a347a332ca953e0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"``image``"},{"line_number":75,"context_line":"    An image backed disk if used"},{"line_number":76,"context_line":"``ephemerals``"},{"line_number":77,"context_line":"    A list of all ephemeral disks"},{"line_number":78,"context_line":"``block_device_mapping``"},{"line_number":79,"context_line":"    A list of all cinder volumes"},{"line_number":80,"context_line":"``swap``"}],"source_content_type":"text/x-rst","patch_set":8,"id":"cae71288_5c005290","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":33},"in_reply_to":"3cf74a44_4a2b2ed5","updated":"2022-08-16 10:24:49.000000000","message":"Ack","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"}],"nova/tests/unit/virt/libvirt/test_blockinfo.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"05843986409c8fb7c3e489ef5bcd88bec9fc09dc","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _test_block_device_info(self, with_eph\u003dTrue, with_swap\u003dTrue,"},{"line_number":75,"context_line":"                                with_bdms\u003dTrue):"},{"line_number":76,"context_line":"        swap \u003d {\u0027device_name\u0027: \u0027/dev/vdb\u0027, \u0027swap_size\u0027: 1}"},{"line_number":77,"context_line":"        image \u003d [{\u0027device_type\u0027: \u0027disk\u0027, \u0027boot_index\u0027: 0}]"},{"line_number":78,"context_line":"        ephemerals \u003d [{\u0027device_type\u0027: \u0027disk\u0027, \u0027guest_format\u0027: \u0027ext4\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"98c86278_73a0f122","line":75,"updated":"2022-08-10 09:13:06.000000000","message":"ok so these changes are just adding the image value not that its part of the block device info +1","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7e70aa8d975e401fec2a02a735c362ac7af8e033","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        }"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _test_block_device_info(self, with_eph\u003dTrue, with_swap\u003dTrue,"},{"line_number":75,"context_line":"                                with_bdms\u003dTrue):"},{"line_number":76,"context_line":"        swap \u003d {\u0027device_name\u0027: \u0027/dev/vdb\u0027, \u0027swap_size\u0027: 1}"},{"line_number":77,"context_line":"        image \u003d [{\u0027device_type\u0027: \u0027disk\u0027, \u0027boot_index\u0027: 0}]"},{"line_number":78,"context_line":"        ephemerals \u003d [{\u0027device_type\u0027: \u0027disk\u0027, \u0027guest_format\u0027: \u0027ext4\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"2134b72a_7b93abbe","line":75,"in_reply_to":"98c86278_73a0f122","updated":"2022-08-16 09:01:13.000000000","message":"Ack","commit_id":"5df97016b4c00d5a2699d56d184f237225d01b96"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9b1d5f54b1a47d001ca0635f64348f6db0d0f898","unresolved":true,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    pre_assigned_device_names \u003d ["},{"line_number":572,"context_line":"        block_device.strip_dev(get_device_name(bdm))"},{"line_number":573,"context_line":"            for bdm in driver_bdms if get_device_name(bdm)"},{"line_number":574,"context_line":"    ]"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    # Try to find the root driver bdm, either an image based disk or volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffdc40a6_b60972a6","line":573,"range":{"start_line":573,"start_character":8,"end_line":573,"end_character":12},"updated":"2022-02-21 18:39:58.000000000","message":"nit: drop","commit_id":"3f410ae7550e887474e099266e0806cc5dd78eef"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7e70aa8d975e401fec2a02a735c362ac7af8e033","unresolved":false,"context_lines":[{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    pre_assigned_device_names \u003d ["},{"line_number":572,"context_line":"        block_device.strip_dev(get_device_name(bdm))"},{"line_number":573,"context_line":"            for bdm in driver_bdms if get_device_name(bdm)"},{"line_number":574,"context_line":"    ]"},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"    # Try to find the root driver bdm, either an image based disk or volume"}],"source_content_type":"text/x-python","patch_set":3,"id":"dee47c55_9094bd28","line":573,"range":{"start_line":573,"start_character":8,"end_line":573,"end_character":12},"in_reply_to":"ffdc40a6_b60972a6","updated":"2022-08-16 09:01:13.000000000","message":"Done","commit_id":"3f410ae7550e887474e099266e0806cc5dd78eef"}]}