)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"521dd89a699b4ea6e29d6fbecccadcc744289f10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"514da82a_9d0f4d38","updated":"2022-02-21 18:41:17.000000000","message":"I\u0027d really like type hints here, but I won\u0027t block on that","commit_id":"aaada5660eadcd703c17efad230a15b9bae0ec42"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"22b9f94869cd3bbc4ab440f5da79ebb3ae265cac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b950751b_9a95428d","updated":"2022-04-05 06:20:12.000000000","message":"Unit tests failing all over the place","commit_id":"20db5800159aa53b6ab0c53f9d31a891f32e81f2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"98e0be3a2f6de861e2954f17ab99546cfcf3b028","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2b0970a8_8e950f12","updated":"2022-08-09 16:01:40.000000000","message":"Nice and easy","commit_id":"c18f8d41e4e9d3df75ffd9b7a042a3d12f3cfff9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c49f10374b9d218a382274699a05b135cd9bc3e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3e221a27_b8cb2b6d","updated":"2022-08-19 11:52:46.000000000","message":"Tiny nit. A follow-up would be okay with me","commit_id":"6d9e8739d4a5a0e12f99f7c793f2fc6e84b5c43e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"099407a8451903ba7b885feece41f325e395ca1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6527b966_8f5ad607","updated":"2022-08-26 12:19:50.000000000","message":"pretty simple change","commit_id":"6d9e8739d4a5a0e12f99f7c793f2fc6e84b5c43e"}],"nova/tests/unit/virt/test_virt.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8959191a480c0b07904966310477ba0de1b4c39c","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    def test_block_device_info_get_encrypted_disks(self):"},{"line_number":106,"context_line":"        block_device_info \u003d {"},{"line_number":107,"context_line":"            \u0027swap\u0027: {\u0027device_name\u0027: \u0027/dev/sdb\u0027, \u0027swap_size\u0027: 1},"},{"line_number":108,"context_line":"            \u0027image\u0027: ["},{"line_number":109,"context_line":"                {\u0027device_name\u0027: \u0027/dev/vda\u0027, \u0027encrypted\u0027: False},"},{"line_number":110,"context_line":"                {\u0027device_name\u0027: \u0027/dev/vdb\u0027, \u0027encrypted\u0027: True},"},{"line_number":111,"context_line":"            ],"},{"line_number":112,"context_line":"            \u0027ephemerals\u0027: ["},{"line_number":113,"context_line":"                {\u0027device_name\u0027: \u0027/dev/vdc\u0027, \u0027encrypted\u0027: True},"},{"line_number":114,"context_line":"                {\u0027device_name\u0027: \u0027/dev/vdd\u0027, \u0027encrypted\u0027: False},"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a45730d_aea8cf3c","line":111,"range":{"start_line":108,"start_character":12,"end_line":111,"end_character":14},"updated":"2022-08-10 09:17:47.000000000","message":"how can this ever have multipel entries.\n\nthis is only the root disk.","commit_id":"c18f8d41e4e9d3df75ffd9b7a042a3d12f3cfff9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8e8a55e893f077474a0974989827fff6088af4dc","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def test_block_device_info_get_encrypted_disks(self):"},{"line_number":106,"context_line":"        block_device_info \u003d {"},{"line_number":107,"context_line":"            \u0027swap\u0027: {\u0027device_name\u0027: \u0027/dev/sdb\u0027, \u0027swap_size\u0027: 1},"},{"line_number":108,"context_line":"            \u0027image\u0027: ["},{"line_number":109,"context_line":"                {\u0027device_name\u0027: \u0027/dev/vda\u0027, \u0027encrypted\u0027: False},"},{"line_number":110,"context_line":"                {\u0027device_name\u0027: \u0027/dev/vdb\u0027, \u0027encrypted\u0027: True},"},{"line_number":111,"context_line":"            ],"},{"line_number":112,"context_line":"            \u0027ephemerals\u0027: ["},{"line_number":113,"context_line":"                {\u0027device_name\u0027: \u0027/dev/vdc\u0027, \u0027encrypted\u0027: True},"},{"line_number":114,"context_line":"                {\u0027device_name\u0027: \u0027/dev/vdd\u0027, \u0027encrypted\u0027: False},"}],"source_content_type":"text/x-python","patch_set":8,"id":"3bc37a93_acad20ec","line":111,"range":{"start_line":108,"start_character":12,"end_line":111,"end_character":14},"in_reply_to":"7a45730d_aea8cf3c","updated":"2022-08-16 09:01:25.000000000","message":"My bad.","commit_id":"c18f8d41e4e9d3df75ffd9b7a042a3d12f3cfff9"}],"nova/virt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"521dd89a699b4ea6e29d6fbecccadcc744289f10","unresolved":true,"context_lines":[{"line_number":101,"context_line":"    return block_device_mapping"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def block_device_info_get_encrypted_disks(block_device_info):"},{"line_number":105,"context_line":"    return ["},{"line_number":106,"context_line":"        driver_bdm for driver_bdm in itertools.chain("},{"line_number":107,"context_line":"            block_device_info[\u0027image\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1c90e155_a7759386","line":104,"updated":"2022-02-21 18:41:17.000000000","message":"Type hints? Pretty please?","commit_id":"aaada5660eadcd703c17efad230a15b9bae0ec42"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e30243c2867c784a29f3fc3bd238a83d83fbd1ae","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    return block_device_mapping"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def block_device_info_get_encrypted_disks(block_device_info):"},{"line_number":105,"context_line":"    return ["},{"line_number":106,"context_line":"        driver_bdm for driver_bdm in itertools.chain("},{"line_number":107,"context_line":"            block_device_info[\u0027image\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"4e79623a_c0318698","line":104,"in_reply_to":"1c90e155_a7759386","updated":"2022-04-05 05:37:28.000000000","message":"Done","commit_id":"aaada5660eadcd703c17efad230a15b9bae0ec42"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"521dd89a699b4ea6e29d6fbecccadcc744289f10","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            block_device_info[\u0027image\u0027],"},{"line_number":108,"context_line":"            block_device_info[\u0027ephemerals\u0027]"},{"line_number":109,"context_line":"        )"},{"line_number":110,"context_line":"            if driver_bdm[\u0027encrypted\u0027]"},{"line_number":111,"context_line":"    ]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1e8dfd3e_c05d98e3","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":12},"updated":"2022-02-21 18:41:17.000000000","message":"nit: strike","commit_id":"aaada5660eadcd703c17efad230a15b9bae0ec42"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"e30243c2867c784a29f3fc3bd238a83d83fbd1ae","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            block_device_info[\u0027image\u0027],"},{"line_number":108,"context_line":"            block_device_info[\u0027ephemerals\u0027]"},{"line_number":109,"context_line":"        )"},{"line_number":110,"context_line":"            if driver_bdm[\u0027encrypted\u0027]"},{"line_number":111,"context_line":"    ]"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"44c7ccdc_dfadffff","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":12},"in_reply_to":"1e8dfd3e_c05d98e3","updated":"2022-04-05 05:37:28.000000000","message":"Done","commit_id":"aaada5660eadcd703c17efad230a15b9bae0ec42"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c49f10374b9d218a382274699a05b135cd9bc3e3","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def block_device_info_get_encrypted_disks("},{"line_number":108,"context_line":"    block_device_info: ty.Mapping[str, ty.Any],"},{"line_number":109,"context_line":") -\u003e ty.List[\u0027nova.virt.block_device.DriverBlockDevice\u0027]:"},{"line_number":110,"context_line":"    block_device_info \u003d block_device_info or {}"},{"line_number":111,"context_line":"    return ["}],"source_content_type":"text/x-python","patch_set":9,"id":"e2d8016c_af3fab09","line":108,"updated":"2022-08-19 11:52:46.000000000","message":"Either this type hint is wrong or there\u0027s be no need for the false\u0027y check below on L110. If the false\u0027y check is valid, then you want\n\n  block_device_info: ty.Optional[ty.Mapping[str, ty.Any]],\n\n...though I\u0027m not sure why nothing picked this up.","commit_id":"6d9e8739d4a5a0e12f99f7c793f2fc6e84b5c43e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"26df98c222e421e4fa5df120eba0cd598ec8cb52","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def block_device_info_get_encrypted_disks("},{"line_number":108,"context_line":"    block_device_info: ty.Mapping[str, ty.Any],"},{"line_number":109,"context_line":") -\u003e ty.List[\u0027nova.virt.block_device.DriverBlockDevice\u0027]:"},{"line_number":110,"context_line":"    block_device_info \u003d block_device_info or {}"},{"line_number":111,"context_line":"    return ["}],"source_content_type":"text/x-python","patch_set":9,"id":"f639d6c6_40525567","line":108,"in_reply_to":"7f4613fe_08c1ced8","updated":"2022-08-22 17:09:48.000000000","message":"Thanks!","commit_id":"6d9e8739d4a5a0e12f99f7c793f2fc6e84b5c43e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fe3cde5fa9cba57bfbcfa1182f7eb21e61881546","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"def block_device_info_get_encrypted_disks("},{"line_number":108,"context_line":"    block_device_info: ty.Mapping[str, ty.Any],"},{"line_number":109,"context_line":") -\u003e ty.List[\u0027nova.virt.block_device.DriverBlockDevice\u0027]:"},{"line_number":110,"context_line":"    block_device_info \u003d block_device_info or {}"},{"line_number":111,"context_line":"    return ["}],"source_content_type":"text/x-python","patch_set":9,"id":"7f4613fe_08c1ced8","line":108,"in_reply_to":"e2d8016c_af3fab09","updated":"2022-08-19 17:50:36.000000000","message":"Oh, I see. You\u0027re right it should be ty.Optional, I\u0027ve rolled it into the follow up patch at the top:\nhttps://review.opendev.org/c/openstack/nova/+/853254","commit_id":"6d9e8739d4a5a0e12f99f7c793f2fc6e84b5c43e"}]}