)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"fa0804a2375f559dd8d2b38ae96258aefd5c28ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d375c7fe_4f1da3c9","updated":"2022-06-10 18:09:25.000000000","message":"Failures are legit.","commit_id":"a3f1626d4784ca03f44882ad582fd8c9c50d45f9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2bfcf766eba10f9c18fb10199724837625a6ffef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4944425d_2bfa434a","updated":"2022-06-11 02:30:08.000000000","message":"Failures are still legit.","commit_id":"a353a51bd6f8caf0af69fc25aa2eb56a456ec5ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"06538dc39a1535c6c1b0f445c1cfafeab7da872d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0dbb117d_387c8279","updated":"2022-06-11 00:55:18.000000000","message":"actully no i changed my mind, looking at this later we are not callign these unprivladge funcitons in a privsep context are we? i saw you extending this to take a dict of random arge in a followup for encprtion which we relaly should nto be doign for privaldged calls so it the qemu image create does not need eleveated privaldage it sould not be in the privsep module\n\nin the evnet you need a privlage version you should not intoduce a generic function.\nit should be sepcific. with limted arges passed.","commit_id":"a353a51bd6f8caf0af69fc25aa2eb56a456ec5ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d333ed256ed56d7ff688a3b0361ee0f156528a89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b987e5b3_b36b62ea","updated":"2022-06-11 00:48:16.000000000","message":"im not sure why we are moving thses we do we really want to keep addign to the tech debt by moving more things unter the privsep module when we should be trayting to remove it entrily and distibuting the privaldeged function to the moudels where they are used.\n\nim not going to -1 since fixing our privsep issues is out of scope of what your are working on but over all this it not the direction the code should be moving long term.","commit_id":"a353a51bd6f8caf0af69fc25aa2eb56a456ec5ad"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bcd671bd8f51c46bfdcf0d333945685970d44d9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"728ecb55_e166361a","in_reply_to":"0dbb117d_387c8279","updated":"2022-06-11 02:26:51.000000000","message":"Yeah... not sure why the unprivileged method was moved under privsep. I guess to keep all the qemu commands together? What do you think should be done instead? Do you think I should drop this patch out of the stack?","commit_id":"a353a51bd6f8caf0af69fc25aa2eb56a456ec5ad"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"da8e46331c0965fc6e7373e3f29a8d8fedd87871","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b6c3da08_796bae41","in_reply_to":"728ecb55_e166361a","updated":"2022-06-13 10:48:39.000000000","message":"ya i would prefer to leave  them where they are.\n\nlongterm i would prefer to move the code in the other direction\nso drop all the privsep/qemu.py modules code an put the privaldged function in the libvirt/utils.py\n\nto do that we just need to slight tweek how our privesep context is defiend so allow it to be used from any submodule of nova.\n\nso since this does not need to be privladged i woudl prefer to keep it where it is so we doen need to move it later.","commit_id":"a353a51bd6f8caf0af69fc25aa2eb56a456ec5ad"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"af3feedd5a1dc3262f96b5355ee777701d571e63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"51ca5f44_f1fb73c5","in_reply_to":"b6c3da08_796bae41","updated":"2022-06-17 06:29:33.000000000","message":"OK, I have swapped in https://review.opendev.org/c/openstack/nova/+/846246 in place of this patch.","commit_id":"a353a51bd6f8caf0af69fc25aa2eb56a456ec5ad"}],"nova/privsep/qemu.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d07b99e199f569e08f080350eed76ca29810e852","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    :param path: Desired location of the disk image"},{"line_number":45,"context_line":"    :param disk_format: Disk image format (as known by qemu-img)"},{"line_number":46,"context_line":"    :param disk_size: Desired size of disk image. May be given as an int or"},{"line_number":47,"context_line":"                      a string. If given as an int, it will be interpreted"},{"line_number":48,"context_line":"                      as bytes. If it\u0027s a string, it should consist of a number"},{"line_number":49,"context_line":"                      with an optional suffix (\u0027K\u0027 for Kibibytes,"},{"line_number":50,"context_line":"                      M for Mebibytes, \u0027G\u0027 for Gibibytes, \u0027T\u0027 for Tebibytes)."}],"source_content_type":"text/x-python","patch_set":2,"id":"81df0741_fdece81f","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":22},"updated":"2022-02-21 18:47:07.000000000","message":"nit: I know this is copy-paste, but can we go with a simple 4 space indent?","commit_id":"0d3be43139787f542b003561a531e5ccfd84b1e0"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8aa050dee5279373cdde8e9434e310376fb18049","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        msg \u003d (_(\"Failed to run qemu-img info on %(path)s : %(error)s\") %"},{"line_number":172,"context_line":"               {\u0027path\u0027: path, \u0027error\u0027: err})"},{"line_number":173,"context_line":"        raise exception.InvalidDiskInfo(reason\u003dmsg)"},{"line_number":174,"context_line":"    return imageutils.QemuImgInfo(out, format\u003d\u0027json\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5ce847df_5b3abaa7","line":174,"updated":"2022-06-10 21:45:23.000000000","message":"Note: this change is needed because unprivileged_create_image() requires a QemuImgInfo object on L60.","commit_id":"9bc7d90e3ebbae43a83e5013da2ace387b716ae7"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2bfcf766eba10f9c18fb10199724837625a6ffef","unresolved":true,"context_lines":[{"line_number":4491,"context_line":"                                                 \u0027%dG\u0027 % ephemeral_size,"},{"line_number":4492,"context_line":"                                                 specified_fs)"},{"line_number":4493,"context_line":"                return"},{"line_number":4494,"context_line":"            nova.privsep.unprivileged_create_image("},{"line_number":4495,"context_line":"                target, \u0027raw\u0027, f\u0027{ephemeral_size}G\u0027)"},{"line_number":4496,"context_line":""},{"line_number":4497,"context_line":"        # Run as root only for block devices."}],"source_content_type":"text/x-python","patch_set":6,"id":"d1520646_b198b483","line":4494,"updated":"2022-06-11 02:30:08.000000000","message":"This should be nova.privsep.qemu.unprivileged_create_image 😑","commit_id":"a353a51bd6f8caf0af69fc25aa2eb56a456ec5ad"}]}