)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d63d4d5374e1c7f107ac966fcc29e45135eafe1a","unresolved":false,"context_lines":[{"line_number":823,"context_line":"        self.assertFalse(drvr.capabilities[\u0027supports_ephemeral_encryption\u0027],"},{"line_number":824,"context_line":"                         \"Driver capabilities for \u0027 \""},{"line_number":825,"context_line":"                         \"\u0027supports_ephemeral_encryption\u0027 \""},{"line_number":826,"context_line":"                         \"is invalid\")"},{"line_number":827,"context_line":"        self.assertFalse("},{"line_number":828,"context_line":"            drvr.capabilities[\u0027supports_ephemeral_encryption_luks\u0027],"},{"line_number":829,"context_line":"            \"Driver capabilities for \u0027supports_ephemeral_encryption_luks\u0027 \""}],"source_content_type":"text/x-python","patch_set":6,"id":"12de9c72_a868eb65","line":826,"updated":"2022-08-09 16:10:41.000000000","message":"nit: it annoys me that the formatting here has gone back to the old, overly indented style 😅","commit_id":"d533b4ab4fee2bb840dc8fc1ac2399c32e8e71c1"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"5934e148d6b9273db3ef3953c973f9a39a1c247e","unresolved":true,"context_lines":[{"line_number":439,"context_line":"            \"supports_ephemeral_encryption\":"},{"line_number":440,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":441,"context_line":"            \"supports_ephemeral_encryption_luks\":"},{"line_number":442,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":443,"context_line":"        }"},{"line_number":444,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ca10d7df_ca749319","line":442,"updated":"2022-08-16 09:01:54.000000000","message":"Hm, wondering if \"supports_ephemeral_encryption_plain\" should be in here too? Referring to a NOTE in nova/virt/driver.py that says:\n\n # NOTE(aspiers): When adding new capabilities, ensure they are\n # mirrored in ComputeDriver.capabilities, and that the corresponding\n # values should always be standard traits in os_traits.  If something\n # isn\u0027t a standard trait, it doesn\u0027t need to be a compute node\n # capability trait; and if it needs to be a compute node capability\n # trait, it needs to be (made) standard, and must be prefixed with\n # \"COMPUTE_\".","commit_id":"0bed462c709b532ef6448357262c390c481b1290"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aed9ee4d21925edd7bdde7b8b9f85c636c694e61","unresolved":true,"context_lines":[{"line_number":439,"context_line":"            \"supports_ephemeral_encryption\":"},{"line_number":440,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":441,"context_line":"            \"supports_ephemeral_encryption_luks\":"},{"line_number":442,"context_line":"                self.image_backend.backend().SUPPORTS_LUKS,"},{"line_number":443,"context_line":"        }"},{"line_number":444,"context_line":"        super(LibvirtDriver, self).__init__(virtapi)"},{"line_number":445,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b79be846_f0671c83","line":442,"in_reply_to":"ca10d7df_ca749319","updated":"2023-01-13 21:57:43.000000000","message":"it does not hurt to list it and explicitly set it to false.\n\nthis code will only report traits that are True to placemnt\n\nwe set \"supports_migrate_to_same_host\": False, already so you could add it if you need to respin this.","commit_id":"0bed462c709b532ef6448357262c390c481b1290"}]}