)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"98c7fd3eebbe9edba6084240ea5f86d801a3e057","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0bcf704a_f55db67d","updated":"2023-03-18 01:41:52.000000000","message":"recheck openstack-tox-py38 openstack-tox-py310","commit_id":"5092d59c1eed7087736dad371742cf5d190d3f8b"}],"nova/tests/unit/virt/libvirt/test_imagebackend.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b0782ef8f66e379e0db98f8f412ee783d9dcb063","unresolved":true,"context_lines":[{"line_number":230,"context_line":"        self._test_libvirt_info_scsi_with_unit(disk_unit)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def test_libvirt_info_with_encryption(self):"},{"line_number":233,"context_line":"        self.flags("},{"line_number":234,"context_line":"            fixed_key\u003d\u002700000000000000000000000000000000\u0027"},{"line_number":235,"context_line":"                      \u002700000000000000000000000000000000\u0027,"},{"line_number":236,"context_line":"            group\u003d\u0027key_manager\u0027"},{"line_number":237,"context_line":"        )"},{"line_number":238,"context_line":"        disk_info \u003d {"},{"line_number":239,"context_line":"            \u0027bus\u0027: \u0027virtio\u0027,"},{"line_number":240,"context_line":"            \u0027dev\u0027: \u0027/dev/vda\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"46e83bc9_24ada4c1","line":237,"range":{"start_line":233,"start_character":7,"end_line":237,"end_character":9},"updated":"2022-08-10 09:42:19.000000000","message":"hum i tought we said we were not going to support fixed key even for tests.\n\nif i remember correctly we said we would require a real key manager.","commit_id":"699c31a916aa2bc8519c49dbaca64a819dad9b0d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b1dc7f3c2628c7655868886e365a017753da055d","unresolved":true,"context_lines":[{"line_number":230,"context_line":"        self._test_libvirt_info_scsi_with_unit(disk_unit)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def test_libvirt_info_with_encryption(self):"},{"line_number":233,"context_line":"        self.flags("},{"line_number":234,"context_line":"            fixed_key\u003d\u002700000000000000000000000000000000\u0027"},{"line_number":235,"context_line":"                      \u002700000000000000000000000000000000\u0027,"},{"line_number":236,"context_line":"            group\u003d\u0027key_manager\u0027"},{"line_number":237,"context_line":"        )"},{"line_number":238,"context_line":"        disk_info \u003d {"},{"line_number":239,"context_line":"            \u0027bus\u0027: \u0027virtio\u0027,"},{"line_number":240,"context_line":"            \u0027dev\u0027: \u0027/dev/vda\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a13ae4b9_dfed6f0a","line":237,"range":{"start_line":233,"start_character":7,"end_line":237,"end_character":9},"in_reply_to":"46e83bc9_24ada4c1","updated":"2022-08-16 09:03:07.000000000","message":"Hm, I dunno anything about that. I think I did this because the nova.keymgr.conf_key_mgr.ConfKeyManager is the default backend in the ConfFixture [1].\n\nWhich key manager do you think should be used? I have only been familiar with the barbican key manager so far and it requires the barbican service.\n\nLooking at the castellan code, I see they have a MockKeyManager [2]. Is that what you were thinking?\n\n[1] https://github.com/openstack/nova/blob/627af67f5e631e8e1b23aa1527517a6cd6abd462/nova/tests/fixtures/conf.py#L48\n[2] https://github.com/openstack/castellan/blob/73569c8ff07706c33bd8961a9ab03a94bcb47a63/castellan/tests/unit/key_manager/mock_key_manager.py","commit_id":"699c31a916aa2bc8519c49dbaca64a819dad9b0d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"edc17c38d72b0eec3889788708df942a465f2b9a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        self._test_libvirt_info_scsi_with_unit(disk_unit)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def test_libvirt_info_with_encryption(self):"},{"line_number":233,"context_line":"        self.flags("},{"line_number":234,"context_line":"            fixed_key\u003d\u002700000000000000000000000000000000\u0027"},{"line_number":235,"context_line":"                      \u002700000000000000000000000000000000\u0027,"},{"line_number":236,"context_line":"            group\u003d\u0027key_manager\u0027"},{"line_number":237,"context_line":"        )"},{"line_number":238,"context_line":"        disk_info \u003d {"},{"line_number":239,"context_line":"            \u0027bus\u0027: \u0027virtio\u0027,"},{"line_number":240,"context_line":"            \u0027dev\u0027: \u0027/dev/vda\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"a9d4e0bf_a3dad41a","line":237,"range":{"start_line":233,"start_character":7,"end_line":237,"end_character":9},"in_reply_to":"a13ae4b9_dfed6f0a","updated":"2023-02-07 09:35:43.000000000","message":"Done","commit_id":"699c31a916aa2bc8519c49dbaca64a819dad9b0d"}]}