)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"47c127d3e19c825240fbea7ffe87dde5155b0361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ee2bba7e_9950ac1f","updated":"2022-01-28 19:11:58.000000000","message":"FYI https://review.opendev.org/c/openstack/nova/+/825729 is trying to achieve the same thing, arguably in a nicer way. Might be worth a review","commit_id":"f078cbed46b7ca96f7111e26a6d2af50fe18cbe0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a366df571cead21acea4e23895f192eb4b3eb0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bfc37040_fd250c6a","updated":"2022-01-28 19:12:20.000000000","message":"S","commit_id":"f078cbed46b7ca96f7111e26a6d2af50fe18cbe0"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"3859ec004a61b57d6e1b725966cc5a65d362790c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82ff0eb7_6a6e2d0d","updated":"2022-01-31 09:37:07.000000000","message":"What is the motivation for this change?\n\nAs you may already know, libvirt will auto-enable SMM when requesting secure boot.  Secure boot is not really \"secure\" without SMM.\n\nAlso, libvirt ensures that SMM is not changed (on -\u003e off or off -\u003e on) on migration.","commit_id":"f078cbed46b7ca96f7111e26a6d2af50fe18cbe0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2575622da6e9360c16b451fcec8fbe1f57c5d42d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7b9c7dcd_e269d4bc","in_reply_to":"6a1cbfbf_6d5414b3","updated":"2022-01-28 19:29:58.000000000","message":"ack ill take a look","commit_id":"f078cbed46b7ca96f7111e26a6d2af50fe18cbe0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4212665a34b99ad454e019c6e045c34ed073592d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b227e406_f984a83d","in_reply_to":"82ff0eb7_6a6e2d0d","updated":"2022-01-31 12:12:34.000000000","message":"simple on ubuntu libvirt does not enable SMM mode when you request secure boot.\ni have abandonded my patch in favor of \nhttps://review.opendev.org/c/openstack/nova/+/825496\nso that nova can work around the delta in libvirt behavior.","commit_id":"f078cbed46b7ca96f7111e26a6d2af50fe18cbe0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a366df571cead21acea4e23895f192eb4b3eb0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6a1cbfbf_6d5414b3","in_reply_to":"ee2bba7e_9950ac1f","updated":"2022-01-28 19:12:20.000000000","message":"Sorry, https://review.opendev.org/c/openstack/nova/+/825496","commit_id":"f078cbed46b7ca96f7111e26a6d2af50fe18cbe0"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b24faca93342285c673fc1ae8faba434557d3c7a","unresolved":true,"context_lines":[{"line_number":2710,"context_line":"        super().__init__(\"smm\", **kwargs)"},{"line_number":2711,"context_line":"        # FIXME(sean-k-mooney): do this check properly, on is the default"},{"line_number":2712,"context_line":"        # so hardcode for now if this element is required."},{"line_number":2713,"context_line":"        self.state \u003d True"},{"line_number":2714,"context_line":""},{"line_number":2715,"context_line":"    def format_dom(self):"},{"line_number":2716,"context_line":"        root \u003d super(LibvirtConfigGuestFeatureSMM, self).format_dom()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d4b2bc60_1f7fd4ed","line":2713,"range":{"start_line":2713,"start_character":21,"end_line":2713,"end_character":25},"updated":"2022-01-28 19:19:51.000000000","message":"this should be true if the value is required or optional else false","commit_id":"f078cbed46b7ca96f7111e26a6d2af50fe18cbe0"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b24faca93342285c673fc1ae8faba434557d3c7a","unresolved":true,"context_lines":[{"line_number":5946,"context_line":""},{"line_number":5947,"context_line":"            smm \u003d (flavor.extra_specs.get(\u0027os:secure_boot\u0027) or"},{"line_number":5948,"context_line":"                   image_meta.properties.get(\u0027os_secure_boot\u0027))"},{"line_number":5949,"context_line":"            LOG.debug(f\u0027\\n\\n\\n\\n smm:{smm}\u0027)"},{"line_number":5950,"context_line":"            if smm is not None:"},{"line_number":5951,"context_line":"                guest.features.append("},{"line_number":5952,"context_line":"                    vconfig.LibvirtConfigGuestFeatureSMM(smm))"}],"source_content_type":"text/x-python","patch_set":1,"id":"a600d2c6_7763e311","line":5949,"range":{"start_line":5949,"start_character":11,"end_line":5949,"end_character":44},"updated":"2022-01-28 19:19:51.000000000","message":"so this i should remove.","commit_id":"f078cbed46b7ca96f7111e26a6d2af50fe18cbe0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d56f3ac1f0b8e04a229ab11a3ee321a4bff0715d","unresolved":true,"context_lines":[{"line_number":5948,"context_line":"                   image_meta.properties.get(\u0027os_secure_boot\u0027))"},{"line_number":5949,"context_line":"            LOG.debug(f\u0027\\n\\n\\n\\n smm:{smm}\u0027)"},{"line_number":5950,"context_line":"            if smm is not None:"},{"line_number":5951,"context_line":"                guest.features.append("},{"line_number":5952,"context_line":"                    vconfig.LibvirtConfigGuestFeatureSMM(smm))"},{"line_number":5953,"context_line":""},{"line_number":5954,"context_line":"    def _check_number_of_serial_console(self, num_ports):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8a07f79a_2edae185","line":5951,"updated":"2022-01-28 19:22:55.000000000","message":"actully we proably want to do the check here\nso if smm is optional or required we shoudl add teh elemet with state on\notherwise we shoudl not add the element and allow libvirts default.","commit_id":"f078cbed46b7ca96f7111e26a6d2af50fe18cbe0"}]}