)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e666cdac406de3c41ed530e94755c8c4340e5d6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c878a81e_2f16195a","updated":"2022-01-31 13:29:28.000000000","message":"I agree that this is a bugfix replacing a silent error with en explicit HTTP400 response. So no microversion bump is needed","commit_id":"9fe465427310f8215890d26bf169617653605e23"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"225a3ee838b1a75a7483eefd7500eb567fc89eed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d93d2b6f_8763131f","updated":"2022-01-31 13:38:56.000000000","message":"i agree with gibi regarding using a set but also since we will never have more then 32 port and likely far far less i dont think the O(n) vs O(1) delta here si significant since n is always \u003c32 and typicaly between 1 and 5.\n\ntl;dr +2+w this has come up downstream a number of time where customers make this mistake in heat or other higher level orchstrtors and its always a pain to debug. this will certenly help with that.","commit_id":"9fe465427310f8215890d26bf169617653605e23"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e666cdac406de3c41ed530e94755c8c4340e5d6c","unresolved":false,"context_lines":[{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        networks \u003d []"},{"line_number":411,"context_line":"        network_uuids \u003d []"},{"line_number":412,"context_line":"        port_uuids \u003d []"},{"line_number":413,"context_line":"        for network in requested_networks:"},{"line_number":414,"context_line":"            request \u003d objects.NetworkRequest()"},{"line_number":415,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7b439a_b840d7f7","line":412,"range":{"start_line":412,"start_character":21,"end_line":412,"end_character":23},"updated":"2022-01-31 13:29:28.000000000","message":"nit: this could be a set","commit_id":"9fe465427310f8215890d26bf169617653605e23"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"225a3ee838b1a75a7483eefd7500eb567fc89eed","unresolved":false,"context_lines":[{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        networks \u003d []"},{"line_number":411,"context_line":"        network_uuids \u003d []"},{"line_number":412,"context_line":"        port_uuids \u003d []"},{"line_number":413,"context_line":"        for network in requested_networks:"},{"line_number":414,"context_line":"            request \u003d objects.NetworkRequest()"},{"line_number":415,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"36feecff_56d5d4e8","line":412,"range":{"start_line":412,"start_character":21,"end_line":412,"end_character":23},"in_reply_to":"fa7b439a_b840d7f7","updated":"2022-01-31 13:38:56.000000000","message":"ya that would be the correct data stucture.\n\ngivne the number of port we support in a vm is semi bounded by the number of pcie device we can have to \u003c32 i think a liniar search is fine in this case but ya set is the correct thing to use.","commit_id":"9fe465427310f8215890d26bf169617653605e23"}]}