)]}'
{"id":"openstack%2Fnova~827126","triplet_id":"openstack%2Fnova~stable%2Ftrain~Ie90fb83662dd06e7188f042fc6340596f93c5ef9","project":"openstack/nova","branch":"stable/train","topic":"bug/1821088","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2023-09-01 17:00:21.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ie90fb83662dd06e7188f042fc6340596f93c5ef9","subject":"api: Reject duplicate port IDs in server create","status":"ABANDONED","created":"2022-01-31 15:15:40.000000000","updated":"2023-09-01 17:00:21.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d9f98cd37f4fd05ea628eb8df982fe3a71f05bd6","_number":827126,"virtual_id_number":827126,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2022-01-31 17:19:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-01-31 17:19:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-01-31 17:35:34.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"14a633689f4dbc98b8022c1dd043b5e099a881e7","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-01-31 15:15:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fbd96bc9c57f5e4296faab5d25ee6c1d98be87b3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-01-31 17:19:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/585820fbfe3e4b7880ace17a561b4367 : FAILURE in 17m 27s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/386efbcdcedf433ab25d484ae60388fb : SUCCESS in 43m 01s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b3076c3a184544a9be96901ba78e8e81 : SUCCESS in 23m 25s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/76695857ea3f442c88e97115ae2e0391 : SUCCESS in 16m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fd87011b9b8944f99e981dea27632910 : SUCCESS in 11m 21s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f4b522f9556442e5b09beeaa4334dec6 : SUCCESS in 13m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ea2dd05fbf8e447c9fba49e46174491c : SUCCESS in 13m 03s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/a60d2d6c485040ab9ac9f548d5e8ee3a : SUCCESS in 13m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/22783ad40334460c82ea5cfc2196fb45 : SUCCESS in 11m 12s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e2859b73bda34acca13dbed2d32085bf : SUCCESS in 21m 14s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/876c7a9764d444e9a25b4f5478732d2f : SUCCESS in 1h 15m 02s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/0464499daa574fa4ab47f998052437f1 : FAILURE in 1h 19m 25s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/ccda0d50dbec4c61887044a82ac30836 : FAILURE in 26m 33s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/4dfa919621e440c8a6196566e5babc16 : SUCCESS in 1h 36m 28s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/73a6059631654acf89646e17d2a01e4b : SUCCESS in 1h 06m 06s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/cfd0fbef5d2f4fffa0eaea0c0e9deb2f : FAILURE in 22m 10s\n- nova-next https://zuul.opendev.org/t/openstack/build/b932a579c7aa41f498a94e47de776c26 : POST_FAILURE in 16m 11s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/e3ab941048eb4d64afa550097d733f87 : SUCCESS in 26m 50s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/8b7e96e6cff24448b8a326db87fcc441 : SUCCESS in 19m 42s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/ea603101800a4e6c8b87b76906b24387 : FAILURE in 6m 18s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/a39835345a954153a047b01628b2f745 : FAILURE in 20m 23s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/6a7f976aea17494d8f53856fbb7f8d9c : FAILURE in 16m 59s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b50f07d9f88b419497bcdb47dac6d2fe : FAILURE in 18m 49s","accounts_in_message":[],"_revision_number":1},{"id":"e1c02c4ff7f55e7e1669a5dd531759c43d155fd3","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-01-31 17:35:34.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/26/827126/1/check/tempest-dsvm-full-bionic-py3/6473c12/ : SUCCESS in 1h 55m 03s","accounts_in_message":[],"_revision_number":1},{"id":"c445037437f35041f81f59b1ad16351040fd7dfb","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-02-02 12:24:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6e7a5c9a9e44e3a406b27b03eb2c2ce241797c78","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-02 13:55:13.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/633a767073b54d978f7b18fac82e7d84 : FAILURE in 17m 11s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/09a7762eec834cfc9e28900d48ee5679 : SUCCESS in 1h 02m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/2b7586f3e2ed412da7633bb998de9121 : SUCCESS in 17m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/769d5a4fa71d479c97b9f595bfc8370d : SUCCESS in 14m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/87bac96f3dd54513a0973fc331cf5f86 : SUCCESS in 12m 25s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e8fdc926a6b8476f91997b51af3bba3c : SUCCESS in 13m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4835b652f1a04bd3b27b9482e9a2c8f6 : SUCCESS in 13m 12s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/66e2723577a54c50aa35823a21504fb7 : SUCCESS in 14m 56s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/877bbef08926446aa29fe5fde30eb322 : SUCCESS in 11m 48s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1d665ce6ca1e49bf9fbb1ef8dc60fedd : SUCCESS in 20m 04s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/2b9604318b1d43aab9f4d0497bcee134 : SUCCESS in 1h 15m 36s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/d0ac367bb9594a51b5e7625a38b1369f : FAILURE in 1h 08m 02s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/743f27102d4b4f8ab19c7788f953513b : FAILURE in 27m 40s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/9e20ab91bf5e4bb1bfff4615eaac87d5 : SUCCESS in 1h 16m 04s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/f4bbf3e2dc0c46be9e210eb918168677 : SUCCESS in 1h 05m 39s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/c1012bee977045cdb1799dd03b4da453 : FAILURE in 14m 31s\n- nova-next https://zuul.opendev.org/t/openstack/build/9e59099d351a4071a10067b189d1d623 : POST_FAILURE in 13m 27s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/45bd9200c1fc4d3f8e4a129807957ca1 : SUCCESS in 18m 03s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/00f01ae36785498eb4e9cbdfca238690 : SUCCESS in 20m 04s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/4b0b632d98f14bb39d0b7334e6613998 : FAILURE in 7m 22s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/ded7a2581bd441429d9d2f21310e67a8 : FAILURE in 14m 23s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/a5d1d5bb4b0c4cf99658bbeb5efaf1b2 : FAILURE in 11m 44s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/99ddbee9a4f440d3901ed0f3e8b7409f : FAILURE in 11m 56s","accounts_in_message":[],"_revision_number":1},{"id":"1e80d01b25fba136745b2bc2c0dda5a8d990385f","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-02-02 15:39:40.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-bionic-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/26/827126/1/check/tempest-dsvm-full-bionic-py3/143042d/ : SUCCESS in 2h 38m 52s","accounts_in_message":[],"_revision_number":1},{"id":"d9f98cd37f4fd05ea628eb8df982fe3a71f05bd6","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 17:00:21.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3243420b0f8010d779a73ff6160eb50655f940d0","revisions":{"3243420b0f8010d779a73ff6160eb50655f940d0":{"kind":"REWORK","_number":1,"created":"2022-01-31 15:15:40.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/26/827126/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/26/827126/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/827126/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/827126/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/827126/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/26/827126/1"}}},"commit":{"parents":[{"commit":"8906552cfc2525a44251d4cf313ece61e57251eb","subject":"address open redirect with 3 forward slashes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8906552cfc2525a44251d4cf313ece61e57251eb"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2022-01-31 12:56:57.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2022-01-31 15:14:18.000000000","tz":0},"subject":"api: Reject duplicate port IDs in server create","message":"api: Reject duplicate port IDs in server create\n\nSpecifying a duplicate port ID is currently \"allowed\" but results in an\nintegrity error when nova attempts to create a duplicate\n\u0027VirtualInterface\u0027 entry. Start rejecting these requests by checking for\nduplicate IDs and rejecting offending requests. This is arguably an API\nchange because there isn\u0027t a HTTP 5xx error (server create is an async\noperation), however, users shouldn\u0027t have to opt in to non-broken\nbehavior and the underlying instance was never actually created\npreviously, meaning automation that relied on this \"feature\" was always\ngoing to fail in a later step. We\u0027re also silently failing to do what\nthe user asked (per flow chart at [1]).\n\n[1] https://docs.openstack.org/nova/latest/contributor/microversions.html#when-do-i-need-a-new-microversion\n\nConflicts:\n  nova/api/openstack/compute/servers.py\n  nova/tests/unit/api/openstack/compute/test_serversV21.py\n\nNOTE(stephenfin): Conflicts are due to change\nIfa9c5c468400261a5e1f66b72c575845173a4f8f (\"nova-net: Remove final\nreferences to nova-network\") and change\nIbd97a0be22e0a894f3b1fdea052ee6359753457c (\"nova-net: Remove unnecessary\n\u0027neutronv2\u0027 prefixes\"), neither of which are backportable.\n\nChange-Id: Ie90fb83662dd06e7188f042fc6340596f93c5ef9\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\nCloses-Bug: #1821088\n(cherry picked from commit 9fe465427310f8215890d26bf169617653605e23)\n(cherry picked from commit d4c92bc2314c6402c4e3464a5aa61a94293eaf91)\n(cherry picked from commit fcbe6eecd7358dfa22b2dca8eca2afaa11f882f3)\n(cherry picked from commit 3731d1f5afe28b1cb6d36e88c407b65d1653a6df)\n(cherry picked from commit 23e7e6011b9087e25ca14f0da42ebafb0bef653a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3243420b0f8010d779a73ff6160eb50655f940d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3243420b0f8010d779a73ff6160eb50655f940d0"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}