)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"238a257c94b73330b585716f1a41ec2f6e005ccc","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Previously, Nova would wait for network-vif-plugged external events"},{"line_number":10,"context_line":"from Neutron for any VIF whose backend causes plug-time events. This"},{"line_number":11,"context_line":"is incorrect in the case of VIFs that are not active. This patch adds"},{"line_number":12,"context_line":"an \"is active?\" check to this logic."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I99ac604293d0acaa873e24ef60d163e9bfda230a"},{"line_number":15,"context_line":"Closes-bug: 1951623"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5d17fe08_8f65a152","line":12,"updated":"2024-02-16 10:39:32.000000000","message":"i would genereralluy disagree with that statement by the way.\nthe admin state is not ment ot influance if the event is sent.\nan inactive vif should still be notified to nova.\n\nneutron is not doing that today so skipping them on our side is potitally valid and really the only thing we can do but neutorn may still have clean up to do on the host even if the port is in active so this is also likely a neutron bug.","commit_id":"837eab4c87add13c3ad623b772dc0b1ed73d63f8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9930a67702cfdf12b7fea2be28be773b14bb81e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"749dbaab_650702b3","updated":"2024-02-16 10:40:12.000000000","message":"ideally the fucntional test would be a repoducre test prior to this in our normal 2 patch style","commit_id":"837eab4c87add13c3ad623b772dc0b1ed73d63f8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"238a257c94b73330b585716f1a41ec2f6e005ccc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"73b6125a_695efac7","updated":"2024-02-16 10:39:32.000000000","message":"my orginal comment is still unadressed\n\nalso i would like to see a functional test where we boot a vm with ports that are set to admin state donw and then live migrate it.","commit_id":"837eab4c87add13c3ad623b772dc0b1ed73d63f8"}],"nova/network/model.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"feb43c4e8f55ca15a576327fde4e13589b374855","unresolved":true,"context_lines":[{"line_number":577,"context_line":"        \"\"\""},{"line_number":578,"context_line":"        return [(\u0027network-vif-plugged\u0027, vif[\u0027id\u0027])"},{"line_number":579,"context_line":"                for vif in self if (vif.has_live_migration_plug_time_event and"},{"line_number":580,"context_line":"                                    vif.get(\u0027active\u0027, True) is True)]"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"    def get_plug_time_events(self, migration):"},{"line_number":583,"context_line":"        \"\"\"Returns a list of external events for any VIFs that have"}],"source_content_type":"text/x-python","patch_set":1,"id":"3788777a_152a74bd","line":580,"range":{"start_line":580,"start_character":60,"end_line":580,"end_character":62},"updated":"2022-02-01 17:43:04.000000000","message":"in this case it might be safer to use an equality check(\u003d\u003d).\nor better just remove the is True and let the and operator take care of it","commit_id":"6052c7d1057edf72e53e614baca5d8826649813b"}]}