)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18535b3f0a9610761ab34caa41d0c309f95d1932","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25ec03a0_9d13a08f","updated":"2022-02-02 19:48:36.000000000","message":"+1 but i think there are other things that should be adress which i have noted in my review of the architcture and cells docs.","commit_id":"b9c9bf4a49fda1f718a5d893042bdb273faa3d90"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a97700c473de47494456792e27022ca977561296","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"783fcdb6_e03ec07d","updated":"2022-02-03 18:53:43.000000000","message":"This LGTM, thanks!","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3ec258542e81843929a96f00826dd2139af81b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f02b8c24_c1459c37","updated":"2022-02-03 15:49:03.000000000","message":"im ok with this over all it woudl be good if gibi and melanie can review to confirm nothing has been missed from the previous patches.","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32ca3868187baf7c66d31cd5abfdaffce4ac7374","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3b46b8a_5927977c","updated":"2022-02-07 10:12:58.000000000","message":"just two nits. Nothing blocking","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"}],"doc/source/admin/architecture.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3ec258542e81843929a96f00826dd2139af81b","unresolved":true,"context_lines":[{"line_number":114,"context_line":"Projects are isolated resource containers that form the principal"},{"line_number":115,"context_line":"organizational structure within the Nova service. They typically consist of"},{"line_number":116,"context_line":"networks, volumes, instances, images, keys, and users. A user can"},{"line_number":117,"context_line":"specify the project by appending ``project_id`` to their access key."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"For projects, you can use quota controls to limit the number of processor cores"},{"line_number":120,"context_line":"and the amount of RAM that can be allocated. Other projects also allow quotas"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2fac7d07_39260595","line":117,"updated":"2022-02-03 15:49:03.000000000","message":"+1","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3ec258542e81843929a96f00826dd2139af81b","unresolved":true,"context_lines":[{"line_number":151,"context_line":"Nova provides the ability to create a root disk and an optional \"ephemeral\""},{"line_number":152,"context_line":"volume. The root disk will always be present unless the instance is a"},{"line_number":153,"context_line":":term:`Boot From Volume` instance."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"The root disk is associated with an instance, and exists only for the life of"},{"line_number":156,"context_line":"this very instance. Generally, it is used to store an instance\u0027s root file"},{"line_number":157,"context_line":"system, persists across the guest operating system reboots, and is removed on"}],"source_content_type":"text/x-rst","patch_set":3,"id":"edff7b0a_bf7b932e","line":154,"updated":"2022-02-03 15:49:03.000000000","message":"+1","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3ec258542e81843929a96f00826dd2139af81b","unresolved":true,"context_lines":[{"line_number":165,"context_line":"for different operating systems as ext4 for Linux distributions, VFAT for"},{"line_number":166,"context_line":"non-Linux and non-Windows operating systems, and NTFS for Windows. However, it"},{"line_number":167,"context_line":"is possible to configure other filesystem types."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":".. note::"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"   For example, the ``cloud-init`` package included into an Ubuntu\u0027s stock"}],"source_content_type":"text/x-rst","patch_set":3,"id":"eb6398df_30ce1b7e","line":168,"updated":"2022-02-03 15:49:03.000000000","message":"i assume we dont want to call attention to the fact tha tyou can actully have it be multipel disks instead of one. its not really an architectural detail. so it feels too low level to include here. arguably the partioning/filesystem detail are also too low level but im fine with leaving them","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3ec258542e81843929a96f00826dd2139af81b","unresolved":true,"context_lines":[{"line_number":178,"context_line":"The OpenStack Block Storage service, Cinder, provides persistent volumes hat"},{"line_number":179,"context_line":"are represented by a persistent virtualized block device independent of any"},{"line_number":180,"context_line":"particular instance."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Persistent volumes can be accessed by a single instance or attached to multiple"},{"line_number":183,"context_line":"instances. This type of configuration requires a traditional network file"},{"line_number":184,"context_line":"system to allow multiple instances accessing the persistent volume. It also"}],"source_content_type":"text/x-rst","patch_set":3,"id":"27407c41_feeee7b7","line":181,"updated":"2022-02-03 15:49:03.000000000","message":"+1","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"}],"doc/source/admin/availability-zones.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3ec258542e81843929a96f00826dd2139af81b","unresolved":true,"context_lines":[{"line_number":25,"context_line":"consequently allows users to schedule instances to a specific set of hosts, the"},{"line_number":26,"context_line":"ones belonging to the aggregate. There are a few additional differences to note"},{"line_number":27,"context_line":"when comparing availability zones and host aggregates:"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- A host can be part of multiple aggregates but it can only be in one"},{"line_number":30,"context_line":"  availability zone."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"7fd63d42_9315e301","line":28,"updated":"2022-02-03 15:49:03.000000000","message":"+1","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"}],"doc/source/admin/cells.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18535b3f0a9610761ab34caa41d0c309f95d1932","unresolved":true,"context_lines":[{"line_number":74,"context_line":"there will be a cell database (where the bulk of the instance information"},{"line_number":75,"context_line":"lives) for each cell, each containing a portion of the instances for the entire"},{"line_number":76,"context_line":"deployment within, as well as per-cell message queues and per-cell"},{"line_number":77,"context_line":":program:`nova-conductor` instances. There will also be an additional"},{"line_number":78,"context_line":":program:`nova-conductor` instance, known as a *super conductor*, to handle"},{"line_number":79,"context_line":"API-level operations."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"a7192e2b_b8b9821c","line":77,"updated":"2022-02-02 19:48:36.000000000","message":"and per cell metadata apis","commit_id":"b9c9bf4a49fda1f718a5d893042bdb273faa3d90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3ec258542e81843929a96f00826dd2139af81b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"there will be a cell database (where the bulk of the instance information"},{"line_number":75,"context_line":"lives) for each cell, each containing a portion of the instances for the entire"},{"line_number":76,"context_line":"deployment within, as well as per-cell message queues and per-cell"},{"line_number":77,"context_line":":program:`nova-conductor` instances. There will also be an additional"},{"line_number":78,"context_line":":program:`nova-conductor` instance, known as a *super conductor*, to handle"},{"line_number":79,"context_line":"API-level operations."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"3e20f973_8d3b3834","line":77,"in_reply_to":"a7192e2b_b8b9821c","updated":"2022-02-03 15:49:03.000000000","message":"this is really a nit by th eway you dont need to add the metadata api to this list since its optional and only need if you have networks that dont spance cells and the central metadta api is not accessable for some reason in a remote cell","commit_id":"b9c9bf4a49fda1f718a5d893042bdb273faa3d90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3ec258542e81843929a96f00826dd2139af81b","unresolved":true,"context_lines":[{"line_number":298,"context_line":"- ``pci_devices``"},{"line_number":299,"context_line":"- ``block_device_mapping``"},{"line_number":300,"context_line":"- ``virtual_interfaces``"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"Usage"},{"line_number":304,"context_line":"-----"}],"source_content_type":"text/x-rst","patch_set":3,"id":"2f066720_178546eb","side":"PARENT","line":301,"updated":"2022-02-03 15:49:03.000000000","message":"+1 droping the tables makes sense to me that is an implemation level detail that dose not add much value to this dock.","commit_id":"ef4d759e87d11e6d53c22cf57a3b9296fa00c642"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32ca3868187baf7c66d31cd5abfdaffce4ac7374","unresolved":true,"context_lines":[{"line_number":29,"context_line":"The purpose of the cells functionality in nova is to allow larger deployments"},{"line_number":30,"context_line":"to shard their many compute nodes into cells. All nova deployments are by"},{"line_number":31,"context_line":"definition cells deployments, even if most will only ever have a single cell."},{"line_number":32,"context_line":"This means a multi-cell deployment will not b radically different from a"},{"line_number":33,"context_line":"\"standard\" nova deployment."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Consider such a deployment. It will consists of the following components:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"5893c19f_a39b409e","line":32,"range":{"start_line":32,"start_character":44,"end_line":32,"end_character":45},"updated":"2022-02-07 10:12:58.000000000","message":"nit: be","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"}],"doc/source/reference/glossary.rst":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"18535b3f0a9610761ab34caa41d0c309f95d1932","unresolved":true,"context_lines":[{"line_number":28,"context_line":"        A cell mostly consists of a database, queue, and set of compute nodes."},{"line_number":29,"context_line":"        All deployments willl have at least one cell (and one \"fake\" cell)."},{"line_number":30,"context_line":"        Larger deployments can have many."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        For more information, refer to :doc:`/admin/cells`."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Cross-Cell Resize"}],"source_content_type":"text/x-rst","patch_set":2,"id":"291236dd_ed6c773e","line":31,"updated":"2022-02-02 19:48:36.000000000","message":"a cell does not form a independently upgradeable partion of a cloud and is not intended to provde fault tolerance. a failure of the share commonets will affect all cells equally althogh a failure of a cell compent will generally not affect other cells.","commit_id":"b9c9bf4a49fda1f718a5d893042bdb273faa3d90"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2e3ec258542e81843929a96f00826dd2139af81b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        A cell mostly consists of a database, queue, and set of compute nodes."},{"line_number":29,"context_line":"        All deployments willl have at least one cell (and one \"fake\" cell)."},{"line_number":30,"context_line":"        Larger deployments can have many."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        For more information, refer to :doc:`/admin/cells`."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Cross-Cell Resize"}],"source_content_type":"text/x-rst","patch_set":2,"id":"a194db9e_7f4d95c7","line":31,"in_reply_to":"291236dd_ed6c773e","updated":"2022-02-03 15:49:03.000000000","message":"you have kind of adressed this else whwer for AZs we could still call it out here but its proably fine. the glossary does not neesisaly need to container it but it mmight be nice.","commit_id":"b9c9bf4a49fda1f718a5d893042bdb273faa3d90"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a97700c473de47494456792e27022ca977561296","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    Cell"},{"line_number":27,"context_line":"        A cell is a shard or horizontal partition in a nova deployment."},{"line_number":28,"context_line":"        A cell mostly consists of a database, queue, and set of compute nodes."},{"line_number":29,"context_line":"        All deployments willl have at least one cell (and one \"fake\" cell)."},{"line_number":30,"context_line":"        Larger deployments can have many."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        For more information, refer to :doc:`/admin/cells`."}],"source_content_type":"text/x-rst","patch_set":3,"id":"6b3d5d03_bae86fb8","line":29,"range":{"start_line":29,"start_character":69,"end_line":29,"end_character":73},"updated":"2022-02-03 18:53:43.000000000","message":"Tempting to want to add that the fake cell is called \"cell0\" here, just to be extra clear.","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"32ca3868187baf7c66d31cd5abfdaffce4ac7374","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    Cell"},{"line_number":27,"context_line":"        A cell is a shard or horizontal partition in a nova deployment."},{"line_number":28,"context_line":"        A cell mostly consists of a database, queue, and set of compute nodes."},{"line_number":29,"context_line":"        All deployments willl have at least one cell (and one \"fake\" cell)."},{"line_number":30,"context_line":"        Larger deployments can have many."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        For more information, refer to :doc:`/admin/cells`."}],"source_content_type":"text/x-rst","patch_set":3,"id":"bd3b0d48_1ca46426","line":29,"range":{"start_line":29,"start_character":24,"end_line":29,"end_character":29},"updated":"2022-02-07 10:12:58.000000000","message":"nit: will","commit_id":"136f1deb6ec312c1ddd6a1356e2e2dbf6290a2e4"}]}