)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95d32d6f401ed2137436e56e4c7245c594df527e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The addresses field containes delayed (cached) information,"},{"line_number":10,"context_line":"due to internal implementation details."},{"line_number":11,"context_line":"This used to be considered API contact breakage,"},{"line_number":12,"context_line":"but apperently no plan for fixing it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8db2800ede0276d60138369ec2d60c55a1791040"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"49cb57db_d72de1e1","line":12,"updated":"2024-04-29 17:21:55.000000000","message":"i would disagree with this.\nwe never had an api guarenee with regard to the liveness of the data.\n\nit was an implemeation detail but not part of the api contract.","commit_id":"39a0e47f98901f82f8dbdede2a478982e7dae0fe"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"cb6eb8fd21dc0e13c1b09c35ac176493cab99f1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c72628d_53815c20","updated":"2022-02-07 18:15:17.000000000","message":"I agree to reflect it in doc and once we fix it (if we do) then we can remove it.","commit_id":"39a0e47f98901f82f8dbdede2a478982e7dae0fe"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"083570cda09c2c67e9f1f4c4652a4dafd9c1c0fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"13ddfc07_3cc50739","updated":"2024-04-29 17:27:10.000000000","message":"if someone wants to fix the typo im fine with fast approving this again.","commit_id":"39a0e47f98901f82f8dbdede2a478982e7dae0fe"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"dd30cc4ab080006ee33ec22b9251fff2a7147e13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6cbd257c_83537936","updated":"2024-04-29 17:00:39.000000000","message":"recheck pep8 fail logs are gone\nalready +w lgtm","commit_id":"39a0e47f98901f82f8dbdede2a478982e7dae0fe"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c31315df998a55cea7457bfe306b706700aa7837","unresolved":true,"context_lines":[{"line_number":1556,"context_line":"  description: |"},{"line_number":1557,"context_line":"    The addresses for the server.  Servers with status ``BUILD`` hide their"},{"line_number":1558,"context_line":"    addresses information."},{"line_number":1559,"context_line":"    The floating ip address may show up only after a delay."},{"line_number":1560,"context_line":"  in: body"},{"line_number":1561,"context_line":"  required: true"},{"line_number":1562,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9eeae4ac_a99ad781","line":1559,"updated":"2022-02-04 14:35:07.000000000","message":"This is about https://review.opendev.org/c/openstack/tempest/+/811191, right? I\u0027m not sure that this is the best place to put it, as any use of the `addresses` parameter anywhere in the api-ref will start including this disclaimer, whereas the delay is specific to floating IP assocation, as it has to do with the Neutron -\u003e Nova external event interaction. And even then, the delay is only important for code, not for humans, as normally just the time it takes to type out `server show` on the CLI is enough.\n\nPerhaps include this in `Show Server Details` section? Or in the Neutron api-ref, in the `Update Floating IP` section?","commit_id":"0db7b1dc29a9377588436e784a6d939f5280d43b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95d32d6f401ed2137436e56e4c7245c594df527e","unresolved":true,"context_lines":[{"line_number":1556,"context_line":"  description: |"},{"line_number":1557,"context_line":"    The addresses for the server.  Servers with status ``BUILD`` hide their"},{"line_number":1558,"context_line":"    addresses information."},{"line_number":1559,"context_line":"    The floating ip address may show up only after a delay."},{"line_number":1560,"context_line":"  in: body"},{"line_number":1561,"context_line":"  required: true"},{"line_number":1562,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"aeb6b672_b39df91b","line":1559,"in_reply_to":"781213d4_2932eda1","updated":"2024-04-29 17:21:55.000000000","message":"nova deprecated all or proxy apis to other services many many years ago.\n\nthis was never guaranteed by our api contract to be up to date or not.\nit was considered an implementation detail as we never documented the behaviour,\n\nthis is not something we intent do revert back to the old behaviour.\n\nip adress info shouldbe retirved form neutron so i agree with the docs updated.","commit_id":"0db7b1dc29a9377588436e784a6d939f5280d43b"},{"author":{"_account_id":5803,"name":"Attila Fazekas","email":"afazekas@redhat.com","username":"afazekas"},"change_message_id":"7be1642034a11a28f2a844ce33295b7647feaca7","unresolved":true,"context_lines":[{"line_number":1556,"context_line":"  description: |"},{"line_number":1557,"context_line":"    The addresses for the server.  Servers with status ``BUILD`` hide their"},{"line_number":1558,"context_line":"    addresses information."},{"line_number":1559,"context_line":"    The floating ip address may show up only after a delay."},{"line_number":1560,"context_line":"  in: body"},{"line_number":1561,"context_line":"  required: true"},{"line_number":1562,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"781213d4_2932eda1","line":1559,"in_reply_to":"9eeae4ac_a99ad781","updated":"2022-02-07 07:19:59.000000000","message":"The address basically never guaranteed to be up-to-date in any OpenStack Compute (nova)api API call today, so it can be part of the address field description.\n\nThe accepted API contract used to be no-delay.\n\nAdding such wait was hard NO from the formal QA PTL and other cores, \nif I remember correctly he also had TC to agree with this.\n\nBTW, when people were asked, about would they expect delay there if they would be new to openstack and would not know about internals.\nNobody said yes.","commit_id":"0db7b1dc29a9377588436e784a6d939f5280d43b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"408f419074862f9dbe749066b33cd3ba702e36b2","unresolved":true,"context_lines":[{"line_number":1556,"context_line":"  description: |"},{"line_number":1557,"context_line":"    The addresses for the server.  Servers with status ``BUILD`` hide their"},{"line_number":1558,"context_line":"    addresses information."},{"line_number":1559,"context_line":"    This view is not updated immediatly."},{"line_number":1560,"context_line":"    Please consult with OpenStack Networking API for up-to-date information."},{"line_number":1561,"context_line":"  in: body"},{"line_number":1562,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"e7cd6f70_97222b39","line":1559,"range":{"start_line":1559,"start_character":29,"end_line":1559,"end_character":39},"updated":"2024-04-29 17:22:53.000000000","message":"ah this is a spelling misatke\n\napi-ref/source/parameters.yaml:1559: immediatly \u003d\u003d\u003e immediately\n0","commit_id":"39a0e47f98901f82f8dbdede2a478982e7dae0fe"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"47b9ed5c889792c222fb2161949f3fc535a08574","unresolved":false,"context_lines":[{"line_number":1556,"context_line":"  description: |"},{"line_number":1557,"context_line":"    The addresses for the server.  Servers with status ``BUILD`` hide their"},{"line_number":1558,"context_line":"    addresses information."},{"line_number":1559,"context_line":"    This view is not updated immediatly."},{"line_number":1560,"context_line":"    Please consult with OpenStack Networking API for up-to-date information."},{"line_number":1561,"context_line":"  in: body"},{"line_number":1562,"context_line":"  required: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1d8d1470_768cb66c","line":1559,"range":{"start_line":1559,"start_character":29,"end_line":1559,"end_character":39},"in_reply_to":"e7cd6f70_97222b39","updated":"2024-04-29 17:33:30.000000000","message":"Done","commit_id":"39a0e47f98901f82f8dbdede2a478982e7dae0fe"}]}
