)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"13ba2aad981662bd613fed7ca55e515d6c65fd41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6a93335a_a28f9e7a","updated":"2022-02-08 20:21:01.000000000","message":"Thanks.","commit_id":"c87230be68935e6fa7f5904ed84e452419faa780"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b7b1350c9cf2b781dd1f582993687ad1ddfdf01d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8fc2bb10_57c6d32b","updated":"2022-02-10 09:52:12.000000000","message":"Make sense","commit_id":"2787a90abfddbb7f627469c997a2985d831948e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b849f61c12b41d957e6a6e3a7bc84217cd53c47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2bb07720_58fa298f","updated":"2022-02-10 13:49:18.000000000","message":"holding +w for now so that you can respond to my comment inline but i agree this is an improvement\nin that it conveys this is best effort.","commit_id":"2787a90abfddbb7f627469c997a2985d831948e9"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"1a1cac885acbe9862e6ca1b404b884d24fb203f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf75c708_56018931","updated":"2022-02-23 14:30:20.000000000","message":"LGTM!","commit_id":"4993129cc743bdbd4ed13de97f56c395177d8347"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c45d2fed291e8e0011a65cbae8488bc14b269947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"25208800_b5818db0","updated":"2022-02-23 15:01:13.000000000","message":"Looks good!","commit_id":"4993129cc743bdbd4ed13de97f56c395177d8347"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"7f6a72e5371fb87b54b465f99b550d98923831af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cab877b3_d8be7578","updated":"2022-02-23 16:46:51.000000000","message":"LGTM!","commit_id":"de110b042d8e340d19a52b9fb7ef6f4c52bc0762"}],"doc/source/admin/configuring-migrations.rst":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b7b1350c9cf2b781dd1f582993687ad1ddfdf01d","unresolved":true,"context_lines":[{"line_number":266,"context_line":"   ``live_migration_downtime`` sets the period of time Nova will try to keep "},{"line_number":267,"context_line":"   the instance paused during the last part of the memory copy, in *milliseconds*."},{"line_number":268,"context_line":"   This value may be exceeded if there is any reduction on the transfer rate after"},{"line_number":269,"context_line":"   the VM is paused. The default is 500."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"   ``live_migration_downtime_steps`` sets the total number of adjustment steps"},{"line_number":272,"context_line":"   until ``live_migration_downtime`` is reached.  The default is 10 steps."}],"source_content_type":"text/x-rst","patch_set":3,"id":"8d50911d_70f1e986","line":269,"updated":"2022-02-10 09:52:12.000000000","message":"yepp as nova only estimates how much downtime is needed.","commit_id":"2787a90abfddbb7f627469c997a2985d831948e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1cf1fe405de023c9f10232aad112f47c5a9fc55e","unresolved":true,"context_lines":[{"line_number":266,"context_line":"   ``live_migration_downtime`` sets the period of time Nova will try to keep "},{"line_number":267,"context_line":"   the instance paused during the last part of the memory copy, in *milliseconds*."},{"line_number":268,"context_line":"   This value may be exceeded if there is any reduction on the transfer rate after"},{"line_number":269,"context_line":"   the VM is paused. The default is 500."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"   ``live_migration_downtime_steps`` sets the total number of adjustment steps"},{"line_number":272,"context_line":"   until ``live_migration_downtime`` is reached.  The default is 10 steps."}],"source_content_type":"text/x-rst","patch_set":3,"id":"42208150_3d768777","line":269,"in_reply_to":"19fc7508_2f1c31cb","updated":"2022-02-23 13:26:51.000000000","message":"well i suggested \"target\" to imply best effort my current reading was you were not implying the downtime was a minium downtime.\n\nspefcicially i read\n\n   ``live_migration_downtime`` sets the period of time Nova will try to keep \n   the instance paused during the last part of the memory copy, in *milliseconds*.\n\nas stating that nova will always pause the vm for live_migration_downtime milliseconds\n\ni feel like this has swong to much in the other direction.","commit_id":"2787a90abfddbb7f627469c997a2985d831948e9"},{"author":{"_account_id":33987,"name":"Pedro Monteiro Azevedo de Moura Almeida","display_name":"Pedro Almeida","email":"pedro.monteiroazevedodemouraalmeida@windriver.com","username":"pedroalmd"},"change_message_id":"87d60917020988312856d3c559a8876983f4c0f5","unresolved":false,"context_lines":[{"line_number":266,"context_line":"   ``live_migration_downtime`` sets the period of time Nova will try to keep "},{"line_number":267,"context_line":"   the instance paused during the last part of the memory copy, in *milliseconds*."},{"line_number":268,"context_line":"   This value may be exceeded if there is any reduction on the transfer rate after"},{"line_number":269,"context_line":"   the VM is paused. The default is 500."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"   ``live_migration_downtime_steps`` sets the total number of adjustment steps"},{"line_number":272,"context_line":"   until ``live_migration_downtime`` is reached.  The default is 10 steps."}],"source_content_type":"text/x-rst","patch_set":3,"id":"344658d3_ef1bd3b1","line":269,"in_reply_to":"42208150_3d768777","updated":"2022-02-23 14:28:28.000000000","message":"I see what your point is now, I agree, changed it. Thanks!","commit_id":"2787a90abfddbb7f627469c997a2985d831948e9"},{"author":{"_account_id":33987,"name":"Pedro Monteiro Azevedo de Moura Almeida","display_name":"Pedro Almeida","email":"pedro.monteiroazevedodemouraalmeida@windriver.com","username":"pedroalmd"},"change_message_id":"fd2890c4685af3adf71ad0900ba9d1495cddd71f","unresolved":true,"context_lines":[{"line_number":266,"context_line":"   ``live_migration_downtime`` sets the period of time Nova will try to keep "},{"line_number":267,"context_line":"   the instance paused during the last part of the memory copy, in *milliseconds*."},{"line_number":268,"context_line":"   This value may be exceeded if there is any reduction on the transfer rate after"},{"line_number":269,"context_line":"   the VM is paused. The default is 500."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"   ``live_migration_downtime_steps`` sets the total number of adjustment steps"},{"line_number":272,"context_line":"   until ``live_migration_downtime`` is reached.  The default is 10 steps."}],"source_content_type":"text/x-rst","patch_set":3,"id":"19fc7508_2f1c31cb","line":269,"in_reply_to":"672da62b_6bf2520f","updated":"2022-02-11 13:36:38.000000000","message":"I just feel like saying \"target maximum\" may lead the reader to think *there\u0027s no way* that value is exceeded, which is not true. What do you think?","commit_id":"2787a90abfddbb7f627469c997a2985d831948e9"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2b849f61c12b41d957e6a6e3a7bc84217cd53c47","unresolved":true,"context_lines":[{"line_number":266,"context_line":"   ``live_migration_downtime`` sets the period of time Nova will try to keep "},{"line_number":267,"context_line":"   the instance paused during the last part of the memory copy, in *milliseconds*."},{"line_number":268,"context_line":"   This value may be exceeded if there is any reduction on the transfer rate after"},{"line_number":269,"context_line":"   the VM is paused. The default is 500."},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"   ``live_migration_downtime_steps`` sets the total number of adjustment steps"},{"line_number":272,"context_line":"   until ``live_migration_downtime`` is reached.  The default is 10 steps."}],"source_content_type":"text/x-rst","patch_set":3,"id":"672da62b_6bf2520f","line":269,"in_reply_to":"8d50911d_70f1e986","updated":"2022-02-10 13:49:18.000000000","message":"nit: i kind of feel like this shoudl be \n\n ``live_migration_downtime`` sets the target maximum period of time Nova will try to keep","commit_id":"2787a90abfddbb7f627469c997a2985d831948e9"}],"nova/conf/libvirt.py":[{"author":{"_account_id":33987,"name":"Pedro Monteiro Azevedo de Moura Almeida","display_name":"Pedro Almeida","email":"pedro.monteiroazevedodemouraalmeida@windriver.com","username":"pedroalmd"},"change_message_id":"11c2a33b28c68ed2ef7d72ea4d6822bf2a32a147","unresolved":false,"context_lines":[{"line_number":321,"context_line":"               default\u003d500,"},{"line_number":322,"context_line":"               min\u003d100,"},{"line_number":323,"context_line":"               help\u003d\"\"\""},{"line_number":324,"context_line":"Target maximum period of time Nova will try to keep the instance paused during the last"},{"line_number":325,"context_line":"part of the memory copy, in *milliseconds*."},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"Will be rounded up to a minimum of 100ms. You can increase this value"}],"source_content_type":"text/x-python","patch_set":4,"id":"dd2255ce_38735f9d","line":324,"in_reply_to":"3a4c527a_7a029500","updated":"2022-02-23 16:22:25.000000000","message":"\u003e pep8: E501 line too long (87 \u003e 79 characters)\n\nPlease fix.","commit_id":"4993129cc743bdbd4ed13de97f56c395177d8347"}]}
