)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6ddf837c03e70d0588fa194dd0308aa5be45f29f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f115768_c3f1c075","updated":"2022-02-09 11:23:46.000000000","message":"Looks good to me","commit_id":"5ec856842497376956c28e5774cd9704cf9d8ed8"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"9b2ad2cfad8a62e6cce6afc505933ccddf29ec37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed40153d_198a990e","updated":"2022-02-09 12:58:13.000000000","message":"Thanks. logging is added","commit_id":"5ec856842497376956c28e5774cd9704cf9d8ed8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"41198e5917f20aa69ee59fa57ffdfbd35aa0af55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e6936e38_edb19a6c","updated":"2022-02-09 11:30:52.000000000","message":"i agree with gibi in general by the way i just think we could have better logging to help with debuging this. if you respin im more or less +2\n\nit would be nice to also have a \"fixes\" release note\n\nwe likely will want to backport this and operators will likely want to see this called out in the release notes","commit_id":"5ec856842497376956c28e5774cd9704cf9d8ed8"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"29b1d1fae0a5f7f89292835f03316a4a1dc18292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"473b8ffa_9075ed4d","updated":"2022-02-09 13:03:51.000000000","message":"now also added a release note","commit_id":"23166f58538dff5edb5d33de1e1e1aa9e911a0df"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"31455723aeb4a119a8a7ded3dd80f09c5af66d51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45efe236_42ef6097","updated":"2022-02-14 11:18:06.000000000","message":"Still good","commit_id":"9eb116b99ce32bc69c4abf8ec3b0179ef89a8860"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b282d2ed0536a07d54b7c0b8df9f5adc406daf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c97a4cc5_667e005d","updated":"2022-02-09 14:26:36.000000000","message":"thanks for the prompt response.\n\nthe release note reads slightly clunky to me but it links to the bug\nso i think its ok.","commit_id":"9eb116b99ce32bc69c4abf8ec3b0179ef89a8860"}],"nova/compute/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6ddf837c03e70d0588fa194dd0308aa5be45f29f","unresolved":false,"context_lines":[{"line_number":4808,"context_line":"                context, instance, device, volume, disk_bus\u003ddisk_bus,"},{"line_number":4809,"context_line":"                device_type\u003ddevice_type, tag\u003dtag,"},{"line_number":4810,"context_line":"                delete_on_termination\u003ddelete_on_termination)"},{"line_number":4811,"context_line":"        except oslo_exceptions.MessagingTimeout:"},{"line_number":4812,"context_line":"            # The compute node might have already created the attachment but"},{"line_number":4813,"context_line":"            # we never received the answer. In this case it is safe to delete"},{"line_number":4814,"context_line":"            # the attachment as nobody will ever pick it up again."}],"source_content_type":"text/x-python","patch_set":1,"id":"2b8f5c90_55fe1813","line":4811,"updated":"2022-02-09 11:23:46.000000000","message":"This looks good. The call above is just a way we reserve device names on the compute to avoid races. So even if the reservation succeeds on the compute but we never get the response we will not attach the volume so we need to drop the reservation, i.e. delete the bdm.","commit_id":"5ec856842497376956c28e5774cd9704cf9d8ed8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4f95441ef6044785aede95b2f40d5f18b8476e8e","unresolved":true,"context_lines":[{"line_number":4817,"context_line":"                    objects.BlockDeviceMapping.get_by_volume_and_instance("},{"line_number":4818,"context_line":"                        context, volume[\u0027id\u0027], instance.uuid).destroy()"},{"line_number":4819,"context_line":"                except exception.VolumeBDMNotFound:"},{"line_number":4820,"context_line":"                    pass"},{"line_number":4821,"context_line":"        try:"},{"line_number":4822,"context_line":"            self._check_attach_and_reserve_volume(context, volume, instance,"},{"line_number":4823,"context_line":"                                                  volume_bdm,"}],"source_content_type":"text/x-python","patch_set":1,"id":"a9674d40_679051e0","line":4820,"range":{"start_line":4820,"start_character":20,"end_line":4820,"end_character":24},"updated":"2022-02-09 11:29:14.000000000","message":"we try to avoid just doing pass althogu hi have done it myself in the past.\n\ni feel like we shoudl have a debug log \n\nso\n\n                try:\n                    LOG.debug(f\"Attaching volume {volume[\u0027id\u0027]} timedout removing bdm in db\")\n                    objects.BlockDeviceMapping.get_by_volume_and_instance(\n                        context, volume[\u0027id\u0027], instance.uuid).destroy()\n                except exception.VolumeBDMNotFound:\n                    LOG.debug(f\"BDM not found ignoring removal error volume {volume[\u0027id\u0027]}\")","commit_id":"5ec856842497376956c28e5774cd9704cf9d8ed8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b282d2ed0536a07d54b7c0b8df9f5adc406daf6","unresolved":false,"context_lines":[{"line_number":4817,"context_line":"                    objects.BlockDeviceMapping.get_by_volume_and_instance("},{"line_number":4818,"context_line":"                        context, volume[\u0027id\u0027], instance.uuid).destroy()"},{"line_number":4819,"context_line":"                except exception.VolumeBDMNotFound:"},{"line_number":4820,"context_line":"                    pass"},{"line_number":4821,"context_line":"        try:"},{"line_number":4822,"context_line":"            self._check_attach_and_reserve_volume(context, volume, instance,"},{"line_number":4823,"context_line":"                                                  volume_bdm,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b9b06a1_1158168a","line":4820,"range":{"start_line":4820,"start_character":20,"end_line":4820,"end_character":24},"in_reply_to":"381e9a3c_19c70273","updated":"2022-02-09 14:26:36.000000000","message":"Done","commit_id":"5ec856842497376956c28e5774cd9704cf9d8ed8"},{"author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"change_message_id":"9b2ad2cfad8a62e6cce6afc505933ccddf29ec37","unresolved":true,"context_lines":[{"line_number":4817,"context_line":"                    objects.BlockDeviceMapping.get_by_volume_and_instance("},{"line_number":4818,"context_line":"                        context, volume[\u0027id\u0027], instance.uuid).destroy()"},{"line_number":4819,"context_line":"                except exception.VolumeBDMNotFound:"},{"line_number":4820,"context_line":"                    pass"},{"line_number":4821,"context_line":"        try:"},{"line_number":4822,"context_line":"            self._check_attach_and_reserve_volume(context, volume, instance,"},{"line_number":4823,"context_line":"                                                  volume_bdm,"}],"source_content_type":"text/x-python","patch_set":1,"id":"381e9a3c_19c70273","line":4820,"range":{"start_line":4820,"start_character":20,"end_line":4820,"end_character":24},"in_reply_to":"a9674d40_679051e0","updated":"2022-02-09 12:58:13.000000000","message":"Thanks for the suggestion. I added logging for both paths.","commit_id":"5ec856842497376956c28e5774cd9704cf9d8ed8"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8b282d2ed0536a07d54b7c0b8df9f5adc406daf6","unresolved":false,"context_lines":[{"line_number":4820,"context_line":"                              f\"attachment request for volume {volume[\u0027id\u0027]}\")"},{"line_number":4821,"context_line":"                except exception.VolumeBDMNotFound:"},{"line_number":4822,"context_line":"                    LOG.debug(\"BDM not found, ignoring removal. \""},{"line_number":4823,"context_line":"                              f\"Error attaching volume {volume[\u0027id\u0027]}\")"},{"line_number":4824,"context_line":"        try:"},{"line_number":4825,"context_line":"            self._check_attach_and_reserve_volume(context, volume, instance,"},{"line_number":4826,"context_line":"                                                  volume_bdm,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae96679_08b3dbdf","line":4823,"updated":"2022-02-09 14:26:36.000000000","message":"+1","commit_id":"9eb116b99ce32bc69c4abf8ec3b0179ef89a8860"}]}