)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"998e062fdb83205c1535e6cd0fc0b70d00b7a366","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ada81990_29ef0969","updated":"2022-03-22 19:56:50.000000000","message":"lgtm, thanks. 1 comment.","commit_id":"06ab3bf0e611a99101441b1b25c474184eb989ad"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3659b57db9e3ff0a5b0be188157c35e0115fc544","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e5c5f67b_68841c97","updated":"2022-03-23 10:50:16.000000000","message":"Legit.","commit_id":"7beff288d65fb015bdecba02fab06efd004a336e"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0fce1958d942581a131ba37513f49dcc9c2f5bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b4493504_a1bb3fda","updated":"2022-03-23 14:17:46.000000000","message":"thanks Stephen","commit_id":"7beff288d65fb015bdecba02fab06efd004a336e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"dd4f93d4c7d07266cf70d65dbab1f97f938591d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4d78fd95_62a0af8e","updated":"2022-03-23 14:48:13.000000000","message":"this also looks good to me thanks stephen.","commit_id":"7beff288d65fb015bdecba02fab06efd004a336e"}],"doc/source/contributor/api.rst":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"998e062fdb83205c1535e6cd0fc0b70d00b7a366","unresolved":true,"context_lines":[{"line_number":146,"context_line":"    @validation.schema(schema.update_something)"},{"line_number":147,"context_line":"    def update(self, req, id, body):"},{"line_number":148,"context_line":"        ...."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Similarly to controller modularity, JSON-Schema definitions can be added"},{"line_number":151,"context_line":"in same or separate JSON-Schema module."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"The following are the combinations of extensible API and method name"},{"line_number":154,"context_line":"which returns additional JSON-Schema parameters:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"* Create a server API  - get_server_create_schema()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"For example, keypairs extension(Keypairs class) contains the method"},{"line_number":159,"context_line":"get_server_create_schema() which returns::"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    {"},{"line_number":162,"context_line":"        \u0027key_name\u0027: parameter_types.name,"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"then the parameter key_name is allowed on Create a server API."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. note:: Currently only create schema are implemented in modular way."},{"line_number":168,"context_line":"          Final goal is to merge them all and define the concluded"},{"line_number":169,"context_line":"          process in this doc."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"These are essentially hooks into the servers controller which allow other"},{"line_number":172,"context_line":"controller to modify behaviour without having to modify servers.py. In"},{"line_number":173,"context_line":"the past not having this capability led to very large chunks of"},{"line_number":174,"context_line":"unrelated code being added to servers.py which was difficult to"},{"line_number":175,"context_line":"maintain."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Unit Tests"},{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"be90a159_c7541fb2","side":"PARENT","line":177,"range":{"start_line":149,"start_character":0,"end_line":177,"end_character":0},"updated":"2022-03-22 19:56:50.000000000","message":"we can remove this section entirely. Schema extensions hook is also removed during extensions merge and we no longer have that logic.","commit_id":"9a31212a445eef451e6227b51feca7c14cd6ba3c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"40968593db68534e4b7a36b443091536a32fbd37","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    @validation.schema(schema.update_something)"},{"line_number":147,"context_line":"    def update(self, req, id, body):"},{"line_number":148,"context_line":"        ...."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Similarly to controller modularity, JSON-Schema definitions can be added"},{"line_number":151,"context_line":"in same or separate JSON-Schema module."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"The following are the combinations of extensible API and method name"},{"line_number":154,"context_line":"which returns additional JSON-Schema parameters:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"* Create a server API  - get_server_create_schema()"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"For example, keypairs extension(Keypairs class) contains the method"},{"line_number":159,"context_line":"get_server_create_schema() which returns::"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    {"},{"line_number":162,"context_line":"        \u0027key_name\u0027: parameter_types.name,"},{"line_number":163,"context_line":"    }"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"then the parameter key_name is allowed on Create a server API."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":".. note:: Currently only create schema are implemented in modular way."},{"line_number":168,"context_line":"          Final goal is to merge them all and define the concluded"},{"line_number":169,"context_line":"          process in this doc."},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"These are essentially hooks into the servers controller which allow other"},{"line_number":172,"context_line":"controller to modify behaviour without having to modify servers.py. In"},{"line_number":173,"context_line":"the past not having this capability led to very large chunks of"},{"line_number":174,"context_line":"unrelated code being added to servers.py which was difficult to"},{"line_number":175,"context_line":"maintain."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"Unit Tests"},{"line_number":179,"context_line":"----------"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"f79b6d15_f0edf972","side":"PARENT","line":177,"range":{"start_line":149,"start_character":0,"end_line":177,"end_character":0},"in_reply_to":"be90a159_c7541fb2","updated":"2022-03-23 10:26:33.000000000","message":"Done","commit_id":"9a31212a445eef451e6227b51feca7c14cd6ba3c"}]}