)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e61c8b631472dffdc08fa1be15bb049ae64d0c8d","unresolved":true,"context_lines":[{"line_number":19,"context_line":"```"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I8a9b150815313b1a694363bb31e5ac509c912643"},{"line_number":22,"context_line":"Closes-bug: #1960840"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"826a3ea8_9622ac68","line":22,"updated":"2022-02-15 00:26:51.000000000","message":"i dont know how this fixes anything.\nit certenly dose not adress the bug.\n\nparse_dom is used for pasrsing the xml and reconstucting our config object form it however nova is what generates teh xml.\nwe do not use the quota values sotred in the xml and you cannot change them via virsh or other means and expect it to be persited. that is explictly not supported so we dont actully need to support parsing the quota xml values in general.\n\n\nthe correct way to “fix” this would be to validate the flavor extra specs and assert the maxium size as part of that validation. we woudl also need to validate the size as part of the xml generation not the parsing.\n\nthat should be done by setting the max value here https://github.com/openstack/nova/blob/3a14c1a4277a9f44b67e080138b28b680e5e6824/nova/api/validation/extra_specs/quota.py#L183\n\nto uint32 max","commit_id":"74e288391e5da615beba91225933f2aba6c6edf9"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"7f29f56fb5b6b5593cb65b24a945dba708961aff","unresolved":false,"context_lines":[{"line_number":19,"context_line":"```"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I8a9b150815313b1a694363bb31e5ac509c912643"},{"line_number":22,"context_line":"Closes-bug: #1960840"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"2e45a3d3_73e9375a","line":22,"in_reply_to":"826a3ea8_9622ac68","updated":"2022-02-15 00:52:50.000000000","message":"Hopefully you like this patch better.","commit_id":"74e288391e5da615beba91225933f2aba6c6edf9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2caf23676ab38ab39788eb6dd016b997ca872252","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"83a76a57_4a3182c5","updated":"2022-02-21 19:01:00.000000000","message":"This looks good. Can you add a release note (using \u0027reno\u0027)","commit_id":"8a1c41a1c4537ba8c5053413df06c8b6b2a7fa1d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"71db41cd83421ef8e7979efc1f78dc2653bb87c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"36539f79_290ef1c0","in_reply_to":"55e6d585_497b840d","updated":"2023-06-20 10:04:51.000000000","message":"I don\u0027t see why it wouldn\u0027t be. It\u0027s still an issue with libvirt afaik. It\u0027s a small issue but that doesn\u0027t mean we can\u0027t fix it","commit_id":"8a1c41a1c4537ba8c5053413df06c8b6b2a7fa1d"},{"author":{"_account_id":7130,"name":"David Hill","email":"davidchill@hotmail.com","username":"dhill"},"change_message_id":"46d4c3a8140c2bff5fa1fe214bc01aa8df2ce801","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"55e6d585_497b840d","in_reply_to":"83a76a57_4a3182c5","updated":"2023-06-05 15:05:49.000000000","message":"If we think this is still needed, I can put the effort on that otherwise we can abandon this commit.","commit_id":"8a1c41a1c4537ba8c5053413df06c8b6b2a7fa1d"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e61c8b631472dffdc08fa1be15bb049ae64d0c8d","unresolved":true,"context_lines":[{"line_number":1744,"context_line":"        self.vif_inbound_average \u003d None"},{"line_number":1745,"context_line":"        self.vif_outbound_peak \u003d None"},{"line_number":1746,"context_line":"        self.vif_outbound_burst \u003d None"},{"line_number":1747,"context_line":"        self.vif_outbound_average \u003d None"},{"line_number":1748,"context_line":"        self.vlan \u003d None"},{"line_number":1749,"context_line":"        self.device_addr \u003d None"},{"line_number":1750,"context_line":"        self.mtu \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"7d836cb3_3d07a69e","line":1747,"updated":"2022-02-15 00:26:51.000000000","message":"you should proably also convert the self.vif_* vaules\nto self._vif_* and add vif_* properties with setters that validate teh max value\nand raise ValueError or a new nova out of range exception or similar.","commit_id":"74e288391e5da615beba91225933f2aba6c6edf9"}]}