)]}'
{"nova/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f1f30bb31a3e6276b522bb5729ab4f910a067a01","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        :param service_ref: The nova.objects.Service for this"},{"line_number":139,"context_line":"        \"\"\""},{"line_number":140,"context_line":"        self.service_ref \u003d service_ref"},{"line_number":141,"context_line":"        self.health_manager \u003d hm.HealthcheckManager("},{"line_number":142,"context_line":"            service_ref.uuid, self.service_name)"},{"line_number":143,"context_line":"        context.register_healthcheck_tracker(self.health_manager.tracker)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def post_start_hook(self):"},{"line_number":146,"context_line":"        \"\"\"Hook to provide the manager the ability to do additional"}],"source_content_type":"text/x-python","patch_set":12,"id":"cc87b54f_41967aef","line":143,"range":{"start_line":141,"start_character":0,"end_line":143,"end_character":73},"updated":"2024-02-09 10:07:16.000000000","message":"it feels a bit strange that we create the tracker here and the inject into the global variable. If the tracker needs to be a singleton per process (I think so) then I would have a global getter that initialize the tracker at the first call and then call that getter here. \n\nImagine that at some point we will have to managers in the same process then they will start racing on who sets the global tracker.","commit_id":"d25d4110456598c3f7be2826849410bbeb74bd22"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"24cd2885cdf4e707c0cc25a02ed26a84f80ed3ea","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        :param service_ref: The nova.objects.Service for this"},{"line_number":139,"context_line":"        \"\"\""},{"line_number":140,"context_line":"        self.service_ref \u003d service_ref"},{"line_number":141,"context_line":"        self.health_manager \u003d hm.HealthcheckManager("},{"line_number":142,"context_line":"            service_ref.uuid, self.service_name)"},{"line_number":143,"context_line":"        context.register_healthcheck_tracker(self.health_manager.tracker)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def post_start_hook(self):"},{"line_number":146,"context_line":"        \"\"\"Hook to provide the manager the ability to do additional"}],"source_content_type":"text/x-python","patch_set":12,"id":"dbc7c448_bc25ffea","line":143,"range":{"start_line":141,"start_character":0,"end_line":143,"end_character":73},"in_reply_to":"cc87b54f_41967aef","updated":"2024-02-13 10:05:07.000000000","message":"ill think about this some more.\n\ni didnt really reant this to be a global singelton for testing reason and wanted to have the manage passed via the context. im not sure if we will ever want more then one manger per process but id idnt want to require this to be a singleton in terms of access. i.e. i expiclty didnt whant this to work like how we use oslo.config","commit_id":"d25d4110456598c3f7be2826849410bbeb74bd22"}],"nova/scheduler/manager.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1b0beab79c40342a9b231401c6927e4e66717f28","unresolved":true,"context_lines":[{"line_number":134,"context_line":"            else:"},{"line_number":135,"context_line":"                LOG.debug(msg)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def reset(self):"},{"line_number":138,"context_line":"        super().reset()"},{"line_number":139,"context_line":"        # NOTE(tssurya): This is a SIGHUP handler which will reset the cells"},{"line_number":140,"context_line":"        # and enabled cells caches in the host manager. So every time an"}],"source_content_type":"text/x-python","patch_set":5,"id":"17dd1cd1_750a7cb0","line":137,"updated":"2023-08-03 10:08:22.000000000","message":"at what point health_manager become part of this !!","commit_id":"2e3bd7660e99fd8f66a7bd8efc449e5a391a1582"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fd2042528a60dec9d164e5bc3c0d788ca4c37524","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            else:"},{"line_number":135,"context_line":"                LOG.debug(msg)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def reset(self):"},{"line_number":138,"context_line":"        super().reset()"},{"line_number":139,"context_line":"        # NOTE(tssurya): This is a SIGHUP handler which will reset the cells"},{"line_number":140,"context_line":"        # and enabled cells caches in the host manager. So every time an"}],"source_content_type":"text/x-python","patch_set":5,"id":"9d3997fb_baad1c2e","line":137,"in_reply_to":"17dd1cd1_750a7cb0","updated":"2024-01-24 13:57:12.000000000","message":"here when we added it to the base class https://review.opendev.org/c/openstack/nova/+/829468/11/nova/manager.py#141","commit_id":"2e3bd7660e99fd8f66a7bd8efc449e5a391a1582"}]}