)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f8df1dca3bbe33d6a679ee1abcf66ac8ff24eec","unresolved":true,"context_lines":[{"line_number":10,"context_line":"extra specs in flavor as well as server APIs response."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"As per RBAC new guidelines, we are restricting project level"},{"line_number":13,"context_line":"respurces APIs to project scoped only. To do that, we are"},{"line_number":14,"context_line":"separating the flavor extra specs index policy for server"},{"line_number":15,"context_line":"APIs and make them only for project scoped."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"0b7933ae_d1a39ffc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":9},"updated":"2022-02-23 16:27:04.000000000","message":"nit: resources","commit_id":"9555fb2a12f495315a08ff42f884f32e1d2a9c75"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1259518231f0f68f2c385893adf918945682d117","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"45a7d613_70926ff8","updated":"2022-02-24 13:00:21.000000000","message":"looks OK","commit_id":"9555fb2a12f495315a08ff42f884f32e1d2a9c75"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f8df1dca3bbe33d6a679ee1abcf66ac8ff24eec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"eb957b0a_2187ce30","updated":"2022-02-23 16:27:04.000000000","message":"looks good overall to me but I have a question for https://review.opendev.org/c/openstack/nova/+/829626/9/nova/api/openstack/compute/views/servers.py#443","commit_id":"9555fb2a12f495315a08ff42f884f32e1d2a9c75"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b013e69bf45bce251d69782544d6ffe6215a3af3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a898b7c2_5d5accf8","updated":"2022-02-25 12:48:29.000000000","message":"recheck","commit_id":"1be007243b71713d4d19b3f15eb1c472c7fb2d96"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7af36d5c6b88b1cd4b6287e0d63750029cf4c00d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d2d64214_8a88d5a7","updated":"2022-02-25 00:57:01.000000000","message":"recheck","commit_id":"1be007243b71713d4d19b3f15eb1c472c7fb2d96"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"09d3fec2ae58291320001e7d8c05e1bdd8efc77b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cc8eaccc_dd29c5b6","updated":"2022-02-26 08:13:38.000000000","message":"recheck ssh timeout","commit_id":"1be007243b71713d4d19b3f15eb1c472c7fb2d96"}],"nova/api/openstack/compute/views/servers.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f8df1dca3bbe33d6a679ee1abcf66ac8ff24eec","unresolved":true,"context_lines":[{"line_number":440,"context_line":"            # once before we iterate the list of instances"},{"line_number":441,"context_line":"            show_extra_specs \u003d context.can("},{"line_number":442,"context_line":"                servers_policies.SERVERS % \u0027show:flavor-extra-specs\u0027,"},{"line_number":443,"context_line":"                fatal\u003dFalse)"},{"line_number":444,"context_line":"        else:"},{"line_number":445,"context_line":"            show_extra_specs \u003d False"},{"line_number":446,"context_line":"        show_extended_attr \u003d context.can("}],"source_content_type":"text/x-python","patch_set":9,"id":"962964dd_4e602fd6","line":443,"updated":"2022-02-23 16:27:04.000000000","message":"shouldn\u0027t we restrict to only the list of instances for THAT project_id I\u0027m part of?","commit_id":"9555fb2a12f495315a08ff42f884f32e1d2a9c75"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3f2d05ecd1689dbfb50f79b9259b3357caae7e0a","unresolved":true,"context_lines":[{"line_number":440,"context_line":"            # once before we iterate the list of instances"},{"line_number":441,"context_line":"            show_extra_specs \u003d context.can("},{"line_number":442,"context_line":"                servers_policies.SERVERS % \u0027show:flavor-extra-specs\u0027,"},{"line_number":443,"context_line":"                fatal\u003dFalse)"},{"line_number":444,"context_line":"        else:"},{"line_number":445,"context_line":"            show_extra_specs \u003d False"},{"line_number":446,"context_line":"        show_extended_attr \u003d context.can("}],"source_content_type":"text/x-python","patch_set":9,"id":"002a1291_47aff9fd","line":443,"in_reply_to":"83030bed_ba24813b","updated":"2022-02-23 16:43:29.000000000","message":"Ack","commit_id":"9555fb2a12f495315a08ff42f884f32e1d2a9c75"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c08d4ac927a9796d512751919ee658eaa0bf583a","unresolved":true,"context_lines":[{"line_number":440,"context_line":"            # once before we iterate the list of instances"},{"line_number":441,"context_line":"            show_extra_specs \u003d context.can("},{"line_number":442,"context_line":"                servers_policies.SERVERS % \u0027show:flavor-extra-specs\u0027,"},{"line_number":443,"context_line":"                fatal\u003dFalse)"},{"line_number":444,"context_line":"        else:"},{"line_number":445,"context_line":"            show_extra_specs \u003d False"},{"line_number":446,"context_line":"        show_extended_attr \u003d context.can("}],"source_content_type":"text/x-python","patch_set":9,"id":"83030bed_ba24813b","line":443,"in_reply_to":"962964dd_4e602fd6","updated":"2022-02-23 16:38:33.000000000","message":"it will do while doing the DB query to list the instances. For policy it is same thing that it will pass as it will check the requester context\u0027s project_id itself (https://github.com/openstack/nova/blob/134c4791ff8233264b7862db692e058f60ae2f80/nova/policy.py#L183)\n\nif all-tenants is requested then it fetch all project instance.","commit_id":"9555fb2a12f495315a08ff42f884f32e1d2a9c75"}],"nova/policies/flavor_extra_specs.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f8df1dca3bbe33d6a679ee1abcf66ac8ff24eec","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from nova.policies import base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"POLICY_ROOT \u003d \u0027os_compute_api:os-flavor-extra-specs:%s\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"18e44013_4089c550","side":"PARENT","line":20,"updated":"2022-02-23 16:27:04.000000000","message":"unnecessary change","commit_id":"87bfbc55675e277b7ac6e83e8ff6f0d5dbb49025"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f8df1dca3bbe33d6a679ee1abcf66ac8ff24eec","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"POLICY_ROOT \u003d \u0027os_compute_api:os-flavor-extra-specs:%s\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"flavor_extra_specs_policies \u003d ["},{"line_number":25,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":26,"context_line":"        name\u003dPOLICY_ROOT % \u0027show\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"e76517b9_035dff61","side":"PARENT","line":23,"updated":"2022-02-23 16:27:04.000000000","message":"unnecessary removal too","commit_id":"87bfbc55675e277b7ac6e83e8ff6f0d5dbb49025"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f8df1dca3bbe33d6a679ee1abcf66ac8ff24eec","unresolved":true,"context_lines":[{"line_number":86,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}/os-extra_specs/\u0027,"},{"line_number":87,"context_line":"                \u0027method\u0027: \u0027GET\u0027"},{"line_number":88,"context_line":"            },"},{"line_number":89,"context_line":"            # Microversion 2.47 operations for servers:"},{"line_number":90,"context_line":"            {"},{"line_number":91,"context_line":"                \u0027path\u0027: \u0027/servers/detail\u0027,"},{"line_number":92,"context_line":"                \u0027method\u0027: \u0027GET\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"52256aa3_92fedb73","side":"PARENT","line":89,"updated":"2022-02-23 16:27:04.000000000","message":"what happens with this microversion support ?\n\nlater : oh this was moved to to the servers policy definition file.","commit_id":"87bfbc55675e277b7ac6e83e8ff6f0d5dbb49025"}],"nova/policies/servers.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4f8df1dca3bbe33d6a679ee1abcf66ac8ff24eec","unresolved":true,"context_lines":[{"line_number":108,"context_line":"        scope_types\u003d[\u0027project\u0027]),"},{"line_number":109,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":110,"context_line":"        name\u003dSERVERS % \u0027show:flavor-extra-specs\u0027,"},{"line_number":111,"context_line":"        check_str\u003dbase.PROJECT_READER,"},{"line_number":112,"context_line":"        description\u003d\"Starting with microversion 2.47, the flavor and its \""},{"line_number":113,"context_line":"        \"extra specs used for a server is also returned in the response \""},{"line_number":114,"context_line":"        \"when showing server details, updating a server or rebuilding a \""}],"source_content_type":"text/x-python","patch_set":9,"id":"3dfb06e5_8dec47f3","line":111,"updated":"2022-02-23 16:27:04.000000000","message":"yeah, makes sense to restrict to the project_id","commit_id":"9555fb2a12f495315a08ff42f884f32e1d2a9c75"}]}