)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b0fa2b663bc44cf3d03f7c60a955ad987bd70e23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4c7d9c8_ec12124c","updated":"2022-02-17 20:37:25.000000000","message":"clean backport","commit_id":"ee5970e689bff559b01ea3d85db8cb4836b2c813"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"46f1c6db971f14020e7dc207df5cfc3467ef4fae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68a648cb_244e9eed","updated":"2022-02-18 06:01:23.000000000","message":"recheck","commit_id":"ee5970e689bff559b01ea3d85db8cb4836b2c813"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8516f2156766a8419f57cc480d2b7765e5fbd2f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8c22ca7b_1787ba9c","updated":"2022-08-16 17:24:17.000000000","message":"recheck","commit_id":"bb549a4c2018f4c365036d7a6492511bd9c53743"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"6185ceff71090cb32ca000d9db471ce502e2366c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5ffdaeeb_48a42fea","updated":"2022-10-25 16:32:38.000000000","message":"This is a bit \"feature-ish\", but as Sean commented:\n* clean cherry pick (from yoga, which was master at merge time)\n* default behavior is kept\n\nI\u0027m not against backporting this, but let other stable cores to also review.","commit_id":"5031e5f73099824e88c10da53bf255ec934828a1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7db527bf2dee29737c0852993d62fdf34240557d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5bce8601_af9439c7","updated":"2022-10-19 10:33:26.000000000","message":"yep this is clean and it default to keeping the same behavior so without enabling the config option there is not impact on exsiting deployments and existing deployment can opt into this if they choose too.","commit_id":"5031e5f73099824e88c10da53bf255ec934828a1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c777a0ac7c34fb1653d7de615aa3e36569fdc869","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"17b00c2e_fc8a93e3","in_reply_to":"5bce8601_af9439c7","updated":"2023-04-26 21:19:02.000000000","message":"patchset was rebased, please merge","commit_id":"5031e5f73099824e88c10da53bf255ec934828a1"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d1e921111730094031c83d19901244540614ddde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dc9d1bfa_46cdd9f8","in_reply_to":"5ffdaeeb_48a42fea","updated":"2023-04-19 15:21:19.000000000","message":"My former comment is still valid:\n\n\u003e This is a bit \"feature-ish\", but as Sean commented:\n\u003e * clean cherry pick (from yoga, which was master at merge time)\n\u003e * default behavior is kept\n\u003e \n\u003e I\u0027m not against backporting this, but let other stable cores to also review.","commit_id":"5031e5f73099824e88c10da53bf255ec934828a1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e44cd31737b301cbb662abe20fa29f72aacefbfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2c952098_c20a1fef","updated":"2023-02-07 17:40:57.000000000","message":"fixed merge conflict","commit_id":"bc69c9fcce6f8df2ba325213806a499e57ba0d5c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3d85267db09ae110befab282920fc238b32522c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2c7a4ebd_c04cd3db","updated":"2023-06-08 13:59:53.000000000","message":"Can you link me to the discussion of this? To me this looks like almost entirely a feature being backported to an EM branch, and not really a regression from previous releases (AFAICT). I\u0027m not sure how this really satisfies the criteria for a backport in general, especially to an EM release, with a \"features\" reno and a new config knob. I\u0027m -1ing for visibility, but really hoping to review the discussion about this as maybe I\u0027m missing something important.","commit_id":"221723123af5c32cd1b48779ad25d352605b427d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"3efafcb1d2555c5b1f46b0d585d08ee65118641c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"af3c9f52_a15f5ad4","updated":"2023-06-08 18:25:47.000000000","message":"Directed by Robert B. Weide","commit_id":"221723123af5c32cd1b48779ad25d352605b427d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8fb5db213ca63fda5780b8384e0efaa704078e37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ec417ffb_fbd15bb8","updated":"2023-06-08 18:45:43.000000000","message":"for more context to fix the","commit_id":"221723123af5c32cd1b48779ad25d352605b427d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6140f95159ca56532e20d7fa4056ae2d2825e046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36bf71ec_08b9b36c","updated":"2023-05-30 16:08:19.000000000","message":"up","commit_id":"221723123af5c32cd1b48779ad25d352605b427d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6b98786ed73c01a84f267466c110cf3f61f9c85d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"49202c63_bb052f47","updated":"2023-05-15 20:21:04.000000000","message":"we discussed this on the last nova team meeting and agreed that this was ok to backport.","commit_id":"221723123af5c32cd1b48779ad25d352605b427d"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"152e35c5a928f16d7eeb0840044537d3ef7f55cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e7275f81_66a2dde8","in_reply_to":"2c7a4ebd_c04cd3db","updated":"2023-06-08 14:16:25.000000000","message":"this is not a feature and was ready to be merged long time (more than year) before EM. the lack of reviewers, long discussions, etc. takes very long time before we merge this and you again stop the process for a while.","commit_id":"221723123af5c32cd1b48779ad25d352605b427d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8fb5db213ca63fda5780b8384e0efaa704078e37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d2feda87_bd8a48e2","in_reply_to":"4f410b21_db6a3301","updated":"2023-06-08 18:45:43.000000000","message":"for more context to fix the supprot for host with large numers of numa nodes,  which was actully the primary motivation for backporitng this  https://bugs.launchpad.net/nova/+bug/1978372\nwe shoudl be backporting https://review.opendev.org/c/openstack/nova/+/845896 not this patch.\n\nthis patch was one possible workaround for bug/1978372\nas noted in https://bugs.launchpad.net/nova/+bug/1978372/comments/6\n\nbut we realsied that a better solution was to improve the algortim by useing memertorisation which is what https://review.opendev.org/c/openstack/nova/+/845896\ndid.","commit_id":"221723123af5c32cd1b48779ad25d352605b427d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0e1e5fce8f990e18eb76a48c677c19f604e57486","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4f410b21_db6a3301","in_reply_to":"e7275f81_66a2dde8","updated":"2023-06-08 17:40:36.000000000","message":"actuly whther this is a feature or a bug was debated when this was first merged.\n\nso dan is correct to question if this is backportable.\n\nespically since checkign the logs i commented on teh wrong patch\n\nhttps://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2023-05-09.log.html#t2023-05-09T16:18:46\n\nwe agreed to backport https://review.opendev.org/c/openstack/nova/+/877500/1/releasenotes/notes/Do-not-send-mtu-value-in-metadata-for-networks-with-enabled-dhcp-641506f2a13b540f.yaml\n\nnot this","commit_id":"221723123af5c32cd1b48779ad25d352605b427d"}]}