)]}'
{"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"a2b03324f69f8d73fbd9990f27d5ea00a2ab62e6","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        # Attach any other disks"},{"line_number":343,"context_line":"        for vdi in vdis[1:]:"},{"line_number":344,"context_line":"            # vdi[\u0027vdi_type\u0027] is either \u0027os\u0027 or \u0027swap\u0027, but we don\u0027t"},{"line_number":345,"context_line":"            # really care what it is right here."},{"line_number":346,"context_line":"            vdi_ref \u003d self._session.call_xenapi(\u0027VDI.get_by_uuid\u0027,"},{"line_number":347,"context_line":"                    vdi[\u0027vdi_uuid\u0027])"},{"line_number":348,"context_line":"            VMHelper.create_vbd(session\u003dself._session, vm_ref\u003dvm_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F8xA%3D","side":"PARENT","line":345,"updated":"2011-10-13 01:15:07.000000000","message":"Should we ignore \u0027swap\u0027 vdi types here if FLAGS.xenapi_generate_swap is True?  With my images (that have a swap in .ova), I\u0027d end up with 2 swap vdis attached.  I think I\u0027ll let this pass for now as I\u0027m guessing we may ditch the swap in .ova support altogether.","commit_id":"56be39aedb195576179e73c859db2271a9585496"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"1d0a33131bb2367a28633b9b539c03a74162993f","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        # Attach any other disks"},{"line_number":343,"context_line":"        for vdi in vdis[1:]:"},{"line_number":344,"context_line":"            # vdi[\u0027vdi_type\u0027] is either \u0027os\u0027 or \u0027swap\u0027, but we don\u0027t"},{"line_number":345,"context_line":"            # really care what it is right here."},{"line_number":346,"context_line":"            vdi_ref \u003d self._session.call_xenapi(\u0027VDI.get_by_uuid\u0027,"},{"line_number":347,"context_line":"                    vdi[\u0027vdi_uuid\u0027])"},{"line_number":348,"context_line":"            VMHelper.create_vbd(session\u003dself._session, vm_ref\u003dvm_ref,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F8fU%3D","side":"PARENT","line":345,"in_reply_to":"AAAACX%2F%2F8xA%3D","updated":"2011-10-13 21:19:33.000000000","message":"Good question. I was thinking that we\u0027d just ditch swap vhd\u0027s altogether so it wouldn\u0027t matter. That said, it might not be a bad idea to go ahead and make this as fool-proof as possible.","commit_id":"56be39aedb195576179e73c859db2271a9585496"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"a2b03324f69f8d73fbd9990f27d5ea00a2ab62e6","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        if spawn_error.args:"},{"line_number":447,"context_line":"            last_arg \u003d spawn_error.args[-1]"},{"line_number":448,"context_line":"            resources \u003d last_arg"},{"line_number":449,"context_line":"        if vdis:"},{"line_number":450,"context_line":"            for vdi in vdis:"},{"line_number":451,"context_line":"                resources.append(dict(vdi_type\u003dvdi[\u0027vdi_type\u0027],"},{"line_number":452,"context_line":"                                      vdi_uuid\u003dvdi[\u0027vdi_uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F8w8%3D","side":"PARENT","line":449,"updated":"2011-10-13 01:15:07.000000000","message":"What was going on here that this needed to change?","commit_id":"56be39aedb195576179e73c859db2271a9585496"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"1d0a33131bb2367a28633b9b539c03a74162993f","unresolved":false,"context_lines":[{"line_number":446,"context_line":"        if spawn_error.args:"},{"line_number":447,"context_line":"            last_arg \u003d spawn_error.args[-1]"},{"line_number":448,"context_line":"            resources \u003d last_arg"},{"line_number":449,"context_line":"        if vdis:"},{"line_number":450,"context_line":"            for vdi in vdis:"},{"line_number":451,"context_line":"                resources.append(dict(vdi_type\u003dvdi[\u0027vdi_type\u0027],"},{"line_number":452,"context_line":"                                      vdi_uuid\u003dvdi[\u0027vdi_uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F8fM%3D","side":"PARENT","line":449,"in_reply_to":"AAAACX%2F%2F8w8%3D","updated":"2011-10-13 21:19:33.000000000","message":"An exception was being raised and then caught by _handle_spawn_error. The problem was that the last_arg of the exception wasn\u0027t a list, which caused the rest of the handle_spawn_error code to blow up. (I can\u0027t remember what the last_arg was besides a list, but it seemed reasonable, so I decided that the handler code--not the exception-- was broken).\n\nLooking around, I noticed a similar pattern was used elsewhere (see _create_vm), but it had the isinstance(last_arg, list) guard, so I cargo-culted that over and it fixed the issue.","commit_id":"56be39aedb195576179e73c859db2271a9585496"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"43fac828ff32d064e45a2c7b94b83dd8c7b2f6f7","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            VMHelper.generate_swap(session\u003dself._session, instance\u003dinstance,"},{"line_number":352,"context_line":"                                   vm_ref\u003dvm_ref, userdevice\u003duserdevice,"},{"line_number":353,"context_line":"                                   swap_mb\u003dswap_mb)"},{"line_number":354,"context_line":"            userdevice +\u003d 1"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        # Attach any other disks"},{"line_number":357,"context_line":"        for vdi in vdis[1:]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F8e4%3D","line":354,"updated":"2011-10-13 21:54:56.000000000","message":"Having looked through the way things currently work, it looks like, if the image is an ISO image, swap ends up being VBD 3, whereas, for all other image types, it ends up being VBD 2.  Is this something we should strongly consider making consistent?  There, I\u0027m not sure...","commit_id":"1f150e696fc8a684edff2a60f4eb3738eee3aceb"}]}