)]}'
{"id":"openstack%2Fnova~830602","triplet_id":"openstack%2Fnova~stable%2Fqueens~I334f2a4b1c3dbec2ef82e6f4a2083e07c8aa7a2e","project":"openstack/nova","branch":"stable/queens","attention_set":{},"removed_from_attention_set":{"29074":{"account":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"last_update":"2022-02-23 15:09:28.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I334f2a4b1c3dbec2ef82e6f4a2083e07c8aa7a2e","subject":"Gracefull recovery when attaching volume fails","status":"ABANDONED","created":"2022-02-23 13:04:19.000000000","updated":"2022-02-23 15:09:28.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7e4a3ae4b6588893102823823e7c222ed03d294f","_number":830602,"virtual_id_number":830602,"owner":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2022-02-23 15:03:08.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-23 14:17:55.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-02-23 15:03:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6ae823286b9baf254a97a759e5aee10ef755f1b0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"date":"2022-02-23 13:04:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8929b2254f514b86986354608b83cba8b6d86476","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-02-23 14:17:55.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/02/830602/1/check/tempest-dsvm-full-xenial/c8c30ee/ : FAILURE in 33m 04s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/02/830602/1/check/tempest-dsvm-full-xenial-py3/845ee8e/ : FAILURE in 28m 10s","accounts_in_message":[],"_revision_number":1},{"id":"9a550d9d0caa3637a1e1057f62d83a9f7b010758","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-23 15:03:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d35f74ee636345deb241dce4fc60cb71 : SUCCESS in 8m 57s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/41d7cb0b6aa74d91935de0de5af2beeb : SUCCESS in 12m 09s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/df7454620b5240299469e04465bc6108 : SUCCESS in 14m 03s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/f54cb9d21ce64afd932da41ed1dbde35 : FAILURE in 6m 48s\n- tempest-full https://zuul.opendev.org/t/openstack/build/3a40a3c9856f4550b278841d158dd899 : SUCCESS in 1h 09m 25s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/44796516b64e4a3188fe50f1b95caa37 : SUCCESS in 39m 06s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/399b0ed7aa93477eb38f331e5f77c364 : SUCCESS in 1h 24m 26s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3392cdbb87b04db4a7ba017250d7c67d : SUCCESS in 21m 16s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/ea545b4ca70a48a9b5e84244a53715db : SUCCESS in 35m 32s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/e470f2f6da4147ca8f2cff692f1e2893 : SUCCESS in 46m 18s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/8d214ad4a7fc4584bfbcf8d3e1398899 : SUCCESS in 44m 33s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/3844e91426114079aa1af3a5bc057542 : SUCCESS in 48m 15s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/c4c15e364e334a508777f55b44194a26 : SUCCESS in 51m 32s\n- nova-next https://zuul.opendev.org/t/openstack/build/e6fa373d15614dd3acc8d45a82e6a7b9 : SUCCESS in 1h 08m 41s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/f741fd8bf1544811a10256d0e6ff97f1 : SUCCESS in 1h 54m 26s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/274848999ca04eceb5f98105dfb3acc6 : SUCCESS in 20m 42s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/747e6cb78de6475a8186e59356c9de98 : SUCCESS in 26m 37s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/ebf5507ad3ef48b49394cd465b811ab2 : SUCCESS in 1h 09m 30s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/2a2ee53e281e43b5b5c1ef2eaeeaa0db : SUCCESS in 1h 14m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"7e4a3ae4b6588893102823823e7c222ed03d294f","tag":"autogenerated:gerrit:abandon","author":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"date":"2022-02-23 15:09:28.000000000","message":"Abandoned\n\nthis change was never intended","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5bcc686cade972c614999b3240ee6962e5136b27","revisions":{"5bcc686cade972c614999b3240ee6962e5136b27":{"kind":"REWORK","_number":1,"created":"2022-02-23 13:04:19.000000000","uploader":{"_account_id":29074,"name":"Felix Huettner","email":"felix.huettner@digits.schwarz","username":"felix.huettner"},"ref":"refs/changes/02/830602/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/02/830602/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/830602/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/830602/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/02/830602/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/02/830602/1"}}},"commit":{"parents":[{"commit":"9cd02d3967c4f7984102edaa2e4870441c562fb0","subject":"Merge \"[neutron] Get only ID and name of the SGs from Neutron\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9cd02d3967c4f7984102edaa2e4870441c562fb0"}]}],"author":{"name":"Felix Huettner","email":"felix.huettner@mail.schwarz","date":"2022-02-09 11:03:15.000000000","tz":60},"committer":{"name":"Felix Huettner","email":"felix.huettner@mail.schwarz","date":"2022-02-23 13:02:20.000000000","tz":60},"subject":"Gracefull recovery when attaching volume fails","message":"Gracefull recovery when attaching volume fails\n\nWhen trying to attach a volume to an already running instance the nova-api\nrequests the nova-compute service to create a BlockDeviceMapping. If the\nnova-api does not receive a response within `rpc_response_timeout` it will\ntreat the request as failed and raise an exception.\n\nThere are multiple cases where nova-compute actually already processed the\nrequest and just the reply did not reach the nova-api in time (see bug report).\nAfter the failed request the database will contain a BlockDeviceMapping entry\nfor the volume + instance combination that will never be cleaned up again.\nThis entry also causes the nova-api to reject all future attachments of this\nvolume to this instance (as it assumes it is already attached).\n\nTo work around this we check if a BlockDeviceMapping has already been created\nwhen we see a messaging timeout. If this is the case we can safely delete it\nas the compute node has already finished processing and we will no longer pick\nit up.\nThis allows users to try the request again.\n\nA previous fix was abandoned but without a clear reason ([1]).\n\n[1]: https://review.opendev.org/c/openstack/nova/+/731804\n\nCloses-Bug: 1960401\nChange-Id: I17f4d7d2cb129c4ec1479cc4e5d723da75d3a527\n(cherry picked from commit 9eb116b99ce32bc69c4abf8ec3b0179ef89a8860)\n\nDepends-on: Ibd32d30aacae65702d0ccbdb8a02b1667ec4e8ee\nChange-Id: I334f2a4b1c3dbec2ef82e6f4a2083e07c8aa7a2e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5bcc686cade972c614999b3240ee6962e5136b27"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5bcc686cade972c614999b3240ee6962e5136b27"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
