)]}'
{"id":"openstack%2Fnova~830649","triplet_id":"openstack%2Fnova~master~I30a667ee3d489d148812980030b078c2b32f40bb","project":"openstack/nova","branch":"master","topic":"bp/virtual-iommu-support","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2024-04-26 17:17:26.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I30a667ee3d489d148812980030b078c2b32f40bb","subject":"WIP: libvirt: Remove handling for older libvirt versions","status":"ABANDONED","created":"2022-02-23 16:17:31.000000000","updated":"2024-04-26 17:17:26.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"862ec65307bf8cc403fef2b16e0bb44c86df8e5b","_number":830649,"virtual_id_number":830649,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2022-02-23 17:31:19.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-02-23 16:46:46.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2022-02-23 16:47:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-02-23 17:02:51.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-02-23 17:31:19.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-02-23 20:26:12.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"}],"messages":[{"id":"64cf9503e813732e9f5a351df375703badd43b22","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-02-23 16:17:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dc196f629eff190fec3e38fa2bd2d65e70533386","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2022-02-23 16:46:46.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/830649/1/iscsi : FAILURE in 16m 48s","accounts_in_message":[],"_revision_number":1},{"id":"c422b69b09f0e31eb179cfc0b00adb65c0aacd53","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-23 16:47:35.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/67f09233c0624a71b4c6a7c334473d0d : FAILURE in 11m 33s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/8c44d716d0ce4fa0be68d0ec86a6a32a : FAILURE in 13m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8ab0c0307c7c8f6c1a7ad567dc2ca00cdcd0dd3b","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2022-02-23 17:02:51.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* openstack-sriov-nova-master-direct http://13.74.249.42/refs/changes/49/830649/1/openstack-sriov-nova-master-direct : ABORTED\n\n* openstack-sriov-nova-master-macvtap http://13.74.249.42/refs/changes/49/830649/1/openstack-sriov-nova-master-macvtap : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"38cc1ebd889558fe51d925279590cc4b1d685d6d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-02-23 17:31:19.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/2ec7947116564a4aa0ce7eb447b9984f : FAILURE in 44m 20s\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/f95987bf46dd4c729df13012a3cf1f0e : FAILURE in 52m 49s (non-voting)\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/c6fbdcee274e4a40b8238b9ff8330242 : FAILURE in 53m 52s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b0e6d93b89684edfb50bd1ff57c2a0fe : FAILURE in 7m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f11172e5a11743bd8a9c90fe8489b40d : FAILURE in 7m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7a6ff652824d4d1db404a296826eaa97 : SUCCESS in 12m 06s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/db173ef986424382a3a6c7b54c5c84f1 : FAILURE in 7m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4d80f8ef7cb643c8b869d9c7a487eb70 : FAILURE in 9m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a547f9f16f9484e8f9c6aa47c651647 : SUCCESS in 10m 00s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/5eab7a687ee04dd1866e12456b0b1f4a : SUCCESS in 1h 06m 13s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/6dbc9f0da45f49c2a46e9562663ff5d7 : FAILURE in 58m 45s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/5f6cb9d5210c413b87bc0c923dee53a9 : POST_FAILURE in 59m 56s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/b24daac586214a028ee3605ebabe84fa : POST_FAILURE in 58m 38s (non-voting)\n- nova-lvm https://zuul.opendev.org/t/openstack/build/3605d9408b5b4bda93d04eebfac25432 : FAILURE in 32m 36s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/a3b349407477401fa8e8f0bde07ec444 : FAILURE in 1h 00m 46s\n- nova-next https://zuul.opendev.org/t/openstack/build/a15b03f016064376972573e7b6f45463 : POST_FAILURE in 1h 01m 57s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/3335ff9345e44ece8a208c4132be44f6 : POST_FAILURE in 40m 45s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/885614d6d467478b9d8649d09c8ad0ae : SUCCESS in 7m 01s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/45bc69eaa09e47988ba8090ed3967b4e : FAILURE in 20m 58s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/16cb04fcadae4b4e8abcd09141b91115 : FAILURE in 22m 37s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a395297efad54e729bfc32c35793b0b2 : FAILURE in 22m 37s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/375c063f19bf47aaa27173a05caec202 : FAILURE in 44m 53s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/787584656a7e46d0bd6fc5b25abe56e2 : FAILURE in 34m 14s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/dec948c3fbbe47a88893e1463781891f : FAILURE in 39m 16s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/8501eff4d7bc4bf696fffc36e25ab47d : FAILURE in 39m 35s (non-voting)\n- tempest-centos8-stream-fips https://zuul.opendev.org/t/openstack/build/9d948b0acb594cb4a8917f6a256626b0 : FAILURE in 57m 58s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1d105f17a0b8800b21c5d31dd346b3cf595fc6e8","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-02-23 20:26:12.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/49/830649/1/check/tempest-dsvm-full-focal-py3/4352142/ : FAILURE in 2h 26m 35s","accounts_in_message":[],"_revision_number":1},{"id":"5f089703ccc7e7ddc023a4f5354e843fe7ac870c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2022-02-23 21:00:28.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* openstack-sriov-nova-master-direct http://13.74.249.42/refs/changes/49/830649/1/openstack-sriov-nova-master-direct : ABORTED\n\n* openstack-sriov-nova-master-macvtap http://13.74.249.42/refs/changes/49/830649/1/openstack-sriov-nova-master-macvtap : ABORTED","accounts_in_message":[],"_revision_number":1},{"id":"862ec65307bf8cc403fef2b16e0bb44c86df8e5b","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2024-04-26 17:17:26.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"84a4dbae9ae405d322ba4f78c14d4140b08c7300","revisions":{"84a4dbae9ae405d322ba4f78c14d4140b08c7300":{"kind":"REWORK","_number":1,"created":"2022-02-23 16:17:31.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/49/830649/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/49/830649/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/49/830649/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/49/830649/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/49/830649/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/49/830649/1"}}},"commit":{"parents":[{"commit":"face0c5c317311f940d3f1acb30acc64ac706129","subject":"libvirt: Shuffle methods around","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/face0c5c317311f940d3f1acb30acc64ac706129"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2022-02-23 16:14:20.000000000","tz":0},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2022-02-23 16:16:54.000000000","tz":0},"subject":"WIP: libvirt: Remove handling for older libvirt versions","message":"WIP: libvirt: Remove handling for older libvirt versions\n\nThe \u0027Guest.delete_configuration\u0027 method was handling the absence of the\n\u0027virDomainUndefineFlags\u0027 libvirt API. However, this was introduced in\nlibvirt commit b26a9fa9c226447e5f1153fb59eea4b92b848178 (\"undefine:\nDefine the new API\") and was released in libvirt v0.9.4, while the\n\u0027VIR_DOMAIN_UNDEFINE_NVRAM\u0027 flag was introduced in libvirt commit\n273b6581ca8dae11e6ff40e3d13813fdbb37d41b (\"virDomainUndefineFlags: Allow\nNVRAM unlinking\") and was released in libvirt v1.2.9. We don\u0027t need to\nhandle the absence of either.\n\nSimilarly, the \u0027Guest.get_job_info\u0027 method was handling the absence of\nthe \u0027virDomainGetJobStats\u0027 API. However, this was introduced in libvirt\ncommit 4dd00f4238df262092550d533496bbf0bc7522a2 (\"Introduce\nvirDomainGetJobStats API\") from v1.0.3. We don\u0027t need to handle this\nbeing missing either.\n\nWIP cos tests.\n\nChange-Id: I30a667ee3d489d148812980030b078c2b32f40bb\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/84a4dbae9ae405d322ba4f78c14d4140b08c7300"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/84a4dbae9ae405d322ba4f78c14d4140b08c7300"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}