)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b73e0738ccfbe3f82a8e8294185501e8f501fe4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e834764_ddda78ee","updated":"2022-02-28 12:18:07.000000000","message":"+1 typo inline but the clean ups look good overall","commit_id":"611655c752c49973f45915f38619aeee1f3bf70d"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"2b3a8e6a696846c04383f4a1b4e77a1961152219","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8a81a3d0_1a973fcf","updated":"2022-03-07 14:25:24.000000000","message":"LGTM","commit_id":"5505b6f438853a6c738f7192479edd8a0318284f"}],"nova/limit/placement.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b73e0738ccfbe3f82a8e8294185501e8f501fe4","unresolved":true,"context_lines":[{"line_number":56,"context_line":") -\u003e ty.Dict[str, int]:"},{"line_number":57,"context_line":"    \"\"\"Called by oslo_limit\u0027s enforcer\"\"\""},{"line_number":58,"context_line":"    if not limit_utils.use_unified_limits():"},{"line_number":59,"context_line":"        raise NotImplementedError(\"Unified limits support is disabled\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    count_servers \u003d False"},{"line_number":62,"context_line":"    resource_classes \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ceb71fc_a8c4e394","line":59,"updated":"2022-02-28 12:18:07.000000000","message":"this is just to prevent use calling this code accidentally without guarding it behind the config value right.","commit_id":"611655c752c49973f45915f38619aeee1f3bf70d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"58f0240c44ce78b5096fbf8d9dd22cd8b90c222d","unresolved":true,"context_lines":[{"line_number":56,"context_line":") -\u003e ty.Dict[str, int]:"},{"line_number":57,"context_line":"    \"\"\"Called by oslo_limit\u0027s enforcer\"\"\""},{"line_number":58,"context_line":"    if not limit_utils.use_unified_limits():"},{"line_number":59,"context_line":"        raise NotImplementedError(\"Unified limits support is disabled\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    count_servers \u003d False"},{"line_number":62,"context_line":"    resource_classes \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"73ba142b_60097892","line":59,"in_reply_to":"6ceb71fc_a8c4e394","updated":"2022-03-04 03:46:37.000000000","message":"I believe so.","commit_id":"611655c752c49973f45915f38619aeee1f3bf70d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"512b25403b24463aab044b29642ac22d12468fe0","unresolved":false,"context_lines":[{"line_number":56,"context_line":") -\u003e ty.Dict[str, int]:"},{"line_number":57,"context_line":"    \"\"\"Called by oslo_limit\u0027s enforcer\"\"\""},{"line_number":58,"context_line":"    if not limit_utils.use_unified_limits():"},{"line_number":59,"context_line":"        raise NotImplementedError(\"Unified limits support is disabled\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    count_servers \u003d False"},{"line_number":62,"context_line":"    resource_classes \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"74bf98f9_d0b6cb2d","line":59,"in_reply_to":"73ba142b_60097892","updated":"2022-03-04 12:31:29.000000000","message":"Ack","commit_id":"611655c752c49973f45915f38619aeee1f3bf70d"}],"nova/quota.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b73e0738ccfbe3f82a8e8294185501e8f501fe4","unresolved":true,"context_lines":[{"line_number":1254,"context_line":"    queued_for_delete tells us whether or not we should count them for instance"},{"line_number":1255,"context_line":"    quota usage. The user_id field enables us to scope instance quota usage to"},{"line_number":1256,"context_line":"    a user (legacy quota)."},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    Scoping instance quota to a user is only possible"},{"line_number":1259,"context_line":"    when counting quota usage from placement is configured and unified limits"},{"line_number":1260,"context_line":"    is not configured. WHen unified limits is configured, quotas are scoped"}],"source_content_type":"text/x-python","patch_set":2,"id":"b6a7b408_1f4be9a6","line":1257,"updated":"2022-02-28 12:18:07.000000000","message":"checking if they are populated is really just to catch the case where people have not run the migrations right.","commit_id":"611655c752c49973f45915f38619aeee1f3bf70d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"58f0240c44ce78b5096fbf8d9dd22cd8b90c222d","unresolved":true,"context_lines":[{"line_number":1254,"context_line":"    queued_for_delete tells us whether or not we should count them for instance"},{"line_number":1255,"context_line":"    quota usage. The user_id field enables us to scope instance quota usage to"},{"line_number":1256,"context_line":"    a user (legacy quota)."},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    Scoping instance quota to a user is only possible"},{"line_number":1259,"context_line":"    when counting quota usage from placement is configured and unified limits"},{"line_number":1260,"context_line":"    is not configured. WHen unified limits is configured, quotas are scoped"}],"source_content_type":"text/x-python","patch_set":2,"id":"d627ed87_ebcc764b","line":1257,"in_reply_to":"b6a7b408_1f4be9a6","updated":"2022-03-04 03:46:37.000000000","message":"Yes that\u0027s right.","commit_id":"611655c752c49973f45915f38619aeee1f3bf70d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"512b25403b24463aab044b29642ac22d12468fe0","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"    queued_for_delete tells us whether or not we should count them for instance"},{"line_number":1255,"context_line":"    quota usage. The user_id field enables us to scope instance quota usage to"},{"line_number":1256,"context_line":"    a user (legacy quota)."},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    Scoping instance quota to a user is only possible"},{"line_number":1259,"context_line":"    when counting quota usage from placement is configured and unified limits"},{"line_number":1260,"context_line":"    is not configured. WHen unified limits is configured, quotas are scoped"}],"source_content_type":"text/x-python","patch_set":2,"id":"ab52c652_3d60c63c","line":1257,"in_reply_to":"d627ed87_ebcc764b","updated":"2022-03-04 12:31:29.000000000","message":"Ack","commit_id":"611655c752c49973f45915f38619aeee1f3bf70d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b73e0738ccfbe3f82a8e8294185501e8f501fe4","unresolved":true,"context_lines":[{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    Scoping instance quota to a user is only possible"},{"line_number":1259,"context_line":"    when counting quota usage from placement is configured and unified limits"},{"line_number":1260,"context_line":"    is not configured. WHen unified limits is configured, quotas are scoped"},{"line_number":1261,"context_line":"    only to projects."},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"    In the future when it is possible to count instance usage from placement,"}],"source_content_type":"text/x-python","patch_set":2,"id":"98123e29_a882f4c3","line":1260,"range":{"start_line":1260,"start_character":23,"end_line":1260,"end_character":27},"updated":"2022-02-28 12:18:07.000000000","message":"nit When","commit_id":"611655c752c49973f45915f38619aeee1f3bf70d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"58f0240c44ce78b5096fbf8d9dd22cd8b90c222d","unresolved":false,"context_lines":[{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"    Scoping instance quota to a user is only possible"},{"line_number":1259,"context_line":"    when counting quota usage from placement is configured and unified limits"},{"line_number":1260,"context_line":"    is not configured. WHen unified limits is configured, quotas are scoped"},{"line_number":1261,"context_line":"    only to projects."},{"line_number":1262,"context_line":""},{"line_number":1263,"context_line":"    In the future when it is possible to count instance usage from placement,"}],"source_content_type":"text/x-python","patch_set":2,"id":"02213934_eee77ba9","line":1260,"range":{"start_line":1260,"start_character":23,"end_line":1260,"end_character":27},"in_reply_to":"98123e29_a882f4c3","updated":"2022-03-04 03:46:37.000000000","message":"Done","commit_id":"611655c752c49973f45915f38619aeee1f3bf70d"}]}