)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4cf184a510ff4293b9b95806df512faa200ce163","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fa5d0256_eca4ce65","updated":"2022-03-21 14:44:51.000000000","message":"Pretty close, just a few extra cases for test coverage and I think we\u0027ll be good.","commit_id":"938cb17f754f76c850c1e36f1613de912a78dea7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"29c58fac0de0821457ab4db3c0c233a8c8327179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"83ce5e7f_e802cd82","updated":"2022-03-23 11:00:31.000000000","message":"Thanks Dan","commit_id":"44b8d65e9891ceb67c6168cc4d1755a4a0e48a5a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"978ea943be12aa383e39ad097d349962fe7985d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"337d8457_271fcff8","updated":"2022-03-24 04:15:57.000000000","message":"recheck\n\nFailure in cover job for unrelated compute test\n\nnova.tests.unit.compute.test_virtapi.ComputeVirtAPITest.test_wait_for_instance_event_one_received_one_timed_out\n\nAssertionError: expected call not found.\nExpected: warning(\u0027Timeout waiting for %(events)s for instance with vm_state %(vm_state)s and task_state %(task_state)s. Event states are: %(event_states)s\u0027, {\u0027events\u0027: [\u0027foo-bar\u0027, \u0027missing-event\u0027], \u0027vm_state\u0027: sentinel.vm_state, \u0027task_state\u0027: sentinel.task_state, \u0027event_states\u0027: \u0027foo-bar: received after waiting 0.00 seconds, missing-event: timed out after 0.00 seconds\u0027}, instance\u003d\u003cMock name\u003d\u0027mock.instance\u0027 id\u003d\u0027140576361786240\u0027\u003e)\nActual: warning(\u0027Timeout waiting for %(events)s for instance with vm_state %(vm_state)s and task_state %(task_state)s. Event states are: %(event_states)s\u0027, {\u0027events\u0027: [\u0027foo-bar\u0027, \u0027missing-event\u0027], \u0027vm_state\u0027: sentinel.vm_state, \u0027task_state\u0027: sentinel.task_state, \u0027event_states\u0027: \u0027foo-bar: received after waiting 0.00 seconds, missing-event: timed out after 0.51 seconds\u0027}, instance\u003d\u003cMock name\u003d\u0027mock.instance\u0027 id\u003d\u0027140576361786240\u0027\u003e)","commit_id":"44b8d65e9891ceb67c6168cc4d1755a4a0e48a5a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"438e58688d1f96bb9f50e47e14f7f2c877e1716a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"558121cf_d22ec1ce","updated":"2022-08-26 09:49:43.000000000","message":"i think this patch is more or less ok\nbut the way you create the instance in the tests just feels a little odd","commit_id":"ab67fbd564fe94bf502f4f8ab520ce7061144ca1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4b8c280fdbc7f02de1c78f96eacaa968ef7d04fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"3bc716bb_06d7c06d","updated":"2022-08-29 08:59:02.000000000","message":"this looks OK to me.","commit_id":"bc3462a254f5d943ac89c69d09e1539b6f339448"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"457c8e22cfc67827cd39e5d59a0edc7f80e746d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"2186c2e5_f6c9a861","updated":"2022-08-31 10:11:15.000000000","message":"Easy patch just touching the RPC interfaces.","commit_id":"0fe6e196beec747b7b978c84f25f6a0c8beae81f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dd9d3b9783ec73b4bffae5a169dd3ca3ec32deb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7dc85459_ac9099fc","updated":"2022-08-29 21:34:12.000000000","message":"recheck nova-next job subnode lost contact with placement for a big chunk of the middle of the test run","commit_id":"0fe6e196beec747b7b978c84f25f6a0c8beae81f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3ed6e4b5cd35c4c6891b27060eaf706d2dba6673","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"fb60ac44_913a84e9","updated":"2022-08-30 14:57:34.000000000","message":"this looks fine to me too","commit_id":"0fe6e196beec747b7b978c84f25f6a0c8beae81f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c67d73c65d516d9e7ea12563bae7f99cab69a12c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"dd774941_246b071f","updated":"2022-09-01 04:00:41.000000000","message":"recheck\n\nbase patch failed zuul","commit_id":"6919db561280874d18fdf61b6750e0c765e0f632"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10b49c41ce7f8488cba820daa6df01e59de06041","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"79fc2179_57080b54","updated":"2022-08-31 20:14:58.000000000","message":"recheck\n\nhttps://review.opendev.org/c/openstack/nova/+/855378 merged","commit_id":"6919db561280874d18fdf61b6750e0c765e0f632"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"672afd3560d94eb04348364854b697cb6c4be39e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"1c91c80d_077661f6","updated":"2022-08-31 16:42:08.000000000","message":"recheck\n\nnova-multi-cell seems to be failing a lot\nfailure in test test_unshelve_to_specific_host","commit_id":"6919db561280874d18fdf61b6750e0c765e0f632"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0134808879b65f2a08f8336b3b850fe093577019","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"250b1261_d96ee060","updated":"2022-08-31 14:03:53.000000000","message":"recheck unshelve failure","commit_id":"6919db561280874d18fdf61b6750e0c765e0f632"}],"nova/conductor/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4b8c280fdbc7f02de1c78f96eacaa968ef7d04fc","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"                limits\u003dlimits,"},{"line_number":1345,"context_line":"                request_spec\u003drequest_spec,"},{"line_number":1346,"context_line":"                accel_uuids\u003daccel_uuids,"},{"line_number":1347,"context_line":"                reimage_boot_volume\u003dreimage_boot_volume)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"    def _validate_image_traits_for_rebuild(self, context, instance, image_ref):"},{"line_number":1350,"context_line":"        \"\"\"Validates that the traits specified in the image can be satisfied"}],"source_content_type":"text/x-python","patch_set":20,"id":"6d88d922_df609896","line":1347,"updated":"2022-08-29 08:59:02.000000000","message":"Ahh OK.","commit_id":"bc3462a254f5d943ac89c69d09e1539b6f339448"}],"nova/conductor/rpcapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4cf184a510ff4293b9b95806df512faa200ce163","unresolved":true,"context_lines":[{"line_number":444,"context_line":"              \u0027request_spec\u0027: request_spec,"},{"line_number":445,"context_line":"              \u0027reimage_boot_volume\u0027: reimage_boot_volume"},{"line_number":446,"context_line":"              }"},{"line_number":447,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":448,"context_line":"            version \u003d \u00271.12\u0027"},{"line_number":449,"context_line":"            del kw[\u0027reimage_boot_volume\u0027]"},{"line_number":450,"context_line":"        if not self.client.can_send_version(version):"}],"source_content_type":"text/x-python","patch_set":11,"id":"738b97af_485b5db3","line":447,"updated":"2022-03-21 14:44:51.000000000","message":"We need the same \"if True, raise\" check here, like compute, right?","commit_id":"938cb17f754f76c850c1e36f1613de912a78dea7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"29c58fac0de0821457ab4db3c0c233a8c8327179","unresolved":false,"context_lines":[{"line_number":444,"context_line":"              \u0027request_spec\u0027: request_spec,"},{"line_number":445,"context_line":"              \u0027reimage_boot_volume\u0027: reimage_boot_volume"},{"line_number":446,"context_line":"              }"},{"line_number":447,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":448,"context_line":"            version \u003d \u00271.12\u0027"},{"line_number":449,"context_line":"            del kw[\u0027reimage_boot_volume\u0027]"},{"line_number":450,"context_line":"        if not self.client.can_send_version(version):"}],"source_content_type":"text/x-python","patch_set":11,"id":"4e52b78a_23031ff5","line":447,"in_reply_to":"738b97af_485b5db3","updated":"2022-03-23 11:00:31.000000000","message":"Yes, I think it makes sense to block it here only however I\u0027m not sure if we will reach the check on compute after that, In any case, i think it\u0027s not harmful there, will update here.","commit_id":"938cb17f754f76c850c1e36f1613de912a78dea7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"457c8e22cfc67827cd39e5d59a0edc7f80e746d2","unresolved":true,"context_lines":[{"line_number":448,"context_line":"            if kw[\u0027reimage_boot_volume\u0027]:"},{"line_number":449,"context_line":"                raise exception.NovaException("},{"line_number":450,"context_line":"                    \u0027Conductor RPC version does not support \u0027"},{"line_number":451,"context_line":"                    \u0027reimage_boot_volume parameter.\u0027)"},{"line_number":452,"context_line":"            else:"},{"line_number":453,"context_line":"                del kw[\u0027reimage_boot_volume\u0027]"},{"line_number":454,"context_line":"            version \u003d \u00271.12\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"664bfc73_4a46c44f","line":451,"updated":"2022-08-31 10:11:15.000000000","message":"same point here, you\u0027re a bit conservative but OK.","commit_id":"0fe6e196beec747b7b978c84f25f6a0c8beae81f"}],"nova/tests/functional/api_sample_tests/test_evacuate.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4cf184a510ff4293b9b95806df512faa200ce163","unresolved":true,"context_lines":[{"line_number":80,"context_line":"                orig_sys_metadata\u003dmock.ANY, bdms\u003dmock.ANY, recreate\u003dmock.ANY,"},{"line_number":81,"context_line":"                on_shared_storage\u003dFalse, preserve_ephemeral\u003dmock.ANY,"},{"line_number":82,"context_line":"                host\u003d\u0027testHost\u0027, request_spec\u003dmock.ANY,"},{"line_number":83,"context_line":"                reimage_boot_volume\u003dmock.ANY)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @mock.patch(\u0027nova.conductor.manager.ComputeTaskManager.rebuild_instance\u0027)"},{"line_number":86,"context_line":"    def test_server_evacuate_find_host(self, rebuild_mock):"}],"source_content_type":"text/x-python","patch_set":11,"id":"10100fcd_f265b364","line":83,"range":{"start_line":83,"start_character":36,"end_line":83,"end_character":44},"updated":"2022-03-21 14:44:51.000000000","message":"I see that the behavior here is not great and we\u0027re not verifying a lot of our values. However, since your new parameter can lead to data loss if it doesn\u0027t default properly to False, I think we should have at least one case where we confirm that it does. I dunno if it\u0027s best to deviate here, or just write a new quick test, but I think we should validate it some way.","commit_id":"938cb17f754f76c850c1e36f1613de912a78dea7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"29c58fac0de0821457ab4db3c0c233a8c8327179","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                orig_sys_metadata\u003dmock.ANY, bdms\u003dmock.ANY, recreate\u003dmock.ANY,"},{"line_number":81,"context_line":"                on_shared_storage\u003dFalse, preserve_ephemeral\u003dmock.ANY,"},{"line_number":82,"context_line":"                host\u003d\u0027testHost\u0027, request_spec\u003dmock.ANY,"},{"line_number":83,"context_line":"                reimage_boot_volume\u003dmock.ANY)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @mock.patch(\u0027nova.conductor.manager.ComputeTaskManager.rebuild_instance\u0027)"},{"line_number":86,"context_line":"    def test_server_evacuate_find_host(self, rebuild_mock):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fffdfeb0_335f8abf","line":83,"range":{"start_line":83,"start_character":36,"end_line":83,"end_character":44},"in_reply_to":"10100fcd_f265b364","updated":"2022-03-23 11:00:31.000000000","message":"I understand the concern and will validate it to False here in next PS.","commit_id":"938cb17f754f76c850c1e36f1613de912a78dea7"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4cf184a510ff4293b9b95806df512faa200ce163","unresolved":true,"context_lines":[{"line_number":4769,"context_line":"            kw \u003d {\u0027instance\u0027: inst_obj, **rebuild_args}"},{"line_number":4770,"context_line":"            cctxt_mock.cast.assert_called_once_with("},{"line_number":4771,"context_line":"                self.context, \u0027rebuild_instance\u0027, **kw)"},{"line_number":4772,"context_line":"        _test()"},{"line_number":4773,"context_line":""},{"line_number":4774,"context_line":""},{"line_number":4775,"context_line":"class ConductorTaskAPITestCase(_BaseTaskTestCase, test_compute.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"df25a984_0f4de739","line":4772,"updated":"2022-03-21 14:44:51.000000000","message":"We need checks to validate the compatibility behavior, like the test above you does (for ServiceTooOld).","commit_id":"938cb17f754f76c850c1e36f1613de912a78dea7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"29c58fac0de0821457ab4db3c0c233a8c8327179","unresolved":false,"context_lines":[{"line_number":4769,"context_line":"            kw \u003d {\u0027instance\u0027: inst_obj, **rebuild_args}"},{"line_number":4770,"context_line":"            cctxt_mock.cast.assert_called_once_with("},{"line_number":4771,"context_line":"                self.context, \u0027rebuild_instance\u0027, **kw)"},{"line_number":4772,"context_line":"        _test()"},{"line_number":4773,"context_line":""},{"line_number":4774,"context_line":""},{"line_number":4775,"context_line":"class ConductorTaskAPITestCase(_BaseTaskTestCase, test_compute.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"03bac7b0_ea92a8e3","line":4772,"in_reply_to":"df25a984_0f4de739","updated":"2022-03-23 11:00:31.000000000","message":"Done","commit_id":"938cb17f754f76c850c1e36f1613de912a78dea7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"438e58688d1f96bb9f50e47e14f7f2c877e1716a","unresolved":true,"context_lines":[{"line_number":4749,"context_line":"        can_send_version.assert_called_once_with(\u00271.23\u0027)"},{"line_number":4750,"context_line":""},{"line_number":4751,"context_line":"    def test_rebuild_instance_volume_backed(self):"},{"line_number":4752,"context_line":"        inst \u003d fake_instance.fake_db_instance()"},{"line_number":4753,"context_line":"        inst_obj \u003d objects.Instance._from_db_object("},{"line_number":4754,"context_line":"            self.context, objects.Instance(), inst, [])"},{"line_number":4755,"context_line":"        version \u003d \u00271.24\u0027"},{"line_number":4756,"context_line":"        cctxt_mock \u003d mock.MagicMock()"},{"line_number":4757,"context_line":"        rebuild_args, compute_args \u003d self._prepare_rebuild_args("}],"source_content_type":"text/x-python","patch_set":17,"id":"7c77435f_9a45e92b","line":4754,"range":{"start_line":4752,"start_character":8,"end_line":4754,"end_character":55},"updated":"2022-08-26 09:49:43.000000000","message":"you cand just do\n\ninst_obj \u003d objects.Instance()\n\nor\n\ninst_obj \u003d self._create_fake_instance_obj()\n\nor\ninst_obj \u003d fake_instance.fake_instance_obj(self.context)\n\n\nwe have a lot of ways to create the instance \n\nwhy are you creating a fake db instnace then converting it?","commit_id":"ab67fbd564fe94bf502f4f8ab520ce7061144ca1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"179f759460813391ded510abe12aa40b5e807353","unresolved":false,"context_lines":[{"line_number":4749,"context_line":"        can_send_version.assert_called_once_with(\u00271.23\u0027)"},{"line_number":4750,"context_line":""},{"line_number":4751,"context_line":"    def test_rebuild_instance_volume_backed(self):"},{"line_number":4752,"context_line":"        inst \u003d fake_instance.fake_db_instance()"},{"line_number":4753,"context_line":"        inst_obj \u003d objects.Instance._from_db_object("},{"line_number":4754,"context_line":"            self.context, objects.Instance(), inst, [])"},{"line_number":4755,"context_line":"        version \u003d \u00271.24\u0027"},{"line_number":4756,"context_line":"        cctxt_mock \u003d mock.MagicMock()"},{"line_number":4757,"context_line":"        rebuild_args, compute_args \u003d self._prepare_rebuild_args("}],"source_content_type":"text/x-python","patch_set":17,"id":"8d981ca0_6def0018","line":4754,"range":{"start_line":4752,"start_character":8,"end_line":4754,"end_character":55},"in_reply_to":"7c77435f_9a45e92b","updated":"2022-08-26 21:01:43.000000000","message":"Done","commit_id":"ab67fbd564fe94bf502f4f8ab520ce7061144ca1"}]}