)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c1ca199727c358e06f72ffbb75a8ba34f2e70066","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the PCI device capability dict creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"VPD handling was added in ab49f97b2c08294234c7bfd3dedb75780ca519e6 and"},{"line_number":10,"context_line":"introduced a regression which was not caught by unit or functional"},{"line_number":11,"context_line":"tests: if a VPD capability is present for a PCI device, it overrides"},{"line_number":12,"context_line":"the network capabilities obtained from the associated netdev."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"af73ad86_bff00e0f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":3},"updated":"2022-03-16 18:39:09.000000000","message":"just realised this is about VPD not VDPA... but the reasoning is the same\nwe should fix this but it should not break anyone since we currently never read the network capablities.\n\neventually we should report pci devices to placemnt and we should translate the network capablities to traits so we should still fix this so that we dont have to deal with that tech debth in the future.","commit_id":"c3ad968c875ae7fa67e7a1f8d321f1fc622897bc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"46c47247af5591a3878d3b6653d126d0ea1e9f3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0368afc4_819ad328","updated":"2022-04-14 09:02:40.000000000","message":"This looks good to me. The VDP capabilities now collected as part of the overall device capabilities.","commit_id":"c3ad968c875ae7fa67e7a1f8d321f1fc622897bc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c3debaa4ebb55e62e2035b40535c14948a1089f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e2a6e810_6ed2f7df","updated":"2022-03-16 18:34:03.000000000","message":"i agree this is  a valid but but it also raises a question on if we should keep the network\ncapabilities.\n\nthis predates the createion of placment and because of placement we never implemented the second half of the feature.\n\nfor consintancy we should fix this bug but we shoudl consider removing the network capablity entirely in the future.\n\ncurrently there is no code in nova that actully ueses them\nthe intent was too allow neutron to ask for sriov port with specific offloads.\nwhen traits where added to placment we also had plans to translate the data in this table into\ntraits on the RP.\n\nim off until next week so ill review this properly when im back +1 for now for the general direction fo fixing this although the but is not goign to affacte anyone direclty since these capablites are never used.","commit_id":"c3ad968c875ae7fa67e7a1f8d321f1fc622897bc"}]}