)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aff05788c6833d7ecb0e2777cf88922d360d2d48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5736972d_16b0b89b","updated":"2022-04-14 09:06:28.000000000","message":"Thanks for the answers. I keep the -1 for visibility about the agreed rebase on top of https://review.opendev.org/c/openstack/nova/+/834382 but other than that this is looks good to me now.","commit_id":"c308e7199e5fbe0633e2440a788801d2adcb3031"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"8c6c4304784b05f637c9d442c7efb42dfb75d23a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61a0218e_ed40e044","updated":"2022-04-14 13:00:15.000000000","message":"Just a rebase on top of the discussed changes.","commit_id":"2234b179b5202d4d609c1df2c9c999656ca12378"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a71e6f41c7d79f1fffbc8b716adc88ab4a7ef230","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ac92f1c6_3364b20f","updated":"2022-04-29 10:54:15.000000000","message":"its also always nice to see patches that fix/improve things that delete more code then they add :)","commit_id":"2234b179b5202d4d609c1df2c9c999656ca12378"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f804ddf50c69a06817e1c8f632f37a7dc078af36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"315416a2_1126e02a","updated":"2022-04-21 09:36:14.000000000","message":"looks good","commit_id":"2234b179b5202d4d609c1df2c9c999656ca12378"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"93fee7941891382084bdb91c76cbcdc0244a5551","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3676c025_e81ebaee","updated":"2022-04-29 10:53:30.000000000","message":"thanks dimitrii for following up and cleaning this up","commit_id":"2234b179b5202d4d609c1df2c9c999656ca12378"}],"nova/network/neutron.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"235c5476d6316c65cb6ef88832c7439628be91de","unresolved":true,"context_lines":[{"line_number":3669,"context_line":"            return None"},{"line_number":3670,"context_line":"        return device"},{"line_number":3671,"context_line":""},{"line_number":3672,"context_line":"    def _update_port_pci_binding_profile(self, pci_dev, binding_profile):"},{"line_number":3673,"context_line":"        \"\"\"Update the binding profile dict with new PCI device data."},{"line_number":3674,"context_line":""},{"line_number":3675,"context_line":"        :param pci_dev: The PciDevice object to update the profile with."}],"source_content_type":"text/x-python","patch_set":1,"id":"803e90a0_027e6501","line":3672,"updated":"2022-03-20 09:02:28.000000000","message":"The usage of this function can be replaced with the usage of _get_vf_pci_device_profile(). I have a patch for this refactor: https://review.opendev.org/c/openstack/nova/+/834382","commit_id":"c308e7199e5fbe0633e2440a788801d2adcb3031"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"8c6c4304784b05f637c9d442c7efb42dfb75d23a","unresolved":false,"context_lines":[{"line_number":3669,"context_line":"            return None"},{"line_number":3670,"context_line":"        return device"},{"line_number":3671,"context_line":""},{"line_number":3672,"context_line":"    def _update_port_pci_binding_profile(self, pci_dev, binding_profile):"},{"line_number":3673,"context_line":"        \"\"\"Update the binding profile dict with new PCI device data."},{"line_number":3674,"context_line":""},{"line_number":3675,"context_line":"        :param pci_dev: The PciDevice object to update the profile with."}],"source_content_type":"text/x-python","patch_set":1,"id":"1ad4b999_e8c7d194","line":3672,"in_reply_to":"7868416f_f45308a8","updated":"2022-04-14 13:00:15.000000000","message":"Done","commit_id":"c308e7199e5fbe0633e2440a788801d2adcb3031"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"f615d6aa56a0e8c785dd29140d82619b136fded5","unresolved":true,"context_lines":[{"line_number":3669,"context_line":"            return None"},{"line_number":3670,"context_line":"        return device"},{"line_number":3671,"context_line":""},{"line_number":3672,"context_line":"    def _update_port_pci_binding_profile(self, pci_dev, binding_profile):"},{"line_number":3673,"context_line":"        \"\"\"Update the binding profile dict with new PCI device data."},{"line_number":3674,"context_line":""},{"line_number":3675,"context_line":"        :param pci_dev: The PciDevice object to update the profile with."}],"source_content_type":"text/x-python","patch_set":1,"id":"7868416f_f45308a8","line":3672,"in_reply_to":"803e90a0_027e6501","updated":"2022-04-05 14:22:45.000000000","message":"Ack, I\u0027ll rebase on top of it.","commit_id":"c308e7199e5fbe0633e2440a788801d2adcb3031"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"235c5476d6316c65cb6ef88832c7439628be91de","unresolved":true,"context_lines":[{"line_number":295,"context_line":"                \u0027pci_slot\u0027: \u00270000:81:00.2\u0027,"},{"line_number":296,"context_line":"                \u0027physical_network\u0027: \u0027physnet4\u0027,"},{"line_number":297,"context_line":"                \u0027pf_mac_address\u0027: \u002752:54:00:1e:59:c6\u0027,"},{"line_number":298,"context_line":"                \u0027vf_num\u0027: 1,"},{"line_number":299,"context_line":"            },"},{"line_number":300,"context_line":"            port[\u0027binding:profile\u0027],"},{"line_number":301,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5b575d42_730aa3ec","side":"PARENT","line":298,"updated":"2022-03-20 09:02:28.000000000","message":"Why this information is now not provided in the bidining:profile in this test?","commit_id":"c3ad968c875ae7fa67e7a1f8d321f1fc622897bc"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"f615d6aa56a0e8c785dd29140d82619b136fded5","unresolved":true,"context_lines":[{"line_number":295,"context_line":"                \u0027pci_slot\u0027: \u00270000:81:00.2\u0027,"},{"line_number":296,"context_line":"                \u0027physical_network\u0027: \u0027physnet4\u0027,"},{"line_number":297,"context_line":"                \u0027pf_mac_address\u0027: \u002752:54:00:1e:59:c6\u0027,"},{"line_number":298,"context_line":"                \u0027vf_num\u0027: 1,"},{"line_number":299,"context_line":"            },"},{"line_number":300,"context_line":"            port[\u0027binding:profile\u0027],"},{"line_number":301,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3e54336_df1d321f","side":"PARENT","line":298,"in_reply_to":"5b575d42_730aa3ec","updated":"2022-04-05 14:22:45.000000000","message":"For VFs that are not remote-managed this information is not necessary.\n\nThe condition is now more explicit to require all fields instead of adding vf_num and pf_mac_address when a card_serial_number is not present.\n\nhttps://review.opendev.org/c/openstack/nova/+/834006/1/nova/network/neutron.py#1578","commit_id":"c3ad968c875ae7fa67e7a1f8d321f1fc622897bc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aff05788c6833d7ecb0e2777cf88922d360d2d48","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                \u0027pci_slot\u0027: \u00270000:81:00.2\u0027,"},{"line_number":296,"context_line":"                \u0027physical_network\u0027: \u0027physnet4\u0027,"},{"line_number":297,"context_line":"                \u0027pf_mac_address\u0027: \u002752:54:00:1e:59:c6\u0027,"},{"line_number":298,"context_line":"                \u0027vf_num\u0027: 1,"},{"line_number":299,"context_line":"            },"},{"line_number":300,"context_line":"            port[\u0027binding:profile\u0027],"},{"line_number":301,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"250dbd88_2edd5fa2","side":"PARENT","line":298,"in_reply_to":"a3e54336_df1d321f","updated":"2022-04-14 09:06:28.000000000","message":"Ohh. I see. Thanks.","commit_id":"c3ad968c875ae7fa67e7a1f8d321f1fc622897bc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"235c5476d6316c65cb6ef88832c7439628be91de","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                \u0027pci_slot\u0027: \u00270000:81:00.2\u0027,"},{"line_number":574,"context_line":"                \u0027physical_network\u0027: \u0027physnet4\u0027,"},{"line_number":575,"context_line":"                \u0027pf_mac_address\u0027: \u002752:54:00:1e:59:c6\u0027,"},{"line_number":576,"context_line":"                \u0027vf_num\u0027: 1,"},{"line_number":577,"context_line":"            },"},{"line_number":578,"context_line":"            port[\u0027binding:profile\u0027],"},{"line_number":579,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"10d219cb_c7730a22","side":"PARENT","line":576,"updated":"2022-03-20 09:02:28.000000000","message":"ditto","commit_id":"c3ad968c875ae7fa67e7a1f8d321f1fc622897bc"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"f615d6aa56a0e8c785dd29140d82619b136fded5","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                \u0027pci_slot\u0027: \u00270000:81:00.2\u0027,"},{"line_number":574,"context_line":"                \u0027physical_network\u0027: \u0027physnet4\u0027,"},{"line_number":575,"context_line":"                \u0027pf_mac_address\u0027: \u002752:54:00:1e:59:c6\u0027,"},{"line_number":576,"context_line":"                \u0027vf_num\u0027: 1,"},{"line_number":577,"context_line":"            },"},{"line_number":578,"context_line":"            port[\u0027binding:profile\u0027],"},{"line_number":579,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"7e0db654_edcfbc76","side":"PARENT","line":576,"in_reply_to":"10d219cb_c7730a22","updated":"2022-04-05 14:22:45.000000000","message":"For VFs that are not remote-managed this information is not necessary.\n\nThe condition is now more explicit to require all fields instead of adding vf_num and pf_mac_address when a card_serial_number is not present.","commit_id":"c3ad968c875ae7fa67e7a1f8d321f1fc622897bc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aff05788c6833d7ecb0e2777cf88922d360d2d48","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                \u0027pci_slot\u0027: \u00270000:81:00.2\u0027,"},{"line_number":574,"context_line":"                \u0027physical_network\u0027: \u0027physnet4\u0027,"},{"line_number":575,"context_line":"                \u0027pf_mac_address\u0027: \u002752:54:00:1e:59:c6\u0027,"},{"line_number":576,"context_line":"                \u0027vf_num\u0027: 1,"},{"line_number":577,"context_line":"            },"},{"line_number":578,"context_line":"            port[\u0027binding:profile\u0027],"},{"line_number":579,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"90241d2a_fe6f37bf","side":"PARENT","line":576,"in_reply_to":"7e0db654_edcfbc76","updated":"2022-04-14 09:06:28.000000000","message":"Ack","commit_id":"c3ad968c875ae7fa67e7a1f8d321f1fc622897bc"}]}