)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b325dde5e306c4ad564a4a49d0a55d56ed738666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf46f8ff_a1b916bc","updated":"2022-04-05 18:10:01.000000000","message":"This looks legit. Ordinarily we would want to have test coverage to go along with the fix but I see there is no existing testing of this area and could not easily see how to add it. This is also the NoAuthMiddleware which is (1) not used in production and (2) is deprecated for removal in the future [1], so I think it\u0027s OK to go without a test here. If I figure out how to cover it, I will post a followup patch.\n\n[1] https://github.com/openstack/nova/blob/415084c4be680a6b575a11462e53585eb765021c/etc/nova/api-paste.ini#L36","commit_id":"5e6b9a86984b854d0a717cff1c2ac49412ec6f47"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3a0aa1eabda780139a11cd3f542dea1245a88f8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6713b4a5_2b98b4a9","updated":"2022-04-04 04:47:47.000000000","message":"recheck","commit_id":"5e6b9a86984b854d0a717cff1c2ac49412ec6f47"}],"nova/api/openstack/auth.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b325dde5e306c4ad564a4a49d0a55d56ed738666","unresolved":true,"context_lines":[{"line_number":50,"context_line":"        token \u003d req.headers[\u0027X-Auth-Token\u0027]"},{"line_number":51,"context_line":"        user_id, _sep, project_id \u003d token.partition(\u0027:\u0027)"},{"line_number":52,"context_line":"        project_id \u003d project_id or user_id"},{"line_number":53,"context_line":"        remote_address \u003d getattr(req, \u0027remote_addr\u0027, \u0027127.0.0.1\u0027)"},{"line_number":54,"context_line":"        if CONF.api.use_forwarded_for:"},{"line_number":55,"context_line":"            remote_address \u003d req.headers.get(\u0027X-Forwarded-For\u0027, remote_address)"},{"line_number":56,"context_line":"        is_admin \u003d always_admin or (user_id \u003d\u003d \u0027admin\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4608bbbc_bdd79b16","line":53,"updated":"2022-04-05 18:10:01.000000000","message":"This looks correct as shown in the webob.Request docs:\nhttps://docs.pylonsproject.org/projects/webob/en/stable/api/request.html#webob.request.BaseRequest.remote_addr","commit_id":"5e6b9a86984b854d0a717cff1c2ac49412ec6f47"}]}