)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7024da58924591569e0b3a7cc44a4b9998af972b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Deprecate [api] use_forwarded_for"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"... because functionality of this parameter is effectively duplicate of"},{"line_number":10,"context_line":"the HTTPProxyToWSGI middleware in oslo.middleware library."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1967686"},{"line_number":13,"context_line":"Change-Id: Ifebcfb6b5c1594c075bb9c152a06aa7af7c61bc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fabf9802_0c0b0041","line":10,"updated":"2022-04-22 22:18:12.000000000","message":"Note to self: HTTPProxyToWSGI has been around since oslo.middleware 2.9.0 (Newton):\n\nhttps://docs.openstack.org/oslo.middleware/newton/history.html#id22","commit_id":"77cf91ac8a71548910a4ff6444f597b901d4316f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2dabb8b1cc917b619f2d1e9b0e5e69aa6da5c36e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Deprecate [api] use_forwarded_for"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"... because functionality of this parameter is effectively duplicate of"},{"line_number":10,"context_line":"the HTTPProxyToWSGI middleware in oslo.middleware library."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1967686"},{"line_number":13,"context_line":"Change-Id: Ifebcfb6b5c1594c075bb9c152a06aa7af7c61bc8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df22467e_ff6742d3","line":10,"in_reply_to":"fabf9802_0c0b0041","updated":"2022-04-23 16:18:28.000000000","message":"Yes. Also, the middleware was added to compute api pipenline during Newton cycle[1] and has been enabled in the default api-paste.ini.\n\n[1] https://review.opendev.org/c/openstack/nova/+/322630","commit_id":"77cf91ac8a71548910a4ff6444f597b901d4316f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7024da58924591569e0b3a7cc44a4b9998af972b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a1487f37_0126bd5b","updated":"2022-04-22 22:18:12.000000000","message":"Looks legit, just one typo in the release note.","commit_id":"77cf91ac8a71548910a4ff6444f597b901d4316f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e8712251cc61d4fbe2b416b8f0e315f274854245","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"65fe37e2_dc076f8a","updated":"2022-04-12 04:23:47.000000000","message":"recheck","commit_id":"77cf91ac8a71548910a4ff6444f597b901d4316f"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"b3567e0a39a59d240bd421007fbc71f361356e8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3bd15e1_571fc27b","updated":"2022-04-12 01:52:14.000000000","message":"vmware-recheck-patch","commit_id":"77cf91ac8a71548910a4ff6444f597b901d4316f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"df86b34a26fd2fcdb83d1bdf2036f3b9cd2a155b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a301c686_eb390b55","updated":"2022-04-25 15:11:17.000000000","message":"LGTM, thanks","commit_id":"cf906cdcc25c112956f56f9fb9f62b2cfdeacc65"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"80bf5f36ae68da30c0f7202e9333ec65ba44f2cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"240f8a64_b60ce595","updated":"2022-04-25 18:05:35.000000000","message":"thanks, lgtm. new option in middleware is also false so it will not impact users by default. https://github.com/openstack/oslo.middleware/blob/672919216bdf4209a2976e86f6e58850ffc9478f/oslo_middleware/http_proxy_to_wsgi.py#L20","commit_id":"cf906cdcc25c112956f56f9fb9f62b2cfdeacc65"}],"nova/conf/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83f8dc813356d4c28e1883ae46ad887a1603fd0c","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        default\u003dFalse,"},{"line_number":45,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":46,"context_line":"        deprecated_reason\u003d\u0027This feature is duplicate of the HTTPProxyToWSGI \u0027"},{"line_number":47,"context_line":"                          \u0027middleware in oslo.middleware\u0027,"},{"line_number":48,"context_line":"        deprecated_group\u003d\"DEFAULT\","},{"line_number":49,"context_line":"        help\u003d\"\"\""},{"line_number":50,"context_line":"When True, the \u0027X-Forwarded-For\u0027 header is treated as the canonical remote"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ecd467a_af87c22d","line":47,"updated":"2022-04-05 10:03:39.000000000","message":"Can you add deprecated_since also so we remember to get rid of this later?","commit_id":"dff958f2def1dfff354f76cc0291a73b9ee328d1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d84e8dc2f8de8dc671a18a0d91967a5adbef49fc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        default\u003dFalse,"},{"line_number":45,"context_line":"        deprecated_for_removal\u003dTrue,"},{"line_number":46,"context_line":"        deprecated_reason\u003d\u0027This feature is duplicate of the HTTPProxyToWSGI \u0027"},{"line_number":47,"context_line":"                          \u0027middleware in oslo.middleware\u0027,"},{"line_number":48,"context_line":"        deprecated_group\u003d\"DEFAULT\","},{"line_number":49,"context_line":"        help\u003d\"\"\""},{"line_number":50,"context_line":"When True, the \u0027X-Forwarded-For\u0027 header is treated as the canonical remote"}],"source_content_type":"text/x-python","patch_set":3,"id":"ab71dba4_779dfba5","line":47,"in_reply_to":"1ecd467a_af87c22d","updated":"2022-04-11 23:14:49.000000000","message":"Done","commit_id":"dff958f2def1dfff354f76cc0291a73b9ee328d1"}],"releasenotes/notes/deprecate-use_forwarded_for-f7b24eaf130782b9.yaml":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7024da58924591569e0b3a7cc44a4b9998af972b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default ``api-pate.ini`` file has been updated and now the Metadata"},{"line_number":5,"context_line":"    API pipeline includes the ``HTTPProxyToWSGI`` middleware."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"01f9431b_627e2461","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":26},"updated":"2022-04-22 22:18:12.000000000","message":"paste","commit_id":"77cf91ac8a71548910a4ff6444f597b901d4316f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2dabb8b1cc917b619f2d1e9b0e5e69aa6da5c36e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default ``api-pate.ini`` file has been updated and now the Metadata"},{"line_number":5,"context_line":"    API pipeline includes the ``HTTPProxyToWSGI`` middleware."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"deprecations:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f02cf1c_63a8b24f","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":26},"in_reply_to":"01f9431b_627e2461","updated":"2022-04-23 16:18:28.000000000","message":"Done","commit_id":"77cf91ac8a71548910a4ff6444f597b901d4316f"}]}
