)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"737d18bb400e7002f581ff82b78b7c8b4b91db55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"368b37a2_a7512638","updated":"2022-04-05 11:55:24.000000000","message":"ok so even with \n\n[12:49:36]➜ git diff --cached\ndiff --git a/nova/__init__.py b/nova/__init__.py\nindex b8044faece..bcbc8d130c 100644\n--- a/nova/__init__.py\n+++ b/nova/__init__.py\n@@ -22,3 +22,7 @@\n    :platform: Unix\n    :synopsis: Infrastructure-as-a-Service Cloud platform.\n \"\"\"\n+import six\n+\n+\n+print(dir(six))\ndiff --git a/nova/monkey_patch.py b/nova/monkey_patch.py\nindex 6bcd9017a9..807f7568c6 100644\n--- a/nova/monkey_patch.py\n+++ b/nova/monkey_patch.py\n@@ -19,6 +19,9 @@\n \"\"\"Enable eventlet monkey patching.\"\"\"\n \n import os\n+import six\n+\n+print(dir(six))\n\n\nthis still does not trigger for me with \ntox -e pep8\n\n\nam i testing this incorrectly\n\ndid you forget to enabel the extension?\nhttps://github.com/openstack/nova/blob/master/tox.ini#L318\u003d\n","commit_id":"79f8830ee951c07ab9147febfc9ccab527d23249"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9a9374ee0408a2da3ae618eade31084896873fe3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c242a98_17d61804","updated":"2022-04-05 11:37:23.000000000","message":"this would work at the tox level\nbut it wont corrently be run by pre-commit\n\nis there a way for us to include the hacking checks in the pre-commit run?\nim ok with deferring that if you want to keep this simple but it would be nice if it worked\nfor tox -e fast8 and/or pre-commit\n\n\nrunning tox -e pep8 with the change below also did not work so -1 untill i can ensure this actully works\n\n\ndiff --git a/nova/__init__.py b/nova/__init__.py\nindex b8044faece..bcbc8d130c 100644\n--- a/nova/__init__.py\n+++ b/nova/__init__.py\n@@ -22,3 +22,7 @@\n    :platform: Unix\n    :synopsis: Infrastructure-as-a-Service Cloud platform.\n \"\"\"\n+import six\n+\n+\n+print(dir(six))\n\n\n[12:30:24]➜ tox -e pep8\npep8 create: /home/sean/repos/nova/.tox/pep8\npep8 installdeps: -chttps://releases.openstack.org/constraints/upper/master, -r/home/sean/repos/nova/requirements.txt, -r/home/sean/repos/nova/test-requirements.txt, autopep8\npep8 develop-inst: /home/sean/repos/nova\npep8 installed: alembic\u003d\u003d1.7.7,amqp\u003d\u003d5.1.0,appdirs\u003d\u003d1.4.4,attrs\u003d\u003d21.4.0,automaton\u003d\u003d2.5.0,autopage\u003d\u003d0.5.0,autopep8\u003d\u003d1.5.5,bandit\u003d\u003d1.7.4,bcrypt\u003d\u003d3.2.0,cachetools\u003d\u003d5.0.0,castellan\u003d\u003d3.10.1,certifi\u003d\u003d2021.10.8,cffi\u003d\u003d1.15.0,charset-normalizer\u003d\u003d2.0.12,cliff\u003d\u003d3.10.1,cmd2\u003d\u003d2.4.0,colorama\u003d\u003d0.4.4,coverage\u003d\u003d6.3.2,cryptography\u003d\u003d36.0.2,cursive\u003d\u003d0.2.2,ddt\u003d\u003d1.4.4,debtcollector\u003d\u003d2.5.0,decorator\u003d\u003d5.1.1,dnspython\u003d\u003d2.2.1,dogpile.cache\u003d\u003d1.1.5,eventlet\u003d\u003d0.33.0,extras\u003d\u003d1.0.0,fasteners\u003d\u003d0.17.3,fixtures\u003d\u003d3.0.0,flake8\u003d\u003d3.8.4,future\u003d\u003d0.18.2,futurist\u003d\u003d2.4.0,gabbi\u003d\u003d2.4.0,gitdb\u003d\u003d4.0.9,GitPython\u003d\u003d3.1.27,greenlet\u003d\u003d1.1.2,hacking\u003d\u003d3.1.0,idna\u003d\u003d3.3,importlib-metadata\u003d\u003d4.11.3,importlib-resources\u003d\u003d5.6.0,iniconfig\u003d\u003d1.1.1,iso8601\u003d\u003d1.0.2,Jinja2\u003d\u003d3.1.1,jmespath\u003d\u003d1.0.0,jsonpatch\u003d\u003d1.32,jsonpath-rw\u003d\u003d1.4.0,jsonpath-rw-ext\u003d\u003d1.2.2,jsonpointer\u003d\u003d2.2,jsonschema\u003d\u003d3.2.0,keystoneauth1\u003d\u003d4.5.0,keystonemiddleware\u003d\u003d9.4.0,kombu\u003d\u003d5.2.4,lxml\u003d\u003d4.8.0,Mako\u003d\u003d1.2.0,MarkupSafe\u003d\u003d2.1.1,mccabe\u003d\u003d0.6.1,microversion-parse\u003d\u003d1.0.1,mock\u003d\u003d4.0.3,msgpack\u003d\u003d1.0.3,munch\u003d\u003d2.5.0,mypy\u003d\u003d0.942,mypy-extensions\u003d\u003d0.4.3,netaddr\u003d\u003d0.8.0,netifaces\u003d\u003d0.11.0,networkx\u003d\u003d2.7.1,-e git+https://opendev.org/openstack/nova@79f8830ee951c07ab9147febfc9ccab527d23249#egg\u003dnova,numpy\u003d\u003d1.22.3,openstacksdk\u003d\u003d0.61.0,os-brick\u003d\u003d5.2.0,os-client-config\u003d\u003d2.1.0,os-resource-classes\u003d\u003d1.1.0,os-service-types\u003d\u003d1.7.0,os-traits\u003d\u003d2.7.0,os-vif\u003d\u003d2.7.1,os-win\u003d\u003d5.6.0,osc-lib\u003d\u003d2.5.0,oslo.cache\u003d\u003d2.10.1,oslo.concurrency\u003d\u003d4.5.0,oslo.config\u003d\u003d8.8.0,oslo.context\u003d\u003d4.1.0,oslo.db\u003d\u003d11.2.0,oslo.i18n\u003d\u003d5.1.0,oslo.limit\u003d\u003d1.5.0,oslo.log\u003d\u003d4.7.0,oslo.messaging\u003d\u003d12.13.0,oslo.metrics\u003d\u003d0.4.0,oslo.middleware\u003d\u003d4.5.1,oslo.policy\u003d\u003d3.11.0,oslo.privsep\u003d\u003d2.7.0,oslo.reports\u003d\u003d2.3.0,oslo.rootwrap\u003d\u003d6.3.1,oslo.serialization\u003d\u003d4.3.0,oslo.service\u003d\u003d2.8.0,oslo.upgradecheck\u003d\u003d1.5.0,oslo.utils\u003d\u003d4.12.2,oslo.versionedobjects\u003d\u003d2.6.0,oslotest\u003d\u003d4.5.0,osprofiler\u003d\u003d3.4.2,ovs\u003d\u003d2.16.0,ovsdbapp\u003d\u003d1.15.1,packaging\u003d\u003d21.3,paramiko\u003d\u003d2.8.1,Paste\u003d\u003d3.5.0,PasteDeploy\u003d\u003d2.1.1,pbr\u003d\u003d5.8.1,pluggy\u003d\u003d1.0.0,ply\u003d\u003d3.11,prettytable\u003d\u003d3.2.0,prometheus-client\u003d\u003d0.13.1,psutil\u003d\u003d5.9.0,psycopg2-binary\u003d\u003d2.9.3,py\u003d\u003d1.11.0,pycadf\u003d\u003d3.1.1,pycodestyle\u003d\u003d2.6.0,pycparser\u003d\u003d2.21,pydot\u003d\u003d1.4.2,pyflakes\u003d\u003d2.2.0,pyinotify\u003d\u003d0.9.6,PyMySQL\u003d\u003d1.0.2,PyNaCl\u003d\u003d1.5.0,pyOpenSSL\u003d\u003d22.0.0,pyparsing\u003d\u003d3.0.7,pyperclip\u003d\u003d1.8.2,pyroute2\u003d\u003d0.6.9,pyroute2.core\u003d\u003d0.6.9,pyroute2.ethtool\u003d\u003d0.6.9,pyroute2.ipdb\u003d\u003d0.6.9,pyroute2.ipset\u003d\u003d0.6.9,pyroute2.ndb\u003d\u003d0.6.9,pyroute2.nftables\u003d\u003d0.6.9,pyroute2.nslink\u003d\u003d0.6.9,pyrsistent\u003d\u003d0.18.1,pytest\u003d\u003d7.1.1,python-barbicanclient\u003d\u003d5.3.0,python-cinderclient\u003d\u003d8.3.0,python-dateutil\u003d\u003d2.8.2,python-glanceclient\u003d\u003d3.6.0,python-ironicclient\u003d\u003d4.11.0,python-keystoneclient\u003d\u003d4.4.0,python-neutronclient\u003d\u003d7.8.0,python-subunit\u003d\u003d1.4.0,pytz\u003d\u003d2022.1,PyYAML\u003d\u003d6.0,repoze.lru\u003d\u003d0.7,requests\u003d\u003d2.27.1,requests-mock\u003d\u003d1.9.3,requestsexceptions\u003d\u003d1.4.0,retrying\u003d\u003d1.3.3,rfc3986\u003d\u003d1.5.0,Routes\u003d\u003d2.5.1,simplejson\u003d\u003d3.17.6,six\u003d\u003d1.16.0,smmap\u003d\u003d5.0.0,sortedcontainers\u003d\u003d2.4.0,SQLAlchemy\u003d\u003d1.4.34,sqlalchemy-migrate\u003d\u003d0.13.0,sqlparse\u003d\u003d0.4.2,statsd\u003d\u003d3.3.0,stestr\u003d\u003d3.2.1,stevedore\u003d\u003d3.5.0,taskflow\u003d\u003d4.6.4,Tempita\u003d\u003d0.5.2,tenacity\u003d\u003d6.3.1,testresources\u003d\u003d2.0.1,testscenarios\u003d\u003d0.5.0,testtools\u003d\u003d2.5.0,toml\u003d\u003d0.10.2,tomli\u003d\u003d2.0.1,tooz\u003d\u003d2.11.0,types-cryptography\u003d\u003d3.3.18,types-paramiko\u003d\u003d2.8.17,typing_extensions\u003d\u003d4.1.1,urllib3\u003d\u003d1.26.9,vine\u003d\u003d5.0.0,voluptuous\u003d\u003d0.13.0,warlock\u003d\u003d1.3.3,wcwidth\u003d\u003d0.2.5,WebOb\u003d\u003d1.8.7,websockify\u003d\u003d0.10.0,wrapt\u003d\u003d1.14.0,wsgi-intercept\u003d\u003d1.9.3,yappi\u003d\u003d1.3.3,zipp\u003d\u003d3.7.0\npep8 run-test-pre: PYTHONHASHSEED\u003d\u00271137648858\u0027\npep8 run-test: commands[0] | bash tools/mypywrap.sh\n/run/current-system/sw/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)\nSuccess: no issues found in 25 source files\npep8 run-test: commands[1] | autopep8 --exit-code --max-line-length\u003d79 --diff -r nova doc setup.py\npep8 run-test: commands[2] | bash tools/flake8wrap.sh\n/run/current-system/sw/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)\nRunning flake8 on all files\n\npep8 run-test: commands[3] | bash -c \u0027! find doc/ -type f -name *.json | xargs grep -U -n $\u0027\"\u0027\"\u0027\\r\u0027\"\u0027\"\u0027\u0027\n/run/current-system/sw/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)\npep8 run-test: commands[4] | bash -c \u0027! find doc/ -type f -name *.json | xargs -t -n1 python -m json.tool 2\u003e\u00261 \u003e /dev/null | grep -B1 -v ^python\u0027\n/run/current-system/sw/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)\n________________________________________________________________________________ summary _________________________________________________________________________________\n  pep8: commands succeeded\n  congratulations :)\n","commit_id":"79f8830ee951c07ab9147febfc9ccab527d23249"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"14a7ed023d72df009bc6990ca1249e96287eb740","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"92fd4a72_3d4435c6","in_reply_to":"368b37a2_a7512638","updated":"2022-04-05 11:56:50.000000000","message":"actully no here \nhttps://github.com/openstack/nova/blob/master/tox.ini#L331\u003d\ndont you have to list it as a local plugin?","commit_id":"79f8830ee951c07ab9147febfc9ccab527d23249"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"826376985f2aeb68020e9a46491b6f90391de31b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ed06471_396aa0e7","in_reply_to":"92fd4a72_3d4435c6","updated":"2022-04-05 11:59:35.000000000","message":"Oh, indeed. Whoops! Done","commit_id":"79f8830ee951c07ab9147febfc9ccab527d23249"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c61e6d29623d48c453100bc90b5a7e2093595b07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e5b2f672_2161d10f","updated":"2022-04-05 12:37:32.000000000","message":"ok tested this locally (via the follow up patch) and it now works with pre-comit, tox -e fast8 and tox -e pep8 so +2 from me.\n\n\n~/repos/nova on  review/stephen_finucane/hacking [$⇡] via 🐍 v3.8.12 (.venv) \n[13:29:54]➜ pre-commit\n[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.\n[INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks.\n[INFO] Initializing environment for local:hacking\u003e\u003d3.1.0,\u003c3.2.0.\n[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.\n[INFO] Once installed this environment will be reused.\n[INFO] This may take a few minutes...\n[INFO] Installing environment for https://github.com/Lucas-C/pre-commit-hooks.\n[INFO] Once installed this environment will be reused.\n[INFO] This may take a few minutes...\n[INFO] Installing environment for local.\n[INFO] Once installed this environment will be reused.\n[INFO] This may take a few minutes...\n[INFO] Installing environment for https://github.com/pre-commit/mirrors-autopep8.\n[INFO] Once installed this environment will be reused.\n[INFO] This may take a few minutes...\ntrim trailing whitespace.............................(no files to check)Skipped\nmixed line ending....................................(no files to check)Skipped\ncheck BOM - deprecated: use fix-byte-order-marker....(no files to check)Skipped\ncheck that executables have shebangs.................(no files to check)Skipped\ncheck for merge conflicts............................(no files to check)Skipped\ndebug statements (python)............................(no files to check)Skipped\ncheck yaml...........................................(no files to check)Skipped\nTabs remover.........................................(no files to check)Skipped\nflake8...............................................(no files to check)Skipped\nautopep8.............................................(no files to check)Skipped\n~/repos/nova on  review/stephen_finucane/hacking [$⇡] via 🐍 v3.8.12 (.venv) took 17s \n[13:30:16]➜ pre-commit --all-files\nusage: pre-commit [-h] [-V] {autoupdate,clean,hook-impl,gc,init-templatedir,install,install-hooks,migrate-config,run,sample-config,try-repo,uninstall,help} ...\npre-commit: error: unrecognized arguments: --all-files\n~/repos/nova on  review/stephen_finucane/hacking [$⇡] via 🐍 v3.8.12 (.venv) \n[13:30:25]❯ pre-commit run --all-files\ntrim trailing whitespace.................................................Passed\nmixed line ending........................................................Passed\ncheck BOM - deprecated: use fix-byte-order-marker........................Passed\ncheck that executables have shebangs.....................................Passed\ncheck for merge conflicts................................................Passed\ndebug statements (python)................................................Passed\ncheck yaml...............................................................Passed\nTabs remover.............................................................Passed\nflake8...................................................................Failed\n- hook id: flake8\n- exit code: 1\n\nnova/__init__.py:25:1: N370: Don\u0027t use or import six\nnova/monkey_patch.py:22:1: N370: Don\u0027t use or import six\n\nautopep8.................................................................Passed\n~/repos/nova on  review/stephen_finucane/hacking [$⇡] via 🐍 v3.8.12 (.venv) took 1m56s \n[13:32:32]❯ tox -e fast8\n/home/sean/repos/nova/.tox/shared/lib/python3.8/site-packages/setuptools/command/easy_install.py:144: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.\n  warnings.warn(\n/home/sean/repos/nova/.tox/shared/lib/python3.8/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.\n  warnings.warn(\nfast8 develop-inst-noop: /home/sean/repos/nova\nfast8 installed: alembic\u003d\u003d1.7.7,amqp\u003d\u003d5.1.0,appdirs\u003d\u003d1.4.4,attrs\u003d\u003d21.4.0,automaton\u003d\u003d2.5.0,autopage\u003d\u003d0.5.0,bandit\u003d\u003d1.7.4,bcrypt\u003d\u003d3.2.0,cachetools\u003d\u003d5.0.0,castellan\u003d\u003d3.10.1,certifi\u003d\u003d2021.10.8,cffi\u003d\u003d1.15.0,charset-normalizer\u003d\u003d2.0.12,cliff\u003d\u003d3.10.1,cmd2\u003d\u003d2.4.0,colorama\u003d\u003d0.4.4,coverage\u003d\u003d6.3.2,cryptography\u003d\u003d36.0.2,cursive\u003d\u003d0.2.2,ddt\u003d\u003d1.4.4,debtcollector\u003d\u003d2.5.0,decorator\u003d\u003d5.1.1,dnspython\u003d\u003d2.2.1,dogpile.cache\u003d\u003d1.1.5,eventlet\u003d\u003d0.33.0,extras\u003d\u003d1.0.0,fasteners\u003d\u003d0.17.3,fixtures\u003d\u003d3.0.0,flake8\u003d\u003d3.8.4,future\u003d\u003d0.18.2,futurist\u003d\u003d2.4.0,gabbi\u003d\u003d2.4.0,gitdb\u003d\u003d4.0.9,GitPython\u003d\u003d3.1.27,greenlet\u003d\u003d1.1.2,hacking\u003d\u003d3.1.0,idna\u003d\u003d3.3,importlib-metadata\u003d\u003d4.11.3,importlib-resources\u003d\u003d5.6.0,iniconfig\u003d\u003d1.1.1,iso8601\u003d\u003d1.0.2,Jinja2\u003d\u003d3.1.1,jmespath\u003d\u003d1.0.0,jsonpatch\u003d\u003d1.32,jsonpath-rw\u003d\u003d1.4.0,jsonpath-rw-ext\u003d\u003d1.2.2,jsonpointer\u003d\u003d2.2,jsonschema\u003d\u003d3.2.0,keystoneauth1\u003d\u003d4.5.0,keystonemiddleware\u003d\u003d9.4.0,kombu\u003d\u003d5.2.4,lxml\u003d\u003d4.8.0,Mako\u003d\u003d1.2.0,MarkupSafe\u003d\u003d2.1.1,mccabe\u003d\u003d0.6.1,microversion-parse\u003d\u003d1.0.1,mock\u003d\u003d4.0.3,msgpack\u003d\u003d1.0.3,munch\u003d\u003d2.5.0,mypy\u003d\u003d0.942,mypy-extensions\u003d\u003d0.4.3,netaddr\u003d\u003d0.8.0,netifaces\u003d\u003d0.11.0,networkx\u003d\u003d2.7.1,-e git+https://opendev.org/openstack/nova@319abcd66a3a3a0a794d10b4f1f0df783acec474#egg\u003dnova,numpy\u003d\u003d1.22.3,openstacksdk\u003d\u003d0.61.0,os-brick\u003d\u003d5.2.0,os-client-config\u003d\u003d2.1.0,os-resource-classes\u003d\u003d1.1.0,os-service-types\u003d\u003d1.7.0,os-traits\u003d\u003d2.7.0,os-vif\u003d\u003d2.7.1,os-win\u003d\u003d5.6.0,osc-lib\u003d\u003d2.5.0,oslo.cache\u003d\u003d2.10.1,oslo.concurrency\u003d\u003d4.5.0,oslo.config\u003d\u003d8.8.0,oslo.context\u003d\u003d4.1.0,oslo.db\u003d\u003d11.2.0,oslo.i18n\u003d\u003d5.1.0,oslo.limit\u003d\u003d1.5.0,oslo.log\u003d\u003d4.7.0,oslo.messaging\u003d\u003d12.13.0,oslo.metrics\u003d\u003d0.4.0,oslo.middleware\u003d\u003d4.5.1,oslo.policy\u003d\u003d3.11.0,oslo.privsep\u003d\u003d2.7.0,oslo.reports\u003d\u003d2.3.0,oslo.rootwrap\u003d\u003d6.3.1,oslo.serialization\u003d\u003d4.3.0,oslo.service\u003d\u003d2.8.0,oslo.upgradecheck\u003d\u003d1.5.0,oslo.utils\u003d\u003d4.12.2,oslo.versionedobjects\u003d\u003d2.6.0,oslotest\u003d\u003d4.5.0,osprofiler\u003d\u003d3.4.2,ovs\u003d\u003d2.16.0,ovsdbapp\u003d\u003d1.15.1,packaging\u003d\u003d21.3,paramiko\u003d\u003d2.8.1,Paste\u003d\u003d3.5.0,PasteDeploy\u003d\u003d2.1.1,pbr\u003d\u003d5.8.1,pluggy\u003d\u003d1.0.0,ply\u003d\u003d3.11,prettytable\u003d\u003d3.2.0,prometheus-client\u003d\u003d0.13.1,psutil\u003d\u003d5.9.0,psycopg2-binary\u003d\u003d2.9.3,py\u003d\u003d1.11.0,pycadf\u003d\u003d3.1.1,pycodestyle\u003d\u003d2.6.0,pycparser\u003d\u003d2.21,pydot\u003d\u003d1.4.2,pyflakes\u003d\u003d2.2.0,pyinotify\u003d\u003d0.9.6,PyMySQL\u003d\u003d1.0.2,PyNaCl\u003d\u003d1.5.0,pyOpenSSL\u003d\u003d22.0.0,pyparsing\u003d\u003d3.0.7,pyperclip\u003d\u003d1.8.2,pyroute2\u003d\u003d0.6.9,pyroute2.core\u003d\u003d0.6.9,pyroute2.ethtool\u003d\u003d0.6.9,pyroute2.ipdb\u003d\u003d0.6.9,pyroute2.ipset\u003d\u003d0.6.9,pyroute2.ndb\u003d\u003d0.6.9,pyroute2.nftables\u003d\u003d0.6.9,pyroute2.nslink\u003d\u003d0.6.9,pyrsistent\u003d\u003d0.18.1,pytest\u003d\u003d7.1.1,python-barbicanclient\u003d\u003d5.3.0,python-cinderclient\u003d\u003d8.3.0,python-dateutil\u003d\u003d2.8.2,python-glanceclient\u003d\u003d3.6.0,python-ironicclient\u003d\u003d4.11.0,python-keystoneclient\u003d\u003d4.4.0,python-neutronclient\u003d\u003d7.8.0,python-subunit\u003d\u003d1.4.0,pytz\u003d\u003d2022.1,PyYAML\u003d\u003d6.0,repoze.lru\u003d\u003d0.7,requests\u003d\u003d2.27.1,requests-mock\u003d\u003d1.9.3,requestsexceptions\u003d\u003d1.4.0,retrying\u003d\u003d1.3.3,rfc3986\u003d\u003d1.5.0,Routes\u003d\u003d2.5.1,simplejson\u003d\u003d3.17.6,six\u003d\u003d1.16.0,smmap\u003d\u003d5.0.0,sortedcontainers\u003d\u003d2.4.0,SQLAlchemy\u003d\u003d1.4.34,sqlalchemy-migrate\u003d\u003d0.13.0,sqlparse\u003d\u003d0.4.2,statsd\u003d\u003d3.3.0,stestr\u003d\u003d3.2.1,stevedore\u003d\u003d3.5.0,taskflow\u003d\u003d4.6.4,Tempita\u003d\u003d0.5.2,tenacity\u003d\u003d6.3.1,testresources\u003d\u003d2.0.1,testscenarios\u003d\u003d0.5.0,testtools\u003d\u003d2.5.0,tomli\u003d\u003d2.0.1,tooz\u003d\u003d2.11.0,types-cryptography\u003d\u003d3.3.18,types-paramiko\u003d\u003d2.8.17,typing_extensions\u003d\u003d4.1.1,urllib3\u003d\u003d1.26.9,vine\u003d\u003d5.0.0,voluptuous\u003d\u003d0.13.0,warlock\u003d\u003d1.3.3,wcwidth\u003d\u003d0.2.5,WebOb\u003d\u003d1.8.7,websockify\u003d\u003d0.10.0,wrapt\u003d\u003d1.14.0,wsgi-intercept\u003d\u003d1.9.3,yappi\u003d\u003d1.3.3,zipp\u003d\u003d3.7.0\nfast8 run-test-pre: PYTHONHASHSEED\u003d\u00271662214798\u0027\nfast8 run-test: commands[0] | bash tools/flake8wrap.sh -HEAD\n/run/current-system/sw/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)\nRunning flake8 on nova/__init__.py nova/monkey_patch.py \n\nConsider using the \u0027pre-commit\u0027 tool instead.\n\n    pip install --user pre-commit\n    pre-commit install --allow-missing-config\n\nnova/__init__.py:25:1: N370: Don\u0027t use or import six\nnova/monkey_patch.py:22:1: N370: Don\u0027t use or import six\nERROR: InvocationError for command /run/current-system/sw/bin/bash tools/flake8wrap.sh -HEAD (exited with code 1)\n________________________________________________________________________________ summary _________________________________________________________________________________\nERROR:   fast8: commands failed\n~/repos/nova on  review/stephen_finucane/hacking [$⇡] via 🐍 v3.8.12 (.venv) took 4s \n[13:32:54]❯ tox -e pep8\n/home/sean/repos/nova/.tox/pep8/lib/python3.8/site-packages/setuptools/command/easy_install.py:144: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.\n  warnings.warn(\n/home/sean/repos/nova/.tox/pep8/lib/python3.8/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.\n  warnings.warn(\npep8 develop-inst-noop: /home/sean/repos/nova\npep8 installed: alembic\u003d\u003d1.7.7,amqp\u003d\u003d5.1.0,appdirs\u003d\u003d1.4.4,attrs\u003d\u003d21.4.0,automaton\u003d\u003d2.5.0,autopage\u003d\u003d0.5.0,autopep8\u003d\u003d1.5.5,bandit\u003d\u003d1.7.4,bcrypt\u003d\u003d3.2.0,cachetools\u003d\u003d5.0.0,castellan\u003d\u003d3.10.1,certifi\u003d\u003d2021.10.8,cffi\u003d\u003d1.15.0,charset-normalizer\u003d\u003d2.0.12,cliff\u003d\u003d3.10.1,cmd2\u003d\u003d2.4.0,colorama\u003d\u003d0.4.4,coverage\u003d\u003d6.3.2,cryptography\u003d\u003d36.0.2,cursive\u003d\u003d0.2.2,ddt\u003d\u003d1.4.4,debtcollector\u003d\u003d2.5.0,decorator\u003d\u003d5.1.1,dnspython\u003d\u003d2.2.1,dogpile.cache\u003d\u003d1.1.5,eventlet\u003d\u003d0.33.0,extras\u003d\u003d1.0.0,fasteners\u003d\u003d0.17.3,fixtures\u003d\u003d3.0.0,flake8\u003d\u003d3.8.4,future\u003d\u003d0.18.2,futurist\u003d\u003d2.4.0,gabbi\u003d\u003d2.4.0,gitdb\u003d\u003d4.0.9,GitPython\u003d\u003d3.1.27,greenlet\u003d\u003d1.1.2,hacking\u003d\u003d3.1.0,idna\u003d\u003d3.3,importlib-metadata\u003d\u003d4.11.3,importlib-resources\u003d\u003d5.6.0,iniconfig\u003d\u003d1.1.1,iso8601\u003d\u003d1.0.2,Jinja2\u003d\u003d3.1.1,jmespath\u003d\u003d1.0.0,jsonpatch\u003d\u003d1.32,jsonpath-rw\u003d\u003d1.4.0,jsonpath-rw-ext\u003d\u003d1.2.2,jsonpointer\u003d\u003d2.2,jsonschema\u003d\u003d3.2.0,keystoneauth1\u003d\u003d4.5.0,keystonemiddleware\u003d\u003d9.4.0,kombu\u003d\u003d5.2.4,lxml\u003d\u003d4.8.0,Mako\u003d\u003d1.2.0,MarkupSafe\u003d\u003d2.1.1,mccabe\u003d\u003d0.6.1,microversion-parse\u003d\u003d1.0.1,mock\u003d\u003d4.0.3,msgpack\u003d\u003d1.0.3,munch\u003d\u003d2.5.0,mypy\u003d\u003d0.942,mypy-extensions\u003d\u003d0.4.3,netaddr\u003d\u003d0.8.0,netifaces\u003d\u003d0.11.0,networkx\u003d\u003d2.7.1,-e git+https://opendev.org/openstack/nova@319abcd66a3a3a0a794d10b4f1f0df783acec474#egg\u003dnova,numpy\u003d\u003d1.22.3,openstacksdk\u003d\u003d0.61.0,os-brick\u003d\u003d5.2.0,os-client-config\u003d\u003d2.1.0,os-resource-classes\u003d\u003d1.1.0,os-service-types\u003d\u003d1.7.0,os-traits\u003d\u003d2.7.0,os-vif\u003d\u003d2.7.1,os-win\u003d\u003d5.6.0,osc-lib\u003d\u003d2.5.0,oslo.cache\u003d\u003d2.10.1,oslo.concurrency\u003d\u003d4.5.0,oslo.config\u003d\u003d8.8.0,oslo.context\u003d\u003d4.1.0,oslo.db\u003d\u003d11.2.0,oslo.i18n\u003d\u003d5.1.0,oslo.limit\u003d\u003d1.5.0,oslo.log\u003d\u003d4.7.0,oslo.messaging\u003d\u003d12.13.0,oslo.metrics\u003d\u003d0.4.0,oslo.middleware\u003d\u003d4.5.1,oslo.policy\u003d\u003d3.11.0,oslo.privsep\u003d\u003d2.7.0,oslo.reports\u003d\u003d2.3.0,oslo.rootwrap\u003d\u003d6.3.1,oslo.serialization\u003d\u003d4.3.0,oslo.service\u003d\u003d2.8.0,oslo.upgradecheck\u003d\u003d1.5.0,oslo.utils\u003d\u003d4.12.2,oslo.versionedobjects\u003d\u003d2.6.0,oslotest\u003d\u003d4.5.0,osprofiler\u003d\u003d3.4.2,ovs\u003d\u003d2.16.0,ovsdbapp\u003d\u003d1.15.1,packaging\u003d\u003d21.3,paramiko\u003d\u003d2.8.1,Paste\u003d\u003d3.5.0,PasteDeploy\u003d\u003d2.1.1,pbr\u003d\u003d5.8.1,pluggy\u003d\u003d1.0.0,ply\u003d\u003d3.11,prettytable\u003d\u003d3.2.0,prometheus-client\u003d\u003d0.13.1,psutil\u003d\u003d5.9.0,psycopg2-binary\u003d\u003d2.9.3,py\u003d\u003d1.11.0,pycadf\u003d\u003d3.1.1,pycodestyle\u003d\u003d2.6.0,pycparser\u003d\u003d2.21,pydot\u003d\u003d1.4.2,pyflakes\u003d\u003d2.2.0,pyinotify\u003d\u003d0.9.6,PyMySQL\u003d\u003d1.0.2,PyNaCl\u003d\u003d1.5.0,pyOpenSSL\u003d\u003d22.0.0,pyparsing\u003d\u003d3.0.7,pyperclip\u003d\u003d1.8.2,pyroute2\u003d\u003d0.6.9,pyroute2.core\u003d\u003d0.6.9,pyroute2.ethtool\u003d\u003d0.6.9,pyroute2.ipdb\u003d\u003d0.6.9,pyroute2.ipset\u003d\u003d0.6.9,pyroute2.ndb\u003d\u003d0.6.9,pyroute2.nftables\u003d\u003d0.6.9,pyroute2.nslink\u003d\u003d0.6.9,pyrsistent\u003d\u003d0.18.1,pytest\u003d\u003d7.1.1,python-barbicanclient\u003d\u003d5.3.0,python-cinderclient\u003d\u003d8.3.0,python-dateutil\u003d\u003d2.8.2,python-glanceclient\u003d\u003d3.6.0,python-ironicclient\u003d\u003d4.11.0,python-keystoneclient\u003d\u003d4.4.0,python-neutronclient\u003d\u003d7.8.0,python-subunit\u003d\u003d1.4.0,pytz\u003d\u003d2022.1,PyYAML\u003d\u003d6.0,repoze.lru\u003d\u003d0.7,requests\u003d\u003d2.27.1,requests-mock\u003d\u003d1.9.3,requestsexceptions\u003d\u003d1.4.0,retrying\u003d\u003d1.3.3,rfc3986\u003d\u003d1.5.0,Routes\u003d\u003d2.5.1,simplejson\u003d\u003d3.17.6,six\u003d\u003d1.16.0,smmap\u003d\u003d5.0.0,sortedcontainers\u003d\u003d2.4.0,SQLAlchemy\u003d\u003d1.4.34,sqlalchemy-migrate\u003d\u003d0.13.0,sqlparse\u003d\u003d0.4.2,statsd\u003d\u003d3.3.0,stestr\u003d\u003d3.2.1,stevedore\u003d\u003d3.5.0,taskflow\u003d\u003d4.6.4,Tempita\u003d\u003d0.5.2,tenacity\u003d\u003d6.3.1,testresources\u003d\u003d2.0.1,testscenarios\u003d\u003d0.5.0,testtools\u003d\u003d2.5.0,toml\u003d\u003d0.10.2,tomli\u003d\u003d2.0.1,tooz\u003d\u003d2.11.0,types-cryptography\u003d\u003d3.3.18,types-paramiko\u003d\u003d2.8.17,typing_extensions\u003d\u003d4.1.1,urllib3\u003d\u003d1.26.9,vine\u003d\u003d5.0.0,voluptuous\u003d\u003d0.13.0,warlock\u003d\u003d1.3.3,wcwidth\u003d\u003d0.2.5,WebOb\u003d\u003d1.8.7,websockify\u003d\u003d0.10.0,wrapt\u003d\u003d1.14.0,wsgi-intercept\u003d\u003d1.9.3,yappi\u003d\u003d1.3.3,zipp\u003d\u003d3.7.0\npep8 run-test-pre: PYTHONHASHSEED\u003d\u00272477319945\u0027\npep8 run-test: commands[0] | bash tools/mypywrap.sh\n/run/current-system/sw/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)\nSuccess: no issues found in 25 source files\npep8 run-test: commands[1] | autopep8 --exit-code --max-line-length\u003d79 --diff -r nova doc setup.py\npep8 run-test: commands[2] | bash tools/flake8wrap.sh\n/run/current-system/sw/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.utf-8)\nRunning flake8 on all files\n\n./nova/__init__.py:25:1: N370: Don\u0027t use or import six\n./nova/monkey_patch.py:22:1: N370: Don\u0027t use or import six\nERROR: InvocationError for command /run/current-system/sw/bin/bash tools/flake8wrap.sh (exited with code 1)\n________________________________________________________________________________ summary _________________________________________________________________________________\nERROR:   pep8: commands failed\n~/repos/nova on  review/stephen_finucane/hacking [$⇡] via 🐍 v3.8.12 (.venv) took 4m13s \n[13:37:17]❯ \n","commit_id":"b082d06cbccd06bd49d9aa2a35ea922190e42cc5"}],"nova/hacking/checks.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"590c865e99feff7ac0f631e20635c810b943e1f7","unresolved":true,"context_lines":[{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    N370"},{"line_number":1045,"context_line":"    \"\"\""},{"line_number":1046,"context_line":"    match \u003d re.match(six_re, logical_line)"},{"line_number":1047,"context_line":"    if match:"},{"line_number":1048,"context_line":"        yield (0, \"N370: Don\u0027t use or import six\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"f2ed200a_f4b5f317","line":1046,"updated":"2022-04-05 12:38:56.000000000","message":"well does this mean that any new change changing a module would get this pep8flake8 be -1 even if the change isn\u0027t touching the imports ?\n\nLet me test it.","commit_id":"b082d06cbccd06bd49d9aa2a35ea922190e42cc5"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"88f1d68ba8d98a3f2aacf782067bceda7ef0a10a","unresolved":true,"context_lines":[{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    N370"},{"line_number":1045,"context_line":"    \"\"\""},{"line_number":1046,"context_line":"    match \u003d re.match(six_re, logical_line)"},{"line_number":1047,"context_line":"    if match:"},{"line_number":1048,"context_line":"        yield (0, \"N370: Don\u0027t use or import six\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3bcda699_f82ff29c","line":1046,"in_reply_to":"f2ed200a_f4b5f317","updated":"2022-04-05 12:49:11.000000000","message":"OK, we no longer have any six usage now :\n\n  [sbauza@sbauza nova]$ find nova/ -name \"*.py\" -exec grep six {} \\;  -exec echo {} \\;\n  import posixpath\n              path \u003d posixpath.normpath(\"/\" + path)\n              path \u003d posixpath.normpath(path)\n  nova/api/metadata/base.py\n          total of six compute nodes. Then it will page over them with a limit\n  nova/tests/functional/compute/test_host_api.py\n          # Last six included two that were already done, and spanned to the\n  nova/tests/functional/db/test_instance_mapping.py\n          # port_id attribute (so six times)\n  nova/tests/unit/network/test_neutron.py\n          # Try for sixty seconds: six retries at 10 second interval\n  nova/tests/unit/storage/test_rbd.py","commit_id":"b082d06cbccd06bd49d9aa2a35ea922190e42cc5"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"178acb5378185b601b92d59978537b5f4622a164","unresolved":true,"context_lines":[{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    N370"},{"line_number":1045,"context_line":"    \"\"\""},{"line_number":1046,"context_line":"    match \u003d re.match(six_re, logical_line)"},{"line_number":1047,"context_line":"    if match:"},{"line_number":1048,"context_line":"        yield (0, \"N370: Don\u0027t use or import six\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"95801a77_1e9e736b","line":1046,"in_reply_to":"f2ed200a_f4b5f317","updated":"2022-04-05 12:41:28.000000000","message":"we dont currently have any usage of six in nova.\nwe removed it a while ago\n\nhttps://codesearch.opendev.org/?q\u003dsix\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003dopenstack%2Fnova\n\nso this will prevent it being readded","commit_id":"b082d06cbccd06bd49d9aa2a35ea922190e42cc5"}]}